On 11/7/18 9:02 PM, Eric Blake wrote:
Running 'make check' under a ThreadSanitizer build complains that
test-layers leaks a pthread; while harmless, it is also an easy
fix, by detaching the thread to ensure it gets cleaned up.
Signed-off-by: Eric Blake
---
tests/test-layers.c | 6 ++
1
Running 'make check' under a ThreadSanitizer build complains that
test-layers leaks a pthread; while harmless, it is also an easy
fix, by detaching the thread to ensure it gets cleaned up.
Signed-off-by: Eric Blake
---
tests/test-layers.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
ThreadSanitizer [1] pointed out that in the nbd plugin, nbd_close() can
attempt close() in the main thread while the worker thread is still
attempting to start a read(). Normally, if the read() loses the race,
it will get a harmless EBADF that exits the worker thread (which is what
we want, as we
On Wed, 7 Nov 2018 17:32:56 +0100
Tomáš Golembiovský wrote:
> On Wed, 7 Nov 2018 15:31:56 +
> "Richard W.M. Jones" wrote:
>
> > On Wed, Nov 07, 2018 at 12:53:17PM +0100, Tomáš Golembiovský wrote:
> > > changes in v3:
> > > - fix call to install_local
> > >
> > > changes in v2:
> > > -
On Wed, 7 Nov 2018 15:46:49 +
"Richard W.M. Jones" wrote:
> On Wed, Nov 07, 2018 at 12:53:20PM +0100, Tomáš Golembiovský wrote:
> > Signed-off-by: Tomáš Golembiovský
> > ---
> > v2v/convert_linux.ml | 2 ++
> > v2v/windows_virtio.ml | 30 ++
> >
On Wed, Nov 07, 2018 at 05:27:18PM +0100, Tomáš Golembiovský wrote:
> On Wed, 7 Nov 2018 15:46:49 +
> "Richard W.M. Jones" wrote:
>
> > On Wed, Nov 07, 2018 at 12:53:20PM +0100, Tomáš Golembiovský wrote:
> > > Signed-off-by: Tomáš Golembiovský
> > > ---
> > > v2v/convert_linux.ml | 2 ++
On Wed, 7 Nov 2018 15:31:56 +
"Richard W.M. Jones" wrote:
> On Wed, Nov 07, 2018 at 12:53:17PM +0100, Tomáš Golembiovský wrote:
> > changes in v3:
> > - fix call to install_local
> >
> > changes in v2:
> > - moved copy_drivers above copy_files
> > - renamed copy_files to
On Wed, Nov 07, 2018 at 12:53:18PM +0100, Tomáš Golembiovský wrote:
> Changed the function to be more generic and renamed.
> The only change in behavior is in produced debug messages.
>
> Signed-off-by: Tomáš Golembiovský
> ---
> v2v/windows_virtio.ml | 48
On Wed, Nov 07, 2018 at 12:53:20PM +0100, Tomáš Golembiovský wrote:
> Signed-off-by: Tomáš Golembiovský
> ---
> v2v/convert_linux.ml | 2 ++
> v2v/windows_virtio.ml | 30 ++
> v2v/windows_virtio.mli | 4
> 3 files changed, 36 insertions(+)
>
> diff --git
On Wed, Nov 07, 2018 at 12:53:19PM +0100, Tomáš Golembiovský wrote:
> Install packages from local files without touching network.
>
> Signed-off-by: Tomáš Golembiovský
> ---
> v2v/linux.ml | 14 ++
> v2v/linux.mli | 3 +++
> 2 files changed, 17 insertions(+)
>
> diff --git
On Wed, Nov 07, 2018 at 12:53:17PM +0100, Tomáš Golembiovský wrote:
> changes in v3:
> - fix call to install_local
>
> changes in v2:
> - moved copy_drivers above copy_files
> - renamed copy_files to copy_from_virtio_win
> - renamed install to install_local
> - use rpm instead of yum
>
> This
On Wed, Nov 07, 2018 at 01:37:03PM +0200, Peter Dimitrov wrote:
> > That makes no sense because we are supposed to have just forked
> successfully
>
> I just realized libguestfs uses fork. Now we know why qemu-img worked - I
> launched it with popen.
>
> > So it must be something to do with
On Wed, 07 Nov 2018 13:32:45 +0100
Pino Toscano wrote:
> On Wednesday, 7 November 2018 12:53:17 CET Tomáš Golembiovský wrote:
> > - support for Debian is missing
> > I don't know how to install the package only when all it's dependencies
> > are
> > already installed.
>
> dpkg -i foo.deb
On Wednesday, 7 November 2018 12:53:17 CET Tomáš Golembiovský wrote:
> - support for Debian is missing
> I don't know how to install the package only when all it's dependencies are
> already installed.
dpkg -i foo.deb
> dpkg cannot be used to check that (simulate the install).
dpkg
Changed the function to be more generic and renamed.
The only change in behavior is in produced debug messages.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 48 ---
1 file changed, 31 insertions(+), 17 deletions(-)
diff --git
> That makes no sense because we are supposed to have just forked
successfully
I just realized libguestfs uses fork. Now we know why qemu-img worked - I
launched it with popen.
> So it must be something to do with collectd and how it runs programs.
> Is it using LD_PRELOAD trickery, or replacing
Changed the function to be more generic and renamed.
The only change in behavior is in produced debug messages.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 48 ---
1 file changed, 31 insertions(+), 17 deletions(-)
diff --git
Install packages from local files without touching network.
Signed-off-by: Tomáš Golembiovský
---
v2v/linux.ml | 14 ++
v2v/linux.mli | 3 +++
2 files changed, 17 insertions(+)
diff --git a/v2v/linux.ml b/v2v/linux.ml
index 177724e39..966170cdd 100644
--- a/v2v/linux.ml
+++
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_linux.ml | 2 ++
v2v/windows_virtio.ml | 30 ++
v2v/windows_virtio.mli | 4
3 files changed, 36 insertions(+)
diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index e8c64ac1b..a1bafe91a 100644
---
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_linux.ml | 2 ++
v2v/windows_virtio.ml | 30 ++
v2v/windows_virtio.mli | 4
3 files changed, 36 insertions(+)
diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index e8c64ac1b..a1bafe91a 100644
---
Thank you, Rich,
This was the issue indeed. export LIBGUESTFS_BACKEND=direct fixed it.
The next step I tried was to integrate libguestfs in collectd virt plugin
to collect this data automatically.
In this case I'm having an unknown error in add_libvirt_dom() (same with
add_domain) when it's
changes in v2:
- moved copy_drivers above copy_files
- renamed copy_files to copy_from_virtio_win
- renamed install to install_local
- use rpm instead of yum
This installs packages with QEMU Guest Agent when converting Linux machine. The
packages should be available on guest tools ISO. The
Install packages from local files without touching network.
Signed-off-by: Tomáš Golembiovský
---
v2v/linux.ml | 14 ++
v2v/linux.mli | 3 +++
2 files changed, 17 insertions(+)
diff --git a/v2v/linux.ml b/v2v/linux.ml
index 177724e39..966170cdd 100644
--- a/v2v/linux.ml
+++
On Wed, Nov 07, 2018 at 12:32:48PM +0200, Peter Dimitrov wrote:
> Thank you, Rich,
> This was the issue indeed. export LIBGUESTFS_BACKEND=direct fixed it.
>
> The next step I tried was to integrate libguestfs in collectd virt plugin
> to collect this data automatically.
> In this case I'm having
On Tue, 6 Nov 2018 11:32:38 +
"Richard W.M. Jones" wrote:
> On Tue, Nov 06, 2018 at 11:44:14AM +0100, Tomáš Golembiovský wrote:
> > Install packages from local files without touching network.
>
> In fact, not limited to local files, but is limited to guests which
> use ‘yum’. So I think
On Wed, Nov 07, 2018 at 11:24:48AM +0100, Tomáš Golembiovský wrote:
> I used the same style as remove(). I will inline the code as I prefer
> that.
This is a stylistic point, so whichever style is easier to read,
more consistent, etc.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
26 matches
Mail list logo
