Re: [Libguestfs] [PATCH nbdkit] Add support for writing plugins in Rust.

2019-02-08 Thread Richard W.M. Jones
On Fri, Feb 08, 2019 at 08:53:44AM -0600, Eric Blake wrote: > > +++ b/plugins/rust/Cargo.toml.in > > @@ -0,0 +1,14 @@ > > +[package] > > +name = "nbdkit" > > +version = "@VERSION@" > > +authors = ["Richard W.M. Jones "] > > +edition = "2018" > > 2019? Some form of @YEAR@ to make it auto-update

Re: [Libguestfs] [PATCH nbdkit v2] server: utils: Make nbdkit_parse_size to reject negative values

2019-02-08 Thread Eric Blake
On 2/8/19 12:10 AM, Mykola Ivanets wrote: > From: Nikolay Ivanets Grammar in the subject: s/ to// > > nbdkit_parse_size() uses strtoumax() function to parse input strings > which states: > > 1. Some more tests were added to cover described behaviour. > > 2. Input strings where grouped into

Re: [Libguestfs] [PATCH nbdkit v2] server: utils: Make nbdkit_parse_size to reject negative values

2019-02-08 Thread Richard W.M. Jones
Looks OK to me. I'll let Eric have the final say though. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful

[Libguestfs] [PATCH nbdkit] Add support for writing plugins in Rust.

2019-02-08 Thread Richard W.M. Jones
--- .gitignore | 3 + README | 4 +- TODO| 13 +++ configure.ac| 12 +++ docs/nbdkit-plugin.pod | 6 +- docs/nbdkit.pod | 1 +

[Libguestfs] [PATCH nbdkit] Add support for writing plugins in Rust.

2019-02-08 Thread Richard W.M. Jones
This adds very rough support for writing nbdkit plugins in Rust. This is not very idiomatic -- essentially we're handling the direct C calls from nbdkit in Rust. We have to use ‘unsafe’ in a few places because there's no way to tell the Rust code that nbdkit satisfies guarantees (eg. around

[Libguestfs] [PATCH v2 0/3] allow alternative guest tools directories for distributions

2019-02-08 Thread Tomáš Golembiovský
First patch just fixes installing guest tools from directory that was broken. Second patch revamps how virt-v2v chooses from which directory install guest tools on Linux. Details in commit message. v2: - included comments from Pino and Rich - added test Tomáš Golembiovský (3): v2v: fix path to

[Libguestfs] [PATCH v2 3/3] v2v: tests: test paths for installation of linux guest tools

2019-02-08 Thread Tomáš Golembiovský
Signed-off-by: Tomáš Golembiovský --- v2v/Makefile.am | 1 + v2v/test-v2v-copy-guest-tools.sh | 87 2 files changed, 88 insertions(+) create mode 100755 v2v/test-v2v-copy-guest-tools.sh diff --git a/v2v/Makefile.am b/v2v/Makefile.am index

[Libguestfs] [PATCH v2 2/3] v2v: allow alternative directories for distributions

2019-02-08 Thread Tomáš Golembiovský
Allow multiple alternative directory names for distributions (or distribution familiy) when installing Linux guest tools packages. Original naming required that there is a separate directory for every version of a distribution (e.g. fc28, fc29, ...). This is inconvenient when users want to keep

[Libguestfs] [PATCH v2 1/3] v2v: fix path to source when copying files from guest tools directory

2019-02-08 Thread Tomáš Golembiovský
The debug message was slightly changed too to better match the similar message for ISO case. It refers to the root directory instead of the specific subdirectory inside guest tools. Signed-off-by: Tomáš Golembiovský --- v2v/windows_virtio.ml | 7 --- 1 file changed, 4 insertions(+), 3