Re: [Libguestfs] [PATCH] v2v: warn when the guest has direct network interfaces (RHBZ#1518539)

2019-04-12 Thread Richard W.M. Jones
On Fri, Apr 12, 2019 at 05:29:33PM +0200, Pino Toscano wrote: > virt-v2v obviously cannot convert this kind of devices, since they are > specific to the host of the hypervisor. Thus, emit a warning about the > presence of direct network interfaces, so at least this can be noticed > when converting

Re: [Libguestfs] nbdkit, VDDK, extents, readahead, etc

2019-04-12 Thread Richard W.M. Jones
On Fri, Apr 12, 2019 at 03:52:58PM +0200, Martin Kletzander wrote: > On Thu, Apr 11, 2019 at 06:55:55PM +0100, Richard W.M. Jones wrote: > >This seems to be a bug in VDDK, possibly connected with the fact that > >we fork after initializing VDDK but before doing the > >VixDiskLib_ConnectEx. I suspe

[Libguestfs] [PATCH] v2v: warn when the guest has direct network interfaces (RHBZ#1518539)

2019-04-12 Thread Pino Toscano
virt-v2v obviously cannot convert this kind of devices, since they are specific to the host of the hypervisor. Thus, emit a warning about the presence of direct network interfaces, so at least this can be noticed when converting a guest. --- v2v/parse_libvirt_xml.ml | 18 ++ 1 fil

Re: [Libguestfs] [PATCH] v2v: update documentation on nbdkit (RHBZ#1605242)

2019-04-12 Thread Richard W.M. Jones
On Fri, Apr 12, 2019 at 04:22:18PM +0200, Pino Toscano wrote: > nbdkit >= 1.6 ships a VDDK plugin always built, so recommend that > version instead of recommending to build nbdkit from sources. > --- > v2v/virt-v2v-input-vmware.pod | 28 ++-- > 1 file changed, 2 insertions(

Re: [Libguestfs] [supermin PATCH 5/5] utils: remove unused 'compare_architecture' function

2019-04-12 Thread Richard W.M. Jones
ACK series, thanks. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supp

[Libguestfs] [PATCH] v2v: update documentation on nbdkit (RHBZ#1605242)

2019-04-12 Thread Pino Toscano
nbdkit >= 1.6 ships a VDDK plugin always built, so recommend that version instead of recommending to build nbdkit from sources. --- v2v/virt-v2v-input-vmware.pod | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/v2v/virt-v2v-input-vmware.pod b/v2v/vi

Re: [Libguestfs] nbdkit, VDDK, extents, readahead, etc

2019-04-12 Thread Martin Kletzander
On Thu, Apr 11, 2019 at 06:55:55PM +0100, Richard W.M. Jones wrote: As I've spent really too long today investigating this, I want to document this in a public email, even though there's nothing really that interesting here. One thing you find from search for VDD 6.7 / VixDiskLib_QueryAllocatedB

Re: [Libguestfs] [RFC PATCH] protocol: Add NBD_CMD_FLAG_FAST_ZERO

2019-04-12 Thread Kevin Wolf
Am 12.04.2019 um 09:44 hat Richard W.M. Jones geschrieben: > So I had a think about this. > > Isn't this easier/better solved by lifting the 32 bit restriction on > the size of certain non-data requests (ie. NBD_CMD_BLOCK_STATUS, > NBD_CMD_TRIM, NBD_CMD_WRITE_ZEROES). The client can then query th

[Libguestfs] [supermin PATCH 0/5] rpm: fix package selection w/ multilib

2019-04-12 Thread Pino Toscano
This patch series fixes the way supermin sorts the list of installed packages when resolving a name, picking the right package for the host architecture. Pino Toscano (5): rpm: do not unpack parameters rpm: fix version comparison rpm: query the RPM architecture rpm: fix package sorting (RH

[Libguestfs] [supermin PATCH 1/5] rpm: do not unpack parameters

2019-04-12 Thread Pino Toscano
They will be used as parameters again soon. This has no behaviour changes. --- src/ph_rpm.ml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ph_rpm.ml b/src/ph_rpm.ml index 3ff5c94..6769e7b 100644 --- a/src/ph_rpm.ml +++ b/src/ph_rpm.ml @@ -144,10 +144,10 @@ let rpm_

[Libguestfs] [supermin PATCH 4/5] rpm: fix package sorting (RHBZ#1696822)

2019-04-12 Thread Pino Toscano
The sorting algorithm for RPMs sorted this way: - before the packages with the higher versions - among the packages with the version version, first noarch packages, then 64bit packages, and then 32bit packages This was broken in at least two ways: - the higher installed version may not be of the

[Libguestfs] [supermin PATCH 5/5] utils: remove unused 'compare_architecture' function

2019-04-12 Thread Pino Toscano
This was used only in the RPM package handler. --- src/utils.ml | 27 --- src/utils.mli | 3 --- 2 files changed, 30 deletions(-) diff --git a/src/utils.ml b/src/utils.ml index f85418f..b25df88 100644 --- a/src/utils.ml +++ b/src/utils.ml @@ -172,33 +172,6 @@ and split_v

[Libguestfs] [supermin PATCH 3/5] rpm: query the RPM architecture

2019-04-12 Thread Pino Toscano
Query the RPM library for the current architecture of RPM, storing it for later use, and printing it to the debug output. --- src/librpm-c.c | 10 ++ src/librpm.ml | 1 + src/librpm.mli | 3 +++ src/ph_rpm.ml | 8 ++-- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git

[Libguestfs] [supermin PATCH 2/5] rpm: fix version comparison

2019-04-12 Thread Pino Toscano
When comparing two RPMs, also the epoch, and the release must be taken into account. Hence, add a new helper to get the EVR string of a package, and use it when sorting each list of installed packages. The mapping is done to avoid recreating the EVR strings at every comparison. --- src/ph_rpm.ml

Re: [Libguestfs] [RFC PATCH] protocol: Add NBD_CMD_FLAG_FAST_ZERO

2019-04-12 Thread Richard W.M. Jones
So I had a think about this. Isn't this easier/better solved by lifting the 32 bit restriction on the size of certain non-data requests (ie. NBD_CMD_BLOCK_STATUS, NBD_CMD_TRIM, NBD_CMD_WRITE_ZEROES). The client can then query the disk efficiently to see if it starts as zeroes, and can decide on t