yes, this system tailor it's kernel ,reduce the "CONFIG_VIRT_DRIVERS=y "
,this cause the vm fail to start .
after add the virtio driver config ,then recompile the kernel ,
libguestfs-test-tool run successfully .
thanks for help !
thomas.kuang .
At 2019-12-03
This is the third attempt to make the stats filter better. This time I kept the
changes minimal to make it eaier to make progress.
I tried the idea of showing global stats in separate "total" section, but it
became messy and hard to implemnt, so I tried the simpler solution of showing
both
Returns non-null string or "(n/a)".
---
filters/stats/stats.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/filters/stats/stats.c b/filters/stats/stats.c
index 6e48017..44f3379 100644
--- a/filters/stats/stats.c
+++ b/filters/stats/stats.c
@@ -94,6 +94,12 @@
I tried to show the total rate separately, but it becomes messy. Adding
the total rate in the same line is easy, so lets start with this.
Showing both values in the same line may be confusing, so I added
labels:
read: 254 ops, 0.000326 s, 4.78 MiB, 14.31 GiB/s op, 3.80 MiB/s total
---
Use microseconds resolution so we get meaningful data even for rarely
called and fast operation like flush or extents. For consistency, use
same format in for elapsed time.
---
filters/stats/nbdkit-stats-filter.pod | 10 +-
filters/stats/stats.c | 7 ---
2 files
Change the first line to show total ops, time, total size, and rate.
The totals are useful for understanding the total throughput of the
application.
---
filters/stats/nbdkit-stats-filter.pod | 8
filters/stats/stats.c | 19 ++-
2 files changed, 22
We want to show both operation rate based on time spent in operation,
and global rate, based on elapsed time. Add a helper to make it easier.
---
filters/stats/stats.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/filters/stats/stats.c b/filters/stats/stats.c
On Wed, Dec 4, 2019 at 2:48 PM Richard W.M. Jones wrote:
>
> On Wed, Dec 04, 2019 at 01:45:54AM +0200, Nir Soffer wrote:
> > On Mon, Dec 2, 2019 at 12:28 PM Richard W.M. Jones
> > wrote:
> > >
> > >
> > > I have pushed some parts of these patches in order to reduce the delta
> > > between your
On Wed, Dec 4, 2019 at 2:46 PM Richard W.M. Jones wrote:
>
>
> I fixed a few things including whitespace, dealing with divide by
> zero, and allocation failure. How about the attached version?
Thanks, looks better.
___
Libguestfs mailing list
Sorry I missed these patches before, thanks for reminding me.
Yes both series are fine. I don't particularly care about needing
Powershell since I believe all *supported* versions of Windows now
have it, or (in the XP case) are upgradable to having it as long as
you make the very reasonable
On Wed, Dec 04, 2019 at 01:45:54AM +0200, Nir Soffer wrote:
> On Mon, Dec 2, 2019 at 12:28 PM Richard W.M. Jones wrote:
> >
> >
> > I have pushed some parts of these patches in order to reduce the delta
> > between your patches and upstream. However still some problems with
> > the series:
> >
>
I fixed a few things including whitespace, dealing with divide by
zero, and allocation failure. How about the attached version?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Simpifies things a bit, especially the function to run curl without
using a temporary file, and the function to read a whole file.
ACK series,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog:
13 matches
Mail list logo
