Re: [Libguestfs] [PATCH 1/1] WIP: sparsify: Support LUKS-encrypted partitions

2020-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2020 at 03:07:12PM +0100, Jan Synacek wrote: > --- > daemon/listfs.ml | 18 +++--- > daemon/luks.c| 1 + > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/daemon/listfs.ml b/daemon/listfs.ml > index bf4dca6d4..48880f2e5 100644 > ---

Re: [Libguestfs] [PATCH 0/1] WIP: Support LUKS-encrypted partitions

2020-01-21 Thread Richard W.M. Jones
On Tue, Jan 21, 2020 at 03:07:11PM +0100, Jan Synacek wrote: > The following patch attempts to implement sparsification of > LUKS-encrypted partitions. It uses lsblk to pair the underlying LUKS > block device with its mapped name. Also, --allow-discards was added > by default to luks_open(). > >

[Libguestfs] [PATCH 1/1] WIP: sparsify: Support LUKS-encrypted partitions

2020-01-21 Thread Jan Synacek
--- daemon/listfs.ml | 18 +++--- daemon/luks.c| 1 + 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/daemon/listfs.ml b/daemon/listfs.ml index bf4dca6d4..48880f2e5 100644 --- a/daemon/listfs.ml +++ b/daemon/listfs.ml @@ -19,6 +19,7 @@ open Printf open

[Libguestfs] [PATCH 0/1] WIP: Support LUKS-encrypted partitions

2020-01-21 Thread Jan Synacek
The following patch attempts to implement sparsification of LUKS-encrypted partitions. It uses lsblk to pair the underlying LUKS block device with its mapped name. Also, --allow-discards was added by default to luks_open(). There are several potential issues that I can think of: 1) If and entire

Re: [Libguestfs] [PATCH] nbdkit: fix condition in probe_filter

2020-01-21 Thread Richard W.M. Jones
On Mon, Jan 20, 2020 at 02:05:41PM +0100, Tomáš Golembiovský wrote: > The tests assume probe_filter returns true if the filter is available > (and not the other way around). > > Signed-off-by: Tomáš Golembiovský > --- > v2v/nbdkit.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Libguestfs] [PATCH] vCenter: pass user name to nbdkit curl plugin

2020-01-21 Thread Richard W.M. Jones
On Mon, Jan 20, 2020 at 04:54:35PM +0100, Tomáš Golembiovský wrote: > Signed-off-by: Tomáš Golembiovský > --- > v2v/vCenter.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/v2v/vCenter.ml b/v2v/vCenter.ml > index 89c5579b..d9bf12c1 100644 > --- a/v2v/vCenter.ml > +++

Re: [Libguestfs] [PATCH] nbdkit: fix condition in probe_filter

2020-01-21 Thread Richard W.M. Jones
On Mon, Jan 20, 2020 at 02:05:41PM +0100, Tomáš Golembiovský wrote: > The tests assume probe_filter returns true if the filter is available > (and not the other way around). > > Signed-off-by: Tomáš Golembiovský > --- > v2v/nbdkit.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >