Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Richard W.M. Jones
On Wed, Dec 15, 2021 at 04:40:22PM +0100, Laszlo Ersek wrote: > On 12/15/21 16:34, Richard W.M. Jones wrote: > > On Wed, Dec 15, 2021 at 03:33:00PM +, Richard W.M. Jones wrote: > >> On Wed, Dec 15, 2021 at 04:14:42PM +0100, Laszlo Ersek wrote: > >>> Before posting v2, I intended to test it :) ,

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Laszlo Ersek
On 12/15/21 16:34, Richard W.M. Jones wrote: > On Wed, Dec 15, 2021 at 03:33:00PM +, Richard W.M. Jones wrote: >> On Wed, Dec 15, 2021 at 04:14:42PM +0100, Laszlo Ersek wrote: >>> Before posting v2, I intended to test it :) , so I installed a new RHEL5 >>> guest, and tried to run virt-v2v (wit

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Richard W.M. Jones
On Wed, Dec 15, 2021 at 03:33:00PM +, Richard W.M. Jones wrote: > On Wed, Dec 15, 2021 at 04:14:42PM +0100, Laszlo Ersek wrote: > > Before posting v2, I intended to test it :) , so I installed a new RHEL5 > > guest, and tried to run virt-v2v (with the v2 patch) on it: > > > > virt-v2v -i libv

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Richard W.M. Jones
On Wed, Dec 15, 2021 at 04:14:42PM +0100, Laszlo Ersek wrote: > Before posting v2, I intended to test it :) , so I installed a new RHEL5 > guest, and tried to run virt-v2v (with the v2 patch) on it: > > virt-v2v -i libvirt -o local -os ~/output rhel5.11 As a general comment, you might want to ch

[Libguestfs] [v2v PATCH v2] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Laszlo Ersek
If the only CD-ROM in "s_removables" is on an IDE controller, and the guest kernel represents it with a /dev/hdX device node, then convert references to this device node, in the boot config files, to /dev/cdrom. On the destination (after conversion), /dev/cdrom will point to whataver node we conver

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Laszlo Ersek
On 12/15/21 11:57, Richard W.M. Jones wrote: > On Wed, Dec 15, 2021 at 11:17:51AM +0100, Laszlo Ersek wrote: >> I *really* dislike the one aspect of the current multi-line messages >> that they are nailed to column #0. It disrupts the code flow for me. For >> example, consider the following snippet

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Laszlo Ersek
On 12/15/21 16:14, Laszlo Ersek wrote: > Before posting v2, I intended to test it :) , so I installed a new RHEL5 > guest, and tried to run virt-v2v (with the v2 patch) on it: > > virt-v2v -i libvirt -o local -os ~/output rhel5.11 > > Unfortunately, things break before my code gets a chance to r

[Libguestfs] [v2v PATCH] test-v2v-o-libvirt: undefine temporary guest when exiting

2021-12-15 Thread Laszlo Ersek
I've noticed that my libvirtd host that I use for v2v development is littered with tmp-* guests. Re-enable the "virsh undefine" command. Signed-off-by: Laszlo Ersek --- tests/test-v2v-o-libvirt.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test-v2v-o-libvirt.sh b

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Richard W.M. Jones
On Wed, Dec 15, 2021 at 11:17:51AM +0100, Laszlo Ersek wrote: > I *really* dislike the one aspect of the current multi-line messages > that they are nailed to column #0. It disrupts the code flow for me. For > example, consider the following snippet from this very file > [convert/convert_linux.ml]:

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Laszlo Ersek
On 12/14/21 21:51, Richard W.M. Jones wrote: > On Tue, Dec 14, 2021 at 08:46:45PM +, Richard W.M. Jones wrote: >> On Tue, Dec 14, 2021 at 04:17:49PM +0100, Laszlo Ersek wrote: >>> +match cdroms with >>> +| _ :: _ :: _ -> warning (f_"multiple CD-ROMs found; translation of \ >>> +

Re: [Libguestfs] [PATCH] convert_linux: translate the first CD-ROM's references in boot conf files

2021-12-15 Thread Laszlo Ersek
On 12/14/21 21:46, Richard W.M. Jones wrote: > On Tue, Dec 14, 2021 at 04:17:49PM +0100, Laszlo Ersek wrote: >> +match cdroms with >> +| _ :: _ :: _ -> warning (f_"multiple CD-ROMs found; translation of \ >> + CD-ROM references may be inexact") >> +| _ ->