Re: [Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

2023-03-03 Thread Laszlo Ersek
On 3/3/23 23:15, Eric Blake wrote: > In libnbd, we quickly learned that distinguishing between 'handle' > (verb for acting on an object) and 'handle' (noun describing which > object to act on) could get confusing; we solved it by renaming the > latter to 'cookie'. Copy that approach into the NBD s

Re: [Libguestfs] [nbdkit PATCH 0/9] common: catch up with libnbd

2023-03-03 Thread Laszlo Ersek
On 3/3/23 20:18, Eric Blake wrote: > On Fri, Mar 03, 2023 at 07:00:16PM +, Richard W.M. Jones wrote: >> >> This series looks, great, thanks! >> >> ACK > > ACK from me as well; I didn't spot any problems in my read through. > Thank you both for reviewing this; commit range 648a7909b69e..e36cf

Re: [Libguestfs] [PATCH v2 5/6] spec: Introduce NBD_FLAG_BLOCK_STATUS_PAYLOAD

2023-03-03 Thread Eric Blake
On Wed, Feb 22, 2023 at 12:05:44PM +0200, Wouter Verhelst wrote: > On Mon, Nov 14, 2022 at 04:46:54PM -0600, Eric Blake wrote: > > Simple reply message > > > > @@ -1232,6 +1235,19 @@ The field has the following format: > >will be faster than a regular write). Clients MUST NOT set the > >

Re: [Libguestfs] [PATCH v2 3/6] spec: Add NBD_OPT_EXTENDED_HEADERS

2023-03-03 Thread Eric Blake
On Wed, Feb 22, 2023 at 11:49:18AM +0200, Wouter Verhelst wrote: > On Mon, Nov 14, 2022 at 04:46:52PM -0600, Eric Blake wrote: > [...] > > @@ -1370,9 +1475,10 @@ of the newstyle negotiation. > > Return a list of `NBD_REP_META_CONTEXT` replies, one per context, > > followed by an `NBD_REP_

Re: [Libguestfs] [PATCH v2 2/6] spec: Tweak description of maximum block size

2023-03-03 Thread Eric Blake
On Tue, Feb 21, 2023 at 05:21:37PM +0200, Wouter Verhelst wrote: > Hi Eric, > > Busy days, busy times. Sorry about the insane delays here. No problem; I've been tackling other things in the meantime too, so this extension has taken far longer than I planned for more reasons than just slow review

Re: [Libguestfs] [PATCH v2 2/6] spec: Tweak description of maximum block size

2023-03-03 Thread Eric Blake
On Fri, Dec 16, 2022 at 11:22:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 11/15/22 01:46, Eric Blake wrote: > > Commit 9f30fedb improved the spec to allow non-payload requests that > > exceed any advertised maximum block size. Take this one step further > > by permitting the server to use

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-03 Thread Eric Blake
On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 11/15/22 01:46, Eric Blake wrote: > > The spec was silent on how many extents a server could reply with. > > However, both qemu and nbdkit (the two server implementations known to > > have implemented the NBD_CMD_BLO

[Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

2023-03-03 Thread Eric Blake
In libnbd, we quickly learned that distinguishing between 'handle' (verb for acting on an object) and 'handle' (noun describing which object to act on) could get confusing; we solved it by renaming the latter to 'cookie'. Copy that approach into the NBD spec, and make it obvious that a cookie is o

Re: [Libguestfs] [nbdkit PATCH 0/9] common: catch up with libnbd

2023-03-03 Thread Eric Blake
On Fri, Mar 03, 2023 at 07:00:16PM +, Richard W.M. Jones wrote: > > This series looks, great, thanks! > > ACK ACK from me as well; I didn't spot any problems in my read through. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | l

Re: [Libguestfs] [nbdkit PATCH 0/9] common: catch up with libnbd

2023-03-03 Thread Richard W.M. Jones
This series looks, great, thanks! ACK Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html __

Re: [Libguestfs] [V2V PATCH 0/5] Bring support for virtio-scsi back to Windows

2023-03-03 Thread Richard W.M. Jones
On Thu, Mar 02, 2023 at 11:31:14PM +0200, Andrey Drobyshev wrote: > On 3/2/23 22:59, Richard W.M. Jones wrote: > > On Thu, Mar 02, 2023 at 08:52:33PM +0200, Andrey Drobyshev wrote: > >> On 3/2/23 20:36, Richard W.M. Jones wrote: > >>> I can probably do an outline of a patch if you need it, but > >>