Re: [Libguestfs] [PATCH libnbd 1/2] info: Avoid calling nbd_opt_abort if not in option negotiation mode

2023-06-13 Thread Richard W.M. Jones
On Mon, Jun 12, 2023 at 02:32:21PM -0500, Eric Blake wrote: > On Mon, Jun 12, 2023 at 07:27:52PM +0100, Richard W.M. Jones wrote: > > This change avoids the following harmless but annoying warning on the > > normal exit path: > > > > libnbd: debug: nbd1: nbd_opt_abort: enter: > > libnbd: debug: nb

Re: [Libguestfs] [PATCH libnbd 2/2] generator: state machine: Be less verbose in debug messages

2023-06-13 Thread Richard W.M. Jones
On Mon, Jun 12, 2023 at 02:38:44PM -0500, Eric Blake wrote: > On Mon, Jun 12, 2023 at 07:27:53PM +0100, Richard W.M. Jones wrote: > > Logging state transitions in debug mode produces huge amounts of > > output which is not especially helpful. This change removes this > > debugging output. This re

[Libguestfs] [PATCH nbdkit 1/3] tests/test-tar-info*: Remove bogus test requires of guestfish

2023-06-13 Thread Richard W.M. Jones
These tests don't need guestfish so don't test for it. Fixes: commit 05b49f89dccb0ca3fd0919e9502c54dbcadf0b73 --- tests/test-tar-info-xz.sh | 1 - tests/test-tar-info.sh| 1 - 2 files changed, 2 deletions(-) diff --git a/tests/test-tar-info-xz.sh b/tests/test-tar-info-xz.sh index 1f968e9b8..

[Libguestfs] [PATCH nbdkit 3/3] tar: Implement tar-limit

2023-06-13 Thread Richard W.M. Jones
This can be used to ensure that the tar filter does not read indefinite amounts of input when opening the tar file. See: https://github.com/kubevirt/containerized-data-importer/pull/2748#issuecomment-1589852102 --- filters/tar/nbdkit-tar-filter.pod | 19 + tests/Makefile.am

[Libguestfs] [PATCH nbdkit 2/3] tar: Document the optional tar option in --help output

2023-06-13 Thread Richard W.M. Jones
--- filters/tar/tar.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/filters/tar/tar.c b/filters/tar/tar.c index c650a3499..f3adb2c46 100644 --- a/filters/tar/tar.c +++ b/filters/tar/tar.c @@ -96,8 +96,9 @@ tar_config_complete (nbdkit_next_config_complete *next, return

[Libguestfs] [PATCH nbdkit 0/3] tar: Implement tar-limit

2023-06-13 Thread Richard W.M. Jones
This patch series cleans up some issues with nbdkit-tar-filter and (in patch 3) implements a new tar-limit feature which limits how much of the tar file we will read to find the entry within the tar file that we will serve. This protects against the case where a tar file is presented that contains