Re: [Libguestfs] [PATCH v2 3/3] rust: add some (but not yet all) tests

2023-06-26 Thread Richard W.M. Jones
[...] It looks like the test coverage is increasing, so that's good. > +//! This module provides facilities for capturing log output and asserting > that > +//! it does or does not contain certain messages. The primary use of this > module > +//! is to assert that certain libnbd operations are

Re: [Libguestfs] [PATCH v2 2/3] rust: create basic Rust bindings

2023-06-26 Thread Richard W.M. Jones
On Mon, Jun 26, 2023 at 08:02:08AM +, Tage Johansson wrote: > diff --git a/generator/generator.ml b/generator/generator.ml > index c73824e..18856f5 100644 > --- a/generator/generator.ml > +++ b/generator/generator.ml > @@ -61,3 +61,5 @@ let () = >output_to "golang/closures.go" GoLang.genera

Re: [Libguestfs] [PATCH v2 1/3] generator: Move [camel_case] function from GoLang.ml to utils.ml as it will be used in Rust.ml as well

2023-06-26 Thread Richard W.M. Jones
Thanks, this one is upstream in commit 557ed93df3. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows inst

Re: [Libguestfs] nbdkit | Failed pipeline for master | 9d4b87e0

2023-06-26 Thread Richard W.M. Jones
On Thu, Jun 22, 2023 at 11:36:55AM +0100, Richard W.M. Jones wrote: > On Wed, Jun 21, 2023 at 10:07:34PM +, GitLab wrote: > > GitLab > >✖ Pipeline #907639365 has failed! > > > > Project nbdkit / nbdkit > > Branch● master > > Commit● 9d4b87e0 > >

[Libguestfs] [PATCH v2 3/3] rust: add some (but not yet all) tests

2023-06-26 Thread Tage Johansson
From: Tage Johansson --- rust/Cargo.toml | 3 + rust/Makefile.am| 1 + rust/run-tests.sh | 6 +- rust/tests/test_100_handle.rs | 25 +++ rust/tests/test_110_defaults.rs | 33 ++ rust/tests/test

[Libguestfs] [PATCH v2 1/3] generator: Move [camel_case] function from GoLang.ml to utils.ml as it will be used in Rust.ml as well

2023-06-26 Thread Tage Johansson
From: Tage Johansson --- generator/GoLang.ml | 11 --- generator/utils.ml | 8 generator/utils.mli | 3 +++ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/generator/GoLang.ml b/generator/GoLang.ml index 4ab6b26..50ed722 100644 --- a/generator/GoLang.ml +++ b

[Libguestfs] Rust Bindings for Libnbd

2023-06-26 Thread Tage Johansson
>> +let hidden_handle_calls : NameSt.t = + NameSet.of_list +[ >> "get_debug"; "set_debug"; "set_debug_callback"; >> "clear_debug_callback" ] > > So, hmm. Isn't it better to track this in the API.ml file? Perhaps, but it is only specific to Rust, so I thought it was best placed in the Rust.ml