Re: [Libguestfs] virt-v2v: default graphics driver for SUSE guests

2019-03-01 Thread Mike Latimer
Hi Pino, On 2/26/19 5:52 PM, Mike Latimer wrote: > On 2/21/19 3:07 AM, Pino Toscano wrote: >> My question is: is using cirrus still the best choice for SUSE guests? >> If not, what about using qxl as well, as done for any non-SUSE guest? >> (We can also do that depending

Re: [Libguestfs] virt-v2v: default graphics driver for SUSE guests

2019-02-27 Thread Mike Latimer
Hi Pino, On 2/21/19 3:07 AM, Pino Toscano wrote: > in 2013 you added the support for SUSE guests in the old virt-v2v (the > one written in Perl); the commit doing it is attached, since the old > virt-v2v was hosted on fedorahosted.org, which is no more. > As part of that change, the default graphi

Re: [Libguestfs] missing btrfs subvol support

2014-10-10 Thread Mike Latimer
On Friday, October 10, 2014 03:07:51 PM Olaf Hering wrote: > Thanks for the pointers. I will poke around. At least augtool on the > host seems to behave correctly: I don't think this is related to Augeas. Instead, I think it's the naming convention SUSE uses for the root btrfs subvolume (@). I e

Re: [Libguestfs] [PATCH] virt-v2v: Catch invalid initrd path

2014-04-28 Thread Mike Latimer
On Friday, April 25, 2014 08:58:24 PM Richard W.M. Jones wrote: > Sorry for the late reply, but I've been buried in the v2v rewrite for > the past few days. I will take this patch into account when I get > back to the Linux conversion part. No problem. Thanks for looking at it. Regarding the re-

Re: [Libguestfs] Root btrfs partition listed twice?

2014-04-28 Thread Mike Latimer
On Monday, April 28, 2014 10:02:54 AM Matthew Booth wrote: > >> For the record, here's the full filesystem list: > >>> list-filesystems > >> > >> /dev/sda1: swap > >> btrfsvol:/dev/sda2/@: btrfs > >> btrfsvol:/dev/sda2/boot/grub2/i386-pc: btrfs [...] > >> btrfsvol:/dev/sda2/.snapshots: btrfs > >>

[Libguestfs] Root btrfs partition listed twice?

2014-04-25 Thread Mike Latimer
Hi, I know btrfs complicates filesystem lists due to the use of subvolumes. However, I just noticed that the root partition itself ends up being listed twice with list-filesystems, inspect-os, inspect-get-roots, etc... I'm seeing this in version 1.26, but haven't found anything directly resolv

[Libguestfs] [PATCH] virt-v2v: Catch invalid initrd path

2014-04-24 Thread Mike Latimer
In some cases (specifically, SUSE grub2 environments) it is possible to fail to update the block entries in device.map. In turn, this causes an invalid path to be returned in perl-Bootloader code, which causes the conversion to fail with the following message: is_file_opts: is_file: is_file_stub:

[Libguestfs] [PATCH] virt-v2v: Fix typo in Windows conversion warning message

2014-01-03 Thread Mike Latimer
--- lib/Sys/VirtConvert/Converter/Windows.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 765ed9f..59d273f 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm +++ b/lib/Sys/VirtConve

[Libguestfs] [PATCH] virt-v2v: Default to non-virtio drivers if driver path is missing

2014-01-03 Thread Mike Latimer
During a Windows conversion, _prepare_virtio_drivers aborts the conversion completely if the configured virtio driver path does not exist. If the path exists but is empty, the conversion completes correctly by defaulting to the non-virtio drivers. This patch treats a missing directory just like mis

[Libguestfs] [PATCH] virt-v2v: Check for firstboot before unconfiguring XenPV

2014-01-03 Thread Mike Latimer
Although not fatal, _unconfigure_xenpv should report a warning and return if firstboot is not available (during Windows conversions). --- lib/Sys/VirtConvert/Converter/Windows.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConv

Re: [Libguestfs] [PATCH 0/4] virt-v2v: Add support for SUSE guest conversions

2013-11-26 Thread Mike Latimer
On Tuesday, November 26, 2013 03:05:18 PM Matthew Booth wrote: > Thanks, Mike. I've pushed all of these. There were a couple of trivial > bugs in patch 2, but nothing worth an extra round of review. To keep > things simple I pushed the fixes as separate commits. Thanks for the review and help, Mat

[Libguestfs] [PATCH 3/4] Add SUSE to capabilities db and conf

2013-11-07 Thread Mike Latimer
This adds SUSE and openSUSE capabilities to the virt-v2v.db. It also adds a SUSE custom package example, and br0 -> default network map example. --- v2v/virt-v2v.conf | 8 ++ v2v/virt-v2v.db | 73 +++ 2 files changed, 81 insertions(+) di

[Libguestfs] [PATCH 1/4] Add perl-Bootloader support to grub packages

2013-11-07 Thread Mike Latimer
In addition to adding perl-Bootloader support to grub packages, this patch also removes '$root' from the list of parameters being passed to check, as there is nothing which uses this. --- lib/Sys/VirtConvert/Converter/Linux.pm | 46 +++--- 1 file changed, 42 insertions

[Libguestfs] [PATCH 2/4] Add conversion support for SUSE guests

2013-11-07 Thread Mike Latimer
Main set of changes required to support SUSE guest conversions. --- lib/Sys/VirtConvert/Converter/Linux.pm | 434 - 1 file changed, 374 insertions(+), 60 deletions(-) diff --git a/lib/Sys/VirtConvert/Converter/Linux.pm b/lib/Sys/VirtConvert/Converter/Linux.pm ind

[Libguestfs] [PATCH 0/4] virt-v2v: Add support for SUSE guest conversions

2013-11-07 Thread Mike Latimer
The following series of patches adds support for converting SUSE guests through virt-v2v. These changes should not impact non-SUSE guest conversions. Mike Latimer (4): Add perl-Bootloader support to grub packages Add conversion support for SUSE guests Add SUSE to capabilities db and conf

[Libguestfs] [PATCH 4/4] Add SUSE support documentation

2013-11-07 Thread Mike Latimer
--- v2v/virt-v2v.pl | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/v2v/virt-v2v.pl b/v2v/virt-v2v.pl index e1dac4a..8fc6fd8 100755 --- a/v2v/virt-v2v.pl +++ b/v2v/virt-v2v.pl @@ -57,9 +57,9 @@ virt-v2v - Convert a guest to use KVM virt-v2v converts guest

Re: [Libguestfs] [PATCH 0/4] virt-v2v: Convert RedHat.pm to Linux.pm

2013-11-06 Thread Mike Latimer
On Wednesday, November 06, 2013 04:47:37 PM Matthew Booth wrote: > Thanks, Mike. ACK to all of these, and pushed. Thank you! > As it happens, I'd already started breaking some of this stuff out > myself when I found this patchset :/ Rather than redo it, I've kept what > I'd already done and rebas

[Libguestfs] [PATCH 2/4] Make Linux.pm more generic

2013-10-31 Thread Mike Latimer
--- lib/Sys/VirtConvert/Converter/Linux.pm | 125 + 1 file changed, 97 insertions(+), 28 deletions(-) diff --git a/lib/Sys/VirtConvert/Converter/Linux.pm b/lib/Sys/VirtConvert/Converter/Linux.pm index dd3573e..344d89b 100644 --- a/lib/Sys/VirtConvert/Converter/Lin

[Libguestfs] [PATCH 1/4] Rename RedHat.pm to Linux.pm

2013-10-31 Thread Mike Latimer
--- MANIFEST | 2 +- .../VirtConvert/Converter/{RedHat.pm => Linux.pm} | 39 +++--- po/POTFILES.in | 2 +- 3 files changed, 22 insertions(+), 21 deletions(-) diff --git a/MANIFEST b/MANIFEST index 372

[Libguestfs] [PATCH 4/4] Support multiple display types through guestcaps

2013-10-31 Thread Mike Latimer
--- lib/Sys/VirtConvert/Connection/LibVirtTarget.pm | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/Sys/VirtConvert/Connection/LibVirtTarget.pm b/lib/Sys/VirtConvert/Connection/LibVirtTarget.pm index 6a09800..911a7da 100644 --- a/lib/Sys/VirtConvert/Connect

[Libguestfs] [PATCH 3/4] Handle block remaps in grub and grub2 files

2013-10-31 Thread Mike Latimer
--- lib/Sys/VirtConvert/Converter/Linux.pm | 61 ++ 1 file changed, 54 insertions(+), 7 deletions(-) diff --git a/lib/Sys/VirtConvert/Converter/Linux.pm b/lib/Sys/VirtConvert/Converter/Linux.pm index 344d89b..531d72b 100644 --- a/lib/Sys/VirtConvert/Converter/Linu

[Libguestfs] [PATCH 0/4] virt-v2v: Convert RedHat.pm to Linux.pm

2013-10-31 Thread Mike Latimer
legacy and grub2 environments - Allows for qxl or cirrus settings in LibVirtTarget.pm (based on passing guestcaps->{display} from the conversion. I'll submit the SUSE-specific changes after we work through any issues raised here. Mike Latimer (4): Rename RedHat.pm to Linux.pm Make

[Libguestfs] [PATCH] virt-v2v: Add use augeas_error to GrubLegacy, plus typo fixup

2013-10-31 Thread Mike Latimer
The following patch adds augeas_error to the Sys::VirtConvert::Util use statement for GrubLegacy (matching what is used in the Grub2 package). This is required to prevent an undefined subroutine error for the augeas_error call in list_kernels(). There are also a few minor typo fixups: - A messag

Re: [Libguestfs] [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support

2013-10-16 Thread Mike Latimer
On Friday, October 11, 2013 07:05:25 PM Mike Latimer wrote: > +# Add grub or grub2 files to the checklist > +if (defined($grub->{grub_conf})) { > +push (@checklist, "/files$grub->{grub_conf}*/kernel/root"); > +push (@checkli

Re: [Libguestfs] [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support

2013-10-11 Thread Mike Latimer
On Friday, October 11, 2013 04:57:32 PM Mike Latimer wrote: > I think I've addressed all the concerns you raised in the following patch. > Can you take a look and let me know if I've created any new ones? ;) Other than the concern about being a little too obsessed about the 79

Re: [Libguestfs] [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support

2013-10-11 Thread Mike Latimer
On Tuesday, October 08, 2013 10:05:17 AM Matthew Booth wrote: > Feel free to remove ^$path. However, for robustness I ditch the leading > ^ from your replacement. The difference will be down to a different > version of file included in the libguestfs appliance on SUSE. I think I've addressed all t

Re: [Libguestfs] [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support

2013-10-08 Thread Mike Latimer
On Tuesday, October 08, 2013 10:05:17 AM Matthew Booth wrote: > Feel free to remove ^$path. However, for robustness I ditch the leading > ^ from your replacement. The difference will be down to a different > version of file included in the libguestfs appliance on SUSE. Ok. > _install_config shoul

Re: [Libguestfs] [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support

2013-10-07 Thread Mike Latimer
On Friday, October 04, 2013 09:38:58 AM Matthew Booth wrote: > It's specifically an error if we're attempting to configure virtio, and > there's no detected virtio kernel. It shouldn't have been possible to > get here in that state, hence it's a programmer error. The code below > attempts to instal

Re: [Libguestfs] [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support

2013-10-03 Thread Mike Latimer
Thanks for the comments, Matt. On Thursday, October 03, 2013 05:34:27 PM Matthew Booth wrote: > > -# There should be an installed virtio capable kernel if virtio was > > installed -die("virtio configured, but no virtio kernel found") > > +# Warn if there is no installed virtio capable

[Libguestfs] [PATCH 1/1] Track hd->sd block device remaps

2013-09-25 Thread Mike Latimer
--- lib/Sys/VirtConvert/Converter/RedHat.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/Sys/VirtConvert/Converter/RedHat.pm b/lib/Sys/VirtConvert/Converter/RedHat.pm index 36345e7..fc4f5f0 100644 --- a/lib/Sys/VirtConvert/Converter/RedHat.pm +++ b/li

[Libguestfs] [PATCH 0/1] virt-v2v: Track hd->sd block device remaps

2013-09-25 Thread Mike Latimer
the block devices (in such places as /etc/fstab, and /boot/grub/menu.lst), to skip the hd* devices, which leads to a later failure of the guest. This patch adds a hash to track the hd->sd remap, and later uses that hash to add hd->vd maps to the table. Mike Latimer (1): Track hd sd block

Re: [Libguestfs] [PATCH 3/4] Add SUSE converter

2013-09-25 Thread Mike Latimer
On Wednesday, September 25, 2013 05:31:08 PM Richard W.M. Jones wrote: > I thought your concern would be that you'd want similar functionality > in guestconv. Will this SuSE code need to be rewritten for guestconv? Yes, but not completely from scratch. As I mentioned in the other response, I inh

Re: [Libguestfs] [PATCH 3/4] Add SUSE converter

2013-09-25 Thread Mike Latimer
Matt, Thanks for the extensive comments. I'll go through them in detail, but it won't be until next week. For the time being, here's a quick take on some of the main issues: > I do have a major concern, though, which is this is basically a fork of > RedHat.pm. There are well over 1,000 identica

[Libguestfs] [PATCH 4/4] Add verbose logging switches to virt-v2v

2013-09-23 Thread Mike Latimer
This patch has only slight modifications since originally posted as: https://www.redhat.com/archives/libguestfs/2013-September/msg00031.html Although these messages are not always valuable, these changes do show progress when converting smaller guests. This patch also improves usability with -vv a

[Libguestfs] [PATCH 0/4] Add SUSE guest converter to virt-v2v

2013-09-23 Thread Mike Latimer
guest. (grubby is not used during SUSE conversions.) Feedback is welcome (particularly on my virt-v2v.db and messaging changes). -Mike Mike Latimer (4): Add SUSE support documentation to virt-v2v Add SUSE capabilities Add SUSE converter Add verbose logging switches to virt-v2v MAN

[Libguestfs] [PATCH 2/4] Add SUSE capabilities

2013-09-23 Thread Mike Latimer
The following modifications are required to adds conversion capabilities to the virt-v2v.db for SLES and openSUSE through: - Adding virtio capabilities for SLES10/11 and openSUSE 10/11/12. - Designating the rpm containing the cirrus video driver in SLES/openSUSE - Adding app definitions for

[Libguestfs] [PATCH 1/4] Add SUSE support documentation to virt-v2v

2013-09-23 Thread Mike Latimer
--- v2v/virt-v2v.pl | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/v2v/virt-v2v.pl b/v2v/virt-v2v.pl index 3832f67..5ae75ed 100755 --- a/v2v/virt-v2v.pl +++ b/v2v/virt-v2v.pl @@ -57,9 +57,9 @@ virt-v2v - Convert a guest to use KVM virt-v2v converts guest

Re: [Libguestfs] [PATCH] virt-v2v: Add verbose message logging

2013-09-05 Thread Mike Latimer
On Thursday, September 05, 2013 04:21:03 PM Mike Latimer wrote: > This patch adds the following startup options: > > -v | --verbose > Enables verbose messages logging > -vv > Verbose messages, plus sets LIBGUESTFS_TRACE=1 > -vvv > Ver

[Libguestfs] [PATCH] virt-v2v: Add verbose message logging

2013-09-05 Thread Mike Latimer
As a followup to the discussion on verbose logging for virt-v2v, this patch adds basic verbose messages in the main virt-v2v code. As Matt pointed out, the usefulness of these messages is limited as the time spent outside of data copying is trivial. However, when converting smaller guests, these me

Re: [Libguestfs] Status of virt-v2v?

2013-09-05 Thread Mike Latimer
On Thursday, September 05, 2013 04:47:09 PM you wrote: > It turns out that progress logging during the conversion isn't all that > useful. This is because the profile of any conversion is dominated by > the copy process. And when I say dominated, I mean potentially hours to > copy guest data, follo

Re: [Libguestfs] Status of virt-v2v?

2013-09-05 Thread Mike Latimer
On Thursday, September 05, 2013 12:00:44 PM Matthew Booth wrote: > guestconv is not intended to completely replace virt-v2v. Broadly > speaking, virt-v2v does 2 things: > > 1. Move guests between 2 hypervisors. > 2. Make changes to the guest required for a new hypervisor. > > The second is unique

Re: [Libguestfs] [PATCH] virt-v2v: Remove iface:ide parameter (RHBZ#895898)

2013-09-04 Thread Mike Latimer
On Wednesday, September 04, 2013 07:57:25 PM Richard W.M. Jones wrote: > I'll give you a bit of background to this (mis-)feature. The "iface" > optional argument was added so that you could use qemu's IDE interface > instead of whatever the default is (virtio-scsi, falling back to > virtio-blk).

Re: [Libguestfs] [PATCH] virt-v2v: Remove iface:ide parameter (RHBZ#895898)

2013-09-03 Thread Mike Latimer
On Tuesday, September 03, 2013 06:09:26 PM Mike Latimer wrote: > However, as mentioned in the bug, this parameter is likely no longer > required. Unless there is a use-case where this setting is required, it > seems like a good idea to remove it completely (which should work in > eithe

[Libguestfs] [PATCH] virt-v2v: Remove iface:ide parameter (RHBZ#895898)

2013-09-03 Thread Mike Latimer
The iface:ide parameter (used in the libguestfs add_drive call) does not work with a libvirt backend. The error usually seen is: 'iface' parameter is not supported by the libvirt attach-method at /usr/share/perl5/vendor_perl/Sys/VirtConvert/GuestfsHandle.pm line 96. This issue was previously me

[Libguestfs] [PATCH] virt-v2v: Fix 'isn't numeric in numeric gt' error in grub check (RHBZ#974441)

2013-09-03 Thread Mike Latimer
This patch fixes an incorrect integer comparison that results in the following error: Argument "/files/boot/grub/menu.lst/title[1]/kernel" isn't numeric in numeric gt (>) at /usr/share/perl5/vendor_perl/Sys/VirtConvert/Converter/RedHat.pm line 206. This problem is not fatal, but it can result

[Libguestfs] Status of virt-v2v?

2013-09-03 Thread Mike Latimer
Hi, I have recently been looking into virt-v2v, and noticed the mention of an upcoming rewrite in a few places. Is there a roadmap or post someplace that describes the future of this project? I've got a couple of patches against the current code base, and am wondering if they will still be con

Re: [Libguestfs] Status of virt-v2v?

2013-09-03 Thread Mike Latimer
On Tuesday, September 03, 2013 07:52:08 PM Richard W.M. Jones wrote: > Even better, there is a repo: https://github.com/mdbooth/guestconv Excellent. Thanks for the pointer. > Matt - can you push your latest commits, or is there a more canonical > repo that Mike can look at? The last changes in t