Re: [Libguestfs] [libnbd PATCH 04/10] generator: Add information about the lifetime of closures

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 08:34:37AM +, Tage Johansson wrote: > > On 7/25/2023 8:03 PM, Stefan Hajnoczi wrote: > > On Mon, Jul 24, 2023 at 09:04:15PM +0100, Richard W.M. Jones wrote: > > > On Mon, Jul 24, 2023 at 03:22:56PM -0400, Stefan Hajnoczi wrote: > > > &

Re: [Libguestfs] [libnbd PATCH 04/10] generator: Add information about the lifetime of closures

2023-07-25 Thread Stefan Hajnoczi
On Tue, Jul 25, 2023 at 06:46:06AM +, Tage Johansson wrote: > > On 7/24/2023 9:22 PM, Stefan Hajnoczi wrote: > > On Fri, Jul 21, 2023 at 11:37:09AM +0100, Richard W.M. Jones wrote: > > > On Fri, Jul 21, 2023 at 10:13:02AM +, Tage Johansson wrote: > > > >

Re: [Libguestfs] [libnbd PATCH 04/10] generator: Add information about the lifetime of closures

2023-07-25 Thread Stefan Hajnoczi
On Mon, Jul 24, 2023 at 09:04:15PM +0100, Richard W.M. Jones wrote: > On Mon, Jul 24, 2023 at 03:22:56PM -0400, Stefan Hajnoczi wrote: > > On Fri, Jul 21, 2023 at 11:37:09AM +0100, Richard W.M. Jones wrote: > > > On Fri, Jul 21, 2023 at 10:13:02AM +, Tage Johansson wrote: >

Re: [Libguestfs] [libnbd PATCH 04/10] generator: Add information about the lifetime of closures

2023-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2023 at 11:37:09AM +0100, Richard W.M. Jones wrote: > On Fri, Jul 21, 2023 at 10:13:02AM +, Tage Johansson wrote: > > > > On 7/19/2023 4:35 PM, Richard W.M. Jones wrote: > > >On Wed, Jul 19, 2023 at 09:09:48AM +, Tage Johansson wrote: > > >>Add a new field `cbkind` to the `

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-16 Thread Stefan Hajnoczi
> > >>On Wed, Jan 11, 2023 at 11:34:50AM -0500, Stefan Hajnoczi wrote: > > >>>On Sat, Jan 07, 2023 at 07:44:37PM +, Richard W.M. Jones wrote: > > >>>> > > >>>> This is upstream in nbdkit now: > > >>&g

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Sat, Jan 07, 2023 at 07:44:37PM +, Richard W.M. Jones wrote: > > This is upstream in nbdkit now: > https://gitlab.com/nbdkit/nbdkit/-/tree/master/plugins/blkio > > Another question: > > (6) vhost-user + "read-only" property acts a bit strangely. After > opening virtio-blk-vhost-user it t

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Wed, Jan 04, 2023 at 09:43:57PM +, Richard W.M. Jones wrote: > On Wed, Jan 04, 2023 at 06:14:34PM +, Richard W.M. Jones wrote: > > (3) It seems like some drivers require pre-allocated memory regions, > > and since some do that means we might as well implement this. It > > also seems lik

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Wed, Jan 04, 2023 at 07:01:24PM +, Richard W.M. Jones wrote: > (5) "The application is responsible for thread-safety. No thread > synchronization is necessary when a queue is only used from a single > thread. Proper synchronization is required when sharing a queue > between multiple threads.

Re: [Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]

2023-01-11 Thread Stefan Hajnoczi
On Wed, Jan 04, 2023 at 06:14:34PM +, Richard W.M. Jones wrote: > This is an incomplete outline implementation for a libblkio plugin for > nbdkit. At the moment it only supports reading the same ("capacity") > of the device, and not even reading or writing. I have some questions > about the l

Re: [Libguestfs] [libnbd] GSoC21: IO_uring optimization questions

2021-03-31 Thread Stefan Hajnoczi
On Tue, Mar 30, 2021 at 06:05:57PM +0100, Richard W.M. Jones wrote: > [Adding Stefan: Have we retro-fitted io_uring into any other libraries?] Not that I'm aware of. You could check Fedora or another Linux distro's packages to find what depends on liburing and then investigate those packages. Ste

Re: [Libguestfs] [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-20 Thread Stefan Hajnoczi
On Thu, Nov 16, 2017 at 06:00:54PM +, Richard W.M. Jones wrote: > On Thu, Nov 16, 2017 at 05:30:48PM +0000, Stefan Hajnoczi wrote: > > On Thu, Nov 16, 2017 at 3:10 PM, Richard W.M. Jones > > wrote: > > > Both local filesystems, but on different SATA devices. > >

Re: [Libguestfs] [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Stefan Hajnoczi
On Thu, Nov 16, 2017 at 3:10 PM, Richard W.M. Jones wrote: > On Thu, Nov 16, 2017 at 02:47:46PM +0000, Stefan Hajnoczi wrote: >> The threads you observed are the thread pool that performs >> preadv(2)/pwritev(2) syscalls. The Linux AIO API could be used instead >> and doe

Re: [Libguestfs] [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Stefan Hajnoczi
On Thu, Nov 16, 2017 at 3:12 PM, Richard W.M. Jones wrote: > On Thu, Nov 16, 2017 at 03:51:29PM +0100, Peter Lieven wrote: >> Afaik all writes to the same QCOW2 serialize because of the s->lock that >> is held during the write. So its not suprising that there is no benefit from >> mutliple threads

Re: [Libguestfs] [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Stefan Hajnoczi
On Wed, Nov 15, 2017 at 11:52:46AM +, Richard W.M. Jones wrote: > [CC to qemu-devel since I'm obviously doing something wrong here, > I'm just not sure what.] > > I was getting ready to add multiple threads to ‘qemu-img convert’ (the > longest part of v2v conversions) when I noticed that it ha

Re: [Libguestfs] Point-in-time snapshots (was: Re: Inspection of disk snapshots)

2015-03-30 Thread Stefan Hajnoczi
On Fri, Mar 27, 2015 at 03:35:02PM +, Richard W.M. Jones wrote: > On Fri, Mar 27, 2015 at 03:21:25PM +0000, Stefan Hajnoczi wrote: > > On Fri, Mar 27, 2015 at 12:31:41PM +, Richard W.M. Jones wrote: > > > On Fri, Mar 27, 2015 at 12:15:34PM +0000, Stefan Hajnoczi wrote: &

Re: [Libguestfs] Point-in-time snapshots (was: Re: Inspection of disk snapshots)

2015-03-27 Thread Stefan Hajnoczi
On Fri, Mar 27, 2015 at 12:31:41PM +, Richard W.M. Jones wrote: > On Fri, Mar 27, 2015 at 12:15:34PM +0000, Stefan Hajnoczi wrote: > > On Thu, Mar 26, 2015 at 12:02:27AM +0100, Kashyap Chamarthy wrote: > > > So, something like? > > > > > > . .

Re: [Libguestfs] Point-in-time snapshots (was: Re: Inspection of disk snapshots)

2015-03-27 Thread Stefan Hajnoczi
On Thu, Mar 26, 2015 at 12:02:27AM +0100, Kashyap Chamarthy wrote: > [Added Stefan Hajnoczi, who wrote the 'drive-backup' QMP command and > Eric Blake.] > > On Wed, Mar 25, 2015 at 07:41:23PM +, Richard W.M. Jones wrote: > > On Wed, Mar 25, 2015 at 07:38:03PM +0