[Libguestfs] [PATCH 10/13] syntax-check: fix prohibit_test_minus_ao check

2014-09-23 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- align/test-virt-alignment-scan-guests.sh | 2 +- align/test-virt-alignment-scan.sh| 2 +- builder/test-virt-builder-planner.sh | 2 +- builder/website/ubuntu.sh| 2 +- configure.ac | 2 +-

Re: [Libguestfs] [PATCH 10/13] syntax-check: fix prohibit_test_minus_ao check

2014-09-23 Thread Richard W.M. Jones
On Tue, Sep 23, 2014 at 05:20:36PM +0800, Hu Tao wrote: # 0, 2 and 3 are reasonable non-error exit codes. Others are errors. -if [ $r -ne 0 -a $r -ne 2 -a $r -ne 3 ]; then +if [ $r -ne 0 $r -ne 2 $r -ne 3 ]; then I think the intention of this test is that you're supposed to do: if [ $r