Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-02-06 Thread Tomáš Golembiovský
On Wed, 06 Feb 2019 17:02:57 +0100 Pino Toscano wrote: > On Wednesday, 6 February 2019 14:11:41 CET Tomáš Golembiovský wrote: > > > > + * Note that the call may succeed whithout copying any file at all. > > > > This may > > > > + * happen when the source subdirectory exists but is empty or when

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-02-06 Thread Pino Toscano
On Wednesday, 6 February 2019 14:11:41 CET Tomáš Golembiovský wrote: > > > + * Note that the call may succeed whithout copying any file at all. This > > > may > > > + * happen when the source subdirectory exists but is empty or when > > > [filter] > > > + * function is too strict to allow any of

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-02-06 Thread Tomáš Golembiovský
> > + * Note that the call may succeed whithout copying any file at all. This > > may > > + * happen when the source subdirectory exists but is empty or when [filter] > > + * function is too strict to allow any of the files. > > Not sure why copy_from_virtio_win should allow an empty list as

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-02-06 Thread Tomáš Golembiovský
On Mon, 28 Jan 2019 17:39:23 + "Richard W.M. Jones" wrote: > On Sat, Jan 26, 2019 at 01:19:59PM +0100, Tomáš Golembiovský wrote: > > Allow multiple alternative directory names for distributions (or > > distribution familiy) when installing Linux guest tools packages. > > Original naming

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-01-29 Thread Pino Toscano
On Saturday, 26 January 2019 13:19:59 CET Tomáš Golembiovský wrote: > diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml > index 94c4774b7..cc33d9502 100644 > --- a/v2v/windows_virtio.ml > +++ b/v2v/windows_virtio.ml > @@ -186,14 +186,18 @@ let rec install_drivers ((g, _) as reg) inspect

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-01-28 Thread Richard W.M. Jones
On Sat, Jan 26, 2019 at 01:19:59PM +0100, Tomáš Golembiovský wrote: > Allow multiple alternative directory names for distributions (or > distribution familiy) when installing Linux guest tools packages. > Original naming required that there is a separate directory for every > version of a

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-01-28 Thread Sandro Bonazzola
Il giorno sab 26 gen 2019, 13:20 Tomáš Golembiovský ha scritto: > Allow multiple alternative directory names for distributions (or > distribution familiy) when installing Linux guest tools packages. > Original naming required that there is a separate directory for every > version of a

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-01-27 Thread Tomáš Golembiovský
On Sat, 26 Jan 2019 19:42:15 +0100 Sandro Bonazzola wrote: > Il giorno sab 26 gen 2019, 13:20 Tomáš Golembiovský > ha scritto: > > > Allow multiple alternative directory names for distributions (or > > distribution familiy) when installing Linux guest tools packages. > > Original naming

[Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions

2019-01-26 Thread Tomáš Golembiovský
Allow multiple alternative directory names for distributions (or distribution familiy) when installing Linux guest tools packages. Original naming required that there is a separate directory for every version of a distribution (e.g. fc28, fc29, ...). This is inconvenient when users want to keep