Re: [Libguestfs] [PATCH libnbd 4/8] copy: Separate finishing a command from freeing it

2022-02-22 Thread Nir Soffer
On Mon, Feb 21, 2022 at 5:08 PM Eric Blake wrote: > > On Sun, Feb 20, 2022 at 02:13:59PM +0200, Nir Soffer wrote: > > free_command() was abused as a completion callback. Introduce > > finish_command() completion callback, so code that want to free a > > command does not have to add dummy errors.

Re: [Libguestfs] [PATCH libnbd 4/8] copy: Separate finishing a command from freeing it

2022-02-21 Thread Eric Blake
On Sun, Feb 20, 2022 at 02:13:59PM +0200, Nir Soffer wrote: > free_command() was abused as a completion callback. Introduce > finish_command() completion callback, so code that want to free a > command does not have to add dummy errors. > > This will make it easier to manage worker state when a

Re: [Libguestfs] [PATCH libnbd 4/8] copy: Separate finishing a command from freeing it

2022-02-20 Thread Richard W.M. Jones
On Sun, Feb 20, 2022 at 02:13:59PM +0200, Nir Soffer wrote: > free_command() was abused as a completion callback. Introduce > finish_command() completion callback, so code that want to free a In the code it's called "finished_command". ACK patches 1, 2, 3 & 4 (with this fix to the commit

[Libguestfs] [PATCH libnbd 4/8] copy: Separate finishing a command from freeing it

2022-02-20 Thread Nir Soffer
free_command() was abused as a completion callback. Introduce finish_command() completion callback, so code that want to free a command does not have to add dummy errors. This will make it easier to manage worker state when a command completes. Signed-off-by: Nir Soffer ---