Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-03-06 Thread Nir Soffer
On Wed, Feb 23, 2022 at 3:56 PM Nir Soffer wrote: > > On Wed, Feb 23, 2022 at 3:29 PM Richard W.M. Jones wrote: > > > > On Wed, Feb 23, 2022 at 02:53:47PM +0200, Nir Soffer wrote: > > > I'll send more patches for the suggested improvements next week. > > > > I'd like to an upstream stable

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-02-23 Thread Nir Soffer
On Wed, Feb 23, 2022 at 3:29 PM Richard W.M. Jones wrote: > > On Wed, Feb 23, 2022 at 02:53:47PM +0200, Nir Soffer wrote: > > I'll send more patches for the suggested improvements next week. > > I'd like to an upstream stable release early next week, ideally Monday > if possible. The additional

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-02-23 Thread Richard W.M. Jones
On Wed, Feb 23, 2022 at 02:53:47PM +0200, Nir Soffer wrote: > I'll send more patches for the suggested improvements next week. I'd like to an upstream stable release early next week, ideally Monday if possible. Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-02-23 Thread Nir Soffer
On Tue, Feb 22, 2022 at 1:48 PM Nir Soffer wrote: > > On Mon, Feb 21, 2022 at 5:41 PM Eric Blake wrote: > > > > On Sun, Feb 20, 2022 at 02:14:03PM +0200, Nir Soffer wrote: > > > Limit the size of the copy queue also by the number of queued bytes. > > > This allows using many concurrent small

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-02-22 Thread Nir Soffer
On Mon, Feb 21, 2022 at 5:41 PM Eric Blake wrote: > > On Sun, Feb 20, 2022 at 02:14:03PM +0200, Nir Soffer wrote: > > Limit the size of the copy queue also by the number of queued bytes. > > This allows using many concurrent small requests, required to get good > > performance, but limiting the

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-02-21 Thread Eric Blake
On Sun, Feb 20, 2022 at 02:14:03PM +0200, Nir Soffer wrote: > Limit the size of the copy queue also by the number of queued bytes. > This allows using many concurrent small requests, required to get good > performance, but limiting the number of large requests that are actually > faster with lower

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-02-20 Thread Richard W.M. Jones
On Sun, Feb 20, 2022 at 02:14:03PM +0200, Nir Soffer wrote: > Limit the size of the copy queue also by the number of queued bytes. > This allows using many concurrent small requests, required to get good > performance, but limiting the number of large requests that are actually > faster with lower

[Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

2022-02-20 Thread Nir Soffer
Limit the size of the copy queue also by the number of queued bytes. This allows using many concurrent small requests, required to get good performance, but limiting the number of large requests that are actually faster with lower concurrency. New --queue-size option added to control the maximum