Re: [Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-07-27 Thread Richard W.M. Jones
Actually once I re-read Daniel Stenberg's reply from last time I see that using the share interface is actually pessimal with HTTP/2, /3, see: https://curl.se/mail/lib-2023-02/0077.html https://curl.se/mail/lib-2023-02/0082.html I think I'll have to look at the multi interface instead. Rich.

Re: [Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-07-27 Thread Richard W.M. Jones
On Thu, Jul 27, 2023 at 01:59:54PM +0200, Laszlo Ersek wrote: > On 7/27/23 13:46, Richard W.M. Jones wrote: > > Using the libcurl share interface we can share data between the > > separate curl easy handles in the pool. For more about this see: > > > > https://curl.se/libcurl/c/CURLSHOPT_SHARE.ht

[Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-07-27 Thread Richard W.M. Jones
Using the libcurl share interface we can share data between the separate curl easy handles in the pool. For more about this see: https://curl.se/libcurl/c/CURLSHOPT_SHARE.html https://gist.github.com/bagder/7eccf74f8b6d70b5abefeb7f288dba9b https://everything.curl.dev/libcurl/sharing --- plugins/

Re: [Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-02-26 Thread Richard W.M. Jones
On Wed, Feb 22, 2023 at 03:01:45PM +, Richard W.M. Jones wrote: > I'm mainly posting this to the list as a back-up. It does work, it > does _not_ improve performance in any noticable way. However I'm > having lots of trouble getting HTTP/2 to work (with or without this > patch) and that's sto

Re: [Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-02-22 Thread Richard W.M. Jones
On Wed, Feb 22, 2023 at 05:25:03PM +0100, Laszlo Ersek wrote: > On 2/22/23 17:00, Richard W.M. Jones wrote: > > On Wed, Feb 22, 2023 at 04:52:35PM +0100, Laszlo Ersek wrote: > > ... > >> Seems sane to me in general, except for the fact that the documentation > >> at

Re: [Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-02-22 Thread Laszlo Ersek
On 2/22/23 17:00, Richard W.M. Jones wrote: > On Wed, Feb 22, 2023 at 04:52:35PM +0100, Laszlo Ersek wrote: > ... >> Seems sane to me in general, except for the fact that the documentation >> at writes: >> >> """ >> CURL_LOCK_DATA_CONNECT >> >> Put t

Re: [Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-02-22 Thread Richard W.M. Jones
On Wed, Feb 22, 2023 at 04:52:35PM +0100, Laszlo Ersek wrote: ... > Seems sane to me in general, except for the fact that the documentation > at writes: > > """ > CURL_LOCK_DATA_CONNECT > > Put the connection cache in the share object and make all

Re: [Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-02-22 Thread Laszlo Ersek
On 2/22/23 16:01, Richard W.M. Jones wrote: > Using the libcurl share interface we can share data between the > separate curl easy handles in the pool. For more about this see: > > https://curl.se/libcurl/c/CURLSHOPT_SHARE.html > https://gist.github.com/bagder/7eccf74f8b6d70b5abefeb7f288dba9b > h

[Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-02-22 Thread Richard W.M. Jones
Using the libcurl share interface we can share data between the separate curl easy handles in the pool. For more about this see: https://curl.se/libcurl/c/CURLSHOPT_SHARE.html https://gist.github.com/bagder/7eccf74f8b6d70b5abefeb7f288dba9b https://everything.curl.dev/libcurl/sharing --- plugins/

[Libguestfs] [PATCH nbdkit] curl: Try to share as much as possible between handles in the pool

2023-02-22 Thread Richard W.M. Jones
I'm mainly posting this to the list as a back-up. It does work, it does _not_ improve performance in any noticable way. However I'm having lots of trouble getting HTTP/2 to work (with or without this patch) and that's stopping me from testing anything properly. Rich. __