Re: [Libguestfs] [PATCH v2v] convert: Allow preferred block driver to be specified on the command line

2023-03-07 Thread Andrey Drobyshev
On 3/6/23 18:52, Richard W.M. Jones wrote: > This is just an outline patch, only compile tested. > > It doesn't make changes to virt-v2v-in-place, but those would be the > same as made in v2v/v2v.ml. > > It reuses the existing Types.guestcaps_block_type which is a bit ugly > but fairly practical.

Re: [Libguestfs] [PATCH v2v] convert: Allow preferred block driver to be specified on the command line

2023-03-07 Thread Richard W.M. Jones
On Tue, Mar 07, 2023 at 11:26:37AM +0100, Laszlo Ersek wrote: > On 3/7/23 09:35, Richard W.M. Jones wrote: > > On Tue, Mar 07, 2023 at 08:48:56AM +0100, Laszlo Ersek wrote: > >> On 3/6/23 17:52, Richard W.M. Jones wrote: > >> > >>> diff --git a/convert/convert_windows.ml b/convert/convert_windows.m

Re: [Libguestfs] [PATCH v2v] convert: Allow preferred block driver to be specified on the command line

2023-03-07 Thread Laszlo Ersek
On 3/7/23 09:35, Richard W.M. Jones wrote: > On Tue, Mar 07, 2023 at 08:48:56AM +0100, Laszlo Ersek wrote: >> On 3/6/23 17:52, Richard W.M. Jones wrote: >> >>> diff --git a/convert/convert_windows.ml b/convert/convert_windows.ml >>> index 9d8d271d05..f36b486359 100644 >>> --- a/convert/convert_wind

Re: [Libguestfs] [PATCH v2v] convert: Allow preferred block driver to be specified on the command line

2023-03-07 Thread Richard W.M. Jones
On Tue, Mar 07, 2023 at 08:48:56AM +0100, Laszlo Ersek wrote: > On 3/6/23 17:52, Richard W.M. Jones wrote: > > > diff --git a/convert/convert_windows.ml b/convert/convert_windows.ml > > index 9d8d271d05..f36b486359 100644 > > --- a/convert/convert_windows.ml > > +++ b/convert/convert_windows.ml >

Re: [Libguestfs] [PATCH v2v] convert: Allow preferred block driver to be specified on the command line

2023-03-06 Thread Laszlo Ersek
On 3/6/23 17:52, Richard W.M. Jones wrote: > diff --git a/convert/convert_windows.ml b/convert/convert_windows.ml > index 9d8d271d05..f36b486359 100644 > --- a/convert/convert_windows.ml > +++ b/convert/convert_windows.ml > @@ -38,7 +38,7 @@ module G = Guestfs > * time the Windows VM is booted o

[Libguestfs] [PATCH v2v] convert: Allow preferred block driver to be specified on the command line

2023-03-06 Thread Richard W.M. Jones
--- docs/virt-v2v.pod | 10 ++ convert/convert.mli | 1 + convert/convert_linux.mli | 3 ++- convert/convert_windows.mli | 3 ++- convert/convert.ml | 9 ++--- convert/convert_linux.ml| 2 +- convert/convert_windows.ml | 12 +++- in-place/

[Libguestfs] [PATCH v2v] convert: Allow preferred block driver to be specified on the command line

2023-03-06 Thread Richard W.M. Jones
This is just an outline patch, only compile tested. It doesn't make changes to virt-v2v-in-place, but those would be the same as made in v2v/v2v.ml. It reuses the existing Types.guestcaps_block_type which is a bit ugly but fairly practical. I've made the change to the documentation, but it needs