[Libguestfs] [PATCH v6 11/41] utils: Rename ‘guestfs-internal-frontend.h’ to ‘utils.h’.

2017-06-15 Thread Richard W.M. Jones
--- .gitignore| 2 +- builder/index-validate.c | 2 +- builder/pxzcat-c.c| 2 +- common/edit/file-edit.c | 2 +- common/mlutils/c_utils-c.c

Re: [Libguestfs] [PATCH v6 11/41] utils: Rename ‘guestfs-internal-frontend.h’ to ‘utils.h’.

2017-06-16 Thread Pino Toscano
NACK to utils.h -- in the past I've seen a couple of libraries installing public includes as utils.h. They have been fixed, but I'd like to avoid conflicts between an installed header and a project header. -- Pino Toscano signature.asc Description: This is a digitally signed message part. __

Re: [Libguestfs] [PATCH v6 11/41] utils: Rename ‘guestfs-internal-frontend.h’ to ‘utils.h’.

2017-06-16 Thread Richard W.M. Jones
On Fri, Jun 16, 2017 at 03:42:35PM +0200, Pino Toscano wrote: > NACK to utils.h -- in the past I've seen a couple of libraries > installing public includes as utils.h. They have been fixed, but > I'd like to avoid conflicts between an installed header and a project > header. Can we prevent incorre

Re: [Libguestfs] [PATCH v6 11/41] utils: Rename ‘guestfs-internal-frontend.h’ to ‘utils.h’.

2017-06-19 Thread Pino Toscano
On Friday, 16 June 2017 17:03:34 CEST Richard W.M. Jones wrote: > On Fri, Jun 16, 2017 at 03:42:35PM +0200, Pino Toscano wrote: > > NACK to utils.h -- in the past I've seen a couple of libraries > > installing public includes as utils.h. They have been fixed, but > > I'd like to avoid conflicts bet

Re: [Libguestfs] [PATCH v6 11/41] utils: Rename ‘guestfs-internal-frontend.h’ to ‘utils.h’.

2017-06-19 Thread Richard W.M. Jones
On Mon, Jun 19, 2017 at 10:30:47AM +0200, Pino Toscano wrote: > On Friday, 16 June 2017 17:03:34 CEST Richard W.M. Jones wrote: > > On Fri, Jun 16, 2017 at 03:42:35PM +0200, Pino Toscano wrote: > > > NACK to utils.h -- in the past I've seen a couple of libraries > > > installing public includes as