Re: [Libguestfs] missing btrfs subvol support

2015-09-10 Thread Richard W.M. Jones
On Wed, Sep 09, 2015 at 07:14:05PM +0200, Olaf Hering wrote: > On Fri, Oct 10, Olaf Hering wrote: > > > Is btrfs subvol support failing just for me? > > > This is an old thread, and it seems the underlying bug is not fixed > because guestfs takes the wrong approach, IMO. > > >From how I unders

Re: [Libguestfs] missing btrfs subvol support

2015-09-09 Thread Olaf Hering
On Fri, Oct 10, Olaf Hering wrote: > Is btrfs subvol support failing just for me? This is an old thread, and it seems the underlying bug is not fixed because guestfs takes the wrong approach, IMO. >From how I understand btrfs, it has the concept of subvolumes. Each one is an entry point for a s

Re: [Libguestfs] missing btrfs subvol support

2014-10-17 Thread Olaf Hering
On Fri, Oct 17, Pino Toscano wrote: > On Friday 17 October 2014 11:25:03 Olaf Hering wrote: > > On Thu, Oct 16, Olaf Hering wrote: > > > I can probably add a check somewhere to catch the whatever=="@". A > > > better fix would be to check if a given subvolume is for the entire > > > partition. > >

Re: [Libguestfs] missing btrfs subvol support

2014-10-17 Thread Pino Toscano
On Friday 17 October 2014 11:25:03 Olaf Hering wrote: > On Thu, Oct 16, Olaf Hering wrote: > > I can probably add a check somewhere to catch the whatever=="@". A > > better fix would be to check if a given subvolume is for the entire > > partition. > > So after talking to David Sterba there is no

Re: [Libguestfs] missing btrfs subvol support

2014-10-17 Thread Olaf Hering
On Thu, Oct 16, Olaf Hering wrote: > I can probably add a check somewhere to catch the whatever=="@". A > better fix would be to check if a given subvolume is for the entire > partition. So after talking to David Sterba there is no way to tell if a given subvolume is for the entire partition. Als

Re: [Libguestfs] missing btrfs subvol support

2014-10-16 Thread Olaf Hering
On Fri, Oct 10, Mike Latimer wrote: > On Friday, October 10, 2014 03:07:51 PM Olaf Hering wrote: > > Thanks for the pointers. I will poke around. At least augtool on the > > host seems to behave correctly: > > I don't think this is related to Augeas. Instead, I think it's the naming > convention

Re: [Libguestfs] missing btrfs subvol support

2014-10-13 Thread Olaf Hering
On Fri, Oct 10, Richard W.M. Jones wrote: > We use Augeas to parse the /etc/fstab btrfs entries, see > src/inspect-fs-unix.c: check_fstab: > > https://github.com/libguestfs/libguestfs/blob/master/src/inspect-fs-unix.c#L1089 > > And we then pass the subvol back to the mount command in > daemon/mo

Re: [Libguestfs] missing btrfs subvol support

2014-10-10 Thread Mike Latimer
On Friday, October 10, 2014 03:07:51 PM Olaf Hering wrote: > Thanks for the pointers. I will poke around. At least augtool on the > host seems to behave correctly: I don't think this is related to Augeas. Instead, I think it's the naming convention SUSE uses for the root btrfs subvolume (@). I e

Re: [Libguestfs] missing btrfs subvol support

2014-10-10 Thread Olaf Hering
On Fri, Oct 10, Richard W.M. Jones wrote: > My guess is that the last one (opt/value) will be different for you. Thanks for the pointers. I will poke around. At least augtool on the host seems to behave correctly: olaf@bax:~ $ cd /dev/shm/$$ bash: cd: /dev/shm/3570: Datei oder Verzeichnis nicht

Re: [Libguestfs] missing btrfs subvol support

2014-10-10 Thread Richard W.M. Jones
On Fri, Oct 10, 2014 at 01:47:01PM +0200, Olaf Hering wrote: > > Is btrfs subvol support failing just for me? Looks like nothing adds the > required '@/' string. virt-ls uses the first variant of the command: > > > mount -vo subvol=var/spool,ro /dev/sda2 /sysroot/ > [ 113.852047] BTRFS info (dev

[Libguestfs] missing btrfs subvol support

2014-10-10 Thread Olaf Hering
Is btrfs subvol support failing just for me? Looks like nothing adds the required '@/' string. virt-ls uses the first variant of the command: > mount -vo subvol=var/spool,ro /dev/sda2 /sysroot/ [ 113.852047] BTRFS info (device sda2): disk space caching is enabled [ 113.852869] BTRFS: has skinny