Re: [Libhugetlbfs-devel] Remove elflink specific functions out of hugeutils.c

2006-10-12 Thread David Gibson
Oops, missed a couple of things. Please apply this rather than previous versions of this change. Remove elflink specific functions out of hugeutils.c This patch removes the various functions which use the seg_info structure from hugeutils.c to elflink.c which is the only place they're used. Whi

[Libhugetlbfs-devel] Remove elflink specific functions out of hugeutils.c

2006-10-12 Thread David Gibson
his patch removes the various functions which use the seg_info structure from hugeutils.c to elflink.c which is the only place they're used. While we're at it, move in the seg_info definition itself from the .h file, make things static which now can be and re-arrange functions to avoid forward dec

Re: [Libhugetlbfs-devel] hugetlbfs not mounted error message

2006-10-12 Thread David Gibson
On Thu, Oct 12, 2006 at 11:12:53AM -0700, Nishanth Aravamudan wrote: > On 11.10.2006 [11:29:05 +1000], David Gibson wrote: > > On Tue, Oct 10, 2006 at 11:28:55AM -0700, Nishanth Aravamudan wrote: > > > On 10.10.2006 [15:36:47 +1000], David Gibson wrote: > > > > I think commit d00d5d32b213b933770ac

[Libhugetlbfs-devel] hugetlbd

2006-10-12 Thread David Gibson
Nish, or someone else who understands the sharing implementation: Can you explain to me the need for the hugetlbd? i.e. why is it necessary to have a daemon to manage the shared mappings, rather than just using a naming convention within the hugetlbfs to allow the libhugetlbfs instances to direct

Re: [Libhugetlbfs-devel] Saner handling of $(DESTDIR)

2006-10-12 Thread Steve Fox
On Wed, 2006-10-11 at 16:32 +1000, David Gibson wrote: > Commit 70d6e658872b9f0d1b1688e0ef7cc4c711c9161e fixed a make bug due > to confusion as to whether $(BINDIR), $(LIBDIR32) and so forth > referred to the final installed directory of the files in question, or > to where they'll be placed by mak

Re: [Libhugetlbfs-devel] Another dubious commit

2006-10-12 Thread Steve Fox
On Thu, 2006-10-12 at 09:26 -0500, Steve Fox wrote: > Instead of creating the shared mapping of size memsz (aligned), we're > going to make it only filesz + non-zero BSS (we've found that glibc > initializes stdin, stdout, stderr before we get control). Reducing the > size of the shared mapping sh

[Libhugetlbfs-devel] [PATCH] tests: unset QUIET_TEST properly

2006-10-12 Thread Steve Fox
tests: properly unset QUIET_TEST variable when requested Signed-off-by: Steve Fox <[EMAIL PROTECTED]> --- diff --git a/tests/run_tests.sh b/tests/run_tests.sh index be648ff..57f25ea 100755 --- a/tests/run_tests.sh +++ b/tests/run_tests.sh @@ -177,7 +177,7 @@ stress_tests () { while getopts "vVdt:

Re: [Libhugetlbfs-devel] [PATCH] Fix linkshare testcase [was Re: hugetlbfs not mounted error message]

2006-10-12 Thread Nishanth Aravamudan
On 12.10.2006 [12:46:13 -0700], Nishanth Aravamudan wrote: > On 12.10.2006 [11:41:12 -0700], Nishanth Aravamudan wrote: > > On 12.10.2006 [11:12:53 -0700], Nishanth Aravamudan wrote: > > > On 11.10.2006 [11:29:05 +1000], David Gibson wrote: > > > > On Tue, Oct 10, 2006 at 11:28:55AM -0700, Nishanth

[Libhugetlbfs-devel] [PATCH] Fix linkshare testcase [was Re: hugetlbfs not mounted error message]

2006-10-12 Thread Nishanth Aravamudan
On 12.10.2006 [11:41:12 -0700], Nishanth Aravamudan wrote: > On 12.10.2006 [11:12:53 -0700], Nishanth Aravamudan wrote: > > On 11.10.2006 [11:29:05 +1000], David Gibson wrote: > > > On Tue, Oct 10, 2006 at 11:28:55AM -0700, Nishanth Aravamudan wrote: > > > > On 10.10.2006 [15:36:47 +1000], David Gi

Re: [Libhugetlbfs-devel] hugetlbfs not mounted error message

2006-10-12 Thread Nishanth Aravamudan
On 12.10.2006 [11:12:53 -0700], Nishanth Aravamudan wrote: > On 11.10.2006 [11:29:05 +1000], David Gibson wrote: > > On Tue, Oct 10, 2006 at 11:28:55AM -0700, Nishanth Aravamudan wrote: > > > On 10.10.2006 [15:36:47 +1000], David Gibson wrote: > > > > Incidentally have people been running the te

Re: [Libhugetlbfs-devel] Add an option to select 32 or 64 bit tests only

2006-10-12 Thread Adam Litke
On Wed, 2006-10-11 at 14:29 +1000, David Gibson wrote: > This patch adds an option to the run_tests.sh script to select to run > just the 32 bit or just the 64 bit versions of the tests. This can > speed things up when tracking down certain sorts of testsuite > regressions. > > Signed-off-by: Dav

Re: [Libhugetlbfs-devel] hugetlbfs not mounted error message

2006-10-12 Thread Adam Litke
On Wed, 2006-10-11 at 11:48 +1000, David Gibson wrote: > > ERROR'ing because we don't have a hugetlbfs mountpoint is not good, as > > hugetlbfs_find_path() is an exported interface. Revert the change to > > just make it a WARNING. > > Can I suggest this revision. Yes :) And I'll check it in. --

Re: [Libhugetlbfs-devel] hugetlbfs not mounted error message

2006-10-12 Thread Nishanth Aravamudan
On 11.10.2006 [11:29:05 +1000], David Gibson wrote: > On Tue, Oct 10, 2006 at 11:28:55AM -0700, Nishanth Aravamudan wrote: > > On 10.10.2006 [15:36:47 +1000], David Gibson wrote: > > > I think commit d00d5d32b213b933770ac89ce0559c72996a43fc should be > > > reverted. It adds an ERROR() when hugetlb

Re: [Libhugetlbfs-devel] Another dubious commit

2006-10-12 Thread Steve Fox
On Wed, 2006-10-11 at 13:24 +1000, David Gibson wrote: > On Tue, Oct 10, 2006 at 11:37:04AM -0700, Nishanth Aravamudan wrote: > > On 10.10.2006 [17:24:07 +1000], David Gibson wrote: > > > This time commit c3f4d10a80d6ad8bb37ef6f80e70c3c7d778117a. The goal > > > noted in the comment of avoiding nor