Re: [Libhugetlbfs-devel] [PATCH][UPDATED] debug: make HUGETLB_DEBUG generic

2008-02-27 Thread Nishanth Aravamudan
On 28.02.2008 [12:47:08 +1100], David Gibson wrote: > On Wed, Feb 27, 2008 at 03:15:14PM -0800, Nishanth Aravamudan wrote: > > On 27.02.2008 [15:48:24 -0600], Andrew Hastings wrote: > > > Nish, > > > > > > Nice! Just one comment: > > > > > > Nishanth Aravamudan wrote: > > >> --- a/libhugetlbfs_int

Re: [Libhugetlbfs-devel] [PATCH][UPDATED] debug: make HUGETLB_DEBUG generic

2008-02-27 Thread David Gibson
On Wed, Feb 27, 2008 at 03:15:14PM -0800, Nishanth Aravamudan wrote: > On 27.02.2008 [15:48:24 -0600], Andrew Hastings wrote: > > Nish, > > > > Nice! Just one comment: > > > > Nishanth Aravamudan wrote: > >> --- a/libhugetlbfs_internal.h > >> +++ b/libhugetlbfs_internal.h > >> @@ -29,6 +29,7 @@ >

Re: [Libhugetlbfs-devel] [PATCH][UPDATED] debug: make HUGETLB_DEBUG generic

2008-02-27 Thread Andrew Hastings
Nishanth Aravamudan wrote: > On 27.02.2008 [15:48:24 -0600], Andrew Hastings wrote: >> Nish, >> >> Nice! Just one comment: >> >> Nishanth Aravamudan wrote: >>> --- a/libhugetlbfs_internal.h >>> +++ b/libhugetlbfs_internal.h >>> @@ -29,6 +29,7 @@ >>> #define ALIGN(x, a)(((x) + (a) - 1) & ~

[Libhugetlbfs-devel] [PATCH][UPDATED] debug: make HUGETLB_DEBUG generic

2008-02-27 Thread Nishanth Aravamudan
On 27.02.2008 [15:48:24 -0600], Andrew Hastings wrote: > Nish, > > Nice! Just one comment: > > Nishanth Aravamudan wrote: >> --- a/libhugetlbfs_internal.h >> +++ b/libhugetlbfs_internal.h >> @@ -29,6 +29,7 @@ >> #define ALIGN(x, a) (((x) + (a) - 1) & ~((a) - 1)) >> extern int __hugetlbfs_verbos