Re: [Libhugetlbfs-devel] [PATCH] debug: make HUGETLB_DEBUG generic

2008-02-27 Thread Andrew Hastings
Nish, Nice! Just one comment: Nishanth Aravamudan wrote: > --- a/libhugetlbfs_internal.h > +++ b/libhugetlbfs_internal.h > @@ -29,6 +29,7 @@ > #define ALIGN(x, a) (((x) + (a) - 1) & ~((a) - 1)) > > extern int __hugetlbfs_verbose; > +extern int __debug; This should be __hugetlbfs_debug to a

[Libhugetlbfs-devel] [PATCH] debug: make HUGETLB_DEBUG generic

2008-02-27 Thread Nishanth Aravamudan
On 27.02.2008 [13:29:24 -0800], Nishanth Aravamudan wrote: > On 22.02.2008 [14:20:13 -0600], Andrew Hastings wrote: > > Nish, > > > > Thanks for the review! > > > > > Glad you suggested this! It turns out there's a dependency on the order in > > which the three libhugetlbfs constructors run, w