Re: [Libhugetlbfs-devel] [PATCH 07/14] make dump_proc_pid_maps library static

2008-10-20 Thread Mel Gorman
I think the subject is misleading. It says we are making it static, but it's really moving headers. If it's meant to read "move to private header", then it looks ok. On Fri, Oct 17, 2008 at 05:14:14PM +0100, Andy Whitcroft wrote: > Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> > --- > hugetlb

Re: [Libhugetlbfs-devel] [PATCH 07/14] make dump_proc_pid_maps library static

2008-10-20 Thread Andy Whitcroft
On Mon, Oct 20, 2008 at 12:15:13PM +0100, Mel Gorman wrote: > I think the subject is misleading. It says we are making it static, but > it's really moving headers. If it's meant to read "move to private > header", then it looks ok. Yes that is what its mean to be. -apw --

Re: [Libhugetlbfs-devel] [PATCH 07/14] make dump_proc_pid_maps library static

2008-10-17 Thread Adam Litke
On Fri, 2008-10-17 at 17:14 +0100, Andy Whitcroft wrote: > Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> Acked-by: Adam Litke <[EMAIL PROTECTED]> > --- > hugetlbfs.h |4 > libhugetlbfs_internal.h |4 > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --

[Libhugetlbfs-devel] [PATCH 07/14] make dump_proc_pid_maps library static

2008-10-17 Thread Andy Whitcroft
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> --- hugetlbfs.h |4 libhugetlbfs_internal.h |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hugetlbfs.h b/hugetlbfs.h index fc23f9f..6b64ee7 100644 --- a/hugetlbfs.h +++ b/hugetlbfs.h @@ -30,10 +30,6