Re: [Libhugetlbfs-devel] [RFC][PATCH] debug: add HUGETLB_LOG_FILE facility

2008-03-28 Thread Nishanth Aravamudan
On 28.03.2008 [10:58:17 +1100], David Gibson wrote: > On Thu, Mar 27, 2008 at 05:44:54PM -0500, Dean Luick wrote: > > On Thu, Mar 27, 2008 at 02:13:06PM -0700, Nishanth Aravamudan wrote: > > > Not sure how to make it clear which thread is writing the output, > > > though, without prefixing the pid

Re: [Libhugetlbfs-devel] [RFC][PATCH] debug: add HUGETLB_LOG_FILE facility

2008-03-27 Thread David Gibson
On Thu, Mar 27, 2008 at 05:44:54PM -0500, Dean Luick wrote: > On Thu, Mar 27, 2008 at 02:13:06PM -0700, Nishanth Aravamudan wrote: > > Not sure how to make it clear which thread is writing the output, > > though, without prefixing the pid on every line. > > I am working on a patch to optionally ad

Re: [Libhugetlbfs-devel] [RFC][PATCH] debug: add HUGETLB_LOG_FILE facility

2008-03-27 Thread Dean Luick
On Thu, Mar 27, 2008 at 02:13:06PM -0700, Nishanth Aravamudan wrote: > Not sure how to make it clear which thread is writing the output, > though, without prefixing the pid on every line. I am working on a patch to optionally add "[hostname:pid] " in front of all messages. I don't know if it is o

Re: [Libhugetlbfs-devel] [RFC][PATCH] debug: add HUGETLB_LOG_FILE facility

2008-03-27 Thread Adam Litke
On Wed, 2008-03-26 at 18:35 -0700, Nishanth Aravamudan wrote: > @@ -29,16 +30,24 @@ > > int __hugetlbfs_verbose = 1; > int __hugetlbfs_debug = 0; > +FILE *__hugetlbfs_stdout; Do we need to handle stdout at all? As far as I know we don't (at least shouldn't) ever write to stdout. > @@ -47,6 +5

Re: [Libhugetlbfs-devel] [RFC][PATCH] debug: add HUGETLB_LOG_FILE facility

2008-03-27 Thread Nishanth Aravamudan
On 27.03.2008 [15:52:47 -0500], Adam Litke wrote: > On Wed, 2008-03-26 at 18:35 -0700, Nishanth Aravamudan wrote: > > @@ -29,16 +30,24 @@ > > > > int __hugetlbfs_verbose = 1; > > int __hugetlbfs_debug = 0; > > +FILE *__hugetlbfs_stdout; > > Do we need to handle stdout at all? As far as I know

[Libhugetlbfs-devel] [RFC][PATCH] debug: add HUGETLB_LOG_FILE facility

2008-03-26 Thread Nishanth Aravamudan
If set, HUGETLB_LOG_FILE redirects stdout and stderr to the file specified, but only for output from the library. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> diff --git a/HOWTO b/HOWTO index a10461b..798b468 100644 --- a/HOWTO +++ b/HOWTO @@ -324,6 +324,8 @@ libhugetlbfs: HUGET