Re: [Libmesh-users] SVD for rectangular matrices

2015-12-01 Thread John Peterson
On Tue, Dec 1, 2015 at 1:59 AM, Jonas Ballani wrote: > Hi John, > > Thanks for the bug fix. Just a small comment on the test program posted > below: comparing the entries of U and V directly doesn't make much sense to > me since the order of the singular vectors can differ for multiple singular >

Re: [Libmesh-users] SVD for rectangular matrices

2015-12-01 Thread Jonas Ballani
Hi John, Thanks for the bug fix. Just a small comment on the test program posted below: comparing the entries of U and V directly doesn't make much sense to me since the order of the singular vectors can differ for multiple singular values of the same size. Still, your test result from Eigen is

Re: [Libmesh-users] SVD for rectangular matrices

2015-11-30 Thread John Peterson
On Mon, Nov 23, 2015 at 9:37 AM, Jonas Ballani wrote: > Dear all, > > I am relatively new to libmesh and would like to report a problem using > the SVD routine of the DenseMatrix class for rectangular matrices. My > example program looks as follows: > Hi Jonas, #734 fixes the bug and is almost

Re: [Libmesh-users] SVD for rectangular matrices

2015-11-27 Thread Derek Gaston
On Fri, Nov 27, 2015 at 9:57 AM John Peterson wrote: > A question for people that know more about Eigen than me: Could > DenseMatrix just be changed to an Eigen::MatrixXf or something similar? > There might be some trickiness with interfacing with DenseSubMatrix, but it > would be nice to get all

Re: [Libmesh-users] SVD for rectangular matrices

2015-11-27 Thread David Knezevic
On Fri, Nov 27, 2015 at 3:57 PM, John Peterson wrote: > > > On Tue, Nov 24, 2015 at 12:32 AM, David Knezevic < > [email protected]> wrote: > >> A follow-up comment on this: We added lapack-based SVD in DenseMatrix >> before we included Eigen in contrib, and I don't think it was ever used

Re: [Libmesh-users] SVD for rectangular matrices

2015-11-27 Thread John Peterson
On Tue, Nov 24, 2015 at 12:32 AM, David Knezevic wrote: > A follow-up comment on this: We added lapack-based SVD in DenseMatrix > before we included Eigen in contrib, and I don't think it was ever used > very extensively (and it seems to be buggy, as shown by Jonas's example). > It should be fix

Re: [Libmesh-users] SVD for rectangular matrices

2015-11-23 Thread David Knezevic
A follow-up comment on this: We added lapack-based SVD in DenseMatrix before we included Eigen in contrib, and I don't think it was ever used very extensively (and it seems to be buggy, as shown by Jonas's example). I find the lapack API to be quite opaque, so the less we rely on it the better IMO

Re: [Libmesh-users] SVD for rectangular matrices

2015-11-23 Thread John Peterson
A quick thought is that we may be computing the SVD of A^T, since we have to treat A as though it is column-major to interface with Fortran. In that case, A^T = V S U^T that is, we need to treat the "U" handed back to us as "V" and the "V" as "U". I'm out for the next week on vacation but

Re: [Libmesh-users] SVD for rectangular matrices

2015-11-23 Thread John Peterson
On Mon, Nov 23, 2015 at 9:37 AM, Jonas Ballani wrote: > Dear all, > > I am relatively new to libmesh and would like to report a problem using > the SVD routine of the DenseMatrix class for rectangular matrices. My > example program looks as follows: > > #include > #include > #include > #includ

[Libmesh-users] SVD for rectangular matrices

2015-11-23 Thread Jonas Ballani
Dear all, I am relatively new to libmesh and would like to report a problem using the SVD routine of the DenseMatrix class for rectangular matrices. My example program looks as follows: #include #include #include #include #include "libmesh/libmesh.h" #include "libmesh/dense_vector.h" #incl