[mpeg2-dev] [PATCH] move some inline keywords

2012-01-16 Thread Diego Biurrun
Here is a small patch to move inline keywords to the front of function declarations. This fixes some warnings with gcc and -Wextra where it complains about the 'static' keyword not being at the beginning of a function declaration. Apparently gcc gets tripped up and complains about 'static' instea

Re: [mpeg2-dev] [PATCH] Replace int_fast types with their standard?POSIX counterparts.

2011-05-17 Thread Diego Biurrun
On Tue, May 17, 2011 at 06:05:48PM +0300, Rémi Denis-Courmont wrote: > Le mardi 17 mai 2011 02:54:28 Diego Biurrun, vous avez écrit : > > On Mon, May 16, 2011 at 10:53:56PM +0300, Rémi Denis-Courmont wrote: > > > Le lundi 16 mai 2011 21:27:13 Diego Biurrun, vous avez écrit :

Re: [mpeg2-dev] [PATCH] Replace int_fast types with their standard POSIX counterparts.

2011-05-16 Thread Diego Biurrun
On Mon, May 16, 2011 at 10:53:56PM +0300, Rémi Denis-Courmont wrote: > Le lundi 16 mai 2011 21:27:13 Diego Biurrun, vous avez écrit : > > The _fast integer types provide no realworld benefits, but may introduce > > portability issues and are just plain ugly. > > int_fastXX_t

[mpeg2-dev] [PATCH] Replace int_fast types with their standard POSIX counterparts.

2011-05-16 Thread Diego Biurrun
The _fast integer types provide no realworld benefits, but may introduce portability issues and are just plain ugly. --- libmpeg2/idct_alpha.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libmpeg2/idct_alpha.c b/libmpeg2/idct_alpha.c index 8e94219..490b659

[mpeg2-dev] [PATCH] [RFC] workaround for crasher bug

2010-08-03 Thread Diego Biurrun
I can reproduce a crash in libmpeg2 with MPlayer on the sample: http://samples.mplayerhq.hu/MPEG2/libmpeg2-crash.vob The crash happens both with the internal forked copy and with the upstream version. Here is a somewhat ugly patch that we used to apply to the forked copy and that does fix the cr

Re: [mpeg2-dev] [PATCH] make headers compile standalone

2010-06-24 Thread Diego Biurrun
On Thu, Jun 24, 2010 at 10:41:22AM +0200, Diego Biurrun wrote: > On Sat, Jun 12, 2010 at 10:37:48AM +0200, Diego Biurrun wrote: > > On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote: > > > On Thu, Jun 10, 2010, Diego Biurrun wrote: > > > > Here is a patch to

Re: [mpeg2-dev] [PATCH] make headers compile standalone

2010-06-24 Thread Diego Biurrun
On Sat, Jun 12, 2010 at 10:37:48AM +0200, Diego Biurrun wrote: > On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote: > > On Thu, Jun 10, 2010, Diego Biurrun wrote: > > > Here is a patch to make libmpeg2 headers compile standalone. > > > This allows #incl

Re: [mpeg2-dev] [PATCH] make headers compile standalone

2010-06-12 Thread Diego Biurrun
On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote: > On Thu, Jun 10, 2010, Diego Biurrun wrote: > > Here is a patch to make libmpeg2 headers compile standalone. > > This allows #including them directly without worrying about > > header inclusion order or having to #i

[mpeg2-dev] [PATCH] make headers compile standalone

2010-06-10 Thread Diego Biurrun
Here is a patch to make libmpeg2 headers compile standalone. This allows #including them directly without worrying about header inclusion order or having to #include system headers before libmpeg2 headers. Diego Index: include/mpeg2.h ===

Re: [mpeg2-dev] Fwd: Re: [RFC] [PATCH] ARM Advanced SIMD motion compensation

2009-09-18 Thread Diego Biurrun
On Fri, Sep 18, 2009 at 04:32:55PM +0200, Rémi Denis-Courmont wrote: > > Anyway that's orthogonal to optimizing libmpeg2. No offense to anybody, but optimizing libmpeg2 sounds like a waste of time. It's unmaintained and slower to begin with.. Diego

Re: [mpeg2-dev] [PATCH] fix incorrect FSF address in license headers

2008-10-09 Thread Diego Biurrun
On Thu, Oct 09, 2008 at 05:16:50PM +0200, Lionel Debroux wrote: > Diego Biurrun wrote: > > > > A nitpick about your patch that updates the FSF address: I > > > noticed that trunk/src/getopt.{c,h} remain untouched. > > > > Yes, that was done on purpose, >

Re: [mpeg2-dev] [PATCH] fix incorrect FSF address in license headers

2008-10-09 Thread Diego Biurrun
On Thu, Oct 09, 2008 at 03:12:15PM +0200, Lionel Debroux wrote: > > A nitpick about your patch that updates the FSF address: I noticed that > trunk/src/getopt.{c,h} remain untouched. Yes, that was done on purpose, these files are from glibc, not libmpeg2. > What do people think ? Your patch is

[mpeg2-dev] [PATCH] fix incorrect FSF address in license headers

2008-10-09 Thread Diego Biurrun
The FSF changed headquarters a long time ago. Here is a patch to update the license headers in libmpeg2 to reflect that change. It also includes a similar change for the COPYING file. I just replaced yours with the copy in /usr/share/common-licenses/GPL-2 on my Debian system. Please apply. Die

Re: [mpeg2-dev] [PATCH] remove a set of braces for consistency

2008-09-18 Thread Diego Biurrun
On Sat, Sep 13, 2008 at 05:27:36PM +0200, Diego Biurrun wrote: > Here is a small patch to remove an extra set of braces from > libmpeg2/motion_comp.c in order to keep things consistent with the rest > of the file. Applied by Jean-Baptiste Kemp

[mpeg2-dev] [PATCH] remove a set of braces for consistency

2008-09-13 Thread Diego Biurrun
Here is a small patch to remove an extra set of braces from libmpeg2/motion_comp.c in order to keep things consistent with the rest of the file. Diego Index: libmpeg2/motion_comp.c === --- libmpeg2/motion_comp.c (revision 1193) +++ li

Re: [mpeg2-dev] [ANN] libmpeg2 0.5.0

2008-07-12 Thread Diego Biurrun
On Sat, Jul 12, 2008 at 05:24:09PM +0200, Christophe Massiot wrote: > On Sat, Jul 12, 2008, Diego Biurrun wrote: > > > > We are glad to announce a new version of libmpeg2 and mpeg2dec. > > > > I'm happy to hear this. Will you also make another 0.4 branch relea

Re: [mpeg2-dev] [ANN] libmpeg2 0.5.0

2008-07-12 Thread Diego Biurrun
On Sat, Jul 12, 2008 at 01:59:24PM +0200, Christophe Massiot wrote: > > We are glad to announce a new version of libmpeg2 and mpeg2dec. I'm happy to hear this. Will you also make another 0.4 branch release or do you consider 0.4 to have reached end of life? Diego --

Re: [mpeg2-dev] release?

2008-07-02 Thread Diego Biurrun
On Wed, May 14, 2008 at 02:22:47PM +0200, Christophe Massiot wrote: > On Wed, Apr 30, 2008, Jean-Baptiste Kempf wrote: > > On Wed, Apr 30, 2008 at 07:39:00PM +0200, Diego Biurrun wrote : > > > So, all patches that were posted recently have been applied. How about > > >

Re: [mpeg2-dev] [PATCH] AltiVec vector declaration syntax

2008-07-02 Thread Diego Biurrun
On Fri, May 30, 2008 at 02:29:43PM +0200, Diego Biurrun wrote: > Here is a patch to handle AltiVec vector declaration syntax in a > slightly better way. Yes, this reverts a patch I sent earlier :) > > Apple's gcc accepts vector declarations with () instead of {} like the

[mpeg2-dev] [PATCH] AltiVec vector declaration syntax

2008-05-30 Thread Diego Biurrun
Here is a patch to handle AltiVec vector declaration syntax in a slightly better way. Yes, this reverts a patch I sent earlier :) Apple's gcc accepts vector declarations with () instead of {} like the FSF gcc. Newer variants of the Apple compiler understand {} as well and complain about () when

[mpeg2-dev] release?

2008-04-30 Thread Diego Biurrun
So, all patches that were posted recently have been applied. How about making a libmpeg2 release now? A branch release would be very helpful for me since it I could easily import it into MPlayer :) Diego - This SF.net email

Re: [mpeg2-dev] [updated PATCH] Re: [PATCH] warning fixes

2008-04-13 Thread Diego Biurrun
On Sun, Apr 13, 2008 at 01:47:24PM +0200, Lionel Debroux wrote: > > I have split the patch in 3 parts. But why attach a .tar.bz2 4.6k in size? It's much more convenient if you can directly see the patches ... Diego - This S

Re: [mpeg2-dev] [PATCH] warning fixes

2008-04-13 Thread Diego Biurrun
On Fri, Apr 11, 2008 at 08:39:56PM +0200, Lionel Debroux wrote: > Here's a patch that fixes a number of warnings triggered by uncommon GCC > switches such as -Wshadow and -Wwrite-strings. You will likely have more luck if you split this patchset. There are fixes for multiple issues in it, some

Re: [mpeg2-dev] [PATCH] SSE2 idct optimizations

2008-04-10 Thread Diego Biurrun
On Wed, Apr 09, 2008 at 07:21:30PM +0200, Christophe Massiot wrote: > On Tue, Apr 08, 2008, Diego Biurrun wrote: > > > Please try the attached version and let me know if this works as > > expected. Again, I could only do minimal compilation tests, I do not > > have a ma

[mpeg2-dev] [PATCH] trivial typo fixes

2008-04-09 Thread Diego Biurrun
Here's a small one to eliminate two typos. Diego Index: libmpeg2/slice.c === --- libmpeg2/slice.c (revision 1166) +++ libmpeg2/slice.c (working copy) @@ -503,7 +503,7 @@ } else { /* end of block. I commented out this code b

Re: [mpeg2-dev] [PATCH] SSE2 idct optimizations

2008-04-07 Thread Diego Biurrun
On Wed, Apr 02, 2008 at 01:52:24PM +0200, Christophe Massiot wrote: > On Tue, Apr 01, 2008, Diego Biurrun wrote: > > > > Does anyone know why the output of the SSE2 IDCT is different from the > > > one of the MMXEXT IDCT ? Since the algorithm is supposed to be the same

Re: [mpeg2-dev] [PATCH] consistent license headers

2008-04-07 Thread Diego Biurrun
On Mon, Feb 25, 2008 at 04:00:04PM +0100, Diego Biurrun wrote: > On Mon, Feb 25, 2008 at 11:46:30AM +0100, Christophe Massiot wrote: > > On Sun, Feb 24, 2008, Diego Biurrun wrote: > > > Here is a trivial patch to remove a weirdness from all libmpeg2 license > > > hea

[mpeg2-dev] [PATCH] export PIC_FLAG_REPEAT_FIRST_FIELD

2008-04-01 Thread Diego Biurrun
Here is another patch extracted from the MPlayer patchset. It adds another PIC_FLAG definition, PIC_FLAG_REPEAT_FIRST_FIELD, and exports it. FFmpeg also sets this and it is used in various MPlayer filters. Diego Index: include/mpeg2.h =

Re: [mpeg2-dev] [PATCH] SSE2 idct optimizations

2008-04-01 Thread Diego Biurrun
On Thu, Mar 06, 2008 at 06:08:29PM +0100, Christophe Massiot wrote: > On Sun, Feb 24, 2008, Diego Biurrun wrote: > > This patch supercedes previous incarnations sent in by Petri and Lionel. > > It takes the idct part from their patches along with minor cleanups and > > shoul

[mpeg2-dev] [PATCH] revert mistaken changes from MPlayer

2008-04-01 Thread Diego Biurrun
Ahem... Some of the #ifdeffery I submitted is not really functional outside MPlayer in its current form. libmpeg2 does not set things like HAVE_ALTIVEC and similar right now, so surrounding code with this preprocessor conditional effectively disables it. Here is a patch to revert the changes. S

Re: [mpeg2-dev] [PATCH] SSE2 idct optimizations

2008-04-01 Thread Diego Biurrun
On Sun, Feb 24, 2008 at 07:03:09PM +0100, Diego Biurrun wrote: > This patch supercedes previous incarnations sent in by Petri and Lionel. > It takes the idct part from their patches along with minor cleanups and > should be easier to review/verify. > > The motion compensation pa

Re: [mpeg2-dev] [PATCH] ARM optimized motion compensation

2008-03-01 Thread Diego Biurrun
On Thu, Feb 28, 2008 at 07:10:18PM +0100, Diego Biurrun wrote: > On Thu, Feb 28, 2008 at 06:56:36PM +0100, Christophe Massiot wrote: > > On Sun, Feb 24, 2008, Diego Biurrun wrote: > > > Here is a patch taken from the MPlayer patchset for libmpeg2 that adds > > > A

Re: [mpeg2-dev] [PATCH] ARM optimized motion compensation

2008-02-28 Thread Diego Biurrun
On Thu, Feb 28, 2008 at 06:56:36PM +0100, Christophe Massiot wrote: > On Sun, Feb 24, 2008, Diego Biurrun wrote: > > Here is a patch taken from the MPlayer patchset for libmpeg2 that adds > > ARM motion compensation. It supposedly runs well, but I am unable to > > hook up th

Re: [mpeg2-dev] [PATCH] SSE2 idct optimizations

2008-02-27 Thread Diego Biurrun
On Sun, Feb 24, 2008 at 07:03:09PM +0100, Diego Biurrun wrote: > This patch supercedes previous incarnations sent in by Petri and Lionel. > It takes the idct part from their patches along with minor cleanups and > should be easier to review/verify. > > The motion compensation pa

Re: [mpeg2-dev] [PATCH] consistent license headers

2008-02-25 Thread Diego Biurrun
On Mon, Feb 25, 2008 at 11:46:30AM +0100, Christophe Massiot wrote: > On Sun, Feb 24, 2008, Diego Biurrun wrote: > > Here is a trivial patch to remove a weirdness from all libmpeg2 license > > headers: It says "this program" where it should really say "mpeg2dec

[mpeg2-dev] [PATCH] SSE2 idct optimizations

2008-02-24 Thread Diego Biurrun
This patch supercedes previous incarnations sent in by Petri and Lionel. It takes the idct part from their patches along with minor cleanups and should be easier to review/verify. The motion compensation part contained in Petri's/Lionel's patch is not yet proven to give any sort of improvement, be

[mpeg2-dev] [PATCH] ARM optimized motion compensation

2008-02-24 Thread Diego Biurrun
Here is a patch taken from the MPlayer patchset for libmpeg2 that adds ARM motion compensation. It supposedly runs well, but I am unable to hook up the .S file properly in libmpeg2's auto* build system. I get the following compilation failure: /bin/bash ../libtool --mode=compile-c -o motion_

[mpeg2-dev] [PATCH] replace CVS references

2008-02-24 Thread Diego Biurrun
Here is a patch to do away with all the outdated references to CVS and give Subversion instructions instead. Diego Index: README === --- README (revision 1162) +++ README (working copy) @@ -155,33 +155,17 @@ could probably be optimi

[mpeg2-dev] [PATCH] consistent license headers

2008-02-24 Thread Diego Biurrun
Here is a trivial patch to remove a weirdness from all libmpeg2 license headers: It says "this program" where it should really say "mpeg2dec". Diego Index: include/mpeg2.h === --- include/mpeg2.h (revision 1162) +++ include/mpeg2.h (w

[mpeg2-dev] [PATCH] rename -cvs version number

2008-02-24 Thread Diego Biurrun
Well, the days of CVS are long gone around here. Thus libmpeg2 should not bear -cvs in its name. Diego Index: configure.ac === --- configure.ac (revision 1162) +++ configure.ac (working copy) @@ -1,6 +1,6 @@ dnl Process this file wi

Re: [mpeg2-dev] [PATCH] consistent multiple inclusion guards for all header files

2008-02-18 Thread Diego Biurrun
On Mon, Feb 18, 2008 at 07:26:17PM +0100, Diego Biurrun wrote: > Here is a patch to add consistent multiple inclusion guards to all > header files in libmpeg2. I have also used a LIBMPEG2_ prefix to avoid > possible namespace pollution issues. Please apply. Note that this patch sup

[mpeg2-dev] [PATCH] consistent multiple inclusion guards for all header files

2008-02-18 Thread Diego Biurrun
Here is a patch to add consistent multiple inclusion guards to all header files in libmpeg2. I have also used a LIBMPEG2_ prefix to avoid possible namespace pollution issues. Please apply. Diego Index: include/mpeg2.h === --- includ

[mpeg2-dev] [PATCH] fix AltiVec assembler syntay for Apple gcc

2008-02-16 Thread Diego Biurrun
Several files in libmpeg2 contain macros to account for differences in AltiVec assembler syntax between Apple and GNU gcc versions. The check that is performed is against HAVE_ALTIVEC_H. However, this check is brittle as altivec.h exists on Apple systems as well. This patch from the MPlayer patc

[mpeg2-dev] [PATCH] restrict GCC workaround to GNU version

2008-02-16 Thread Diego Biurrun
In libmpeg2/idct_altivec.c there is a workaround for GCC versions prior to 3.3. However, only the GNU version of GCC is affected, the fork that Apple ships is not. This patch extends the check not to include Apple GCC versions. Diego --- libmpeg2/idct_altivec.c 2004/08/02 11:26:43 12933 +++ libm

[mpeg2-dev] [PATCH] AltiVec portability patch

2008-02-15 Thread Diego Biurrun
This patch makes sure that AltiVec stuff is only used when enabled. Diego Index: libmpeg2/motion_comp.c === --- libmpeg2/motion_comp.c (revision 1152) +++ libmpeg2/motion_comp.c (working copy) @@ -42,7 +42,7 @@ mpeg2_mc = mpeg2_mc_m

[mpeg2-dev] [PATCH] SPARC VIS portability patch

2008-02-15 Thread Diego Biurrun
This patch makes sure that VIS stuff is only used when enabled. Diego Index: libmpeg2/cpu_accel.c === --- libmpeg2/cpu_accel.c (revision 1152) +++ libmpeg2/cpu_accel.c (working copy) @@ -127,7 +127,7 @@ } #endif /* ARCH_X86 */ -#i

[mpeg2-dev] [PATCH] ARCH_X86_64 portability patch

2008-02-15 Thread Diego Biurrun
Here is a patch to make some of the MMX optimizations available on x86_64 as well. I have extracted it from the MPlayer local patch set. Please apply. Diego Index: idct_mmx.c === --- idct_mmx.c (revision 1152) +++ idct_mmx.c (working

[mpeg2-dev] [PATCH] fix illegal identifiers

2008-02-14 Thread Diego Biurrun
The C standard reserves identifiers starting with _ and a capital letter for the system. Here is a patch that fixes a few instances in libmpeg2/idct_mmx.c. As a positive side effect, the names of the variables are much better than before. I already committed this to the copy of idct_mmx.c in FFm

[mpeg2-dev] [PATCH] some typo fixes

2008-02-14 Thread Diego Biurrun
Here are some trivial typo fixes, please apply. Diego Index: test/README === --- test/README (revision 1150) +++ test/README (working copy) @@ -9,7 +9,7 @@ # cvs login (Just press Return when prompted for a password) # cvs checkout