Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread Mattias Johnsson
On 6 November 2010 12:13, John LeMoyne Castle wrote: > > Hi all, > Ok, after getting over a short-term dislike of Word Count - with a new found > appreciation for some of the developer comments in OOo issuezilla - I had a > new idea for a test plan.  Perhaps turning on the Scanner clipping has > *

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Miklos Vajna
On Fri, Nov 05, 2010 at 09:36:40PM +, Caolán McNamara wrote: > On Fri, 2010-11-05 at 21:10 +, Wols Lists wrote: > > Just doing an emerge cppunit. > > It shouldn't be necessary to use system cppunit, cppunit should be built > as part of the build. > > So, lets just document debugging thi

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread John LeMoyne Castle
Hi all, Ok, after getting over a short-term dislike of Word Count - with a new found appreciation for some of the developer comments in OOo issuezilla - I had a new idea for a test plan. Perhaps turning on the Scanner clipping has *accidentally* fixed the quote problem as well. Although I inte

[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for calc\sc\source\filter

2010-11-05 Thread julien
Hello, Here is a patch for calc\sc\source\filter Hope i haven't made mistakes, there are 1 or 2 places where i hesitated. (LGPLv3+ / MPL) Julien. RTL_calc_sc_source_filter.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffic

[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for calc\sc\source\core\tool

2010-11-05 Thread julien
Hello, Here is a patch for calc\sc\source\core\tool (i think there's no more in it) (LGPLv3+ / MPL) Julien. RTL_calc_sc_source_core_tool.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://list

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Wols Lists
On 05/11/10 21:36, Caolán McNamara wrote: > On Fri, 2010-11-05 at 21:10 +, Wols Lists wrote: >> Just doing an emerge cppunit. > It shouldn't be necessary to use system cppunit, cppunit should be built > as part of the build. And now I've played, if you ask for system cppunit and it's not there

[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for calc\sc\source\core\data

2010-11-05 Thread julien
Hello, Here is a patch for calc\sc\source\core\data (i think there's no more in it) (LGPLv3+ / MPL) Julien. RTL_calc_sc_source_core_data.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lis

[Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'

2010-11-05 Thread Gert Faller
Hi, just wondering if someone knows why there are duplicate ids in 'writer/sw/inc/cmdid.h' (FN_FORMAT + 129) , (FN_FORMAT + 130), (FN_FORMAT + 131) at line 537. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fre

[Libreoffice] [PUSHED] Re: [PATCH] use linux bridge code on all BSDs

2010-11-05 Thread Thomas Klausner
Pushed, thanks! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Wols Lists
On 05/11/10 21:36, Caolán McNamara wrote: > On Fri, 2010-11-05 at 21:10 +, Wols Lists wrote: >> > Just doing an emerge cppunit. > It shouldn't be necessary to use system cppunit, cppunit should be built > as part of the build. Okay, I'll try and take a look. On the other hand, I've already loo

Re: [Libreoffice] [PATCH] use linux bridge code on all BSDs

2010-11-05 Thread Thomas Klausner
On Fri, Nov 05, 2010 at 09:01:09PM +0100, Robert Nagy wrote: > wiz, does this work on NetBSD? It does on OpenBSD, > so i would like to push it. Sorry for the delay, but I was still building. The patch improves the situation on NetBSD as well, so please push it. Thomas ___

[Libreoffice] [PATCH] Renaming extension options consistently

2010-11-05 Thread Niko Rönkkö
Renamed all extensions to --enable-ext-* because "we do want to present them together in ./configure --help" Deprecated old options not removed but commented instead. Fixed: --without-java (from Wol) --- configure.in | 296 -- 1 files

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Caolán McNamara
On Fri, 2010-11-05 at 21:10 +, Wols Lists wrote: > Just doing an emerge cppunit. It shouldn't be necessary to use system cppunit, cppunit should be built as part of the build. So, lets just document debugging this... sal/cppunittester/makefile.mk has APP1STDLIBS = $(CPPUNITLIB) $(SALLIB)

[Libreoffice] Added support for Microsoft C/C++ x64 compilers

2010-11-05 Thread Jesús Corrius
Hi fellow developers, The master branch has now experimental support for the Microsoft C/C++ x64 compilers. If you are a hacker brave enough to try it, you can enable the use of the x64 compiler (you need at least the 64bits version of the compiler and the Windows SDK installed) either by the con

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Wols Lists
On 05/11/10 20:44, Giuseppe Castagno wrote: > Wols Lists wrote: >> Just (yet again :-) done a completely fresh download of libreoffice, >> type "make", and I get the following fail :-( >> >> I'll investigate further, but has somebody just committed a change and >> broken it? >> > > ... > >> >> Ente

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Giuseppe Castagno
Wols Lists wrote: Just (yet again :-) done a completely fresh download of libreoffice, type "make", and I get the following fail :-( I'll investigate further, but has somebody just committed a change and broken it? ... Entering /home/anthony/gitstuff/loffice/rawbuild/sal/cppunittester Mak

[Libreoffice] [PATCH] remove -d from gunzip flags

2010-11-05 Thread julien
Hello, It's also possible to replace gunzip by gzip like the other lines of this file : # unpack the Crystal icon set $(MISC)$/crystal.flag : $(CRYSTAL_TARBALL) cd $(MISC) && gzip -d -c $(CRYSTAL_TARBALL) | ( tar -xf - ) && $(TOUCH) $(@:f) # unpack the Oxygen icon set $(MISC)$/oxygen.fla

Re: [Libreoffice] [PATCH] use linux bridge code on all BSDs

2010-11-05 Thread Robert Nagy
wiz, does this work on NetBSD? It does on OpenBSD, so i would like to push it. thanks ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] remove -d from gunzip flags

2010-11-05 Thread Robert Nagy
-d is not needed for gunzip because it will do a decompress anyways and -d is not available in every gunzip implementation --- packimages/pack/makefile.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/packimages/pack/makefile.mk b/packimages/pack/makefile.mk index 471f5

[Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Wols Lists
Just (yet again :-) done a completely fresh download of libreoffice, type "make", and I get the following fail :-( I'll investigate further, but has somebody just committed a change and broken it? Cheers, Wol Entering /home/anthony/gitstuff/loffice/rawbuild/sal/cpprt Making:all_salcpprt.dp

[Libreoffice] [PATCH] Distro-configs: adapt to new configure options for extensions

2010-11-05 Thread Niko Rönkkö
Some extensions options for configure were renamed to --enable-ext-* --- distro-configs/GoOoLinux.conf.in |4 ++-- distro-configs/GoOoMacOSX.conf.in|4 ++-- distro-configs/LibreOfficeLinux.conf.in |4 ++-- distro-configs/LibreOfficeLinuxDevel.conf.in |

Re: [Libreoffice] [PATCH] Renaming extension options consistently

2010-11-05 Thread Wols Lists
On 05/11/10 18:12, Niko Rönkkö wrote: > +AC_ARG_WITH(java, > +[ > + --with-java Build LibO with a JDK & Java support.], > +,) > + There's a patch of mine waiting to fix this ... And seeing as java is enabled by default, it seemed that it should be "--without-java Build LibO without a

[Libreoffice] [PATCH] Renaming extension options consistently

2010-11-05 Thread Niko Rönkkö
Renamed all extensions to --enable-ext-* because "we do want to present them together in ./configure --help" Deprecated old options not removed but commented instead. Fixed: --with-java --- configure.in | 296 -- 1 files changed, 205 i

Re: [Libreoffice] [PATCH] Renaming extension options consistently

2010-11-05 Thread Wols Lists
On 05/11/10 17:13, Niko Rönkkö wrote: > dnl === > dnl Optional Packages (--with/without-) > dnl === > @@ -1214,103 +1369,97 @@ AC_ARG_WITH(max-jobs, > Defaults

[Libreoffice] LINEST, LOGEST, TREND and GROWTH patch merged

2010-11-05 Thread Kohei Yoshida
Hi there, Just to let you guys know that, I've merged the feature/calc-function-linest-logest branch into master. That branch contained the patch from Regina (CC'ed) that improves accuracy of LINEST, LOGEST, TREND and GROWTH cell functions. I've done my review, and think it's in a good state. T

[Libreoffice] [PATCH] Renaming extension options consistently

2010-11-05 Thread Niko Rönkkö
Renamed all extensions to --enable-ext-* because "we do want to present them together in ./configure --help" See: b765a28ea9d63b60a14786b1a5484227175d413e Deprecated old options not removed but commented instead. ¡There are still extensions which are only in build/configure.in! Changed BUILD_

Re: [Libreoffice] [PUSHED, partial] Re: [Patch] German Translation and dev-install build improvement

2010-11-05 Thread surensp...@gmail.com
Hey Caolan, On Fri, Nov 5, 2010 at 7:47 PM, Caolán McNamara wrote: > On Thu, 2010-11-04 at 22:22 +0530, surensp...@gmail.com wrote: >> Hi, >> >> Just resending the patches with the suggested changes from other mailing >> threads >> >> Patch 1 : German Translation of comments in writer > > So, ca

Re: [Libreoffice] [PATCH] Use the correct db includes and obey LDFLAGS

2010-11-05 Thread Andreas Radke
ArchLinux is already at db5.1! Make sure it will pick it up. -Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Use the correct db includes and obey LDFLAGS

2010-11-05 Thread Hanno Meyer-Thurow
Hi Robert, you may have a look at what we do for Gentoo Linux, where we have the possibility to install multiple versions of Sleepycat DB. Even with variation of versions in path and filename endings like: '/path/to/dbVERSION' and '/path/to/filename-VERSION' I personally do not like that

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 2

2010-11-05 Thread Caolán McNamara
On Fri, 2010-11-05 at 13:57 +0100, Gert Faller wrote: > Hi, > > a little more in 'libs-core' Looks good pushed. I'd still prefer rtl::OUString sFoo(RTL_CONSTHING("apple")) over rtl::OUString sFoo(rtl::OUString(RTL_CONSTTHING("apple"))); however :-) C.

[Libreoffice] [PATCH] Adapt LibreOffice branding in LibO-SDK user installation script.

2010-11-05 Thread Giuseppe Castagno
Hi all, I tried to install the LibO-SDK as generated in my build from master, and I noted that has some link/mingling with OOo. there are two small issue: 1) When I try to create the working environment in GNU/Linux, it defaults to use the OOo 3 program installation. I can manually change to

Re: [Libreoffice] [PATCH] Use the correct db includes and obey LDFLAGS

2010-11-05 Thread Robert Nagy
Hi I'd personally not give the freedom to the user to pick whatever sleepycat db they want to use, just make a dependency for one only and check for that. On (2010-11-05 15:11), Hanno Meyer-Thurow wrote: > Hi Robert, > you may have a look at what we do for Gentoo Linux, where we have > the possib

[Libreoffice] [PUSHED, partial] Re: [Patch] German Translation and dev-install build improvement

2010-11-05 Thread Caolán McNamara
On Thu, 2010-11-04 at 22:22 +0530, surensp...@gmail.com wrote: > Hi, > > Just resending the patches with the suggested changes from other mailing > threads > > Patch 1 : German Translation of comments in writer So, catch is that there was a few other changes made in the meantime to that file so

Re: [Libreoffice] [PATCH] Use the correct db includes and obey LDFLAGS

2010-11-05 Thread Thomas Klausner
On Fri, Nov 05, 2010 at 12:22:37PM +0100, Robert Nagy wrote: > diff --git a/configure.in b/configure.in > index aab3995..6f72931 100644 > --- a/configure.in > +++ b/configure.in > @@ -4368,11 +4368,16 @@ if test -n "$with_system_db" -o -n > "$with_system_libs" && \ > test "$with_system_db" !=

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-05 Thread Kohei Yoshida
On Fri, 2010-11-05 at 00:51 -0400, Kohei Yoshida wrote: > Hi there, > > Does anyone know if SvxHyperlinkDlg* is still used? Did a full git grep SvxHyperlinkDlg on all repos and I'm more confident that the answer is 'no'. Though it is still referenced (via SvxHyperlinkDlgWrapper) here and there i

Re: [Libreoffice] Changing mailing list behavior

2010-11-05 Thread Sebastian Spaeth
On Fri, 05 Nov 2010 11:28:24 +0100, Regina Henschel wrote: > It is not about using my seamonkey, but why this list is organized > different than others. It's a religious thing. Some belief that the list should set a reply-to to itself while others don't want the list to monkey around with the hea

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread Mattias Johnsson
On 5 November 2010 20:16, Cedric Bosdonnat wrote: > Hi Mattias, > > On Fri, 2010-11-05 at 10:38 +1100, Mattias Johnsson wrote: >> There isn't a bug report in the LO tracker, but there are quite a few >> in the OO.o issue tracker. The basic issue number is 89042, with >> 97116, 102270, 107241, 1133

Re: [Libreoffice] [PATCH] Use the correct db includes and obey LDFLAGS

2010-11-05 Thread Robert Nagy
A little bit more explanation: On OpenBSD there is a db.h in /usr/include which is not sleepycat db4, and of course it gets picked up and the compile test fails. On (2010-11-05 12:22), Robert Nagy wrote: > --- > configure.in | 15 ++- > 1 files changed, 10 insertions(+), 5 deletion

[Libreoffice] [PATCH] Use the correct db includes and obey LDFLAGS

2010-11-05 Thread Robert Nagy
--- configure.in | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/configure.in b/configure.in index aab3995..6f72931 100644 --- a/configure.in +++ b/configure.in @@ -4368,11 +4368,16 @@ if test -n "$with_system_db" -o -n "$with_system_libs" && \ test "$

Re: [Libreoffice] Changing mailing list behavior

2010-11-05 Thread Wols Lists
On 05/11/10 10:28, Regina Henschel wrote: > It is not about using my seamonkey, but why this list is organized > different than others. For example in disc...@documentfoundation.org > (and in all other mailing list I am subscribed, but > libreoffice@lists.freedesktop.org) when I click on "Antworten

Re: [Libreoffice] Building on Debian squeeze

2010-11-05 Thread Rene Engelhard
On Fri, Nov 05, 2010 at 07:34:27PM +0900, Takeshi Abe wrote: > Java source codes in tests of LO/OOo use the annotation feature of JUnit 4, > imported with namespace org.junit.*, which JUnit 3.x lacks. So its version > is worth checking out. Yes, but they are unreliable anyway, so even me who other

Re: [Libreoffice] Building on Debian squeeze

2010-11-05 Thread Takeshi Abe
Hi Wols, On Thu, 04 Nov 2010 18:19:15 +, Wols Lists wrote: > On 04/11/10 18:09, Takeshi Abe wrote: (snip) >> I'm neither sure, but junit4 is also available on sid, lenny, marverick, >> lucid, karmic etc. We should note that it can be confusing that at the >> same time there is the JUnit 3.x's

Re: [Libreoffice] Changing mailing list behavior

2010-11-05 Thread Regina Henschel
Hi all, Kevin Hunter schrieb: At 7:01pm -0400 Thu, 04 Nov 2010, Kohei Yoshida wrote: On Thu, 2010-11-04 at 23:58 +0100, Thorsten Behrens wrote: If you're subscribed, and you don't want extra copies, just set a "Reply-To: libreoffice@lists.freedesktop.org" header. Most mailers (and people) adhe

Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java

2010-11-05 Thread Wols Lists
On 05/11/10 09:53, Rene Engelhard wrote: > On Fri, Nov 05, 2010 at 08:42:34AM +0100, Sebastian Spaeth wrote: >> On Thu, 04 Nov 2010 18:24:04 +, Wols Lists wrote: >>> + --with-java Build LibO with a JDK & Java support.], >> So, what should be the default? Including Java? Then I wou

Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java

2010-11-05 Thread Rene Engelhard
On Fri, Nov 05, 2010 at 08:42:34AM +0100, Sebastian Spaeth wrote: > On Thu, 04 Nov 2010 18:24:04 +, Wols Lists wrote: > > + --with-java Build LibO with a JDK & Java support.], > > So, what should be the default? Including Java? Then I would argue for > making this a --without opt

Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java

2010-11-05 Thread Wols Lists
On 05/11/10 07:42, Sebastian Spaeth wrote: > On Thu, 04 Nov 2010 18:24:04 +, Wols Lists wrote: >> + --with-java Build LibO with a JDK & Java support.], > So, what should be the default? Including Java? Then I would argue for > making this a --without option and having Java enabled

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread Cedric Bosdonnat
Hi Mattias, On Fri, 2010-11-05 at 10:38 +1100, Mattias Johnsson wrote: > There isn't a bug report in the LO tracker, but there are quite a few > in the OO.o issue tracker. The basic issue number is 89042, with > 97116, 102270, 107241, 113375, and 108072 marked as duplicates. Hum, I saw that one..

Re: [Libreoffice] ./download doesn't work behind a proxy

2010-11-05 Thread Miklos Vajna
On Fri, Nov 05, 2010 at 08:52:19AM +0100, Marc-Oliver Straub wrote: > For such a cloned repository, will push be possible? Or is this then a > read-only repository? It's read-only. It's possible to make it writable, but I guess nobody wants to script a hook that would push back to the freedeskt

Re: [Libreoffice] [PATCH] Renaming extension options

2010-11-05 Thread Tor Lillqvist
> So --enable is IMHO what we really want here. I agree. Sure, enabling an extension means that the LO being built will come "with" the extension. So I guess that's the reasoning why the "with" type of options have been used. But it is wrong. --tml __

Re: [Libreoffice] ./download doesn't work behind a proxy

2010-11-05 Thread Marc-Oliver Straub
For such a cloned repository, will push be possible? Or is this then a read-only repository? Thanks, Oli On 11/03/10 18:20, Miklos Vajna wrote: On Wed, Nov 03, 2010 at 02:10:14PM +0100, Florian Effenberger wrote: I'm no git expert, but if someone comes up with a script, that should be no pr

Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java

2010-11-05 Thread Sebastian Spaeth
On Thu, 04 Nov 2010 18:24:04 +, Wols Lists wrote: > + --with-java Build LibO with a JDK & Java support.], So, what should be the default? Including Java? Then I would argue for making this a --without option and having Java enabled by default... ? pgppmfCzt4N2n.pgp Description:

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread John LeMoyne Castle
Hi again, Well I suggested it so ran a few tests after a full re-build finished. I was curious. I don't think the target should be 'counts exactly like Word' but certainly a quotation mark shouldn't count as its own word when it is adjacent to text on either side. Especially there shouldn't b

Re: [Libreoffice] [PUSHED] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 1

2010-11-05 Thread David Tardon
On Thu, Nov 04, 2010 at 09:54:20PM +0100, Gert Faller wrote: > Hi, > > here are some in 'libs-core'. > > Regards. > Thanks! I removed some changes * in BasicManager::SetGlobalUNOConstant, because the variable is function parameter, not a string constant. * in ModuleContainer_Impl::getByName,

Re: [Libreoffice] [PATCH] Renaming extension options

2010-11-05 Thread Sebastian Spaeth
On Thu, 04 Nov 2010 21:26:43 +0200, Niko Rönkkö wrote: > Renamed all extensions to --with-ext-* Thanks, that makes sense, I just didn't get to it. I'd just still argue for --enable rather than --with. > If "we do want to present them together in ./configure --help", > then they all must be a sa