On Mon, 08 Nov 2010 09:05:41 +0200, Niko Rönkkö wrote:
> It's not good to use option descriptions like --enable/disable-*.
>
> Also: If we want to replace default option descriptions with our owns,
> then we shall describe them both (dependency-tracking).
I am not opposed to the patch, but what
I think, I'll add a "how to prepare and send patches" section to the
wiki, as that causes lots of confusion. Is there consensus by committers
whether we want to have patches attached to a mail or sent inline with
"git send-email"? Depending on the outcome, I'll write up the
recommendation according
> With the dependency tracking like this for example, it is not clear
> from the output of configure --help what the default is, on or off?
> Perhaps we should state that in the help text (default is enabled, or
> whatever fits)
In this case The Default is somewhere between those options.
On Fri, 2010-11-05 at 18:13 -0700, John LeMoyne Castle wrote:
> Hi all,
[...]
> Still new to git but I am sure I saw and built and ran the old txtedt.cxx
> and still no LSQEW. Feelin' a bit lost ... I can think of some other
> options for trying to find what fixed the LSQEW but I feel like I'm ch
I have switched from Ubuntu to OpenSuse.
This OpenSuse is a bare system with the latest update, thus OpenSuse 10.3.
I removed the OpenOffice.
Then I tried:
sudo zypper si -d OpenOffice_org-bootstrap
but that did not work. I say that 10.3 was not yet defined, thus I did the
required installations m
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote:
> On Sun, Nov 7, 2010 at 7:00 AM, julien wrote:
> Ahh, welcome to the wonderful world of operator overload.
> >>= is not a right shift but instead, here, nMapWith get populated with the
> >>property (uno) value, converted to a int32.
>
Hi,
translating lo-build.pot to the Japanese .po, I found a typo in libs-core
which affects a msgid (numbered as 277) in the .pot.
It would be nice if we can apply the attached patch before the string freeze.
Cheers,
-- Takeshi Abe
diff --git a/svx/inc/gallery.hxx b/svx/inc/gallery.hxx
index 3656
On Mon, 08 Nov 2010 11:09:36 +0200, Niko Rönkkö wrote:
> > With the dependency tracking like this for example, it is not clear
> > from the output of configure --help what the default is, on or off?
> > Perhaps we should state that in the help text (default is enabled, or
> > whatever fits)
>
> I
If the internal hyphen library is used which does not
build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a,
instead of using -lhyphen on UNX + GCC.
---
.../hyphenator/altlinuxhyph/hyphen/makefile.mk |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/lingu
On 11/08/2010 10:37 AM, Sebastian Spaeth wrote:
I think, I'll add a "how to prepare and send patches" section to the
wiki, as that causes lots of confusion. Is there consensus by committers
whether we want to have patches attached to a mail or sent inline with
"git send-email"? Depending on the o
On Mon, 08 Nov 2010 14:11:23 +0200, Jani Monoses wrote:
> On 11/08/2010 10:37 AM, Sebastian Spaeth wrote:
> > I think, I'll add a "how to prepare and send patches" section to the
> > wiki, as that causes lots of confusion. Is there consensus by committers
> > whether we want to have patches attach
On Mon, 08 Nov 2010 09:37:34 +0100, Sebastian Spaeth wrote:
> wiki, as that causes lots of confusion. Is there consensus by committers
> whether we want to have patches attached to a mail or sent inline with
> "git send-email"? Depending on the outcome, I'll write up the
> recommendation accordingl
2010/11/8 Joost Eekhoorn
> I have switched from Ubuntu to OpenSuse.
> This OpenSuse is a bare system with the latest update, thus OpenSuse 10.3.
> I removed the OpenOffice.
>
> Then I tried:
> sudo zypper si -d OpenOffice_org-bootstrap
> but that did not work. I say that 10.3 was not yet defined,
On Fri, 2010-11-05 at 09:14 +0200, Robert Roth wrote:
> Some more comments and commented code removed, code co- licensed under
> LGPLv3+, GPLv3+ and MPL.
Looks good to me, modulo one type (reloaed) which I fixed, committed and
pushed now.
C.
___
LibreO
On Fri, 2010-11-05 at 15:30 +0100, Giuseppe Castagno wrote:
> Hi all,
>
> I tried to install the LibO-SDK as generated in my build from master,
> and I noted that has some link/mingling with OOo.
Looks good, pushed to head and I cherrypicked it for Libo 3.3 as well
C.
_
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote:
> On Sun, Nov 7, 2010 at 7:00 AM, julien wrote:
> >the if() can only be true if that value is not 0 so here you have a false
> >positive.
Julien, could you log a bug against cppcheck itself with this example,
including the operator overl
On Sat, 2010-11-06 at 10:13 -0500, Norbert Thiebaud wrote:
> There is some improvement on the smoketest front
>
> It run pass many more tests.. but still do not finish:
The smoketest passes every time for me. FWIW
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGS
On Fri, 2010-11-05 at 20:19 +0530, surensp...@gmail.com wrote:
> Updated the second patch and tested it.
Looks good to me, pushed this now. Thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/
On Sun, 2010-11-07 at 12:53 +0200, Aurimas Fišeras wrote:
> Fixes more typos in documentation.
>
> Patch is contributed under the LGPLv3+.
Looks good, all pushed. Thanks.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.
Selon Caolán McNamara :
> Hmm, one of the + 129 is FN_NEW_PAGE_STYLE and appears (according to
> opengrok) unused the FN_PAGE_STYLE_SET_LR_MARGIN and
> FN_PAGE_STYLE_SET_UL_MARGIN i.e. one version of the + 130 and + 131 are
> only mentioned in basesh.cxx as "false not implemented".
>
> So I recko
On Sun, 2010-11-07 at 14:16 +0100, julien wrote:
> Hello,
>
> I can't test this patch since this part of code is for Windows but i
> think it's a true positive
Yes, I agree, its a potential memory leak
> Is this ok or am I wrong ?
Yeah, this is ok, and I've pushed this fix, thanks :-)
Though,
On Mon, 2010-11-08 at 19:22 +0900, Takeshi Abe wrote:
> Hi,
>
> translating lo-build.pot to the Japanese .po, I found a typo in libs-core
> which affects a msgid (numbered as 277) in the .pot.
> It would be nice if we can apply the attached patch before the string freeze.
Excellent! The change l
On Sun, 2010-11-07 at 19:29 +0100, Gert Faller wrote:
> HI,
>
> here are some more in libs-core
>
All good, except BACKEND_SERVICE_NAME isn't a define or a [] so that one
would have resolved to ... sizeof(char*) which is always 4 on 32bit
machines and 8 on 64bit machines, i.e. not what we need h
On Sun, 2010-11-07 at 19:53 +0100, Robert Nagy wrote:
> The diff makes i18npool/source/paper/makefile.mk define
> LIBTARGET=NO just like other makefiles in the i18npool/source/ directory.
> Without this patch I always get:
>
> dmake: /home/robert/build/build/libreoffice-3.2.99.2/solenv/inc/_tg_l
On Mon, 2010-11-08 at 00:59 -0500, Kevin Hunter wrote:
> Hullo List,
>
> Some accessibility tabbar RTL_CONST conversion goodness.
Looks good, pushed. Thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freed
On Mon, 2010-11-08 at 02:42 -0500, Kevin Hunter wrote:
> Hullo Committers,
>
> One more RTL easy hack commit against:
Also looks good, pushed now as well, thanks.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedeskt
Hi,
this time a brief summary of what happened the 6th week on LibreOffice
repos and two living branches:
bugfixes-master-week-44.txt lists all commits that reference a proper
bug id (from a variety of trackers - #i... referring to the OpenOffice
issuezilla, fdo# to freedesktop, rhbz# to RedHat b
On Sat, 2010-11-06 at 19:50 +0100, Robert Nagy wrote:
> Hey
>
> I don't really care which one goes in. I think gzip -d might
> be a better idea then. Any other comments?
I say go ahead with "gzip -d", should be fine for everyone.
C.
___
LibreOffice ma
On 11/8/10, Noel Power wrote:
> On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote:
>> On Sun, Nov 7, 2010 at 7:00 AM, julien wrote:
>
>> Ahh, welcome to the wonderful world of operator overload.
>> >>= is not a right shift but instead, here, nMapWith get populated with
>> >> the property
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:
> here is more commented code removal.
Reviewed and applied the part against the 'sc' module. Thanks a lot!
I removed everything except for the one in sc/inc/compiler.hxx (below).
@@ -101,13 +101,6 @@ class ScTokenArray;
On Mon, 08 Nov 2010 14:59:37 +0100, Sebastian Spaeth wrote:
>
> There was #ifdef'd test code depending on WITH_CORE being defined (which
> is never set in our build system). It is described as test code that
> will core dump for sure. So let's remove this and write proper cppunit
> tests instead.
Sebastian Spaeth wrote:
> > What would be super-nice, would be if we could have a patch a little
> > like the Help->License info one - cf. sfx2/source/appl/appserv.cxx -
> > that would load a nice ODF document containing the output of your work -
> > so that we cna ship that with the binaries, and
On Mon, 2010-11-08 at 10:57 -0500, Norbert Thiebaud wrote:
> On 11/8/10, Noel Power wrote:
> > returns true if it was able to successfully extract the value from the
> > 'theAny' into 'something' so there is a possibility of a runtime divide
> > by zero ( and probably should be defensively coded a
On Sun, 2010-11-07 at 20:42 +0100, Robert Nagy wrote:
> If the internal hyphen library is used which does not
> build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a,
> instead of using -lhyphen on UNX + GCC.
How come, the -L options should place solarlibdir before the system
ones, so -Lh
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:
> here is more commented code removal.
Reviewed and pushed the part against the 'base' module. Thanks a lot!
One thing to note: you added a blank line between the else if blocks,
but I didn't add that change, as I consider that to be unne
On (2010-11-08 16:29), Caolán McNamara wrote:
> On Sun, 2010-11-07 at 20:42 +0100, Robert Nagy wrote:
> > If the internal hyphen library is used which does not
> > build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a,
> > instead of using -lhyphen on UNX + GCC.
>
> How come, the -L optio
On Mon, 2010-11-08 at 15:18 +0100, Gert Faller wrote:
> yes, I checked that too.
> Do you think that can be left untouched ?
They can probably be left untouched without much harm at first glance,
but removing the three duplicated and apparently dead ones is probably
the right thing to do if you wa
On Sun, 2010-11-07 at 23:53 -0500, Kevin Hunter wrote:
> Hullo Committers,
>
> A simple patch set to remove some unnecessary comments. As always, LGPLv3.
Hum, the comments like...
// XServiceInfo
// XAccessible
are being used to indicate in this multiply inherited class for which
parent class
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:
> here is more commented code removal.
Ok. Just pushed the remaining chart2 part of the patch. All looks good.
Thanks much. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffi
At 11:46am -0500 Mon, 08 Nov 2010, Caolán McNamara wrote:
Hum, the comments like...
[ good comments ]
[ aren't in the same category as ]
/*->start removed 2010.10.10
<-end removed 2010.10.10*/
Noted. I'm just learning the ropes of what's important in this code
base. I tend to think t
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Christoph,
On 2010-11-03 at 00:29 +0100, Christoph Noack wrote:
> I'm answering here since - if there is some dev interest - there are
> some more ideas on different lists that might be worth considering. Even
> "Easy / Medium Hacks" that turn out to be very visible ...
Oh - it seems it works
On Mon, 2010-11-08 at 09:57 -0500, Kohei Yoshida wrote:
> On Mon, 2010-11-08 at 19:22 +0900, Takeshi Abe wrote:
> > Hi,
> >
> > translating lo-build.pot to the Japanese .po, I found a typo in libs-core
> > which affects a msgid (numbered as 277) in the .pot.
> > It would be nice if we can apply th
Hello List,
Here's another set of patches. Caolán, I think I've done a little
better on the comments this time, but probably not yet perfect.
accessibility/
Cheers,
Kevin
comment_removals.tbz
Description: application/bzip-compressed-tar
___
Libr
Hi Peter,
On 2010-11-02 at 21:19 -0300, Peter Burtt wrote:
> The cygwin SETUP.EXE accepts a comma-delimited list of packages to
> install. To install cygwin and the packages listed as prerequisites on
> http://wiki.services.openoffice.org/wiki/Documentation/Building_Guide/Building_on_Windows#se
Hullo List,
Another RTL_CONST patch, also against accessibility/ .
Cheers,
Kevin
0001-EasyHack-createAsciiFrom-RTL_CONST.patch.bz2
Description: application/bzip
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.
Hi List,
Here's an RTL patch against basebmp/ .
Kevin
basebmp_rtl_easy_hack.tgz
Description: application/compressed-tar
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi List,
A patch to remove large blocks of already commented code.
basic/
Cheers,
Kevin
basic_commented_removed.tgz
Description: application/compressed-tar
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/
hi',
cleaned some coments
and killed an unused function
fun and all
René
--
-- as life grows older, I gain experience.
0001-comment-crean-up-in-sc.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://li
On Mon, 2010-11-08 at 20:51 +0100, René Kjellerup wrote:
> hi',
>
> cleaned some coments
> and killed an unused function
Looks good. Pushed.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedeskto
Le 08/11/2010 14:33, Caolán McNamara a écrit :
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote:
On Sun, Nov 7, 2010 at 7:00 AM, julien wrote:
the if() can only be true if that value is not 0 so here you have a false
positive.
Julien, could you log a bug against cp
Hi Kohei,
On Mon, 08 Nov 2010 12:40:03 -0500, Kohei Yoshida wrote:
(snip)
>> Excellent! The change looks good, and I build-tested on master.
>>
>> Before cherry-picking this to libreoffice-3-3 branch, let me ask Andre
>> to make sure if we are still before the string freeze.. Andre? :-)
>
> J
Hi,
I read the wiki page
http://wiki.documentfoundation.org/Development/How_to_build
and noticed we do not mention anything about how to build the
libreoffice-3.3 branch.
Here is what works for me:
git clone /path/to/build.git libreoffice-3-3
cd libreoffice-3-3
git checkout --track origin/libr
On Mon, 2010-11-08 at 01:11 -0500, Kevin Hunter wrote:
> Hullo Committers,
>
> A patch set against directory:
>
> accessibility/source/helper
RTL_foo macro looks good, thanks for this :-) and I added in the comment
stuff as well while I was at it.
C.
__
On Mon, 2010-11-08 at 01:33 -0500, Kevin Hunter wrote:
> Hullo Committers,
>
> Another patch set, this time against
>
> accessibility/source/standard/
I pushed all the RTL_macro foo, all good, thanks.
I only pushed a few hunks of the comment removal stuff though. I'm no
fan of the line se
At 4:06pm -0500 Mon, 08 Nov 2010, Caolán McNamara wrote:
I only pushed a few hunks of the comment removal stuff though. I'm no
fan of the line separators or particularly in love with the
commenting format, but there is potentially useful info in having the
service name that each block implem
On Mon, 2010-11-08 at 02:36 -0500, Kevin Hunter wrote:
> At 2:17am -0500 Mon, 08 Nov 2010, Kevin Hunter wrote:
> > Subject says it all. Patch against three files under
> >
> > automation/source/
caolanm->kendy: What's the story with the conversion of leading tabs to
space and the whitespace checki
On Mon, 2010-11-08 at 02:36 -0500, Kevin Hunter wrote:
> At 2:17am -0500 Mon, 08 Nov 2010, Kevin Hunter wrote:
> > Subject says it all. Patch against three files under
> >
> > automation/source/
Pushed the substantial hacking out of the commented-out code in
automation. Thanks. I'm holding back on
On Mon, 2010-11-08 at 17:42 +0100, Robert Nagy wrote:
> Making:libhyphen.so
Ah, this is in lingucomponent/source/hyphenator/altlinuxhyph/hyphen
right ? Then this is a duplicate of the other problem you had with the
build breakage in i18npool. It should be making
libhyphen$(DLLPOSTFIX).so and
At 4:23pm -0500 Mon, 08 Nov 2010, Caolán McNamara wrote:
Pushed the substantial hacking out of the commented-out code in
automation. Thanks. I'm holding back on the end of line whitespace
stuff because all of our files have it, at least in line 4 :-). Maybe
we can resolve all of those in one fell
Hullo again,
Some more easy hack RTL code.
bridges/
Kevin
bridges_rtl_easy_hack.tbz
Description: application/bzip-compressed-tar
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Mon, 2010-11-08 at 21:14 +, Caolán McNamara wrote:
> caolanm->kendy: What's the story with the conversion of leading tabs to
> space and the whitespace checkin rules. e.g. We can't checking in
> trailing whitespace, but nearly every file has trailing whitespace on
> line 4 :-) I'm guessing
I am not a perl expert, but I have figured out this command:
perl -i.bak -wpl -e 's/ +$//g;' *.cxx
The original files are save as *.bak and can be removed if the revoval of
taling spaces was correct.
Joost
2010/11/8 Caolán McNamara
> On Mon, 2010-11-08 at 02:36 -0500, Kevin Hunter wrote:
> >
Hello again list,
My last contribution of the day, with two RTL patches for canvas/ and
chart2/ .
Cheers,
Kevin
canvas_rtl_easy_hack.tbz
Description: application/bzip-compressed-tar
chart2_rtl_easy_hack.tbz
Description: application/bzip-compressed-tar
_
Hi,
Following the hints of Michael Meeks in :
'https://bugs.freedesktop.org/show_bug.cgi?id=30944', here a first try in
writer.
It's 'raw code' : just wondering if it satisfies the required functionality.
Regards.
export_4.patch
Description: Binary data
Hi Caolan,
Caolán McNamara píše v Po 08. 11. 2010 v 21:14 +:
> caolanm->kendy: What's the story with the conversion of leading tabs
> to space and the whitespace checkin rules. e.g. We can't checking in
> trailing whitespace, but nearly every file has trailing whitespace on
> line 4 :-) I'm g
Contact Prowol or Unsubscribe?
聯絡我們 或 不要收到 本電子報？
保證低價，投影機、布幕、音響、影音工程設計規劃
5000流明投影機出租，租金超便宜，(福音用途每小時500元「以實
際使用小時收費，自取價」)。歡迎來電洽詢!
+++我們是一家以"協助教會、廣傳福音、幫助大家、省時省金"為宗旨的基督徒公司+++
普洛瓦創意資訊有限公司
Tel
Contact Prowol or Unsubscribe?
聯絡我們 或 不要收到 本電子報？
Infrared Sensor Auto Hand-Washer
+++我們是一家以"協助教會、廣傳福音、幫助大家、省時省金"為宗旨的基督徒公司+++
普洛瓦創意資訊有限公司Prowol Co., Ltd.
Tel : 886-2-87706959
Fax : 886-2-87
Minor cleanup item I saw when preparing my last patches.
LGPLv3+/MPL
Jordan Ayers
From c2c5af35636a6f1bfd9f69b39e9baddc7da2f894 Mon Sep 17 00:00:00 2001
From: Jordan Ayers
Date: Mon, 8 Nov 2010 19:56:49 -0600
Subject: [PATCH] Remove unused global from perl installer
Per comments in globals.pm,
Miscellaneous cleanup to build.pl. Mostly removal of dead code, with
a few spelling / German->English fixes.
LGPLv3+/MPL
Jordan Ayers
From bcebd3c5cf9c62aa3321dca253a7d61bded6cde9 Mon Sep 17 00:00:00 2001
From: Jordan Ayers
Date: Wed, 3 Nov 2010 23:35:04 -0500
Subject: [PATCH] Cleanup build.pl
TIPOGRAFIA e STAMPA DIGITALE
www.tipoprint.com
Tel: 02 89 92 67 50
Gentile Cliente,
Crediamo sia cosa gradita farvi pervenire questa nostra offerta relativa ai
nostri stampati. E' una occasione da non perdere anche perche' potrete
sfruttare questa offerta per tutto il 2010 a sola condizione che ri
On Mon, 8 Nov 2010 22:23:07 -0600, Jordan Ayers wrote:
> Some more cleanup for the perl installer.
Thanks, pushed as 4e7555bf001050752e7380c54dd804fa9566d7ad
Removing nearly 500 lines of commented out code. I just left one hunk
that seemed remotely usefull for future improvements.
Sebastian
pg
On Mon, 8 Nov 2010 17:20:25 +0100, Thorsten Behrens wrote:
> Ah sorry, my backlog is building up - I actually added that feature
> - now we only need a nice credits .odt. ;)
Mmh, I tried to import the .html into LibreOffice, but it looks pretty
crappy. If someone can come up with a nice template p
73 matches
Mail list logo
