Re: [Libreoffice] [stephan.bergm...@oracle.com: Re: [releases] Minutes for release status meeting from 2010-11-15]

2010-11-22 Thread David Nelson
Hi, :-) On Tue, Nov 16, 2010 at 21:03, Rene Engelhard wrote: > The effect is that an office installation based on OOo before 3.3 > cannot share a URE installation with an office installation based on > OOo 3.3 or later.  Sharing URE installations is only relevant on Linux > and Solaris, not on Wi

Re: [Libreoffice] feature/rip-build-repo - branch for removal of the need of the 'build' repo

2010-11-22 Thread Norbert Thiebaud
On Mon, Nov 22, 2010 at 8:48 PM, Kohei Yoshida wrote: > On Sat, 2010-11-20 at 18:40 -0500, Norbert Thiebaud wrote: >> On Thu, Nov 18, 2010 at 10:18 PM, Jan Holesovsky wrote: >> > Hi, >> > >> > In case you are interested to try to build without the 'build' repo (the >> > rawbuild/ way), you can tr

[Libreoffice] YILIN ŞOK KAMPANYASI !

2010-11-22 Thread KARTASiS
KARTASİS Araç Takip Sistemleri Listeden Çıkmak için b...@listedencikar.com adresine "Çıkar" başlıklı Boş bir e-posta gönderiniz ___ LibreOff

Re: [Libreoffice] [PUSHED] remove dead codes and undesired comments

2010-11-22 Thread David Tardon
On Tue, Nov 23, 2010 at 02:01:57PM +0900, Takeshi Abe wrote: > Hi, > > Easy Hacks on base, some of indentions are left unchanged for clarity. > Thanks! I pushed it except one hunk containing the magical word TODO :) D. ___ LibreOffice mailing list Lib

Re: [Libreoffice] OSL_DEBUG_LEVEL question

2010-11-22 Thread David Tardon
On Mon, Nov 22, 2010 at 11:33:42PM +0100, Miklos Vajna wrote: > On Mon, Nov 22, 2010 at 10:38:31PM +0100, Miklos Vajna > wrote: > > Does anyone have an idea when (and why) this changed, and what's the new > > way of getting the OSL_TRACE() output? > > Oh, I guess this is related to David's recen

Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-22 Thread Mattias Johnsson
On 23 November 2010 16:59, David Tardon wrote: > On Tue, Nov 23, 2010 at 04:14:01PM +1100, Mattias Johnsson wrote: >> >> On a semi-related note, I'm doing a lot of stepping through the search >> and replace code trying to track the problem down. Because LO seems to >> be compiled using -O2 and -O3

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-22 Thread Joost Eekhoorn
I did not do "git pull -r && bin/g pull -r", so I got the same problem. Thus I did the pull, copied the file from the rawbuild to the build/libreoffice-3.2.99.2/sc/source/ui/src directory and then ran "build" in build/libreoffice-3.2.99.2. Now that part of the build is OK. I had just bad karma wit

Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-22 Thread David Tardon
On Tue, Nov 23, 2010 at 04:14:01PM +1100, Mattias Johnsson wrote: > > On a semi-related note, I'm doing a lot of stepping through the search > and replace code trying to track the problem down. Because LO seems to > be compiled using -O2 and -O3, there's a lot of optimization which > means the way

Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-22 Thread Mattias Johnsson
On 22 November 2010 21:22, Michael Meeks wrote: > Hi Mattias, > > On Sun, 2010-11-21 at 00:21 +1100, Mattias Johnsson wrote: >> I've been trying to fix a bug in the search and replace code, and >> after a bit of hacking have discovered that in findattr.cxx there's a >> function > >        Nice wor

[Libreoffice] [PATCH] remove dead codes and undesired comments

2010-11-22 Thread Takeshi Abe
Hi, Easy Hacks on base, some of indentions are left unchanged for clarity. Cheers, -- Takeshi Abe >From 72d1f225685964869caa855122bbed8250f1f927 Mon Sep 17 00:00:00 2001 From: Takeshi Abe Date: Tue, 23 Nov 2010 13:54:22 +0900 Subject: [PATCH] remove dead codes and undesired comments --- dbacce

[Libreoffice] HC Cleanup

2010-11-22 Thread Joseph Powers
While creating the HC Icon set, could you look into the following? default_images/svx/source/svdraw cropmarkers.png - 2d icons for cropping cropmarkers2.png- 3d icons for cropping cropmarkersACC.png - HC icons for cropping

Re: [Libreoffice] feature/rip-build-repo - branch for removal of the need of the 'build' repo

2010-11-22 Thread Kohei Yoshida
On Sat, 2010-11-20 at 18:40 -0500, Norbert Thiebaud wrote: > On Thu, Nov 18, 2010 at 10:18 PM, Jan Holesovsky wrote: > > Hi, > > > > In case you are interested to try to build without the 'build' repo (the > > rawbuild/ way), you can try to get the feature/rip-build-repo branch > > which I hope is

Re: [Libreoffice] Discuss " Easy_Hacks: Remove Sheet From File" ?

2010-11-22 Thread Kohei Yoshida
On Mon, 2010-11-22 at 14:27 -0500, Kohei Yoshida wrote: > On Mon, 2010-11-22 at 18:45 +, Joe Smith wrote: > > > > There should be some data from the Improvement Program on how often > > this item is > > used, no? > > Sure. But such data was not available to us mere mortals (or hackers as >

Re: [Libreoffice] OSL_DEBUG_LEVEL question

2010-11-22 Thread Miklos Vajna
On Mon, Nov 22, 2010 at 10:38:31PM +0100, Miklos Vajna wrote: > Does anyone have an idea when (and why) this changed, and what's the new > way of getting the OSL_TRACE() output? Oh, I guess this is related to David's recent 47d0946 in bootstrap.git. The attached patch fixes the problem for me -

Re: [Libreoffice] [Pushed] RTL_CONSTASCII_USTRINGPARAM for libs-core/svx

2010-11-22 Thread Julien Nabet
Hello, Perhaps a simple table in the wiki to assign oneself a task which is available and its planned deadline could be useful. Julien. Le 22/11/2010 21:59, Joost Eekhoorn a écrit : Hi, I did send my patch to the list and Julien did send his patch just after that. It was pushed this mornin

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-22 Thread Joost Eekhoorn
I did make clean make The make clean removed the the complete build/libreoffice-3.2.99.2 directory. It is now building 2 hours and I will see tomorrow-morning what the result is. Tomorrow-evening (after my work and helping my son with mail-delivering) I will report if it works. Joost 2010/11/22

[Libreoffice] OSL_DEBUG_LEVEL question

2010-11-22 Thread Miklos Vajna
Hi, During the summer I used OSL_TRACE() a lot, that basically acted like printf(), when I used 'build debug=t' and it was a noop when I used 'build'[1]. Recently I wanted to hack something and OSL_TRACE() turned out to be a noop even when build debug=t was used. I digged a bit deeper to check wh

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

2010-11-22 Thread Michael Meeks
Hi Pierre, On Mon, 2010-11-22 at 21:06 +0100, Pierre-André Jacquod wrote: > Okay, but at compile time, there is really a flow of warning. So I > wanted also to work a bit on it. That's just cleaning, not really > improving. Sure sure :-) fair enough. > clone/filters/binfilter/bf_sc/s

Re: [Libreoffice] [Pushed] RTL_CONSTASCII_USTRINGPARAM for libs-core/svx

2010-11-22 Thread Joost Eekhoorn
Hi, I did send my patch to the list and Julien did send his patch just after that. It was pushed this morning by David. It surprises me that it does not happen oftener, because I see no coordination between the people working on RTL_CONSTASCII_USTRINGPARAM. Joost 2010/11/22 Michael Meeks > Hi

Re: [Libreoffice] [PATCH] Impress

2010-11-22 Thread Michael Meeks
Hi there, On Mon, 2010-11-22 at 07:11 -0800, Joseph Powers wrote: > Please disregard my Friday patch for Impress. :-) > Removing the Global High Contrast flag is going to require more work > then the simple remove HC icons project is going to allow. We hard > code too many UI items (text

[Libreoffice] [Pushed] More cleanup in calc

2010-11-22 Thread Michael Meeks
On Mon, 2010-11-22 at 20:18 +0200, Timo Heino wrote: > Removed more commented out code Pushed; thanks ! :-) Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffic

Re: [Libreoffice] [EasyHacks] cppcheck of entire code at http://libreoffice.boldandbusted.com/

2010-11-22 Thread Caolán McNamara
On Sun, 2010-11-21 at 19:38 -0800, some...@boldandbusted.com wrote: > Howdy. To help with EasyHack "cppcheck cleanliness", I've set up > automated reporting on http://libreoffice.boldandbusted.com/ . Here will > live a report generated from a complete scan of the entire LO codebase, > generated ev

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

2010-11-22 Thread Pierre-André Jacquod
Hi, >> - Unused parameters in some methods are triggering compilation >> warnings. Should I fix them by removing the parameter name ? > > Sounds reasonable. > > Really though - the binfilter is not the best place to focus cleanups > (though I appreciate it is fugly old code ;-) Most

Re: [Libreoffice] Discuss " Easy_Hacks: Remove Sheet From File" ?

2010-11-22 Thread Kohei Yoshida
On Mon, 2010-11-22 at 18:45 +, Joe Smith wrote: > > There should be some data from the Improvement Program on how often > this item is > used, no? Sure. But such data was not available to us mere mortals (or hackers as we might like to call ourselves). But hopefully Christoph can fill us i

Re: [Libreoffice] Discuss "Easy_Hacks: Remove Sheet From File"?

2010-11-22 Thread Joe Smith
Kohei Yoshida writes: > ... I'd really really like to see it implemented in > a less confusing fashion. > > The current implementation just re-uses the same dialog from the Insert > - Sheet... menu, with some default values filled. But you can still > switch back to "New Sheet" radio button whi

Re: [Libreoffice] [Pushed] further removing of dead code

2010-11-22 Thread Pierre-André Jacquod
Hi, thanks. Left it back, if someone would have needed to know something was there. regards On 11/22/2010 01:14 PM, Michael Meeks wrote: > Hi Pierre, > > On Sun, 2010-11-21 at 15:28 +0100, Pierre-André Jacquod wrote: >> here in components some other pieces to delete. Again some small parts >> in

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-22 Thread Pierre-André Jacquod
Hi, I know...but I had exactly this problem once, and the make clean did not solved the issue. At the end, I did this an evening, and all went well the next day. I would be interested to know if the make clean works for you. Thanks Pierre-André On 11/22/2010 10:48 AM, Michael Meeks wrote: > > On

[Libreoffice] More cleanup in calc

2010-11-22 Thread Timo Heino
Removed more commented out code From 508c82de834dc890a2b00702147a55c4603c4bb1 Mon Sep 17 00:00:00 2001 From: Timo Heino Date: Mon, 22 Nov 2010 20:14:43 +0200 Subject: [PATCH] More commented out code removed in calc Signed-off-by: Timo Heino --- .../controller/chartapiwrapper/AreaWrapper.cxx

Re: [Libreoffice] [LO 3.3.0b3] Enable experimental (unstable) features?

2010-11-22 Thread NoOp
On 11/22/2010 01:52 AM, Michael Meeks wrote: > Hi there, > > On Sun, 2010-11-21 at 20:43 -0800, NoOp wrote: >> No answers for this on the user list, so I'll ask here: > .. >> Tools|Options|LibreOffice|General: >> - Enable experimental (unstable) features >> >> Does anyone know what this enables?

Re: [Libreoffice] [PATCH] Impress

2010-11-22 Thread Wols Lists
On 22/11/10 15:11, Joseph Powers wrote: > Please disregard my Friday patch for Impress. > > Removing the Global High Contrast flag is going to require more work then the > simple remove HC icons project is going to allow. We hard code too many UI > items (text fonts, background color, border colo

Re: [Libreoffice] [PUSHED] Removed some commented out code

2010-11-22 Thread David Tardon
On Mon, Nov 22, 2010 at 06:52:47PM +0200, Timo Heino wrote: > Check attachment and comments please. (so i know can i search more these) Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailma

Re: [Libreoffice] Discuss "Easy_Hacks: Remove Sheet From File"?

2010-11-22 Thread Kohei Yoshida
On Mon, 2010-11-22 at 10:45 +, Michael Meeks wrote: > Hi Joe, > > On Sat, 2010-11-20 at 03:53 +, Joe Smith wrote: > > Is this the place to discuss this proposal? I don't see any discussion on > > the > > wiki page itself. > > Yes - sounds reasonable. > > > I, for one, find Insert

Re: [Libreoffice] [PUSHED] Clean code at writer [source/filter/{rtf, writer, ww1}]

2010-11-22 Thread David Tardon
On Sun, Nov 21, 2010 at 09:21:37AM -0800, Kayo Hamid wrote: > One more patch to clean dead code covering files at [source/filter/]. And > have these two here in the waiting list for review: > - http://lists.freedesktop.org/archives/libreoffice/2010-November/002994.html- http://lists.freedesktop.or

Re: [Libreoffice] [PUSHED] Re: [PATCH] Clean code at writer [source/filter/{ascii, basflt, html}]

2010-11-22 Thread Kayo Hamid
Thanks for your review, I'll take into account in the next patch. revol_ I kept stuff like // 0.01mm = 0.57twip as that's a useful comment IMO and I kept stuff like void SwHTMLParser::EndNumBulListItem( int nToken, sal_Bool bSetColl, -                                      sal_Bool /*bLastPara

Re: [Libreoffice] Discuss "Easy_Hacks: Remove Sheet From File"?

2010-11-22 Thread Joe Smith
Michael Meeks writes: > Hmm; Kohei - did you add this one ? Christoph - do you have a thought > or two ? Kohei added this one, if I read the wiki page history right. > > If Calc had a clean way to import data from a text file, then I'd love to > > see > > this go, but right now, it woul

[Libreoffice] Removed some commented out code

2010-11-22 Thread Timo Heino
Check attachment and comments please. (so i know can i search more these) From 382e3715abb3f8ee718192f6974a50b862b2a1f0 Mon Sep 17 00:00:00 2001 From: Timo Heino Date: Mon, 22 Nov 2010 18:32:45 +0200 Subject: [PATCH] Removed commented out code Removed code that was commented out from some files i

Re: [Libreoffice] [PUSHED] some cleanup #if 0 deletion

2010-11-22 Thread Kohei Yoshida
On Sun, 2010-11-21 at 10:35 +0100, David Tardon wrote: > On Sat, Nov 20, 2010 at 11:20:34PM +0100, Pierre-André Jacquod wrote: > > Hello, > > was just tired to try reading code like: > > #if 0 > > read a lot here > > #else > > cool I will be compiled > > #endif > > > > So I started to trac

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-22 Thread Thorsten Behrens
Gioele Barabucci wrote: > PS: Isn't there a libreoffice-legal mailing list? > There's a le...@documentfoundation.org alias - but I think code licensing questions are very much on topic on *this here* list. Cheers, -- Thorsten pgpmEFPNNaOfI.pgp Description: PGP signature ___

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

2010-11-22 Thread Norbert Thiebaud
2010/11/22 Michael Meeks : > Hi Joachim, > > On Mon, 2010-11-22 at 13:59 +0100, Joachim Trémouroux wrote: >> I have fixed some compilation warnings in binfilter and some >> unnecessary comments. Patch is attached for review. > >        Hokay - the binfilter is of course un-loved and under-maintaine

Re: [Libreoffice] [PATCH] i18npool/ : minor memory leak

2010-11-22 Thread Caolán McNamara
On Mon, 2010-11-22 at 10:30 -0500, Kevin Hunter wrote: > Hullo List, > > Minor memory leak (but a leak nonetheless), found thanks to cppcheck and > Jesse's appreciated webpage. Emm, I'm unconvinced its a memory leak. Its given to maLookupTable and in lcl_LookupTableHelper::~lcl_LookupTableHelper

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-22 Thread Gioele Barabucci
Michael Meeks 22/11/2010 12:10: Well - as I say; there are problems with lots of scattered licenses. In particular, people can do this to get their personal name / credit into the LICENSES file, which then grows substantially, requires more maintenance, and gives extra credit to those who

[Libreoffice] [PATCH] i18npool/ : minor memory leak

2010-11-22 Thread Kevin Hunter
Hullo List, Minor memory leak (but a leak nonetheless), found thanks to cppcheck and Jesse's appreciated webpage. Kevin 0001-Fix-a-memory-leak.patch.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.

[Libreoffice] [PATCH] Impress

2010-11-22 Thread Joseph Powers
Please disregard my Friday patch for Impress. Removing the Global High Contrast flag is going to require more work then the simple remove HC icons project is going to allow. We hard code too many UI items (text fonts, background color, border color, ...) which have to be modified when in HC mod

Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

2010-11-22 Thread Michael Meeks
Hi Joachim, On Mon, 2010-11-22 at 13:59 +0100, Joachim Trémouroux wrote: > I have fixed some compilation warnings in binfilter and some > unnecessary comments. Patch is attached for review. Hokay - the binfilter is of course un-loved and under-maintained. > I have two questions: > - /*N

Re: [Libreoffice] ixion breakage in sw

2010-11-22 Thread Cedric Bosdonnat
On Tue, 2010-11-16 at 12:36 +0100, Miklos Vajna wrote: > On Tue, Nov 16, 2010 at 12:23:40PM +0100, Henrik /KaarPoSoft > wrote: > > It has been suggested to remove fields-table-formula.diff. > > However, in the "apply" file, it is listed under [Fixes] which is > > included in "Common", which is i

[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper

2010-11-22 Thread Caolán McNamara
On Sun, 2010-11-21 at 21:35 +0100, Julien Nabet wrote: > Hello, > > Here's a patch for libs-core/vbahelper > Julien. Reviewed the vbahelper patch, looks good. Pushed this, thanks for you efforts. btw, when you're sending these patches, you're including the content of previous patches in there as

[Libreoffice] 8th week development summary

2010-11-22 Thread Petr Mladek
Hi, this time a brief summary of what happened the 8th week on LibreOffice repos and two living branches: bugfixes-master-week-46.txt lists all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat b

[Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

2010-11-22 Thread Joachim Trémouroux
Hi, I have fixed some compilation warnings in binfilter and some unnecessary comments. Patch is attached for review. I have two questions: - /*N*/ . Should I fix them massively? I have currently left them unchanged to avoid a big cleanup patch. - Unused parameters in some methods are triggering

Re: [Libreoffice] quickstarter causes crash on end of desktop session

2010-11-22 Thread David Tardon
On Mon, Nov 22, 2010 at 11:45:16AM +, Michael Meeks wrote: > > On Mon, 2010-11-22 at 09:42 +, Caolán McNamara wrote: > > *I* think we should try and fix it in LibreOffice 3.3 seeing as we're > > flooded with these over in RH land. > > Agreed, if I never see the crash recovery dialog

[Libreoffice] [PUSHED, partial] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/sfx2

2010-11-22 Thread Caolán McNamara
On Sun, 2010-11-21 at 16:44 +0100, Julien Nabet wrote: > Hello, > > Here's a patch for libs-core/sfx2 Watch out here, see... sKey = ::rtl::OUString::createFromAscii(JOBCFG_ROOT); JOBCFG_ROOT is actually... static const sal_Char* JOBCFG_ROOT = "foo" so JOBCFG_ROOT is a pointer, not a string l

[Libreoffice] [Pushed] RTL_CONSTASCII_USTRINGPARAM for libs-core/svx

2010-11-22 Thread Michael Meeks
Hi there, On Sun, 2010-11-21 at 17:20 +0100, Julien Nabet wrote: > Here's a patch for libs-core/svx It seems someone merged it without replying 'Pushed' ;-) Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot _

[Libreoffice] [Pushed] RTL_CONSTASCII_USTRINGPARAM for libs-core/sfx2

2010-11-22 Thread Michael Meeks
Pushed - thanks :-) Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] C2U 61 time defined and with 2 differed meanings

2010-11-22 Thread Michael Meeks
Hi Joost, On Sun, 2010-11-21 at 16:36 +0100, Joost Eekhoorn wrote: > I like short naming, thus I find RTL_CONSTASCII_USTRINGPARAM far too > long. Me too - makes the code horribly ugly, and so on. I'd prefer: RTL_USTRP("foo") or somesuch; but Caolan is busy cleaning all t

[Libreoffice] [Pushed] further removing of dead code

2010-11-22 Thread Michael Meeks
Hi Pierre, On Sun, 2010-11-21 at 15:28 +0100, Pierre-André Jacquod wrote: > here in components some other pieces to delete. Again some small parts > in case I was to generous in deleting. Thanks ! :-) I pushed this; I also went back and cleaned up some related comments that were not remo

[Libreoffice] [Pushed] calc: some code deletion and comments translation

2010-11-22 Thread Michael Meeks
Hi Pierre, On Sun, 2010-11-21 at 12:13 +0100, Pierre-André Jacquod wrote: > have done as well some small comment translations. Thanks - pushed :-) Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot

Re: [Libreoffice] Use sal_Unicode or RTL_CONSTASCII_USTRINGPARAM for single unicode character?

2010-11-22 Thread Michael Meeks
Hi Joost, On Sun, 2010-11-21 at 10:59 +0100, Joost Eekhoorn wrote: > So if there is SAuthor += OUString::createFromAscii( " " ); > which is the correct replacement: > * sAuthor += > OUString( RTL_CONSTASCII_USTRINGPARAM(sal_Unicode( " " ); > * sAuthor += OUString( sal_Unicode(

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-22 Thread Michael Meeks
Hi there, On Mon, 2010-11-22 at 10:50 +0530, surensp...@gmail.com wrote: > Here are the few alternatives I can think of : > 1) register an event Listener to listen to any change of that > temporary file. And update the graphic in the call-back function of > that event listener. Remove the event li

[Libreoffice] [PUSHED] Re: [PATCH] binfilter/ : #if 0 removals

2010-11-22 Thread Caolán McNamara
On Sat, 2010-11-20 at 17:23 -0500, Kevin Hunter wrote: > Hullo List, > > Some #if 0 removals in binfilter. Looks good to me. Pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailma

Re: [Libreoffice] quickstarter causes crash on end of desktop session

2010-11-22 Thread Michael Meeks
On Mon, 2010-11-22 at 09:42 +, Caolán McNamara wrote: > *I* think we should try and fix it in LibreOffice 3.3 seeing as we're > flooded with these over in RH land. Agreed, if I never see the crash recovery dialog on re-start again, it will be too soon :-) I'm assuming that we should m

[Libreoffice] [PUSHED] Re: [PATCH] binfilter/ : remove dead code

2010-11-22 Thread Caolán McNamara
On Fri, 2010-11-19 at 19:14 -0500, Kevin Hunter wrote: > Hullo List, > > Removing some dead/non-compiled code in binfilter. Did some drive by > comment translation, and minor tab removals. Looks good, thanks for this. Pushed. C. ___ LibreOffice mail

[Libreoffice] [PUSHED] Re: [PATCH] Clean code at writer [source/filter/{ascii, basflt, html}]

2010-11-22 Thread Caolán McNamara
On Fri, 2010-11-19 at 12:09 -0800, Kayo Hamid wrote: > Sending for review. It covers source/filter/ dirs. > > I kept stuff like // 0.01mm = 0.57twip as that's a useful comment IMO and I kept stuff like void SwHTMLParser::EndNumBulListItem( int nToken, sal_Bool bSetColl, -

[Libreoffice] [PUSHED] Re: [PATCH] remove unused SvXMLNumFmtDefaults methods

2010-11-22 Thread Caolán McNamara
On Fri, 2010-11-19 at 19:28 +0100, Joachim Trémouroux wrote: > Hi Everybody, > > My first mail on this liste :-) > > I was grepping for some dead code using 'grep "#if 0"' and I have > found a bunch of unused method in xmloff package. Yup, agreed, unused code alright. Pushed this change now, th

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-22 Thread Michael Meeks
Hi there, On Mon, 2010-11-22 at 09:47 +0100, Gioele Barabucci wrote: > in bug #31633 I proposed a patch to one of the export filters. It looks > like my contribution has been positively received but I have been asked > to explicitly state that my contribution is licensed under the usual MPL > 1

Re: [Libreoffice] git via http ...

2010-11-22 Thread Michael Meeks
On Sat, 2010-11-20 at 00:20 +0100, Miklos Vajna wrote: > Hmm, I don't want to question you You should ! ;-) > but maybe that's not really necessary. Quite right; configure will 'guess' this from the build/ clone as you say - it is already there. Thanks; removed,

Re: [Libreoffice] crash report and Oracle url

2010-11-22 Thread Michael Meeks
On Fri, 2010-11-19 at 18:12 +, Andrew wrote: > Hmm, that crashed LibreOffice, and then when I started it again, the > Document Recovery Tool opened. At the last step, where it says 'Click > next to open the Error Reporting Tool', I clicked next, but the error > reporting tool didn't open and i

Re: [Libreoffice] Discuss "Easy_Hacks: Remove Sheet From File"?

2010-11-22 Thread Michael Meeks
Hi Joe, On Sat, 2010-11-20 at 03:53 +, Joe Smith wrote: > Is this the place to discuss this proposal? I don't see any discussion on the > wiki page itself. Yes - sounds reasonable. > I, for one, find Insert > Sheet From File a useful shortcut for importing data > from a text file, an

[Libreoffice] [PUSHED] Re: Clean code at writer, last patch.

2010-11-22 Thread Caolán McNamara
On Fri, 2010-11-19 at 09:21 -0800, Kayo Hamid wrote: > It covers source/core/{except, fields, frmedt, graphic, > objectpositioning, ole, para, sw3io}, sending for review. Looks basically good to me, removal of commented out code, etc. Pushed, thanks for this. C.

Re: [Libreoffice] LibreOffice Beta 3

2010-11-22 Thread Michael Meeks
Hi David, On Fri, 2010-11-19 at 18:54 -0500, David Burleigh wrote: > I am running LibreOffice Beta 3 under Ubuntu 10.10 (64-bit) and it seems > to gradually bog down with use, so that I have to exit and restart it > several times a day. It gets so that cursor movement is very slow. This > was also

Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-22 Thread Michael Meeks
Hi Mattias, On Sun, 2010-11-21 at 00:21 +1100, Mattias Johnsson wrote: > I've been trying to fix a bug in the search and replace code, and > after a bit of hacking have discovered that in findattr.cxx there's a > function Nice work :-) > If I'm understanding things correctly, and I may n

Re: [Libreoffice] Issues Wiki

2010-11-22 Thread Júlio Hoffimann
Thank you all, i'll see the links. It's my first time with Bugzilla too. Regards, Júlio. 2010/11/22 Tor Lillqvist > > A place where users can report bugs, > > That is bugs.freedesktop.org as has been mentioned. > > > talk about new features, etc > > This mailing list? For more "theoretical" or

Re: [Libreoffice] [LO 3.3.0b3] Enable experimental (unstable) features?

2010-11-22 Thread Michael Meeks
Hi there, On Sun, 2010-11-21 at 20:43 -0800, NoOp wrote: > No answers for this on the user list, so I'll ask here: .. > Tools|Options|LibreOffice|General: > - Enable experimental (unstable) features > > Does anyone know what this enables? Certainly ! :-) It enables in-line formu

Re: [Libreoffice] Patches to review in IssueZilla

2010-11-22 Thread Caolán McNamara
On Thu, 2010-11-18 at 08:57 +0100, Kálmán „KAMI” Szalai wrote: > Hi, > > I searched across OOo issues. Do we have interesting item to review > and/or integrate? > http://tools.openoffice.org/issues/buglist.cgi?issue_type=PATCH;issue_status=UNCONFIRMED;issue_status=NEW;issue_status=STARTED;issue_st

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-22 Thread Michael Meeks
On Mon, 2010-11-22 at 07:57 +0100, Pierre-André Jacquod wrote: > hello, > rm -rf * > ./download Oh - that is going to waste a -lot- of time ;-) Just remove the build output, not the ( pristine ) git repos. 'make clean' should do that in the top-level.

Re: [Libreoffice] quickstarter causes crash on end of desktop session

2010-11-22 Thread Caolán McNamara
On Mon, 2010-11-22 at 10:33 +0100, David Tardon wrote: > Hi all, > > we have been getting quite a lot of crashes from abrt (crash catching > and reporting tool) on Fedora that had been caused by XIOError. After > some investigation, we have found that they are caused by quickstarter > continuing t

[Libreoffice] quickstarter causes crash on end of desktop session

2010-11-22 Thread David Tardon
Hi all, we have been getting quite a lot of crashes from abrt (crash catching and reporting tool) on Fedora that had been caused by XIOError. After some investigation, we have found that they are caused by quickstarter continuing to run after end of desktop session (see https://bugzilla.redhat.com

Re: [Libreoffice] 5 times LGPL installed

2010-11-22 Thread Kálmán „KAMI” Szalai
Hi! Still trying to understand what scp2 does and how it decides where to put stuff. I'll investigate and do that at some point. Sebastian If you pont the problem, cgit link, I might can help. KAMI -- Szalai Kálmán Bes

Re: [Libreoffice] Issues Wiki

2010-11-22 Thread Tor Lillqvist
> A place where users can report bugs, That is bugs.freedesktop.org as has been mentioned. > talk about new features, etc This mailing list? For more "theoretical" or "political" discussion about product vision etc, perhaps the discuss list at the document foundation? --tml _

Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?

2010-11-22 Thread David Tardon
On Thu, Nov 18, 2010 at 01:01:42PM +0100, David Tardon wrote: > Hi all, > > currently, configuring with --enable-debug means that dbglevel is set to > 2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables > all the OSL_ debugging stuff there is (well, maybe there is some really >

Re: [Libreoffice] 5 times LGPL installed

2010-11-22 Thread Sebastian Spaeth
On Fri, 19 Nov 2010 15:45:08 +, Michael Meeks wrote: > Hi there, > > On Fri, 2010-11-19 at 13:53 +0100, Sebastian Spaeth wrote: > > - Module readlicense_oo needs to be modified to not produce them. Patch > > is in git (and reverted again). > > oh - shame - why reverted ? Because my b

Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?

2010-11-22 Thread David Tardon
On Thu, Nov 18, 2010 at 01:08:49PM +0100, Sebastian Spaeth wrote: > On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: > 1) > > one would just run build -- dbglevel=2 in the desired module similarly > > as one runs build -- debug=true today. > > 2) > > As an alternative, we could add optional

[Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-22 Thread Gioele Barabucci
Hello, in bug #31633 I proposed a patch to one of the export filters. It looks like my contribution has been positively received but I have been asked to explicitly state that my contribution is licensed under the usual MPL 1.1 / GPLv3 / LGPLv3 and to add the standard LibreOffice license heade

Re: [Libreoffice] git via http ...

2010-11-22 Thread Marc-Oliver Straub
I would appreciate this step... On 11/20/10 00:20, Miklos Vajna wrote: On Fri, Nov 19, 2010 at 05:34:34PM +, Michael Meeks wrote: not available. I added this as an easy hack: http://wiki.documentfoundation.org/Development/Easy_Hacks#Make_download_fall-back_to_http It would be won

Re: [Libreoffice] git via http ...

2010-11-22 Thread Marc-Oliver Straub
This works now, thanks! On 11/19/10 18:34, Michael Meeks wrote: Hi Marc, On Wed, 2010-11-03 at 10:16 +0100, Thorsten Behrens wrote: sorry, freedesktop git is only available via native git protocol - So - we now have a public http version (thanks to Tollef) - and it is here: g