Re: [Libreoffice] [PUSHED] Re: [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vector in sw.

2011-02-18 Thread David Tardon
On Thu, Feb 17, 2011 at 11:36:27PM +0100, Jan Holesovsky wrote: > The main thing that I changed was that in some cases you used > vector<...>::iterator it = another_iterator + 1; This is not correct, > operator+() is not defined on std::vector, so the result might be not > what you'd expect; simil

Re: [Libreoffice] It's not a dev topic, but please read it.

2011-02-18 Thread Cor Nouws
Hi revol, Thanks for posting, though the subject is not something that makes us happy of course. There have been some contacts in the Steering Committee on the subject - quite obviously. I have the hope - anyway that is the intention - that we find a way to handle the situation with most respe

[Libreoffice] [PUSHED] Re: German comments translated (for some files in writer-startmath-source)

2011-02-18 Thread Jan Holesovsky
Hi Tobias, tkr...@zedat.fu-berlin.de píše v Čt 17. 02. 2011 v 17:19 +0100: > some more translated German comments from files in > writer/startmath/source. Diffs in the attachment. Thank you very much, pushed! :-) I have just removed (instead of the translation) the completely unhelpful "hier fe

[Libreoffice] [PUSHED] Re: [PATCH] Initializes the runtime library paths on DragonFly

2011-02-18 Thread Jan Holesovsky
Hi Francois, Francois Tigeot píše v Čt 17. 02. 2011 v 18:29 +0100: > One small patch needed at runtime Thank you, pushed! :-) If you can send the further patches as the output of git format-patch HEAD~ (you have to commit locally first), that would be great - helps to apply & push quickly. T

Re: [Libreoffice] Is testing/testautomation really needed ?

2011-02-18 Thread Jan Holesovsky
Hi Francois, Francois Tigeot píše v Čt 17. 02. 2011 v 23:32 +0100: > Following the removal of files in testing/testautomation/framework/optional > I had a look in test/testautomation/ and the files there seemed largely > unused. Which exactly do you have in mind? > I have removed this directory

Re: [Libreoffice] EasyHack: Improved bug filing form / flow

2011-02-18 Thread Jan Holesovsky
Hi Daniel, Daniel Neel píše v Čt 17. 02. 2011 v 22:33 -0500: > Hello all. I've been working on the EasyHack "Improved bug filing > form / > flow" > (http://wiki.documentfoundation.org/Development/Easy_Hacks#Improved_bug_filing_form_.2F_flow) > and have finished the part that asks questions abou

Re: [Libreoffice] [PUSHED] Re: [PATCH] Initializes the runtime library paths on DragonFly

2011-02-18 Thread Francois Tigeot
Hi Jan, On Fri, Feb 18, 2011 at 09:30:06AM +0100, Jan Holesovsky wrote: > Francois Tigeot píše v Čt 17. 02. 2011 v 18:29 +0100: > > > One small patch needed at runtime > > Thank you, pushed! :-) Thanks :-) > If you can send the further patches as the output of > git format-patch HEAD~ > (you

Re: [Libreoffice] Is testing/testautomation really needed ?

2011-02-18 Thread Francois Tigeot
On Fri, Feb 18, 2011 at 09:38:59AM +0100, Jan Holesovsky wrote: > Hi Francois, > > Francois Tigeot píše v Čt 17. 02. 2011 v 23:32 +0100: > > > Following the removal of files in testing/testautomation/framework/optional > > I had a look in test/testautomation/ and the files there seemed largely >

Re: [Libreoffice] [PATCH] javaldx /proc test in ooinstall

2011-02-18 Thread Francois Tigeot
On Thu, Feb 17, 2011 at 06:40:11PM +0100, Francois Tigeot wrote: > On Thu, Feb 17, 2011 at 05:25:06PM +, Michael Meeks wrote: > > > > Well; javaldx sets up the LD_LIBRARY_PATH for java to 'actually > > work' It also used to be the case that without /proc mounted it would crash > > and burn

[Libreoffice] [PUSHED] Re: Removed some commented code

2011-02-18 Thread Jan Holesovsky
Hi Danny, Danny Roberts píše v Pá 18. 02. 2011 v 06:43 +: > This is my first attempt at helping out in LibreOffice and I have > tried to remove code that was commented out as per one of the "Easy > hacks" suggestions. I haven't found the time to go through all the > code yet but I have attach

[Libreoffice] [PUSHED] Re: [PATCH] javaldx /proc test in ooinstall

2011-02-18 Thread Jan Holesovsky
Hi Francois, Francois Tigeot píše v Pá 18. 02. 2011 v 10:34 +0100: > > > The good news is that in 3.4 we will have a totally different component > > > registration mechanism, so - we can kill that check on master > > > pre-emptively (perhaps). > > Here's a patch to remove it. Great - pushed,

Re: [Libreoffice] [PUSHED] Re: Removed some commented code

2011-02-18 Thread Danny Roberts
>Great, thank you a lot, pushed! :-) I did not push few hunks (the ones >where there was a commented out of setting the debug mode). One was >more serious, it was in the solenv/bin/getcsym.awk - the # was part of >the regex. I thought I had rolled back my version of getcsym.awk after realising t

[Libreoffice] [PUSHED] Re: Re: [PATCH] Reworking build.pl: What to do with the "--html" and "--interactive" parameters

2011-02-18 Thread Jan Holesovsky
Hi Christian, Christian Lohmaier píše v Út 15. 02. 2011 v 16:01 +0100: > > BTW - calling 'cat' is a curious thing, can we change that to something > > more Perl? ;-) > > Well, not sure whether it is really preferable, but instead of > system("cat $log_file"); > > a perl-only way would be > > o

[Libreoffice] [PATCH] Remove SCO references in ure

2011-02-18 Thread Francois Tigeot
This patch gets rid of some remaining SCO tests. What's strange is that there were references in sal/osl/os2/ It seems the os2/ files are a straight copy of the unx/ files. Is it possible to merge them ? -- Francois Tigeot >From 2c3aad464aef23602c402c185d67ec8a33d244e8 Mon Sep 17 00:00:00 2001

Re: [Libreoffice] [REVIEW] Properly update column and row header selections. (fdo#34383)

2011-02-18 Thread Caolán McNamara
On Thu, 2011-02-17 at 22:59 -0500, Kohei Yoshida wrote: > I'd like to cherry-pick this commit > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=f3df9f8674d559d38b638396cd48c9eb8f0ecca6 > > into libreoffice-3-3 branch, and ... into libreoffice-3-3-1 branch as well. > > The fix is very l

[Libreoffice] [PATCH] Translate german comments

2011-02-18 Thread Martin Kepplinger
Translated german comments in /writer/sw/source/ui/app/appenv.cxx to english. This is my first patch to libreoffice. --- sw/source/ui/app/appenv.cxx | 41 - 1 files changed, 20 insertions(+), 21 deletions(-) diff --git a/sw/source/ui/app/appenv.cxx b/sw/

[Libreoffice] [PATCH] [writer/sw/source/ui/app] Translate german comments

2011-02-18 Thread Martin Kepplinger
Translated the german comments to english an fixed minor coding style issues in apphdl.cxx and applab.cxx --- sw/source/ui/app/apphdl.cxx | 34 +- sw/source/ui/app/applab.cxx | 43 +-- 2 files changed, 38 insertions(+), 39

[Libreoffice] Overwrite of patched Langpack installation applescript on Mac in 3.3.1 RC2

2011-02-18 Thread Alexander Thurgood
Hi, Just downloaded RC2 and associated French langpack. Someone has apparently overwritten in the source the change I suggested and Thorsten committed to the installation applescript which enables the installer to take the foreground focus even if other windows are open. It would be handy if that

[Libreoffice] Old icons back on Mac ?

2011-02-18 Thread Alexander Thurgood
Hi, Is it just me, or have the new icons disappeared from the install sets and been reverted back to the old ones we had with 3.3.0 ? Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/li

Re: [Libreoffice] [PUSHED] Re: [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vector in sw.

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 09:11 +0100, David Tardon wrote: > On Thu, Feb 17, 2011 at 11:36:27PM +0100, Jan Holesovsky wrote: > > The main thing that I changed was that in some cases you used > > vector<...>::iterator it = another_iterator + 1; This is not correct, > > operator+() is not defined on std

Re: [Libreoffice] [REVIEW] Properly update column and row header selections. (fdo#34383)

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 10:40 +, Caolán McNamara wrote: > On Thu, 2011-02-17 at 22:59 -0500, Kohei Yoshida wrote: > > I'd like to cherry-pick this commit > > > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=f3df9f8674d559d38b638396cd48c9eb8f0ecca6 > > > > into libreoffice-3-3 branch,

Re: [Libreoffice] [PATCH] [PUSH] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 12:13 +0100, Martin Kepplinger wrote: > Translated german comments in /writer/sw/source/ui/app/appenv.cxx to english. Nice work. :-) Pushed to master. > This is my first patch to libreoffice. Welcome to our team! Looking forward to more patches from you in the future. :-)

Re: [Libreoffice] [PATCH] [PUSH] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 11:29 -0500, Kohei Yoshida wrote: > On Fri, 2011-02-18 at 12:13 +0100, Martin Kepplinger wrote: > > Translated german comments in /writer/sw/source/ui/app/appenv.cxx to > > english. > > Nice work. :-) Pushed to master. Actually, can you confirm that your patch is submitted

Re: [Libreoffice] [PATCH] [writer/sw/source/ui/app] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 13:16 +0100, Martin Kepplinger wrote: > Translated the german comments to english an fixed minor coding > style issues in apphdl.cxx and applab.cxx As with your other patch, please confirm that your patch is under LGPLv3 +/MPL dual license. Thanks! Kohei __

Re: [Libreoffice] [PATCH] [PUSH] Translate german comments

2011-02-18 Thread Martin Kepplinger
Am 2011-02-18 17:33, schrieb Kohei Yoshida: > On Fri, 2011-02-18 at 11:29 -0500, Kohei Yoshida wrote: >> On Fri, 2011-02-18 at 12:13 +0100, Martin Kepplinger wrote: >>> Translated german comments in /writer/sw/source/ui/app/appenv.cxx to >>> english. >> >> Nice work. :-) Pushed to master. > > Ac

Re: [Libreoffice] [PATCH] [writer/sw/source/ui/app] Translate german comments

2011-02-18 Thread Martin Kepplinger
Am 2011-02-18 17:34, schrieb Kohei Yoshida: > On Fri, 2011-02-18 at 13:16 +0100, Martin Kepplinger wrote: >> Translated the german comments to english an fixed minor coding >> style issues in apphdl.cxx and applab.cxx > > As with your other patch, please confirm that your patch is under LGPLv3 > +

Re: [Libreoffice] [PATCH] [PUSH] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 17:46 +0100, Martin Kepplinger wrote: > I confirm the submission under LGPLv3+/MPL. Thanks for the confirmation.! > Should I do that in every > patch? I can't say either or or on this. Mentioning this in each and every time will make it more explicit (and indeed some pa

Re: [Libreoffice] [PATCH] [PUSHED] [writer/sw/source/ui/app] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 17:48 +0100, Martin Kepplinger wrote: > Am 2011-02-18 17:34, schrieb Kohei Yoshida: > > On Fri, 2011-02-18 at 13:16 +0100, Martin Kepplinger wrote: > >> Translated the german comments to english an fixed minor coding > >> style issues in apphdl.cxx and applab.cxx > > > > As w

[Libreoffice] cppcheck report service updates

2011-02-18 Thread someone
Howdy *, So, if you browse to http://libreoffice.boldandbusted.com/ to see the cppcheck run, you'll notice a few things: * Less CSS. * Sortable columns! Odd problems: * You may notice some "blanks" in the source code links, like this: http://libreoffice.boldandbusted.com/680.html#line-462 . I be

Re: [Libreoffice] [REVIEW] Properly update column and row header selections. (fdo#34383)

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 11:01 -0500, Kohei Yoshida wrote: > Are their two more brave folks with sharp eyes who can take a quick look > and see if the change makes sense for the 3.3.1 branch as well? :-) OTOH, it's probably not a good idea to cherry-pick this to 3.3.1, since we are trying to push RC

[Libreoffice] [PATCH] Translation of German comment in libs-core/uui

2011-02-18 Thread Albert Thuswaldner
Hi, Found no German comments in this directory. I however took the opportunity to make a few fixes along the way. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert diff --git a/uui/source/fltdlg.cxx b/uui/source/fltdlg.cxx index 2cff694..b5cf78f 100644

Re: [Libreoffice] [PUSHED] Re: [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vector in sw.

2011-02-18 Thread Rafael Dominguez
On Thu, Feb 17, 2011 at 6:06 PM, Jan Holesovsky wrote: > Hi Rafael, > > Rafael Dominguez píše v Ne 13. 02. 2011 v 23:40 +: > > > Well the patch is related to sw, tab entries in Insert->Indexes and > > Tables -> Indexes and Tables. > > Wow - if I am not mistaken, this is your first LibreOffice

[Libreoffice] [PATCH] Cleaning include headers in calc, removing tool/list.hxx

2011-02-18 Thread Rafael Dominguez
The patch is under LGPLv3+MPL. 0001-Remove-deprecated-tools-list.hxx-include.calc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] How to setup an own tinderbox

2011-02-18 Thread Jan Holesovsky
Hi, If you want to make sure LibreOffice master builds on your favorite platform, setup a tinderbox! :-) I have just blogged about that: http://artax.karlin.mff.cuni.cz/~kendy/blog/archives/monthly/2011-02.html#2011-02-18T21_38_49.htm Should be pretty easy; in case of trouble, please let me kno

[Libreoffice] [PATCH][PUSHED 4/54] translated comments

2011-02-18 Thread Christina Roßmanith
Hi, pushed 5 more... Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove DECLARE_LIST(ImplSplitList)

2011-02-18 Thread Rafael Dominguez
Well it seems someone removed it before i did but they forgot to remove the class declaration, also they changed it for a dynamic array using new,memmove,etc, should i change it to standard containers or keep it like that??? Also removed some extra unnecessary comments Patch under the LGPLv3+/MPL

Re: [Libreoffice] [PATCH] Cleaning include headers in calc, removing tool/list.hxx

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 16:14 -0430, Rafael Dominguez wrote: > The patch is under LGPLv3+MPL. Looks good. Thanks for this. But it would be nice if you could set your correct name so that the commit record contains your real name. Right now the commit shows your identity as npcdoom To set your

Re: [Libreoffice] [PATCH] Cleaning include headers in calc, removing tool/list.hxx

2011-02-18 Thread Rafael Dominguez
Its ok i wanna keep it as npcdoom On Fri, Feb 18, 2011 at 4:28 PM, Kohei Yoshida wrote: > On Fri, 2011-02-18 at 16:14 -0430, Rafael Dominguez wrote: > > The patch is under LGPLv3+MPL. > > Looks good. Thanks for this. > > But it would be nice if you could set your correct name so that the > comm

Re: [Libreoffice] [PATCH] [PUSHED] Cleaning include headers in calc, removing tool/list.hxx

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 15:58 -0500, Kohei Yoshida wrote: > But it would be nice if you could set your correct name so that the > commit record contains your real name. Right now the commit shows your > identity as > > npcdoom For this commit I fixed the author name for you. This is pushed to

[Libreoffice] [PATCH] Update on btndlg in libs-gui

2011-02-18 Thread Rafael Dominguez
Joel made a patch to remove a DECLARE_LIST class, but i was working on the same thing, but i made it with ptr_vector instead. 0001-Update-mpItemList-from-std-vector-to-boost-ptr_vecto.patch Description: Binary data ___ LibreOffice mailing list LibreOffi

[Libreoffice] [PATCH] Removed commented code

2011-02-18 Thread Christina Roßmanith
Hi, I've removed some lines of commented code in libs-core/connectivity/source/drivers/file/ FResultSet.cxx FStatement.cxx fanalyzer.cxx fcomp.cxx For fcomp.cxx I'm not sure if line 82 "// inline OCursor..." might be removed as well. There were some calls of RTL_LOGFILE_CONTEXT_AUTHOR co

Re: [Libreoffice] It's not a dev topic, but please read it.

2011-02-18 Thread Arno Teigseth
On Fri, 2011-02-18 at 09:16 +0100, Cor Nouws wrote: > Hi revol, > > Thanks for posting, though the subject is not something that makes us > happy of course. > There have been some contacts in the Steering Committee on the subject - > quite obviously. I have the hope - anyway that is the intentio

[Libreoffice] Missing parts in Print dialog of Calc when translation is not complete

2011-02-18 Thread Andras Timar
Hi, Can you please check this bug: https://bugs.freedesktop.org/show_bug.cgi?id=33189 If it is not easy to fix, I'll work-around it for 3.3.2. OOo also has this bug, reported at http://www.openoffice.org/issues/show_bug.cgi?id=115999 (no sign of developer activity there). Thanks, Andras

Re: [Libreoffice] [PATCH] [PUSHED] Removed commented code

2011-02-18 Thread Kohei Yoshida
Hi Christina, On Fri, Feb 18, 2011 at 4:21 PM, Christina Roßmanith wrote: > Hi, > > I've removed some lines of commented code in > > libs-core/connectivity/source/drivers/file/ >  FResultSet.cxx >  FStatement.cxx >  fanalyzer.cxx >  fcomp.cxx Looks all good. Pushed. I had to change the format

Re: [Libreoffice] EasyHack: Improved bug filing form / flow

2011-02-18 Thread Daniel Neel
On Fri, Feb 18, 2011 at 2:11 AM, Jonathan Aquilina wrote: > Daniel just a suggestion if its not already available in the current > method. > > I am not sure if you have worked with launchpad the ubuntu bug tracker, but > with it you have the ability to assign a bug to a team or user. Is that > s

Re: [Libreoffice] EasyHack: Improved bug filing form / flow

2011-02-18 Thread Daniel Neel
Ok, a quick status update on this. Have been working on it some more - the current code is available at http://dneelyep.webs.com . Notes on the current progress below. Added the information on getting a Linux backtrace Added information that can pop up depending on which checkboxes a

[Libreoffice] DECLARE_LIST() Removal

2011-02-18 Thread Joseph Powers
Rafael, I believe we are almost done. The only ones I show as remaining are: binfilter/inc/bf_svtools/svdde.hxx DECLARE_LIST( DdeConnections, DdeConnection* ) windows binfilter/inc/bf_svtools/svdde.hxx DECLARE_LIST( DdeTransactions, DdeTransaction* )windows binfilter/inc/bf_s