[Libreoffice] [REVIEW] l10n related fixes for LibreOffice 3.3.2

2011-03-03 Thread Andras Timar
Hi, Please review and let me cherry-pick the following commits to libreoffice-3-3: Help: remove (disable) Online Update and Improvement program fdo#33468 http://cgit.freedesktop.org/libreoffice/help/commit/?id=695e40703c30101faf864ac1475e1226f9642709

[Libreoffice] [REVIEWED] Volatile function fix for 3.3.x

2011-03-03 Thread Michael Meeks
Hi Kohei, On Wed, 2011-03-02 at 23:52 -0500, Kohei Yoshida wrote: I'd like to backport another fix from master to libreoffice-3-3. The change is very simple, as attached patch shows. But that alone fixes https://bugs.freedesktop.org/show_bug.cgi?id=31939 .. which cancel out most of the

Re: [Libreoffice] Windows installer size reduction effort - the compression theory

2011-03-03 Thread Michael Meeks
Hi Kami, On Thu, 2011-03-03 at 00:14 +0100, Kálmán „KAMI” Szalai wrote: Compression time (in the tinderbox) was: runtime: 1087.37 (minutes) now: runtime: 1232.32 (minutes) So it takes another 2:30 or so extra ? sounds like quite a lot. Perhaps one thing you could do - would

Re: [Libreoffice] Cleaning make_installer.pl and related modules

2011-03-03 Thread Tor Lillqvist
Can we use modules from the standard Perl distribution What the standard distribution would that be? to handle things like filepaths or creating directory trees? What Perl versions does this need to run on? Cygwin provides Perl 5.10.1. Please don't require any Perl module not provided as a

Re: [Libreoffice] Revert some changing from last commit

2011-03-03 Thread Xisco Faulí
Well, I don't know what fails at that moment but i've built it again and everything is allright. The patch doesn't need to be applied. 2011/2/27 Xisco Faulí aniste...@gmail.com In a previous commit, OSL_ASSERT were changed into OSL_FAIL but 2 of them created the build fail.

Re: [Libreoffice] [PATCH] Comment cleanup writer

2011-03-03 Thread Christina Roßmanith
Hi David, I'm reviewing the patch. You should keep bugids like #i12345# (see the developers wiki - easy hacks - translation of German comments - there you find some details about bugids) and keep comments belonging to bugids. That is what I can tell so far... But nevertheless: Thank you for

Re: [Libreoffice] media export ...

2011-03-03 Thread Michael Meeks
On Wed, 2011-03-02 at 12:27 +0100, Thomas Arnhold wrote: Use Insert - Media and Sound - Select 'All files' as filter, so you are able to add flv videos, and all other formats the player is capable of (works on Linux). Sure sure - the problem is the PDF export piece :-) that just needs

Re: [Libreoffice] Tools - Media Player

2011-03-03 Thread Kálmán „KAMI” Szalai
As all other features too... ;o) KAMI 2011-03-01 20:01 keltezéssel, Thomas Arnhold írta: Hi Kami, it isn't gone. If someone really needs this he could add this through the customizing of the menu :) Thomas On 02/26/2011 03:19 AM, Kálmán „KAMI” Szalai wrote: Hi, But why we remove

[Libreoffice] [PUSHED] fdo#31251 - Improve default page layout

2011-03-03 Thread Michael Meeks
Hi Sebastien, On Tue, 2011-03-01 at 23:42 +0100, Sébastien Le Ray wrote: Here is a complete patch for fdo#31251. It adds a smooth shadow to the page. Wow - it is really pretty indeed :-) I just pushed it. Nice work ! can you confirm is it LGPLv3+/MPL ? Incidentally, it would

Re: [Libreoffice] [REVIEW] l10n related fixes for LibreOffice 3.3.2

2011-03-03 Thread Fridrich Strba
I went through them and they have my OK. Please, cherry-pick. I have all my builds currently running on master :( F. On Thu, 2011-03-03 at 10:18 +0100, Andras Timar wrote: Hi, Please review and let me cherry-pick the following commits to libreoffice-3-3: Help: remove (disable) Online

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Kohei Yoshida
On Thu, 2011-03-03 at 02:22 -0700, Tor Lillqvist wrote: for a cherry-pick candidate to libreoffice-3-3. It's a very simple safe fix, and fixes a crasher as reported in But do you know how those values can end up being negative in the first place, is that a symptom of something being

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Kevin Hunter
At 4:22am -0500 Thu, 03 Mar 2011, Tor Lillqvist wrote: for a cherry-pick candidate to libreoffice-3-3. It's a very simple safe fix, and fixes a crasher as reported in But do you know how those values can end up being negative in the first place, is that a symptom of something being horribly

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Kohei Yoshida
On Thu, 2011-03-03 at 09:42 -0500, Kevin Hunter wrote: At first glance, getTickDepth() and getMaxTickCount() read to me as requests for non-negative values (from an English/math sense). However, I note that the return values are sal_Int32 instead of sal_uInt32. One thing to note when

Re: [Libreoffice] [REVIEWED] Volatile function fix for 3.3.x

2011-03-03 Thread Kohei Yoshida
On Thu, 2011-03-03 at 09:24 +, Michael Meeks wrote: Hi Kohei, On Wed, 2011-03-02 at 23:52 -0500, Kohei Yoshida wrote: I'd like to backport another fix from master to libreoffice-3-3. The change is very simple, as attached patch shows. But that alone fixes

Re: [Libreoffice] [REVIEW] Backport to libreoffice-3-3

2011-03-03 Thread Thorsten Behrens
Kohei Yoshida wrote: I'd like to cherry-pick the following commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=63f695b8cf3572c2697abcfe99e2e7d5da923e9b to the libreoffice-3-3 branch. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=33756 Hi Kohei, um, bit hard to

[Libreoffice] [GSoc] Please add your ideas

2011-03-03 Thread Cedric Bosdonnat
Hi all, I finally created an independent page for the GSoc ideas to avoid the Easy_Hacks page to explode. Please add your ideas on: http://wiki.documentfoundation.org/Development/Gsoc/Ideas I already copied the ideas from last year GSoc, please review them if they are still meaningful. --

Re: [Libreoffice] [REVIEW][PUSHED] fix for fdo#34565

2011-03-03 Thread Petr Mladek
Michael Meeks píše v Út 01. 03. 2011 v 16:47 +: On Tue, 2011-03-01 at 16:21 +0100, Cedric Bosdonnat wrote: Could someone review this commit for inclusion in 3.3 branch? This patch is applied by quite some distros. Looks ok to me. Thanks for review. It looks fine to me as well =

Re: [Libreoffice] [REVIEW] Backport to libreoffice-3-3

2011-03-03 Thread Kohei Yoshida
On Thu, 2011-03-03 at 17:46 +0100, Thorsten Behrens wrote: Kohei Yoshida wrote: I'd like to cherry-pick the following commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=63f695b8cf3572c2697abcfe99e2e7d5da923e9b to the libreoffice-3-3 branch. This fixes

[Libreoffice] [PATCH] translated german comments in module fpicker

2011-03-03 Thread Michael Muench
Hi, translated german comments in libs-core/fpicker/. License is LGPLv3+/MPL. Regards, MichaelFrom 5d559f89cb20cc11bab14b44d95d9a2aa771c426 Mon Sep 17 00:00:00 2001 From: Michael Muench mich...@codingmicha.de Date: Thu, 3 Mar 2011 20:10:07 +0100 Subject: [PATCH] translated german comments in

[Libreoffice] Remove using namespace ::rtl

2011-03-03 Thread Julien Nabet
Hello, I finished the removing of using namespace ::rtl except in binfilters. (there were no compilation pb with my Linux env, hope it's the case with Windows and Mac envs). Even if binfilters is going to be extracted from LO, doesn't it worth to purge using namespace ::rtl from it (I think

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Nigel Hawkins
On Thu, 2011-03-03 at 10:32 -0500, Kohei Yoshida wrote: One thing to note when reading LibO's code (and also OOo's) is that, a lot of code that are written by the Oracle folks avoid using unsigned integers in favor of signed ones even though unsigned ones would make more sense logically. This

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Kohei Yoshida
On Thu, 2011-03-03 at 09:42 -0500, Kevin Hunter wrote: So, the reason for the negative value is in the following line 484: sal_Int32 nIntervalCount = static_castsal_Int32( fSub / m_rIncrement.Distance ); where fSub / m_rIncrement.Distance value (which is double divided by double) is still

Re: [Libreoffice] [PUSHED] fdo#31251 - Improve default page layout

2011-03-03 Thread Sébastien Le Ray
Le Thu, 03 Mar 2011 21:35:11 +0100, Christoph Noack christ...@dogmatux.com a écrit : Hi Sébastien, hi all! Hi Am Donnerstag, den 03.03.2011, 14:16 +0100 schrieb Sébastien Le Ray: Le Thu, 03 Mar 2011 11:59:19 +, Michael Meeks michael.me...@novell.com a écrit : [...] Although I