[Libreoffice] 3-4 build problem: sw module: ‘class SwDrawView’ has no member named ‘UpdateDrawLayersRegion’

2011-05-18 Thread KAMI911 KAMI911
Hi Developers, I got this error: ~/bootstrap/sw$ make [ build DEP ] LNK:Library/libswlx.so R=/home/libo64 && S=$R/bootstrap && O=$S/solver/340/unxlngx6.pro && W=$O/workdir && mkdir -p $W/Dep/LinkTarget/Library/ && RESPONSEFILE=/tmp/gbuild.er9013 && cat ${RESPONSEFILE} /dev/null | xargs -n 200 c

[Libreoffice] [ANN] Preview builds of 3.4 rc1 available

2011-05-18 Thread Thorsten Behrens
Hi *, for the rc1 candidate, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try & report *critical* bugs

[Libreoffice] [PATCH] Removal of deprecated options

2011-05-18 Thread Niko Rönkkö
Still to master and MPL 1.1 / GPLv3+ / LGPLv3+ >From f284735c1be452cf65a9f8b93fa535e00471aff2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= Date: Thu, 19 May 2011 00:28:04 +0300 Subject: [PATCH] Removal of deprecated options Removed all deprecated options of extensions from c

Re: [Libreoffice] REVIEW for fix#37211

2011-05-18 Thread Clio
18.05.2011 04:40, Noel Power пишет: In anycase this should be fixed at the latest in 3.4.1, if we get the right amount of reviewers it will appear in 3.4.0. With libreoffice-3.4.0.1 branch + Linux I tested this patch and it seems to be OK: Del key works fine and also i#50481# (A short cut Ct

Re: [Libreoffice] quota header in file_volume.cxx unneeded?

2011-05-18 Thread Michael Meeks
On Wed, 2011-05-18 at 21:07 +0200, Francois Tigeot wrote: > I've had a look at OpenGrok, and there is nothing in LibreOffice using > any quota stuff. Only some comments indicating there was once code using > returning some quota-related errors. :-) one day we'll get an archaeologist to te

Re: [Libreoffice] build breaks on i686

2011-05-18 Thread Michael Meeks
Hi David, On Wed, 2011-05-18 at 12:22 +0200, David Tardon wrote: > Caolan fixed similar build problem in Fedora some time ago. Does the > attached patch allow you finish the build? Urk - I guess we should have that in master and on the -3-4 branch too - at least the DLLPUBLIC piece of it

[Libreoffice] [PUSHED] Add config.guess to .gitignore

2011-05-18 Thread Michael Meeks
Hi Niko, On Wed, 2011-05-18 at 17:54 +0300, Niko Rönkkö wrote: > To origin/master and MPL 1.1 / GPLv3+ / LGPLv3+ of course. Thanks for that ! I just pushed it :-) What are you most interested in working on ? (apart from cleaning up our noise) :-) All the best, Mi

Re: [Libreoffice] [REVIEW] workaround for fdo#37325 toolkit.UnoScrollBarControl fails on 3.4.0.1 in headless mode

2011-05-18 Thread Michael Meeks
Hi Bjoern, On Wed, 2011-05-18 at 20:21 +0200, Bjoern Michaelsen wrote: > I am looking for reviews for this workaround: Looks fine to me for 3.4 and 3.4.0 - its not code we ship / execute I guess. > to get the patch on the 3.4 branch (only). This is a workaround to get > the test suite ru

[Libreoffice] [last REVIEW needed for] Fix for fdo#37226

2011-05-18 Thread Michael Meeks
On Wed, 2011-05-18 at 11:40 -0400, Kohei Yoshida wrote: > On Tue, 2011-05-17 at 12:04 -0400, Kohei Yoshida wrote: > > The attached patch fixes the crasher reported in the following bug: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=37226 > > And if possible. I'd like to have two more si

[Libreoffice] [one more REVIEW needed for] fix for fod#36552

2011-05-18 Thread Michael Meeks
On Wed, 2011-05-18 at 17:48 +0200, Cedric Bosdonnat wrote: > The patch looks good to me. Still two other reviews to get it in 3.4.0 Looks low risk crash-wise to me :-) one more needed ... ? ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itine

[Libreoffice] [PUSHED] fix for fdo#34997

2011-05-18 Thread Michael Meeks
On Wed, 2011-05-18 at 18:09 +0200, Cedric Bosdonnat wrote: > Could you review the attached patch (sign it off, and so on)? It fixes a > crash when reading some malformed ODT files. It would be great to have > that one in 3.4. Pushed to -3-4 and -3-4-0 (with the third review). Tha

Re: [Libreoffice] quota header in file_volume.cxx unneeded?

2011-05-18 Thread Francois Tigeot
Hi, On Wed, May 18, 2011 at 03:27:02PM +0200, Thomas Klausner wrote: > > When building git head on NetBSD, it fails due to the inclusion of > #include > in ure/sal/osl/unx/file_volume.cxx. (The header isn't standalone any > longer in NetBSD-current). > > Removing the header inclusion makes the

[Libreoffice] [REVIEW] workaround for fdo#37325 toolkit.UnoScrollBarControl fails on 3.4.0.1 in headless mode

2011-05-18 Thread Bjoern Michaelsen
Hi, I am looking for reviews for this workaround: https://bugs.freedesktop.org/attachment.cgi?id=46870 (also attached to this mail) for issue: https://bugs.freedesktop.org/show_bug.cgi?id=37325 to get the patch on the 3.4 branch (only). This is a workaround to get the test suite run without

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 35668, which changed state. Bug 35668 Summary: complex.unoxml.DOMTest testXDocumentBuilder() crashes LO https://bugs.freedesktop.org/show_bug.cgi?id=35668 What|Old Value |New Value --

Re: [Libreoffice] [REVIEW] fix for fdo#34997

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 18:09 +0200, Cedric Bosdonnat wrote: > Hi all, > > Could you review the attached patch (sign it off, and so on)? It fixes a > crash when reading some malformed ODT files. It would be great to have > that one in 3.4. Looks sane to me. You have my sign-off (though if the pop

Re: [Libreoffice] [REVIEW] fix for fdo#34997

2011-05-18 Thread Noel Power
Hi Cedric On 18/05/11 17:09, Cedric Bosdonnat wrote: Hi all, Could you review the attached patch (sign it off, and so on)? It fixes a crash when reading some malformed ODT files. It would be great to have that one in 3.4. looks fine to me, you got 1 signoff Noel ___

[Libreoffice] 3.4rc1: new segfault in build process

2011-05-18 Thread Andreas Radke
Something I haven't seen in 3.4beta5: R=/build/src && S=$R/build && O=$S/solver/340/unxlngx6.pro && W=$O/workdir && mkdir -p $W/Module/check/ && touch $W/Module/check/svl zip warning: help.jar not found or empty adding: com.sun.wiki-publisher/wiki.xhp (deflated 73%) adding: com.sun.w

[Libreoffice] [REVIEW] fix for fdo#34997

2011-05-18 Thread Cedric Bosdonnat
Hi all, Could you review the attached patch (sign it off, and so on)? It fixes a crash when reading some malformed ODT files. It would be great to have that one in 3.4. Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.b

Re: [Libreoffice] [REVIEW] fix for fod#36552

2011-05-18 Thread Noel Power
On 18/05/11 16:48, Cedric Bosdonnat wrote: Hi Noel, The patch looks good to me. Still two other reviews to get it in 3.4.0 thanks, pushed to the libreoffice3-4 branch, of course if I get 2 more acks I'll push it to the 3.4.0 branch Noel ___ LibreOff

Re: [Libreoffice] [REVIEW] fix for fod#36552

2011-05-18 Thread Cedric Bosdonnat
Hi Noel, The patch looks good to me. Still two other reviews to get it in 3.4.0 On Wed, 2011-05-18 at 16:27 +0100, Noel Power wrote: > Hi > I have a fix for https://bugs.freedesktop.org/show_bug.cgi?id=36552 > I'd like to get it into the 3.4 branch if > possiblehttp://cgit.freedesktop.org/libreof

Re: [Libreoffice] [REVIEW] Fix for fdo#36688, undisplayed borders in calc

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 12:10 +0200, Cedric Bosdonnat wrote: > Could you review, sign-off and push to the 3.4.0 branch (or 3.4 if more > appropriate)? Review is done and the fix looks good. Pushed to the -3-4 branch with my sign-off, and would really be nice to get this in for the 3.4.0 branch as

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Kohei Yoshida
On Tue, 2011-05-17 at 12:04 -0400, Kohei Yoshida wrote: > The attached patch fixes the crasher reported in the following bug: > > https://bugs.freedesktop.org/show_bug.cgi?id=37226 And if possible. I'd like to have two more sign-off's so that we can put this in for 3.4. It's a crasher bug, so

[Libreoffice] [REVIEW] fix for fod#36552

2011-05-18 Thread Noel Power
Hi I have a fix for https://bugs.freedesktop.org/show_bug.cgi?id=36552 I'd like to get it into the 3.4 branch if possiblehttp://cgit.freedesktop.org/libreoffice/writer/commit/?id=8f1fe65d4fab09515b0b67319fef67c88533b2e0 thanks, Noel ___ LibreOffice

Re: [Libreoffice] [REVIEW] [PUSHED] FMR on shutdown ...

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 11:18 -0400, Kohei Yoshida wrote: > Hi Michael, > > On Wed, 2011-05-18 at 06:23 +0100, Michael Meeks wrote: > > Fixes a potential crash on shutdown with gtk+ - prolly been there for > > years, would love to have the attached cherry-picked to the > > libreoffice-3-4 branch

Re: [Libreoffice] [REVIEW] FMR on shutdown ...

2011-05-18 Thread Kohei Yoshida
Hi Michael, On Wed, 2011-05-18 at 06:23 +0100, Michael Meeks wrote: > Fixes a potential crash on shutdown with gtk+ - prolly been there for > years, would love to have the attached cherry-picked to the > libreoffice-3-4 branch (but avoid 3.4.0). So, I reviewed it and the change looks sane t

[Libreoffice] environ not found

2011-05-18 Thread Thomas Klausner
Hi! Does this ring a bell for anyone? cp -f batch.bat ../../../unxbsdx3.pro/bin/batch.bat Making:libosl_process.so ../../../unxbsdx3.pro/slo/osl_process.o: In function `read_parent_environment(std::vector >*)': osl_process.cxx:(.text+0x416): undefined reference to `environ' osl_process.cxx:

Re: [Libreoffice] [PUSHED[ [REVIEW] Fix for fdo#37226

2011-05-18 Thread Noel Power
On 18/05/11 15:45, Kohei Yoshida wrote: I accidentally pushed mine to the -3-4 branch already when I signed off and pushed Rafael's patch (since it was already committed locally and pushing Rafael's also pushed mine with it).;-) So, let me just use that as my excuse for picking my version this t

Re: [Libreoffice] [PUSHED] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Noel Power
marking as pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Add config.guess to .gitignore

2011-05-18 Thread Niko Rönkkö
To origin/master and MPL 1.1 / GPLv3+ / LGPLv3+ of course. >From 98ab4a6a5089266257603171ac9f40e28f85cf23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= Date: Wed, 18 May 2011 17:35:08 +0300 Subject: [PATCH] Add config.guess to .gitignore Added pattern '/config.guess' to gitig

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 15:12 +0100, Noel Power wrote: > Anyway +1 from me regardless of which version of the patch ( really > referring the patch I attached as *mine* is rich ;-) I only omitted > some changes you did ) Thanks Noel. Incidentally, I accidentally pushed mine to the -3-4 branch al

[Libreoffice] [PUSHED] Re: [PATCH] Don't print === decoration when running g grep

2011-05-18 Thread Christian Dywan
Am Fri, 6 May 2011 12:35:04 + schrieb Christian Dywan: > git grep -l is useless when the == are there because it no longer is > a plain list of filenames. I needed it for sed, so I patched it. I modified the patch to account for the changes made meanwhile, same functional difference, and pus

[Libreoffice] [PUSHED] Re: [PATCH] Unify Display Grid/ Grid Visible and other menu items

2011-05-18 Thread Christian Dywan
Am Mon, 09 May 2011 14:24:01 +0200 schrieb Fridrich Strba: > I would like to integrate this patch. Is it the final version and are > all parties happy with it? > > F. Sorry for the delay, being at UDS and other things kept me from it. I have a commit account now and pushed the diff as individua

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Noel Power
Hi Kohei On 18/05/11 12:52, Kohei Yoshida wrote: On Wed, 2011-05-18 at 12:08 +0100, Noel Power wrote: [...] So, we (Rafael, Norbert, Joseph and I) talked about this last night on IRC, and one question raised was whether or not boost::bind allows pointers to data members rather than member funct

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 vitriol changed: What|Removed |Added Depends on||37317 --- Comment #110 from vitriol 2011-05-1

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37252, which changed state. Bug 37252 Summary: Crashing when using "Function Wizard" button https://bugs.freedesktop.org/show_bug.cgi?id=37252 What|Old Value |New Value --

Re: [Libreoffice] [REVIEW] [PUSHED] Crasher fix for fdo#37252

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 09:00 +0200, Katarina Machalkova wrote: > > Shoot. I didn't realize we already branched. Can I get two more > > sign-offs for the -3-4-0 branch too? > > +1 from me Thanks everyone. I just pushed this to the -3-4-0 branch as well. Kohei -- Kohei Yoshida, LibreOffice hac

[Libreoffice] quota header in file_volume.cxx unneeded?

2011-05-18 Thread Thomas Klausner
Hi! When building git head on NetBSD, it fails due to the inclusion of #include in ure/sal/osl/unx/file_volume.cxx. (The header isn't standalone any longer in NetBSD-current). Removing the header inclusion makes the problem go away and me wonder if this header is needed on any platform. Currentl

[Libreoffice] bison 2.5 breaks build process

2011-05-18 Thread Andreas Radke
Since bison 2.5 update I get this build break with 3.4rc1: In file included from /build/src/build/connectivity/source/parse/wrap_sqlbison.cxx:32:0: ../../unxlngx6.pro/misc/sqlbison.cxx: In function 'int SQLyyparse()': ../../unxlngx6.pro/misc/sqlbison.cxx:7814:9: error: invalid conversion from 'c

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 12:08 +0100, Noel Power wrote: > On 17/05/11 17:04, Kohei Yoshida wrote: > > Hi there, > > > > The attached patch fixes the crasher reported in the following bug: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=37226 > > > > and also several other usage of standard algori

Re: [Libreoffice] build breaks on i686

2011-05-18 Thread Andreas Radke
Am Wed, 18 May 2011 12:22:53 +0200 schrieb David Tardon : > > This happens only on i686, so I guess it's stlport related. this is > > the only difference to my x86_64 build that finishes to compile. > > > > gcc is 4.6. > > Caolan fixed similar build problem in Fedora some time ago. Does the > at

[Libreoffice] [PATCH] Re: UI Libre Office used 'PI'

2011-05-18 Thread Takeshi Abe
Hi Michael, *, On Tue, 17 May 2011 12:26:09 +0100, Michael Meeks wrote: > On Wed, 2011-05-11 at 08:31 -0700, ape wrote: >> UI Libre Office used 'pi'... The unit of measure 'pica' is the abbreviated >> name 'pi'. This is not compliant with CSS1 ('pica' = 'pc'). Why? > > No idea - where is

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Noel Power
On 17/05/11 17:04, Kohei Yoshida wrote: Hi there, The attached patch fixes the crasher reported in the following bug: https://bugs.freedesktop.org/show_bug.cgi?id=37226 and also several other usage of standard algorithms which I believe is incorrect, since the existing code passes the result o

Re: [Libreoffice] Build from master fails in tail_build on MacOSX - target rule absent in make file for dbcolect.hxx

2011-05-18 Thread Alexander Thurgood
Hi Thorsten, Le 18/05/11 12:12, Thorsten Behrens a écrit : > Hi Alex, > > that's to be expected, every once in a while, on master - if you > need a working build, I suggest the libreoffice-3-4 branch currently > - or have a go at fixing the build yourself. Another option is to > look at http://tin

Re: [Libreoffice] build breaks on i686

2011-05-18 Thread David Tardon
On Sun, Apr 24, 2011 at 02:43:44PM +0200, Andreas Radke wrote: > [ build LNK ] Library/vbaobj.uno.so > [ build CXX ] sw/source/ui/utlui/textcontrolcombo > [ build CXX ] sw/source/ui/utlui/tmplctrl > [ build CUT ] sc_ucalc > [ build CXX ] sw/source/ui/utlui/uiitems > `.L121' referenced in section >

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #109 from Petr Mladek 2011-05-18 03:16:44 PDT --- (In reply to comment #107) > Nominating Bug 37252 as blocker. Crashing when using "Function Wizard" button. > Regression and crash. Kohei provided the fix and we plan to use it for LO

Re: [Libreoffice] Build from master fails in tail_build on MacOSX - target rule absent in make file for dbcolect.hxx

2011-05-18 Thread Thorsten Behrens
Alexander Thurgood wrote: > Building from master today, I got this error, and build failed : > > make[1]: *** No rule to make target > `/Users/alex/DevHack/git/libo/clone/calc/sc/inc/dbcolect.hxx', needed by > `/Users/alex/DevHack/git/libo/solver/340/unxmacxi.pro/workdir/CxxObject/sc/source/core/d

Re: [Libreoffice] [PATCH] [PUSHED] resubmitted: Some more OSL_* love and debug.hxx removal in writer/sw

2011-05-18 Thread Jacek Wolszczak
Hi, Thanks for pushing the patches. If no one else plans to work on this easy hack and submitting patches to this list ok, then a bug is not needed. I will simply ask questions here regarding (possibly unused) functions and whether I should remove them or not. Jacek 2011/5/18 Kohei Yoshida >

[Libreoffice] [REVIEW] Fix for fdo#36688, undisplayed borders in calc

2011-05-18 Thread Cedric Bosdonnat
Hello all, Here is a fix for a regression (neither crash nor anything seriously damaging the program). It's just displaying some missing borders in calc. Could you review, sign-off and push to the 3.4.0 branch (or 3.4 if more appropriate)? Thanks, -- Cédric Bosdonnat LibreOffice hacker http://

[Libreoffice] Build from master fails in tail_build on MacOSX - target rule absent in make file for dbcolect.hxx

2011-05-18 Thread Alexander Thurgood
Hi FYI, Building from master today, I got this error, and build failed : make[1]: *** No rule to make target `/Users/alex/DevHack/git/libo/clone/calc/sc/inc/dbcolect.hxx', needed by `/Users/alex/DevHack/git/libo/solver/340/unxmacxi.pro/workdir/CxxObject/sc/source/core/data/attarray.o'. Stop. A

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #108 from sasha.libreoff...@gmail.com 2011-05-18 02:31:30 PDT --- One another iteresting regression if will confirmed: Writer corrupts tables when saving in doc format Bug 37309 - regression: when table in Writer saved in doc format, i

[Libreoffice] [PUSHED] Re: REVIEW for fix#37211

2011-05-18 Thread Jan Holesovsky
Hi Noel, On 2011-05-17 at 17:47 +0100, Noel Power wrote: > following patch fixes regressions reported in > https://bugs.freedesktop.org/show_bug.cgi?id=37211 & > https://bugs.freedesktop.org/show_bug.cgi?id=37170 > > https://bugs.freedesktop.org/attachment.cgi?id=46831 > > it would be great t

Re: [Libreoffice] [REVIEW] [PUSHED] Crasher fix for fdo#37252

2011-05-18 Thread Jan Holesovsky
Hi Tor, On 2011-05-18 at 00:50 -0600, Tor Lillqvist wrote: > Is there some rule the sign-off providers have to be from different > organisations? Nope, the rule about the different organizations is only for the late feature inclusion. Regards, Kendy ___

Re: [Libreoffice] REVIEW for fix#37211

2011-05-18 Thread Noel Power
On 17/05/11 20:13, Clio wrote: 17.05.2011 12:47, Noel Power пишет: ( not critical so no point pushing for the release branch I think ) If it is not fixed in 3.4.0, you can't Select All neither with the menu Select All from the menu has been broken forever, see http://openoffice.org/bugzilla/

Re: [Libreoffice] .doc and .docx support in master

2011-05-18 Thread Cedric Bosdonnat
Hi Jon, On Tue, 2011-05-17 at 18:19 +0200, Jonathan Aquilina wrote: > I am trying to test out the master branch, and im noticing a major issue > with the .docx as well as the .doc import filters. > > .docx im guessing is still not implemented, and if that is the case what > stage is it at befor

Re: [Libreoffice] [REVIEW] [PUSHED] Crasher fix for fdo#37252

2011-05-18 Thread Katarina Machalkova
> Shoot. I didn't realize we already branched. Can I get two more > sign-offs for the -3-4-0 branch too? +1 from me (provided that sign-off folks don't have to be from different organizations, as Tor says) B. ___ LibreOffice mailing list LibreOffic