Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-07-02 Thread Chr. Rossmanith
Hi, git add git commit --amend I hope this helps. Andras That's really easy - can't remember what went wrong the last time. Attached you find the patch cleaning httprequest.{ch}xx from ByteString, tools/string.hxx has been replaced by rtl/string.hxx. Could someone please review the complete

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-07-02 Thread Andras Timar
Hi, 2011/7/2 Chr. Rossmanith : > Hi, > > Caolan, thank you for your hints. Now I've finished httprequest.{hc}xx but > have two commits for one cleanup because I've committed the partial cleanup > some days ago. I know that "git amend" should be my friend in such a > situation but the last time it

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-07-02 Thread Chr. Rossmanith
Hi, Caolan, thank you for your hints. Now I've finished httprequest.{hc}xx but have two commits for one cleanup because I've committed the partial cleanup some days ago. I know that "git amend" should be my friend in such a situation but the last time it wasn't. If someone could describe in d

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37077, which changed state. Bug 37077 Summary: UI: Extremely annoying flickering problem in Writer https://bugs.freedesktop.org/show_bug.cgi?id=37077 What|Old Value |New Value ---

Re: [Libreoffice] [PATCH] Writer: Bug 36181 - EasyHack: Replace with "Notes" option doesn't work with text selected

2011-07-02 Thread Caolán McNamara
On Fri, 2011-07-01 at 01:08 +0200, Benoit Dolives wrote: > Hi, > > > Please find in attachment the patch for the bug 36181. initially looks good, unless someone else has a look before Monday I'll take this one for review then. Only open question I have, without reading the bug report or building

Re: [Libreoffice] rtl::O[U]StringBuffer now has a "remove" method

2011-07-02 Thread Caolán McNamara
On Fri, 2011-07-01 at 17:53 +0200, Lubos Lunak wrote: > On Thursday 30 of June 2011, Caolán McNamara wrote: > > Do we have a preference ?, I'm easy either way. > > Since nobody seems to have a preference, I'd like to point out that also > std::string uses start+len (even though there one could e

Re: [Libreoffice] Java screws el reg ...

2011-07-02 Thread Caolán McNamara
On Fri, 2011-07-01 at 15:30 +0100, Michael Meeks wrote: > Is this really so ? it'd be great to isolate and kill whatever Java is > required to save anything on Mac ? I'd have to be convinced that it is anything to do with Java, correlation rather than causation IMO. C. __

Re: [Libreoffice] Tinderbox failure, last success: 2011-07-01 22:08:22

2011-07-02 Thread Miklos Vajna
On Sat, Jul 02, 2011 at 02:09:57PM +0200, Miklos Vajna wrote: > On Fri, Jul 01, 2011 at 11:52:00PM +, "ke...@suse.cz" > wrote: > > /local/home/tinderbox/master/writerfilter/source/rtftok/rtfvalue.hxx:44: > > error: '>>' should be '> >' within a nested template argument list > > Interestin

Re: [Libreoffice] Tinderbox failure, last success: 2011-07-01 22:08:22

2011-07-02 Thread Miklos Vajna
On Fri, Jul 01, 2011 at 11:52:00PM +, "ke...@suse.cz" wrote: > /local/home/tinderbox/master/writerfilter/source/rtftok/rtfvalue.hxx:44: > error: '>>' should be '> >' within a nested template argument list Interesting, for some reason I do not get these errors at all with gcc-4.5.3 (tried 'ma

Re: [Libreoffice] Problem with make on fedora 15

2011-07-02 Thread Miklos Vajna
On Sat, Jul 02, 2011 at 01:16:09PM +0700, Ta Duc Tung wrote: > Thank you for replying soon. > Can you show me how to apply that patch? > > [1] > http://pkgs.fedoraproject.org/gitweb/?p=libreoffice.git;a=blob_plain;f=vbahelper.visibility.patch;hb=HEAD Try: patch -p0 < vbahelper.visibility.patch

Re: [Libreoffice] [PUSHED] patch for fdo#38561: can't save pw protected file without pw

2011-07-02 Thread Andras Timar
Hi Markus, 2011/6/27 Markus Mohrhard : > Hello Andras, > >> >> It's not clear to me why the functionality works in 3.3. Encryption >> data is not cleared there, too. >> > > I only had a closer look at the xls export and we didn't use the > EncryptionData in the export there, at least not to detect

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37825, which changed state. Bug 37825 Summary: An Opened Encrypted File can't be saved Unencrypted https://bugs.freedesktop.org/show_bug.cgi?id=37825 What|Old Value |New Value ---

Re: [Libreoffice] Java screws el reg ...

2011-07-02 Thread Tor Lillqvist
Aren't in fact these people reporting bugs in 3rd-party software like LO when using a pre-release version of Mac OS X (or just OS X, as it will be called from 10.7) breaking the terms of using such a pre-release version? At least for iOS and iOS SDK developer pre-releases, the NDA rules are quit

Re: [Libreoffice] Java screws el reg ...

2011-07-02 Thread Christian Lohmaier
Hi Michael, *, On Fri, Jul 1, 2011 at 4:30 PM, Michael Meeks wrote: > > http://www.theregister.co.uk/2011/07/01/mac_os_x_10_point_7_preview/page2.html 1st of all: This is about a not-yet-released version of Max OS X. >        hypothetical scenario, if you had just installed LibreOffice and >  

[Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2011-07-02 Thread Albert Thuswaldner
Hi Submitting a patch for review. This one enables the user to set the default tab prefix name in calc. The new option is located in Menu -> Tools -> Options -> LibreOffice Calc -> Defaults - I think this Is a useful feature for some at least, a few LO/OOo users i've talked to seem to agree. - it

[Libreoffice] issue building smoketestoo_native

2011-07-02 Thread Marco Draeger
Hello, when trying to build LibreOffice, I always fail in smoketestoo_native. The only errors I can find are the following (even with build verbose=t and debug=true): ERROR: The following files could not be found: ERROR: File not found: gdbtrace ERROR: File not found: librtftoklo.so Any ideas ho

Re: [Libreoffice] Java screws el reg ...

2011-07-02 Thread Jonathan Aquilina
If your gonna kill the java parts of LO for mac whats the advantage of keeping it for other os's. Without the java bits is it possible we can gain further performance improvements and over all size reduction? On 01/07/2011 16:30, Michael Meeks wrote: Hi guys, So: http://www.theregist