Re: [Libreoffice] [Pushed] [PATCH] Redundant condition at sc/source/filter/starcalc/scflt.cxx:1837 detected by cppcheck + comment translation

2012-01-22 Thread Muthu Subramanian K
Pushed it with slight modifications. Thank you so much for the patch! Looking forward for more... :) http://cgit.freedesktop.org/libreoffice/core/commit/?id=9042c4d0740c5b222b27d189e526b74fbd740b6f On 01/23/2012 03:32 AM, Mariusz Dykierek wrote: > Subject explains almost everything. > > > > >

Re: [Libreoffice] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Stephan Bergmann
On 01/22/2012 05:55 PM, Lionel Elie Mamane wrote: Hi, With respect to fdo#45090, that is the GNU/Linux dlopen() does not find libldap50.so when loading PostgreSQL-SDBC's postgresql-sdbc-impl.uno.so. "Naturally", libldap50.so is in $INSTALL_DIR/program/. Have we already solved this problem, and

Re: [Libreoffice] "make check" fails with lots of missing dictionaries

2012-01-22 Thread Noel Grandin
I had the same problem. Doing a make clean and then updating to HEAD fixed it for me, but can't say exactly why... On 2012-01-23 09:28, Chr. Rossmanith wrote: Hi, what can I do to make "make check" succeed? Currently it fails with: ... languages en-US ... ... analyzing files ... ERROR: The f

[Libreoffice] "make check" fails with lots of missing dictionaries

2012-01-22 Thread Chr. Rossmanith
Hi, what can I do to make "make check" succeed? Currently it fails with: ... languages en-US ... ... analyzing files ... ERROR: The following files could not be found: ERROR: File not found: dict-an.oxt ERROR: File not found: dict-ar.oxt ERROR: File not found: dict-be.oxt ERROR: File not found:

[Libreoffice] [PATCH] Same expression on both sides of || in if condition at libreoffice@lists.freedesktop.org (cppcheck)

2012-01-22 Thread Mariusz Dykierek
I guess this is what author intended. The other solution is to remove the copy. -- Mariusz Dykerek diff --git a/svtools/source/misc/filechangedchecker.cxx b/svtools/source/misc/filechangedchecker.cxx index 514841f..7a99f15 100644 --- a/svtools/source/misc/filechangedchecker.cxx +++ b/svtools/sou

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on||45084 --- Comment #122 from Cor Nouws 2012-

[Libreoffice] [PATCH] Redundant condition at sc/source/filter/starcalc/scflt.cxx:1837 detected by cppcheck + comment translation

2012-01-22 Thread Mariusz Dykierek
Subject explains almost everything. -- Mariusz Dykerek diff --git a/sc/source/filter/starcalc/scflt.cxx b/sc/source/filter/starcalc/scflt.cxx index 1d30ea2..2086bf5 100644 --- a/sc/source/filter/starcalc/scflt.cxx +++ b/sc/source/filter/starcalc/scflt.cxx @@ -1708,7 +1708,7 @@ void Sc10Import::L

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Lionel Elie Mamane
On Sun, Jan 22, 2012 at 10:03:24PM +0100, Fridrich Strba wrote: > I would guess that maybe there would be a way to generally ask the > extension manager to look for dependent libraries of the extensions in > other place then URE/lib only. LD_LIBRARY_PATH envvar? With GNU ld, it is the only one I

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45078, which changed state. Bug 45078 Summary: upper table border lost in .pdf export. Regression from 3.3.4 https://bugs.freedesktop.org/show_bug.cgi?id=45078 What|Old Value |New Value -

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 45078, which changed state. Bug 45078 Summary: upper table border lost in .pdf export. Regression from 3.3.4 https://bugs.freedesktop.org/show_bug.cgi?id=45078 What|Old Value |New Value -

[Libreoffice] [PATCH] A copy-paste bug detected by cppcheck at sdext/source/presenter/PresenterTimer.cxx:512

2012-01-22 Thread Mariusz Dykierek
Attached patch fixes a copy-paste error in the condition. Seconds used twice instead of Hours. -- Pozdrawiam, Mariusz Dykerek diff --git a/sdext/source/presenter/PresenterTimer.cxx b/sdext/source/presenter/PresenterTimer.cxx index 6c5f8d9..3757bd0 100644 --- a/sdext/source/presenter/PresenterTim

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Fridrich Strba
Lionel, I would guess that maybe there would be a way to generally ask the extension manager to look for dependent libraries of the extensions in other place then URE/lib only. Let us see what Stephan answers in the Windows bug. I guess that generic solution involving loading of shared objects fro

Re: [Libreoffice] [PUSHED] Fix RTF import of dotted and word underline

2012-01-22 Thread Miklos Vajna
Marking as pushed. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fdo#44983 Fix RTF import of \paperh and \paperw

2012-01-22 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=c39e891d4dc963d2cac9843b426494e4dc490278 Could somebody sign-off and push to -3-5, please? Thanks, Miklos ___

[Libreoffice] [REVIEW] fdo#44983 Fix RTF import of \paperh and \paperw

2012-01-22 Thread Miklos Vajna
- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Carlo Strata changed: What|Removed |Added Depends on||36742, 40289, 45078 --- Comment #121 from

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Carlo Strata changed: What|Removed |Added Depends on||36742, 40289, 45078 --- Comment #252 from

[Libreoffice] [REVIEW] 3-5 and 3-4, fdo#45032 Calc export to HTML

2012-01-22 Thread Eike Rathke
Hi, Please review and cherry-pick to 3.5.0 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=d180de79b82d1a73cfd914dd9a1524109c5e78ee Resolves https://bugs.freedesktop.org/show_bug.cgi?id=45032 Calc export to HTML with graphics failed Thanks Eike -- LibreOffice Calc developer.

[Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Lionel Elie Mamane
On Sun, Jan 22, 2012 at 05:55:07PM +0100, Lionel Elie Mamane wrote: > With respect to fdo#45090, that is the GNU/Linux dlopen() does not > find libldap50.so when loading PostgreSQL-SDBC's > postgresql-sdbc-impl.uno.so. > Now that I think of it, only the copy solution will make it work with > a Li

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on|45068 | --- Comment #120 from Rainer Bielefe

[Libreoffice] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Lionel Elie Mamane
Hi, With respect to fdo#45090, that is the GNU/Linux dlopen() does not find libldap50.so when loading PostgreSQL-SDBC's postgresql-sdbc-impl.uno.so. "Naturally", libldap50.so is in $INSTALL_DIR/program/. Have we already solved this problem, and if yes, how do I apply the solution to PostgreSQL-S

[Libreoffice] Windows porter for fdo#45058: postgresl-sdbc "no driver for URL"

2012-01-22 Thread Lionel Elie Mamane
Hi, Could a LibreOffice/Windows developer please take a look at https://bugs.freedesktop.org/show_bug.cgi?id=45058 ? I think I ruled out any missing / not found DLL problem (see bug log). I'm rather unfamiliar with Microsoft Windows, so I'm not sure what to do next as debugging step. Thanks. --

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45068, which changed state. Bug 45068 Summary: Update from 3.4 to 3.5rc1 is not working https://bugs.freedesktop.org/show_bug.cgi?id=45068 What|Old Value |New Value --

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44025, which changed state. Bug 44025 Summary: SEARCH does not go beyond prefetch window if row count is not final https://bugs.freedesktop.org/show_bug.cgi?id=44025 What|Old Value |New

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Volker Merschmann changed: What|Removed |Added Depends on||45068 --- Comment #119 from Volker M

[Libreoffice] Important details for easy woking on LibreOffice

2012-01-22 Thread Danylo Sa
Hello. People who used MS Office before has some complaints about LibreOffice: 1 - Insert number of pages is a pain in LibreOffice Writer. Why all this complication for a simple task? SOLUTION --> Why don't you include the old "pagination" extension in main release? 2 - Printing o

[Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-22 Thread Marcel Metz
Hello lo-devs, the attached patches replace some of the ENSURE_OR_* macros, with regular code. I can't see any advantage in these macros aside from save some typing. regards Marcel Metz >From 1d0aeb0f7266646da553ea7d120afcc9065118e5 Mon Sep 17 00:00:00 2001 Message-Id: <1d0aeb0f7266646da553ea7d12

Re: [Libreoffice] Compiling question by a complete beginner

2012-01-22 Thread Bruno Girin
On 21/01/12 20:49, Bar?s, Akkurt wrote: Hi, I'm a complete beginner in LibreOffice development and at the compiling step now. I tried instructions here: http://wiki.documentfoundation.org/Development/Native_Build But compilation failed while building the moz module. I tried instructions here:

libreoffice@lists.freedesktop.org

2012-01-22 Thread Mariusz Dykierek
Attached patch removes NfCurrencyEntry::ApplyVariableInformation(NfCurrencyEntry const&) as listed in unusedcode.easy. -- Mariusz Dykerek diff --git a/svl/inc/svl/zforlist.hxx b/svl/inc/svl/zforlist.hxx index aa68fc1..ac387d4 100644 --- a/svl/inc/svl/zforlist.hxx +++ b/svl/inc/svl/zforlist.hxx

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

2012-01-22 Thread Stefan Knorr (Astron)
Hi Tim, finally got around to compiling with your patch in and testing the whole thing a bit and think I like the experience. Although, I would still love if you could make sure that we in all cases reach exactly 25% zoom at some point (not just 24 and 26). Thanks for your work. Astron. _

[Libreoffice] [PATCH] Removed LineListBox methods listed in unusedcode.easy

2012-01-22 Thread Mariusz Dykierek
Hi, Attached patch removes: - LineListBox::GetEntryLine1 - LineListBox::GetEntryLine2 - LineListBox::GetEntryDistance - LineListBox::GetSelectEntryLine1 - LineListBox::GetSelectEntryLine2 - LineListBox::GetSelectEntryDistance and corresponding entries in unusedcode.easy. -- Pozdrawiam, Mar

[Libreoffice] [PATCH] EasyHack: remove obsolete BOOTSTRAP defines

2012-01-22 Thread Thomas Collerton
Hello, this patch addresses the EasyHack described at https://bugs.freedesktop.org/show_bug.cgi?id=44988. This and all my future contributions are licensed under the LGPLv3 / MPL 1.1 or later versions. Cheers, Thomas From ad48bdadaa058ae8ca81f855002f88d5bf07bdb0 Mon Sep 17 00:00:00 2001 From: Thoma

[Libreoffice] [REVIEW 3-5] fdo#43705: fix incomplete updating of the page preview pane in Draw

2012-01-22 Thread Ivan Timofeev
Hi, https://bugs.freedesktop.org/show_bug.cgi?id=43705 (regression since 3.4) The fix for review: http://cgit.freedesktop.org/libreoffice/core/commit/?id=799f2de5d1085d845ec498af0a7932965c42ed68 Thanks, Ivan ___ LibreOffice mailing list LibreOffice@li

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Tommy
On Sun, 22 Jan 2012 11:58:38 +0100, Tommy wrote: the 3.4.x is already mature after 5 micro-releases and 3.5.x is imminent. and 3.3.x is old ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Tommy
On Sun, 22 Jan 2012 10:47:39 +0100, Luc Castermans wrote: indeed: 3.5 is the unstable one 3.4.5 is the last stable one everything before is just "old" cheers Luc I agree with Luc. IMHO there no valid reason to leave the 3.3.4 download in the download page: http://www.libreoffice.org/d

[Libreoffice] [PATCH] Removed nonexistent items from unusedcode.easy

2012-01-22 Thread Mariusz Dykierek
Hi, Attached patch removes from "unusedcode.easy" a number of methods that cannot be found in the sources within the "core" directory. Can someone more experienced than I am confirm that items: - CIcc*::* - boost::gregorian::* are really supposed to be enumerated in the "unusedcode.easy"? --

Re: [Libreoffice] validation documents for writer

2012-01-22 Thread Noel Grandin
I thought someone was running a test-bot that downloaded all of the documents from bugzilla and loaded them? Maybe the best place is just to attach them to the relevant bug entries in bugzilla? On Sun, Jan 22, 2012 at 12:12, Luc Castermans wrote: > Hi, > > Below documents could be used in the te

[Libreoffice] validation documents for writer

2012-01-22 Thread Luc Castermans
Hi, Below documents could be used in the test-suite for writer: The first one contains a 2 column layout, but shows 4 columns in 3.5rc1, and triggered a crash in earlier versions, incl. 3.3.4: http://members.ziggo.nl/enouwens/permanente%20dingen/odt-docx/kubus.docx The odt version, triggere

[Libreoffice] note about untouched 37361 issues

2012-01-22 Thread Cor Nouws
Hi, I see that both fdo#43480 and fdo#43869 are still untouched. -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Luc Castermans
Op 22-01-12 10:30, Cor Nouws schreef: Luc Castermans wrote (21-01-12 14:40) 2012/1/20 Cor Nouws: 3.4.3 and up are as stable as 3.3.4 and have many advantages. I think you miss my point. Hmm, I'm not sure I missed it. I just would not call 3.4.3 (and up) unstable. indeed: 3.5 is the u

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Cor Nouws
Luc Castermans wrote (21-01-12 14:40) 2012/1/20 Cor Nouws: 3.4.3 and up are as stable as 3.3.4 and have many advantages. I think you miss my point. Hmm, I'm not sure I missed it. I just would not call 3.4.3 (and up) unstable. I agree with our mutual attempt to make a better download ex