[PATCH] Remove unused code (2)

Hi, This contribution is licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Best Regards, Elton -- Elton Chung Administrator, Sponsor of http://mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email/ IM : el...@layerjet.com -

Several lines not executed in a function of MacabDatabaseMetaData.cxx

Hi, Cppcheck reports this : core/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx 1044unreachableCode style Statements following return, break, continue, goto or throw will never be executed. 1039 Reference< XResultSet > SAL_CALL MacabDatabaseMetaData::getVersionColumns( 104

[PATCH] Remove unused code (3)

Hi, This contribution is licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Best Regards, Elton -- Elton Chung Administrator, Sponsor of http://mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email/ IM : el...@layerjet.com --

Re: tail_build is a discouraging PITA

Hi Olivier, 05.02.2012 02:13, Olivier Hallot пишет: it is now 3 days I cannot build master because of tail_build. editeng/source/editeng/edtspell.cxx:508: #ifdef DBG_UTIL sal_Bool WrongList::DbgIsBuggy() const { ... } #endif remove the surrounding ifdef and then the linker should find thi

Re: Several lines not executed in a function of MacabDatabaseMetaData.cxx

On Sun, Feb 05, 2012 at 01:04:32AM -0800, julien2412 wrote: > Cppcheck reports this : > core/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx > 1044 unreachableCode style Statements following return, break, continue, > goto or throw will never be executed. > Here I hesitate to just

Re: Several lines not executed in a function of MacabDatabaseMetaData.cxx

On 05/02/2012 12:52, Lionel Elie Mamane wrote: On Sun, Feb 05, 2012 at 01:04:32AM -0800, julien2412 wrote: Cppcheck reports this : core/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx 1044unreachableCode style Statements following return, break, continue, goto or throw will ne

[PUSHED][PATCH] Remove unused code

Hi Elton, thanks for your patch; I tweaked it a bit and then pushed. Notes: 1. ScVbaWorksheet( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext ); is *not* unused, we can see it at least in sc/source/ui/vba/vbawork

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 42656, which changed state. Bug 42656 Summary: FILESAVE RTF: some images are not exported https://bugs.freedesktop.org/show_bug.cgi?id=42656 What|Old Value |New Value

[REVIEW] fdo#42656 fix RTF export of picture frame shape type

Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=32fa7e9208b2053d2ff7743b88b0c0edacb8a7e7 Could somebody sign-off and push to -3-5, please? Thanks, Miklos pgpQs4hknNu4i.pgp Description: PGP signature ___ LibreOffice mailing list Libre

[PUSHED][PATCH] Remove unused code (2)

Pushed, thanks; however I have returned ScSubTotalDescriptorBase::GetData(ScSubTotalParam&) const ScSubTotalDescriptorBase::PutData(ScSubTotalParam const&) back to the header, because these functions are is pure virtual, and the implementations in ScSubTotalDescriptorBase is unused, not the all

Re: [Libreoffice] Problems with mozilla build-tools on WindowsXP

Hi Mat. sorry for late reply. I was able to build with that option but Unfortunately I can not build on windows at the moment. I got error in someplace and have not solved until now. I will update that wiki when I can solve. ps Windows build is too slow so usually I build on Linux. (24/01/2012

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

On Fri, 3 Feb 2012, Stephan Bergmann wrote: The secret is that the LO installation sets available from are built with implicit --without-system-stdlibs, so they bring along ure/lib/libgcc_s.so.1 and ure/lib/libstdc++.so.6 (which the programs in the LO inst

Re: [PUSHED 3-5] fix various overlapped controls in the Options dialog

Hi Ivan, 2012/2/5 Ivan Timofeev : > Hi, > > There are some small UI fixes in 1535eed3d40d9741f3cdf68d32bc132e2a39f287 on > master: > Pushed, thanks. Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailm

[PATCH] Reduced duplicate code (simian) / l10ntools

Hi, there were three blocks of nearly identical code. I've moved them to a method ResData2Output(). Please review. Maybe the spelling of Semikolon should be changed while at it...and ByteString->rtl::OString... Christina >From e2fafab4ecc750377c93fb99c45b0d248e8bc448 Mon Sep 17 00:00:00 2001

[PUSHED][PATCH] Remove unused code (3)

pushed this one after all. SfxMedium::GetHdl() seems to be used for now (in tools/inc/tools/ref.hxx), maybe we can remove all of those macro definitions... I also removed 'using SfxControllerItem::GetCoreMetric;' statement from sfx2/inc/sfx2/unoctitm.hxx, and then the build has succeeded.

Re: tail_build is a discouraging PITA

05.02.2012 15:15, Ivan Timofeev пишет: remove the surrounding ifdef and then the linker should find this function. I committed this change. Don't know why I didn't commit it at that time. %-| By the way... 05.02.2012 02:13, Olivier Hallot пишет: All fail in tail_build, a module that takes ho

[PATCH] Remove unused System V oslSemaphore implementation

sal/osl/unx/semaphor.c contains two separate implementations of the osl*Semaphore synchronization functions: - a pthread one (used by default) - an alternative one based on System V semaphores The alternative System V implementation is only used if the macro OSL_USE_SYS_V_SEMAPHORE is defined, wh

PATCH build errors on Ubuntu 10.04

Dear LibreOffice developers, I've checked out the LibreOffice git repository and followed the build instructions. This revealed two problems: 1) Compile error in l10ntools/source/lngex.cxx (see below) 2) There is no build-dep on doxygen (ppa libreoffice), but LibreOffice won't build without i

Re: [PATCH] Reduced duplicate code (simian) / l10ntools

Hi Christina, 05.02.2012 20:26, Chr. Rossmanith пишет: there were three blocks of nearly identical code. Awful! Thanks for working on this task. I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... > bWriteNoSlash seems to b

Re: [PATCH] Reduced duplicate code (simian) / l10ntools

Hi, I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... > bWriteNoSlash seems to be always false I'll add this to the patch and wait until I get feed back wrt the test question (s. below) before I'll push. Yes. And ByteStri

Re: [PATCH] Reduced duplicate code (simian) / l10ntools

05.02.2012 23:37, Chr. Rossmanith пишет: I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... Oh, oh, oh! No, we must pass all the different values as paramerers to the function. Because it was if ( pEntry && pResData->bText

l10ntools: GetXrmFile() nearly equal to GetCfgFile()

Hi, simian detected 21 duplicate lines in the following files: l10ntools/source/xrmmerge.cxx l10ntools/source/cfgmerge.cxx But as far as I can see the methods GetXrmFile() and GetCfgFile() seem to be copy&pasted with minor modifications for ByteString removal and an additional exit(-13). It mi

Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

Am 05.02.2012 20:52, schrieb Ivan Timofeev: 05.02.2012 23:37, Chr. Rossmanith пишет: I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... Oh, oh, oh! No, we must pass all the different values as paramerers to the function. I'v

Re: tail_build is a discouraging PITA

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Ivan... I want to apologize for the rant on my original message, I should have turned my tongue 7 times in my mouth before. I missed ccache when I reformatted my partition some months ago.. Thank you very much inded Ivan, for fixing DBG and for c

Re: PATCH build errors on Ubuntu 10.04

On Sun, Feb 5, 2012 at 12:05 PM, Gert van Valkenhoef wrote: > Dear LibreOffice developers, > 2) There is no build-dep on doxygen (ppa libreoffice), but LibreOffice won't > build without it it will if you specify --without-doxygen but sure, it would be nice if the distribution's dep package would

How far can the LO file's contents be stretched?

The native file format of LO files is simply a ZIP archive with various types of files in it. I intend to do some gymnastics with the ZIP files and the XML in them, and I would like to know how far it can be stretched ;) In particular, I want to explode the archive into git tree, mangle its conten

[ANN] LibreOffice 3.5.0 RC3 available

Dear Community, The Document Foundation is happy to announce the third release candidate of LibreOffice 3.5.0. The upcoming 3.5 will be our third major release line, packed with many exciting new features. Please be aware that LibreOffice 3.5.0 RC3 is not ready for production use, you should conti

[ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

HI all, I have pushed a series of commit that completely remove set_soenv.in and the creation of Env.Host.sh/Env.Build.sh The following wiki page give some explanations: http://wiki.documentfoundation.org/Development/Build_in_3.6 in a nutshell: For 'user' Env.Host.sh is no more All the environ

Fix for a compile issue I was having in l10ntools (GCC 4.4.3, Ubuntu)

Hi, I had some trouble compiling LibO the other day, a syntax error. I found someone had had a similar problem in the list archvies, so I did a fix in the same way they did theirs. Cheers, Josh 0001-Single-line-bugfix-in-l10n-tools-to-fix-compile-on-G.patch Description: Binary data

[PATCH] Some more READMEs

Hi all, Here are some more READMEs for the modules. This covers mostly just URE stuff, copied from: http://wiki.documentfoundation.org/Development/Code_Overview It introduces a little bit of syntax (for linking to cgit and urls). Cheers, Josh 0001-Added-READMEs-for-modules-related-to-URE-with

Re: tail_build is a discouraging PITA

On Sun, 2012-02-05 at 19:14 -0200, Olivier Hallot wrote: > I missed ccache when I reformatted my partition some months ago.. Heh - glad it's sorted out. tail_build is actually a huge meta-module that aggregates a lot of other modules using gnumake - so we can speed up the build b

[PUSHED] Some more READMEs

Hi Josh, On Mon, 2012-02-06 at 13:25 +1030, Josh Heidenreich wrote: > Here are some more READMEs for the modules. Thanks for that :-) > This covers mostly just URE stuff, copied from: > http://wiki.documentfoundation.org/Development/Code_Overview Great. > It introduces a little

My contributions - licence

Hi All, So it's clear, I am willing to dual-license all of my past, present and future contributions to LibreOffice under the MPL/LGPLv3+. Cheers, Josh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/l

Re: [PUSHED] Some more READMEs

Hi, >        Nice work, pushed :-) Cool so I've regenerated the docs again: http://thejosh.info/libreoffice/module_readmes/ I guess this should go onto a cron - I'm waiting until cgit is back before setting this up. Cheers, Josh ___ LibreOffice mailin

Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

On 02/05/2012 04:28 PM, Dag Wieers wrote: On Fri, 3 Feb 2012, Stephan Bergmann wrote: Apart from that, Dag, the only safe solution, in principle, is to use a version of LO that is specificially built for the machine it is run on (i.e., use a LO installation provided by the respective distro).

RE: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button

Stefan Knorr (Astron) wrote (3 februari 2012 21:24) >Writer has two background colour functions, ... The >highlighter is already a split button, but "Background Colour" is not. >By the way, I've actually just discovered even more buttons that would >be eligible for the split-button treatment... >