Re: Weird MSVC compilation error

2012-02-11 Thread Tor Lillqvist
> but cygpath does not work when the directory does not exist, Ah... Thanks! --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

JDK 1.7 error in autogen.sh

2012-02-11 Thread LOH KOK HOE
Hi all, I have an i5 with 8GB ram PC running Fedora 16, it has OpenJDK 1.7 pre-installed in the box. When I am issuing the command: ./autogen.sh --with-num-cpus=2, I hit the following error: checking for java... /usr/bin/java checking the installed JDK... checked (JDK 1.7.0_b147-icedtea) checking

Re: basegfx::fround and friends seems needed in windows build

2012-02-11 Thread Korrawit Pruegsanusak
Hello Michael, all, On Thu, Feb 9, 2012 at 17:39, Michael Meeks wrote: > On Wed, 2012-02-08 at 21:36 +0100, Stephan Bergmann wrote: >> On 02/08/2012 09:30 PM, Caolán McNamara wrote: >> > So there are some alternatives options to hide something from >> > callcatcher. [...] write unit tests that ca

Re: OK to merge the fw? libraries in framework?

2012-02-11 Thread Christian Lohmaier
Hi *, On Fri, Feb 10, 2012 at 11:56 PM, Mathias Bauer wrote: > [...] > Windows 7 already takes 50% of the Windows market, IIRC. >From visitors of www.libreoffice.org (as gathered by piwik) 43% Windows 7 24% Windows XP 13% Linux 12% Mac OS 8% Others ciao Christian __

Adding Extension for Experimental Thai Spelling

2012-02-11 Thread Richard Wordingham
As I understand it, the lack of a usable Thai spell-checker for LibreOffice (unlike, say, a Khmer spell-checker) is due to the Thai break iterator. (I had expected Thai and Khmer to face similar problems, for neither has a visible word separator and syllable boundaries are often unclear in both.)

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-11 Thread julien2412
If it may help, here are the console messages : julien@julienPC:~/compile-libreoffice/libo/install/program$ ./soffice.bin --writer warn:configmgr:9670:1:/home/julien/compile-libreoffice/libo/configmgr/source/xcuparser.cxx:209: bad set node member in "file:///home/julien/compile-libreoffice/libo/so

Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-11 Thread julien2412
Hello, On master branch (not on 3.5 branch), each time I start a module Calc, Writer or Impress (I didn't test on others), when I begin to type something, it seems to freeze for some seconds (about 10 secs) then everything seems ok. So I runned valgrind by using this : valgrind --tool=memcheck --n

[PATCH] Remove unused methods from PDFI

2012-02-11 Thread kate goss
Made available under the MPL/LGPLv3+ From 4e1c72fa61e3e8d754ff3e47afe435286dcf467b Mon Sep 17 00:00:00 2001 From: Kate Goss Date: Sat, 11 Feb 2012 16:31:27 + Subject: [PATCH 1/3] Remove unused pdfi::DrawXmlEmitter::GetBreakIterator() --- sdext/source/pdfimport/tree/drawtreevisiting.cxx | 1

[PUSHED] Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

2012-02-11 Thread julien2412
Since Riccardo was ok with your version and since it removes 1 C-cast (still 9 to convert or remove according to cppcheck :-) ), I pushed it on master. Thank you to both of you. Julien. -- View this message in context: http://nabble.documentfoundation.org/PATCH-avoid-Possible-null-pointer-d

Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

2012-02-11 Thread Ivan Timofeev
On 11.02.2012 20:13, julien2412 wrote: What about the Riccardo's suggestion ? Oh, it is better then mine wrt cheating cppcheck :) But I hate the hacks like ((SpellCheckerDispatcher *) this)->... A type cast from const to non-const looks like a black magic to me. Regards, Ivan __

Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

2012-02-11 Thread Riccardo Magliocchetti
Hello, Il 11/02/2012 17:13, julien2412 ha scritto: Hi Ivan, So it would be this : diff --git a/linguistic/source/spelldsp.hxx b/linguistic/source/spelldsp.hxx index 9ae9cd4..e2186f9 100644 --- a/linguistic/source/spelldsp.hxx +++ b/linguistic/source/spelldsp.hxx @@ -73,7 +73,7 @@ class SpellChe

Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

2012-02-11 Thread julien2412
Hi Ivan, So it would be this : diff --git a/linguistic/source/spelldsp.hxx b/linguistic/source/spelldsp.hxx index 9ae9cd4..e2186f9 100644 --- a/linguistic/source/spelldsp.hxx +++ b/linguistic/source/spelldsp.hxx @@ -73,7 +73,7 @@ class SpellCheckerDispatcher : ::com::sun::star::linguistic

Re: OK to merge the fw? libraries in framework?

2012-02-11 Thread Matúš Kukan
On 9 February 2012 17:29, Matúš Kukan wrote: > On 9 February 2012 15:59, Tor Lillqvist wrote: >> How is the FOO_DLLIMPLEMENTATION thing handled? Don't we in the >> --enable-mergelibs case need to add into the Library_blah.mk file for >> each library that will be part of libmerged a -DFOO_DLLIMPLE

Re: Weird MSVC compilation error

2012-02-11 Thread Matúš Kukan
On 10 February 2012 13:57, Tor Lillqvist wrote: > Am I hallucinating or is there some weird randomness in the > Cygwin-based MSVC build nowadays? Just a moment ago I saw in > config_host.mk that ILIB didn't contain the ...solver\wntmsci12\lib > entry (which caused libxmlsec linking to fail). I sta

Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

2012-02-11 Thread Riccardo Magliocchetti
Hello, Il 11/02/2012 16:21, julien2412 ha scritto: Hello, Cppcheck reports this : [spelldsp.hxx:138]: (error) Possible null pointer dereference: pCache - otherwise it is redundant to check if pCache is null at line 136 Here are the lines : 134 inline linguistic::SpellCache& SpellCheckerD

Re: [PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

2012-02-11 Thread Ivan Timofeev
Hi Julien, On 11.02.2012 19:21, julien2412 wrote: Cppcheck reports this : [spelldsp.hxx:138]: (error) Possible null pointer dereference: pCache - otherwise it is redundant to check if pCache is null at line 136 Here are the lines : 134 inline linguistic::SpellCache& SpellCheckerDispatcher

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #180 from Greg Bell 2012-02-11 07:26:52 PST --- Can't install 3.5 because it says I must quit using another version of libre -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this

[PATCH] avoid Possible null pointer dereference in linguistic/source/spelldsp.hxx

2012-02-11 Thread julien2412
Hello, Cppcheck reports this : [spelldsp.hxx:138]: (error) Possible null pointer dereference: pCache - otherwise it is redundant to check if pCache is null at line 136 Here are the lines : 134 inline linguistic::SpellCache & SpellCheckerDispatcher::GetCache() const 135 { 136 if (!

Re: [PATCH] Remove unused code (5)

2012-02-11 Thread Ivan Timofeev
On 10.02.2012 18:24, Elton Chung wrote: This patch removes 5 unused methods. Pushed, thank you. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-5] Wrong mapping to log level from postgresql-sdbc.ini

2012-02-11 Thread Takeshi Abe
Hi all, Please review the commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4649fafa317f4717634d863d3f3edf1d0180fc1e for cherry-pick to 3-5 if appropriate. Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.o

[PUSHED] Re: Same expression on both sides of '|'

2012-02-11 Thread julien2412
I pushed the suggestion on master (commit 5972e4db625500261d924028189793c7d51b576e) Thank you Caolán ! Julien. -- View this message in context: http://nabble.documentfoundation.org/Same-expression-on-both-sides-of-tp3731097p3735031.html Sent from the Dev mailing list archive at Nabble.com. ___

partial build not show module name on error

2012-02-11 Thread Korrawit Pruegsanusak
Hello all, If a partial build results in an error, the error message doesn't contain the module name, eg, $ /opt/lo/bin/make l10ntools --- Oh dear - something failed during the build - sorry ! For more help with debuggin

[PATCH] glib needed only when enable_librsvg, gettext only when enable_librsvg or cross-compile

2012-02-11 Thread Korrawit Pruegsanusak
Hello all, I'm building on cygwin with --disable-librsvg, but it failed with > ERROR: The following files could not be found: > ERROR: File not found: giolo.dll > ERROR: File not found: gliblo.dll > ERROR: File not found: gmodulelo.dll > ERROR: File not found: gobjectlo.dll > ERROR: File not foun

Re: minutes of ESC call ...

2012-02-11 Thread Lionel Elie Mamane
On Thu, Feb 09, 2012 at 05:54:39PM +, Michael Meeks wrote: > + is it ok to assign bugs to team-leads still ? > + quite attached to a push workflow, new bugs > in the area end up in mailbox (Lionel) I don't have a strong opinion on whether this happens from

Re: [Libreoffice] Problem building the 3.5 branch on Windows, postgresql related.

2012-02-11 Thread Lionel Elie Mamane
On Thu, Jan 05, 2012 at 02:28:14AM -0500, Kohei Yoshida wrote: > I'm having trouble building the latest 3.5 branch on Windows. > First, the postgresql module failed to build due to it not finding > ldap.h from mozilla. I had mozilla entirely disabled (I always > had). That's a bug that is now fi

Re: Please remove obsolete files (?) in dev-www/bundles

2012-02-11 Thread Korrawit Pruegsanusak
Hello Thorsten, On Wed, Feb 8, 2012 at 20:10, Thorsten Behrens wrote: > They are for the 3.4 and possibly still helpful for initially > cloning that branch - I'm not particularly attached to them, but > would suggest to keep them around until 3.4 is closed for > maintenance? That's fine. :-) Be

[PATCH] Fix typos in comments (1)

2012-02-11 Thread Elton Chung
Hi, This patch fixes some typos in comments. Best Regards, Elton -- Elton Chung Administrator, Sponsor of http://mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com --

Re: config_host doesn't set $PATH

2012-02-11 Thread Korrawit Pruegsanusak
Hello Norbert, On Fri, Feb 10, 2012 at 23:20, Norbert Thiebaud wrote: > Fixed. Tested and it's fine now. Thanks for fixing :-) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesk

Re: opengrok not updated?

2012-02-11 Thread Korrawit Pruegsanusak
Hello Jan, On Fri, Feb 10, 2012 at 04:39, Jan Holesovsky wrote: > All should be fine after the next update run; please report back if not. IMHO It's working as it should now. Thanks :-) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing l

changes in profile path in release notes for 3.5

2012-02-11 Thread Jean-Baptiste Faure
Hi, On Linux (or Linux Gnome only ???) the profile directory for LO 3.5.0 has been move to ~/.config/libreoffice. This information should be clearly stated in the release notes for 3.5. Could somebody who knows exactly what has been modified, update the release notes? Best regards JBF -- Seuls d