UI question regarding SfxToolBoxControls

2012-02-20 Thread Winfried Donkers
I am working on fdo45671 which concerns the use of 'split buttons' for font/background/border colours, split button meaning that you can either choose from the colour palette or that you can use the used color. Presently, the last used colour is stored within the control (mLastColor) and in the

Re: [PATCH] [PUSHED] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-20 Thread David Tardon
On Mon, Feb 13, 2012 at 06:16:43PM +0100, Radek Doulik wrote: > On Mon, 2012-02-13 at 18:08 +0100, Lionel Elie Mamane wrote: > > On Mon, Feb 13, 2012 at 05:39:51PM +0100, Radek Doulik wrote: > > > > > looks OK to me. I have cherry-picked it from master, because the > > > attached patch didn't appl

RE: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Winfried Donkers
Jan Holesovsky wrote (20-02-12 18:04) > Nope, still 3 I am afraid :-( - after the feature freeze, before we even > needed 1 review for pushing to the libreoffice-3-5 branch, it was 3 > reviews for a feature or two that got in few days after the feature > freeze (I remember the SmartArt import).

[REVIEW] fix for fdo#46332, crash while opening xls file

2012-02-20 Thread Markus Mohrhard
Hey, this patch ([1]) fixes the crash while opening the test document. The file contains 5 empty categories while we assume that all categories are non empty which results in a crash in chart2/source/tools/ExplicitCategoriesProvider.cxx:364 This patch just skips all empty categories. I checked th

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Cor Nouws
Hi Kendy, Jan Holesovsky wrote (20-02-12 18:04) Nope, still 3 I am afraid :-( - after the feature freeze, before we even needed 1 review for pushing to the libreoffice-3-5 branch, it was 3 reviews for a feature or two that got in few days after the feature freeze (I remember the SmartArt import

[PATCH] Clean-up and translation of German comments in ScTabPageSortFields

2012-02-20 Thread Albert Thuswaldner
Hi, This is just a small clean-up patch of files that I'm currently working on. Regarding the translation effort I hope Christina is not working on these particular files: http://wiki.documentfoundation.org/Development/Easy_Hacks/Translation_Of_Comments I've put her in copy of this email. Haven

[PUSHED-3-5] Updated CREDITS.odt

2012-02-20 Thread Miklos Vajna
On Mon, Feb 20, 2012 at 10:41:32PM +0100, Andras Timar wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0699556c303d724c89b3e9873587c4e9e0d6fe99 > > Based on http://www.libreoffice.org/about-us/credits/ > Please cherry pick to 3-5. Done. _

[PUSHED] desktop: remove duplicated gb_Library_set_include call

2012-02-20 Thread Matúš Kukan
On 20 February 2012 18:26, Riccardo Magliocchetti wrote: > gb_Library_set_include is already called few lines above so no need to do it > again, i think :) Makes sense, pushed. Thanks a lot, Matúš ___ LibreOffice mailing list LibreOffice@lists.freedes

[PUSHED] headless: cleanup HEADLESS preprocessor definition

2012-02-20 Thread Matúš Kukan
Hi Riccardo, On 20 February 2012 18:43, Riccardo Magliocchetti wrote: > define HEADLESS globally as it is meant to be instead of sneaking into > module specific files. Thanks for this and your work. Pushed. Matúš ___ LibreOffice mailing list LibreOffi

[REVIEW-3-5] Updated CREDITS.odt

2012-02-20 Thread Andras Timar
Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=0699556c303d724c89b3e9873587c4e9e0d6fe99 Based on http://www.libreoffice.org/about-us/credits/ Please cherry pick to 3-5. Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesk

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-20 Thread Caolán McNamara
On Sun, 2012-02-19 at 18:49 +0100, Gert van Valkenhoef wrote: > Thanks again for the help. Attached a new series of patches (cumulative > with the previously sent ones and Caolan's), in which (I think) all the > Java invocations have been removed in favor of using the C++ components: Attached is

Re: LibreOffice 3.6.0alpha built on clang

2012-02-20 Thread julien2412
Hi Khoo, Here's the command line I use on LO root directory : ~/llvm/llvm/tools/clang/tools/scan-build/scan-build make 2>1 1>~/llvm/out/llvm.txt Hope it helps Regards, Julien. -- View this message in context: http://nabble.documentfoundation.org/LibreOffice-3-6-0alpha-built-on-clang-tp3758515

Re: [PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-20 Thread julien2412
On pc Debian x86-64, I've got this kind of errors : /home/julien/compile-libreoffice/libo/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx:51:23: error: ISO C++ forbids declaration of 'typeof' with no type [-fpermissive] /home/julien/compile-libreoffice/libo/connectivity/source/dr

Re: [Libreoffice-commits] .: "WaE: add missing sal and cppunit dependencies causing tinderbox failure"

2012-02-20 Thread Stephan Bergmann
On 02/20/2012 08:52 PM, Michael Meeks wrote: On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: WaE: add missing sal and cppunit dependencies causing tinderbox failure ... @@ -1,2 +1,2 @@ -oc officecfg :TRANSLATIONS:translations soltools solenv LIBXSLT:libxslt NULL +oc

Re: Is this bug solved in 3.4.6

2012-02-20 Thread julien2412
Precision : it's fdo#45912 https://bugs.freedesktop.org/show_bug.cgi?id=45912 Connecting to access database using libreoffice's driver: one record missing I don't know if it's resolved but it could be useful you attach a simple MsAccess file to the tracker. Julien. -- View this message in contex

Re: [Libreoffice-commits] .: "WaE: add missing sal and cppunit dependencies causing tinderbox failure"

2012-02-20 Thread Michael Meeks
On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: > > WaE: add missing sal and cppunit dependencies causing tinderbox failure ... > > @@ -1,2 +1,2 @@ > > -oc officecfg :TRANSLATIONS:translations soltools solenv > > LIBXSLT:libxslt NULL > > +oc officecfg :TRANSLATIONS:t

[PUSHED][3-4] fdo#39510 crash on closing document with footnotes

2012-02-20 Thread Miklos Vajna
On Mon, Feb 20, 2012 at 06:29:51PM +0100, Miklos Vajna wrote: > Pushed to libreoffice-3-5. It does not apply to -3-4 - care to backport > it? I take it back, it turns out it was whitespace only - pushed to libreoffice-3-4 as well. ___ LibreOffice mailin

Is this bug solved in 3.4.6

2012-02-20 Thread pirrimanson
Hi all, I would like to know if this bug http://do-the-right-things.blogspot.com.au/2012/02/faulty-libreoffice-base-ms-access.html is solved in 3.4.6 I have tried to figure it out by myself with no success. If it is solved, is it possible to download a nightly build of 3.4.6 from somewhere?

Re: [PATCH] fix building dictionaries when PERL_UNICODE environment

2012-02-20 Thread Tim Retout
Hi! On 18 February 2012 22:29, Petr Vorel wrote: > I run into troubles while building dictionaries, because I have on my system > set PERL_UNICODE=SDL (perl script > clone/dictionaries/dictionaries/util/th_check.pl dies as it's forced to use > UTF-8, but not all dictionaries are in this encoding)

R: I: Building LibreOffice on Windows

2012-02-20 Thread walter
But which cpu do you have ? I have a 4-core i7-870. Best, walter -Messaggio originale- Da: libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.org [mailto:libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.or g] Per conto di Noel Grandin Inviato: lunedì 20 f

Re: I: Building LibreOffice on Windows

2012-02-20 Thread Noel Grandin
Weird, I have a 6-core Windows machine compiling 12 things at once, no problem. On Mon, Feb 20, 2012 at 18:37, walter wrote: > > In fact, my problem is that i can't compile using 8 parallel sessions > because often cl.exe freezes. > > Best, > walter > > > -Messaggio originale- > Da: libre

[PATCH] headless: cleanup HEADLESS preprocessor definition

2012-02-20 Thread Riccardo Magliocchetti
Hello, define HEADLESS globally as it is meant to be instead of sneaking into module specific files. thanks, -- Riccardo Magliocchetti >From ab6904340fea291e3850f9f8fdedbd4c92a2a3b2 Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Mon, 20 Feb 2012 18:39:14 +0100 Subject: [PATCH] h

[PUSHED][3-5] fdo#39510 crash on closing document with footnotes

2012-02-20 Thread Miklos Vajna
Hi Michael, On Sat, Feb 18, 2012 at 12:25:15AM +0100, Michael Stahl wrote: > this was apparently not enough, as some of those pesky footnotes are > quite resistant and hide in unexpected section column frames... > this additional patch should exterminate the pests more thoroughly and > should be

[PATCH] desktop: remove duplicated gb_Library_set_include call

2012-02-20 Thread Riccardo Magliocchetti
Hello, gb_Library_set_include is already called few lines above so no need to do it again, i think :) thanks -- Riccardo Magliocchetti >From 70f6e5533b982da0f8dff2fd1399e4aaa1292afd Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Mon, 20 Feb 2012 11:38:15 +0100 Subject: [PATCH] d

Re: About fdo#46180 LO Base fails to connect to "*.DBF" files but connects OK to "*.dbf"

2012-02-20 Thread Lionel Elie Mamane
On Mon, Feb 20, 2012 at 07:24:04AM -0800, julien2412 wrote: > I think there are 2 different points : > 1) to list files in a directory with extension filter > 2) to open a file with or without extension > About 2), I agree with the fact we should look at the content and, > considering your commen

Re: comphelper dep of officecfg

2012-02-20 Thread Michael Stahl
On 20/02/12 17:50, Norbert Thiebaud wrote: > On Mon, Feb 20, 2012 at 10:20 AM, Stephan Bergmann > wrote: >> [including LO ML on cc, hope you don't mind; context for new readers: > no problem. > >> Does anybody have an idea how to solve this elegantly? >> >> One solution might be to undo the mech

[REVIEWED][3-5] misc fixes for -3-5

2012-02-20 Thread Michael Meeks
Hi Michael, On Sat, 2012-02-18 at 00:19 +0100, Michael Stahl wrote: > some misc commits, mostly crashes fixed while loading ~2000 presumed > ODT documents (looking at actual patches reveals expecting people to set > bug attachment mime types correctly is unrealistic), proposed for > libreoffice-3-

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-02-20 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 03:21:30PM +0100, Stephan Bergmann wrote: > changing the postgresql-sdbc functionality from a bundled extension > into a proper (optional) part of LO. > The attached > 0001-Changed-postgresql-sdbc-from-bundled-oxt-to-proper-o.patch > (against recent libreoffice-3-5) does j

R: cygwin 1.7.10 - LO-3-5 - the compiler error in npwin.cpp reappears [SOLVED]

2012-02-20 Thread walter
LibreOffice build succesfully finished. It took 3 hours on a non-dedicated machine. Best, walter Da: libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.org [mailto:libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.or g] Per conto di walter Inviato:

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Jan Holesovsky
Hi Cor, On 2012-02-20 at 17:44 +0100, Cor Nouws wrote: > > Anyhow - I don't see a special case for bending the rules of triple > > reviews, nor a reason to refuse it if it gets that widespread > > support :-) it's a nice fix. > > Thanks, that sounds encouraging. > As written: going for 3.5.2

Re: Minimum Perl version requirement (was: Re: [PUSHED] Replace make_absolute_path with rel2abs in solenv)

2012-02-20 Thread Tim Retout
On 20 February 2012 16:07, Michael Meeks wrote: >        I poked Fridrich, the oracle on this sort of thing - wrt. our old > build-systems. On windows we have perl 5.10 but on Linux 5.8.8 ( we have > an artificially old Linux machine to produce forward-compatible builds). There are some nice thin

License for my contributions

2012-02-20 Thread Khoo Wei Ming
All my contributions will be licensed under MPL/LGPLv3+. Wei Ming ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: comphelper dep of officecfg

2012-02-20 Thread Norbert Thiebaud
On Mon, Feb 20, 2012 at 10:20 AM, Stephan Bergmann wrote: > [including LO ML on cc, hope you don't mind; context for new readers: no problem. > Does anybody have an idea how to solve this elegantly? > > One solution might be to undo the mechanism by which a cxx only needed in > subsequentcheck is

[PATCH] fdo44611 writer paragraph background color picker with split button

2012-02-20 Thread Winfried Donkers
Attached patch addresses the first fix for fdo45671, the rest will follow one by one. This patch is a bit more elaborate than I expect the rest to be as I prepared the code for the patches to follow, i.e. for the split buttons that I will be adding. I have renamed class SvxFontColorExtToolBoxCo

[PUSHED] Clang-flagged error typedef for CardPropertyGetter/Setter in connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx

2012-02-20 Thread Michael Meeks
On Sat, 2012-02-18 at 09:41 +, Khoo Wei Ming wrote: > clang flags this as Nice research, E-mail & patch, pushed :-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffic

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Cor Nouws
Hi Michael, Michael Meeks wrote (20-02-12 17:13) On Mon, 2012-02-20 at 15:22 +0100, Cor Nouws wrote: Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: Can this patch be pushed to 3.4 and 3.5 branches as well? The patch addresses problem that go way back in time (pre-LibreOffice at least)

I: Building LibreOffice on Windows

2012-02-20 Thread walter
In fact, my problem is that i can't compile using 8 parallel sessions because often cl.exe freezes. Best, walter -Messaggio originale- Da: libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.org [mailto:libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.or g

Re: Building LibreOffice on Windows

2012-02-20 Thread Tor Lillqvist
> Not the last time I benchmarked it (which was long before > filter-showIncludes.pl). For the most part the slowness of forking on windows > was related to some latency, i.e. a new process would take some time to get > started, but it wouldnt eat cycles for that, thus making it irrelevant in a > p

[PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-20 Thread Michael Meeks
Hi there, On Sun, 2012-02-19 at 17:59 +, Khoo Wei Ming wrote: > A big kudos to Kristian Rietveld for his hard work described here > http://wiki.documentfoundation.org/Development/Building_LibreOffice_with_Clang Indeed :-) > So for what it's worth, here's the route I took (by no means

Re: Building LibreOffice on Windows

2012-02-20 Thread Bjoern Michaelsen
Hi, On Mon, Feb 20, 2012 at 05:42:11PM +0200, Tor Lillqvist wrote: > And the slowness of Cygwin's forking and executing the various Perl, > shell and whatnot processes involved in each file being compiled (note > the pipe to filter-showIncludes.pl) has nothing to do with it? Not the last time I

R: Building LibreOffice on Windows

2012-02-20 Thread walter
Yes, indeed, i have taken a huge blindness !! > In any case the problem remains that cl.exe is not able to use all the > cpu power. You said you see max 13% CPU usage by each cl.exe process on a four-core, hyperthreading machine (i.e. 8-processor from Windows's point of view)? What is 100 di

Re: [Libreoffice-commits] .: "WaE: add missing sal and cppunit dependencies causing tinderbox failure"

2012-02-20 Thread Stephan Bergmann
On 02/18/2012 04:29 PM, Michael Meeks wrote: officecfg/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8c67428341d42ada42f9186bbfe3d6f25a0edaef Author: Michael Meeks Date: Sat Feb 18 15:28:35 2012 + WaE: add missing sal and cppunit depend

Re: comphelper dep of officecfg

2012-02-20 Thread Stephan Bergmann
[including LO ML on cc, hope you don't mind; context for new readers: officecfg/CppunitTest_officecfg_cppheader_test.mk requires officecfg/qa/cppheader.cxx, which indirectly includes headers from higher up the module hierarchy; plain "make" build logs show that the cxx is needlessly compiled, c

Re: [PUSHED] Remove unused code (18)

2012-02-20 Thread Elton Chung
Hi Michael, *, >        Thanks for that ! :-) are you tempted by any of the Easy Hacks ? I will try them (and ask for some help) when I am more familiar with the code base. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS P

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Michael Meeks
Hi Cor, On Mon, 2012-02-20 at 15:22 +0100, Cor Nouws wrote: > > Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: > >> Can this patch be pushed to 3.4 and 3.5 branches as well? > >> The patch addresses problem that go way back in time (pre-LibreOffice at > >> least). :-) it is some

Re: Disappearing graphics in Write: where to look (bug 33393)

2012-02-20 Thread Cor Nouws
Hi Michael, Michael Meeks wrote (20-02-12 17:05) Having a well formed, and reproducible bug report would be rather useful :-) Yes, I think we realise that :-) Therefore I added some comments on how I can reliably reproduce (more opening the doc and doing some random work for some tim

Re: Minimum Perl version requirement (was: Re: [PUSHED] Replace make_absolute_path with rel2abs in solenv)

2012-02-20 Thread Michael Meeks
Hi Tim, On Mon, 2012-02-20 at 13:47 +, Tim Retout wrote: > $ corelist File::Spec Nice :-) > Which leads to the question: what is the minimum version of Perl we > can rely on in LibreOffice? Currently configure.in checks for Perl 5, I poked Fridrich, the oracle on this s

Re: Disappearing graphics in Write: where to look (bug 33393)

2012-02-20 Thread Michael Meeks
On Mon, 2012-02-20 at 16:27 +0100, Cor Nouws wrote: > thanks for picking this one up. > Now with 3.5 out in the wild, reports of people loosing data appear. I > would like to propose this issue as *blocker* for 3.5.1 .. nothing less. Having a well formed, and reproducible bug report woul

Re: Building LibreOffice on Windows

2012-02-20 Thread Jesús Corrius
> Did you go with cmake, a cmake-style solution (something which > converted makefiles to VS projects) or manually maintained them? Manually maintained. I started using cmake but it had to be discarded for some reason. Unfortunately I don't remember why, but it was a long time ago so it may not be

Re: 3.5.0 - postgresql files missing in file-list/*.txt files

2012-02-20 Thread Petr Mladek
Andreas Radke píše v Čt 16. 02. 2012 v 18:23 +0100: > My ArchLinux installation makes use of the file-list/*.txt files to > split our packages. That way the postgresql-sdbc stuff is missing in > our installation. I guess they should be added to the base or common > file list. The file-list/*.txt f

Re: Building LibreOffice on Windows

2012-02-20 Thread Tor Lillqvist
> In any case the problem remains that cl.exe is not able to use all the cpu > power. You said you see max 13% CPU usage by each cl.exe process on a four-core, hyperthreading machine (i.e. 8-processor from Windows's point of view)? What is 100 divided by 8? --tml

[PUSHED] Remove unused code (18)

2012-02-20 Thread Michael Meeks
On Mon, 2012-02-20 at 21:25 +0800, Elton Chung wrote: > This patch removes another 16 unused methods. Thanks for that ! :-) are you tempted by any of the Easy Hacks ? All the best, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot _

R: Building LibreOffice on Windows

2012-02-20 Thread walter
In any case the problem remains that cl.exe is not able to use all the cpu power. I think that this problem must be analyzed. Best, walter > I have noted that on my machine the cl.exe process is unable to push a > cpu core to the limit. M

Re: [PUSHED] EasyHack 42790: get rid of PRODUCT define/build system variable

2012-02-20 Thread Matúš Kukan
On 18 February 2012 09:43, jumbo444 wrote: > Actually all use of PRODUCT was removed from the code (if I correctly > greped). However it may also be necessary to remove the definition of > PRODUCT. I was not able to understand clearly how it is defined. I found > some PRODUCT="" or PRODUCT="full"

Re: Building LibreOffice on Windows

2012-02-20 Thread Tor Lillqvist
> I think that is oversimplifying things quite a bit. Well, what isn't? Excuse me for writing quick emails without spending a week researching first. > While there are some > stability issues with cygwin "some" stability issues? > when combined with evil Windows necessities like > in-memory-vir

Re: Building LibreOffice on Windows

2012-02-20 Thread Tor Lillqvist
> I have noted that on my machine the cl.exe process is unable to push a cpu > core to the limit. My experience is the opposite; I occasionally see a cl.exe taking over 25% CPU on a four-core system (not HT)... Might of course just be rounding errors; in any case for compilations taking a long tim

Re: Disappearing graphics in Write: where to look (bug 33393)

2012-02-20 Thread Cor Nouws
Hi Andrew, *, Thorsten Behrens wrote (20-02-12 12:59) Andrew Douglas Pitonyak wrote: Have been poking around the LO code today trying to decide where I might put break points to help in tracking this. Looks like this occurs (for my sample) when auto-save kicks in, so I may place a break point

License for my contributions

2012-02-20 Thread G.H.M.Valkenhoef, van
Hi all, I hereby declare that my past and future contributions to LibreOffice are licensed under the LGPL v3+ and the MPL v1.1. Best wishes, Gert van Valkenhoef ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.or

Re: About fdo#46180 LO Base fails to connect to "*.DBF" files but connects OK to "*.dbf"

2012-02-20 Thread julien2412
I think there are 2 different points : 1) to list files in a directory with extension filter 2) to open a file with or without extension About 2), I agree with the fact we should look at the content and, considering your comment https://bugs.freedesktop.org/show_bug.cgi?id=46180#c5, it should be o

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-20 Thread Ivan Timofeev
On 20.02.2012 19:12, Noel Grandin wrote: The error was sourced several levels down in the boost stuff, and the originating point was everywhere I tried to assign into ptr_map. I think it had something to with the copyability of the Font class. Did you try to use 'insert(key, value)' instead of

R: Building LibreOffice on Windows

2012-02-20 Thread walter
Hi * About windows / Cygwin performance. I have noted that on my machine the cl.exe process is unable to push a cpu core to the limit. The best that the cl.exe can is 13% cpu usage without any I/O activity. Where is the time spent ? Any Idea ? I have a i7 870 @ 2.93 GHz, HT enabled. Best, Walter

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-20 Thread Noel Grandin
On Mon, Feb 20, 2012 at 16:38, Ivan Timofeev wrote: > Hi Noel, > > > What line produces that error? I suppose we should do use ptr_map, because > even you forgot to delete object :) The error was sourced several levels down in the boost stuff, and the originating point was everywhere I tried to a

Re: About Boost 1.48

2012-02-20 Thread Eike Rathke
Hi, On Monday, 2012-02-20 13:42:01 +, Caolán McNamara wrote: > On Sun, 2012-02-19 at 13:36 +0100, Rene Engelhard wrote: > > But it's normal that the internal copy of LO is outdated. See also icu :-) > > Its hard to update icu because the latest versions don't come with the > makefiles (or sc

Re: Building LibreOffice on Windows

2012-02-20 Thread Bjoern Michaelsen
Hi, On Mon, Feb 20, 2012 at 02:06:37PM +0200, Tor Lillqvist wrote: > The main problem in building LibreOffice for Windows on Windows > currently is that the *open source* stuff used in the build, i.e. > Cygwin, is slow and causes random errors. The Microsoft compiler and > linker work fine. If the

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-20 Thread Caolán McNamara
On Sun, 2012-02-19 at 18:49 +0100, Gert van Valkenhoef wrote: > Thanks again for the help. Attached a new series of patches (cumulative > with the previously sent ones and Caolan's), in which (I think) all the > Java invocations have been removed in favor of using the C++ components: > > 1) Im

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-20 Thread Ivan Timofeev
Hi Noel, On 14.02.2012 15:25, Noel Grandin wrote: Note that I tried converting these usages to boost::ptr_map, but I ran into entirely undecipherable C++ template errors. Sorry for the late review... :( What line produces that error? I suppose we should do use ptr_map, because even you forgo

[PUSHED][REVIEW-3-5] Localization of Lightproof extensions

2012-02-20 Thread Caolán McNamara
On Mon, 2012-02-20 at 10:07 +0100, Andras Timar wrote: > http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=312a744c1c8a4afce0fe06a4423d97ebb883fc6d > > Please cherry-pick to 3-5. done C. ___ LibreOffice mailing list LibreOffice@lists.fre

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Cor Nouws
Hi Kendy, *, Jan Holesovsky wrote (14-02-12 14:47) Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: Can this patch be pushed to 3.4 and 3.5 branches as well? The patch addresses problem that go way back in time (pre-LibreOffice at least). The problem is that it is partially a feature,

Re: [PUSHED][REVIEWED][REVIEW 3-5,3-4] resolved rhbz#794679 use proper Indian Rupee currency symbol U+20B9

2012-02-20 Thread Eike Rathke
Hi Caolán, On Monday, 2012-02-20 13:27:01 +, Caolán McNamara wrote: > +1 on review, but they conflict horribly in multiple places on 3-4 and > 3-5. I suggest you fix them up and push them yourself with my signoff The joy of having properly indented the files on master ... thanks for trying ;

Re: [PUSHED:3-5] bin bogus JRE warnings on first-start ...

2012-02-20 Thread Petr Mladek
Stephan Bergmann píše v Po 20. 02. 2012 v 13:42 +0100: > On 02/16/2012 01:49 PM, Michael Meeks wrote: > > This is not really my sphere of expertise, so review appreciated. > > Rather than clobber the DesktopContext with some out-of band magic > > (which creates the JavaInteractionHandler that i

Re: Tinderbox failure, Win-x86@7-MinGW, MASTER, last success: 2012-02-17 07:15:03

2012-02-20 Thread Caolán McNamara
On Fri, 2012-02-17 at 22:50 +0100, Rene Engelhard wrote: > On Fri, Feb 17, 2012 at 09:00:31PM +, ke...@suse.cz wrote: > [...] > > d40a7f1 make gengal work again > > is the breaking one. > > > [ info ALL ] Currently known executables: bestreversemap bmp bmpsum > > cppunit/cppunittester cr

Minimum Perl version requirement (was: Re: [PUSHED] Replace make_absolute_path with rel2abs in solenv)

2012-02-20 Thread Tim Retout
On 20 February 2012 11:30, Michael Meeks wrote: > On Sun, 2012-02-19 at 14:39 +, Tim Retout wrote: >        Great :-) thanks for that, it's always nice to use standard methods > instead of custom / hand-coded ones. Clearly we want to introduce new > perl dependencies on shared modules only wit

Re: About Boost 1.48

2012-02-20 Thread Caolán McNamara
On Sun, 2012-02-19 at 13:36 +0100, Rene Engelhard wrote: > But it's normal that the internal copy of LO is outdated. See also icu :-) Its hard to update icu because the latest versions don't come with the makefiles (or script or whatever they are) to build it with express 2008 under windows, so it

Re: libmerged and related thoughts

2012-02-20 Thread Caolán McNamara
On Mon, 2012-02-20 at 00:31 +0100, Matúš Kukan wrote: > It fails in testtools/source/bridgetest/ And removing the unxlng* in testtools are forcing a rebuild there doesn't help ?, i.e. this might be an unrelated thing with a partial rebuild with missing dependency information in the old dmake-based

[REVIEWED][REVIEW 3-5,3-4] resolved rhbz#794679 use proper Indian Rupee currency symbol U+20B9

2012-02-20 Thread Caolán McNamara
On Fri, 2012-02-17 at 14:48 +0100, Eike Rathke wrote: > Hi, > > Please review and cherry-pick to 3-5 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d6af4f2947432a55324e4f5cc67bca202f939e9 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=4e0928278df9e327dac9ac4d0ebf40bf

[PATCH] Remove unused code (18)

2012-02-20 Thread Elton Chung
Hi, This patch removes another 16 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email: el...@layerjet.com -

Re: About fdo#46180 LO Base fails to connect to "*.DBF" files but connects OK to "*.dbf"

2012-02-20 Thread Lionel Elie Mamane
On Mon, Feb 20, 2012 at 03:49:02AM -0800, julien2412 wrote: > Michael Meeks wrote >> On Sun, 2012-02-19 at 05:49 -0800, julien2412 wrote: >>> I let a comment about this bug >>> https://bugs.freedesktop.org/show_bug.cgi?id=46180#c3. >>> I'm stucked because I don't know what's the use of the boolean

Re: [REVIEW:3-5] bin bogus JRE warnings on first-start ...

2012-02-20 Thread Stephan Bergmann
On 02/16/2012 01:49 PM, Michael Meeks wrote: This is not really my sphere of expertise, so review appreciated. Rather than clobber the DesktopContext with some out-of band magic (which creates the JavaInteractionHandler that in the end complains). I thought I'd just give this guy a nil co

Re: Building LibreOffice on Windows

2012-02-20 Thread Josh Heidenreich
Hi Jesus, Tor, *, > It can be done, yes. But it requires several months of work from > someone who knows what is doing and the result would probably be a > nightmare to maintain. Did you go with cmake, a cmake-style solution (something which converted makefiles to VS projects) or manually maintai

Windows tinderbox on private branch

2012-02-20 Thread Lionel Elie Mamane
Hi, Would it be possible to have a Windows tinderbox build a private branch of mine? It would roughly be libreoffice-3-5 plus most of my commits to master. As far as the LibreOffice project is concerned, this would allow me to dogfood the changes I do to master in production => a better Base in 3

[PUSHED] Remove unused code (17)

2012-02-20 Thread Michael Meeks
On Mon, 2012-02-20 at 00:33 +0800, Elton Chung wrote: > This patch removes 14 unused methods from basegfx. Pushed; thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing l

Re: [tdf-members] LibreOffice 2012 Conference Location Poll - Preliminary Results

2012-02-20 Thread Albert Thuswaldner
Hi Thorsten, Thanks for the update on this poll. On Mon, Feb 20, 2012 at 12:08, Thorsten Behrens wrote: > Dear members, > > the poll for the LibreOffice 2012 conference closed last night. You > can review the full ballot here: > >  https://elections.documentfoundation.org/votes.php?election_id=2

[PUSHED] Using empty() instead of size() == 0 (broad fix for, cppcheck's Possible inefficient checking for '', emptiness)

2012-02-20 Thread Michael Meeks
On Sun, 2012-02-19 at 18:42 +0100, Mariusz Dykierek wrote: > Performance improvement unlikely yet readability/intent clearer + cppcheck > satisfied. Found pushed :-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___

Re: Building LibreOffice on Windows

2012-02-20 Thread Tor Lillqvist
> Speaking with Italo Vignoli (The Document Foundation) I understood that the > goal was to use only open source tools so you do not have to depend in any > way by the owners tools, such as Microsoft. Bah. I don't agree with that. After all, we are talking about building software to run on a Mi

Re: Disappearing graphics in Write: where to look (bug 33393)

2012-02-20 Thread Thorsten Behrens
Andrew Douglas Pitonyak wrote: > Have been poking around the LO code today trying to decide where I > might put break points to help in tracking this. Looks like this > occurs (for my sample) when auto-save kicks in, so I may place a > break point in the auto save code and then start stepping thro

[PUSHED] Remove unused code in XMLTextListAutoStylePool

2012-02-20 Thread Michael Meeks
On Sun, 2012-02-19 at 19:04 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Pushed, thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreO

[PUSHED] Remove unused code

2012-02-20 Thread Michael Meeks
On Mon, 2012-02-20 at 01:13 +0100, Petr Vorel wrote: > another bit of unused core removed. Thanks for that, pushed :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list Lib

Re: About fdo#46180 LO Base fails to connect to "*.DBF" files but connects OK to "*.dbf"

2012-02-20 Thread julien2412
Michael Meeks-2 wrote > > On Sun, 2012-02-19 at 05:49 -0800, julien2412 wrote: >> I let a comment about this bug >> https://bugs.freedesktop.org/show_bug.cgi?id=46180#c3. >> I'm stucked because I don't know what's the use of the boolean variables >> quoted in the comment. > > Does Lionel's

R: Building LibreOffice on Windows

2012-02-20 Thread walter
Speaking with Italo Vignoli (The Document Foundation) I understood that the goal was to use only open source tools so you do not have to depend in any way by the owners tools, such as Microsoft. Best regards walter -Messaggio originale- Da: libreoffice-bounces+w.guerrieri=ranocchilab.

Re: Building LibreOffice on Windows

2012-02-20 Thread Tor Lillqvist
> AFAIK that was a pure community effort and not backed by Sun/Oracle. I meant that Sun/Oracle was behind OpenOffice.org. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Building LibreOffice on Windows

2012-02-20 Thread Bjoern Michaelsen
On Mon, Feb 20, 2012 at 01:36:46PM +0200, Tor Lillqvist wrote: > OpenOffice.org, at least back when Sun/Oracle still was behind it, had > a few (?) people working on using MinGW on Windows. We are not > interested in that. Correspondingly they had not worked on > cross-compilation (to any platform)

Re: Building LibreOffice on Windows

2012-02-20 Thread Tor Lillqvist
> But .. isn't  there a project that involves the complete replacement of the > MS compiler? Yes. But that is not used *on* Windows. The subject of this thread is "Building LibreOffice *on* Windows". MinGW (the commonly used name for the GNU compiler and tool-chain when targeting Windows) is supp

[PUSHED] Replace make_absolute_path with rel2abs in solenv

2012-02-20 Thread Michael Meeks
Hi Tim, On Sun, 2012-02-19 at 14:39 +, Tim Retout wrote: > These three patches remove some home-grown path manipulation from > solenv, and replace it with functions shipped with the Perl core. Great :-) thanks for that, it's always nice to use standard methods instead of custom / hand

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #191 from sasha.libreoff...@gmail.com 2012-02-20 03:28:27 PST --- mentioned above bug 46144 is regression since version 3.4 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mai

R: Building LibreOffice on Windows

2012-02-20 Thread walter
But .. isn't there a project that involves the complete replacement of the MS compiler? Best Regards walter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW-3-5] Localization of Lightproof extensions

2012-02-20 Thread Michael Meeks
On Mon, 2012-02-20 at 11:25 +0100, Xuacu Saturio wrote: > I was about to start working in Asturian Lightproof checker when I was > told our Asturian spellchecker people were working in languagetool. :-) > Please, can you tell us which is/will be the default grammar checker > (if any)?

Re: Building LibreOffice on Windows

2012-02-20 Thread Bjoern Michaelsen
On Mon, Feb 20, 2012 at 09:44:50AM +, Michael Meeks wrote: > > On Mon, 2012-02-20 at 18:22 +1030, Josh Heidenreich wrote: > > Okay so it might be nuts, but has anyone tried creating a native VS > > solution/projects, which ruins inside the ide? Could one be created > > cmake style perhaps? >

Re: cygwin 1.7.10 - LO-3-5-0 - build fails in 'reportbuilder'

2012-02-20 Thread Michael Meeks
On Sat, 2012-02-18 at 14:23 +0100, walter wrote: > Please see logs AT http://pastebin.com/u/walterLO Could it be that your translation/ repository is still on 'master' but your core/ repository is on libreoffice-3-5 ? If so you'd want to do: ./g checkout libreoffice-3-5

[PATCH] Re: R: R: cygwin 1.7.10 - LO-3-5-0 - build fails - my git problem ?

2012-02-20 Thread Michael Stahl
On 20/02/12 11:28, walter wrote: > Now, after a full re-clone, I have a build error in 'reportbuilder'. > Please see logs http://pastebin.com/u/walterLO looking at the log it seems like you have a --with-lang setting and for none of the languages you have enabled there is a translation of the desc

REMINDER: Release 3.5.1-rc1 from libreoffice-3-5 branch

2012-02-20 Thread Petr Mladek
Hi, please note that the commit deadline for 3.5.1-rc1 is today, February 20, 2012. The branch libreoffice-3-5-1 is going to be created the day after. Only commits with 3 reviewers will be allowed for that branch. See also http://wiki.documentfoundation.org/ReleasePlan#3.5_release http://wiki.do

  1   2   >