Re: [PUSHED] Give Macro recorder separate option, apart from Experimental features

2012-06-18 Thread Cor Nouws
Fridrich Strba wrote (15-06-12 15:14) Dank u vel, Cor :-) Pushed Thanks for looking at this one and the others, Fridrich. Shouldn't the commits be visible in the cgit core log ? Regards, -- - Cor - http://nl.libreoffice.org ___ LibreOffice

Re: What is bibisect? And what is it doing in my office?

2012-06-18 Thread Jan Holesovsky
Hi, On 2012-06-16 at 02:22 -0700, bfo wrote: The bibisect is only possible for Bugs which are reproducible under Linux, if Linux has already been excluded (maybe bug history or comments will contain required information) bibisecting will not be possible. But of course, you can use

Re: Cleaning bug list

2012-06-18 Thread Jan Holesovsky
Hi Joel, On 2012-06-15 at 23:09 -0700, Joel Madero wrote: I brainstormed a bit today and I came up with this flowchart. Looking for input. I read through email threads and see that prioritizing bugs has been an interesting discussion but as of now looks to be pretty unsettled. I'm going to

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Roman Eisele b...@eikota.de changed: What|Removed |Added Depends on||49610

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||46480 --- Comment #328

[Libreoffice-commits] .: Branch 'libreoffice-3-5-5' - libvisio/libvisio-0.0.17.patch

2012-06-18 Thread Miklos Vajna
libvisio/libvisio-0.0.17.patch |9 + 1 file changed, 9 insertions(+) New commits: commit 6ad8fcacac45272b0dae94712d90f5f2a8c2e535 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Jun 15 18:15:59 2012 +0200 Fix another crash in exotic circumstances

Smooth filter - to release notes

2012-06-18 Thread Jan Holesovsky
Hi Tomaž, First of all, thanks for all the work around the better bitmap filters! :-) - I love that: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee41193f3e12ea55237f7681e4b53162a0d421d2 [and around] Can you please add that to http://wiki.documentfoundation.org/ReleaseNotes/3.7

[PATCH 1/6] Some doxygen comments for QuickHelpData

2012-06-18 Thread Brad Sowden
Change-Id: Id6e91985f6dbdd8244df9bef0f7a938ac8ecbf3a --- sw/source/ui/docvw/edtwin.cxx | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/sw/source/ui/docvw/edtwin.cxx b/sw/source/ui/docvw/edtwin.cxx index 6e40e57..2a0aa88 100644 ---

[PATCH 2/6] sal_Bool (bit field) to bool and variable renames

2012-06-18 Thread Brad Sowden
bIsAutoText - m_bIsAutoText bIsTip - m_bIsTip bChkInsBlank - m_bAppendSpace bClear - m_bIsDisplayed Change-Id: I7aa047b7e14ed6bd05528c8650ba4c4b7fcb07d2 --- sw/source/ui/docvw/edtwin.cxx | 70 1 files changed, 35 insertions(+), 35

[PATCH 3/6] Member variables can be made local

2012-06-18 Thread Brad Sowden
Change-Id: I571eaa936f8d1afb421da3137aa090e916e633ba --- sw/source/ui/docvw/edtwin.cxx | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/sw/source/ui/docvw/edtwin.cxx b/sw/source/ui/docvw/edtwin.cxx index 532bc16..82be706 100644 ---

[PATCH 4/6] Clearer function names

2012-06-18 Thread Brad Sowden
Change-Id: I7434842fe8392eeb6e3c5fd8e605ee444f66b017 --- sw/source/ui/docvw/edtwin.cxx | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/sw/source/ui/docvw/edtwin.cxx b/sw/source/ui/docvw/edtwin.cxx index 82be706..9cd1ba2 100644 ---

[PATCH 5/6] Remove redundant IF clause

2012-06-18 Thread Brad Sowden
ClearCntnt() already sets m_bIsTip and m_bIsAutoText to true. Change-Id: Ic3ad53a7659dbfe4f28f7995976e659f5bd14afb --- sw/source/ui/docvw/edtwin.cxx |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sw/source/ui/docvw/edtwin.cxx b/sw/source/ui/docvw/edtwin.cxx

[PATCH 6/6] Remove unnecessary temp variable

2012-06-18 Thread Brad Sowden
The only impact aTmpQHD.Move() has on pQuickHlpData is clearing m_aHelpStrings but this is done anyway in the pQuickHlpData-Stop() Change-Id: Ie730ddb1860461c81558275d54e32846c1495abe --- sw/source/ui/docvw/edtwin.cxx |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git

[Libreoffice-commits] .: libvisio/libvisio-0.0.17-fdo48601_part2.patch libvisio/makefile.mk

2012-06-18 Thread Fridrich Strba
libvisio/libvisio-0.0.17-fdo48601_part2.patch | 64 ++ libvisio/makefile.mk |1 2 files changed, 65 insertions(+) New commits: commit 1d1c70d8114a28a0d37315d408fdc3ef25cf44df Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Mon Jun

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - libvisio/libvisio-0.0.17-fdo48601_part1.patch libvisio/libvisio-0.0.17-fdo48601_part2.patch libvisio/makefile.mk

2012-06-18 Thread Fridrich Strba
libvisio/libvisio-0.0.17-fdo48601_part1.patch | 26 ++ libvisio/libvisio-0.0.17-fdo48601_part2.patch | 64 ++ libvisio/makefile.mk |2 3 files changed, 92 insertions(+) New commits: commit 6677c27574523a75477103ebb35c4c81876633e3

[PUSHED 3-5][REVIEW 3-5-5] fdo#48601 FILEOPEN: Open Visio's file with bitmap's blocks

2012-06-18 Thread Fridrich Strba
Thanks for the fix. I pushed it into the 3-5 branch, we need 2 more people for the 3-5-5 by the end of today. Cheers F. On 16/06/12 18:46, Julien Nabet wrote: Hello, fdo#48601 contains 2 files and mixes display problem and crash. Even with the last fixes on Visio, I had crashes for both

[Libreoffice-commits] .: oox/inc

2012-06-18 Thread Miklos Vajna
oox/inc/oox/vml/vmlshape.hxx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit 2db200e0c6111836e2663bf494fc9be9f6dd03d1 Author: Miklos Vajna vmik...@suse.cz Date: Mon Jun 18 10:35:43 2012 +0200 oox: last vmlshape doxygen mistakes

[REVIEW 3-5][REVIEW 3-5-5] fdo#48601 second crash?

2012-06-18 Thread Fridrich Strba
Hello, good people, This one http://cgit.freedesktop.org/libreoffice/core/commit/?id=1d1c70d8114a28a0d37315d408fdc3ef25cf44df is putting some belts and braces to avoid out of bond access on a vector in libvisio. It might fix the second crash in fdo#48601, but I cannot reproduce the crash, so

Re: [PATCH 0/6] QuickHelpData comments and clean-ups

2012-06-18 Thread Fridrich Strba
Hello, Brad, The attachment is missing on this one :( Could you resend? F. On 18/06/12 10:00, Brad Sowden wrote: Hi, Attached are some patches with doxygen comments and clean-ups related to the QuickHelpData struct. - make check + make dev-install successful - functionality tested ok

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - filter/source

2012-06-18 Thread Fridrich Strba
filter/source/svg/gfxtypes.hxx |3 filter/source/svg/svgreader.cxx | 182 2 files changed, 132 insertions(+), 53 deletions(-) New commits: commit 7d9580863ca8dd9509d596b68d95abe2fcd561a9 Author: Chr. Rossmanith chrrossman...@gmx.de Date: Fri Jun

[REVIEW:3-5] fdo#50665 fdo#37063 n#760764 rtftok/dmapper: don't ignore character properties of text fields

2012-06-18 Thread Miklos Vajna
Hi, See commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=9486851 which fixes the dmapper part, and the followup http://cgit.freedesktop.org/libreoffice/core/commit/?id=b9508dd that fixes the rtftok part. From a user's PoV, the docx import never worked, the RTF import is a

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/unx

2012-06-18 Thread Fridrich Strba
vcl/unx/gtk/app/gtksys.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8443397ccf73e8d905f56a1049f3334325d63ed7 Author: Ruslan Kabatsayev b7.10110...@gmail.com Date: Sat Jun 16 03:49:20 2012 +0400 Fix arguments of Rectangle constructor Change-Id:

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - vcl/unx

2012-06-18 Thread Fridrich Strba
vcl/unx/gtk/app/gtksys.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c24210ac8a4a6d9a71752a8d33c504de8fcce6f6 Author: Ruslan Kabatsayev b7.10110...@gmail.com Date: Sat Jun 16 03:49:20 2012 +0400 Fix arguments of Rectangle constructor Change-Id:

[Libreoffice-commits] .: 4 commits - canvas/source solenv/gbuild sw/source

2012-06-18 Thread David Tardon
canvas/source/cairo/cairo_spritecanvashelper.cxx | 66 +-- canvas/source/cairo/cairo_spritecanvashelper.hxx | 12 +++- solenv/gbuild/InstallModule.mk |6 +- solenv/gbuild/InstallModuleTarget.mk | 12 ++-- solenv/gbuild/InstallScript.mk

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - shell/source sw/source

2012-06-18 Thread Fridrich Strba
shell/source/backends/wininetbe/wininetbackend.cxx |2 - sw/source/core/undo/untbl.cxx | 24 - 2 files changed, 15 insertions(+), 11 deletions(-) New commits: commit 561605f7b9383a5349b288580a565a6064b42dad Author: David Tardon dtar...@redhat.com

[PUSHED] [REVIEW 3-5-5] fdo#50896 and typo in fdo#47044

2012-06-18 Thread Fridrich Strba
I pushed the two commits to 3-6 and this one also to 3-5. WE need more review for 3-5-5 Cheers Fridrich On 17/06/12 08:22, Korrawit Pruegsanusak wrote: On Sun, Jun 17, 2012 at 11:40 AM, Korrawit Pruegsanusak detective.conan.1...@gmail.com wrote: *

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - writerfilter/source

2012-06-18 Thread Fridrich Strba
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 11 ++- writerfilter/source/dmapper/DomainMapper_Impl.hxx |1 + writerfilter/source/rtftok/rtfdocumentimpl.cxx| 20 ++-- writerfilter/source/rtftok/rtfdocumentimpl.hxx|2 +- 4 files changed, 30

[PUSHED 3-5] fdo#50665 fdo#37063 n#760764 rtftok/dmapper: don't ignore character properties of text fields

2012-06-18 Thread Fridrich Strba
Merged this patch to 3-5. If you need it for 3-5-5, set the right header and herd 2 more reviewers :) F. On 18/06/12 10:53, Miklos Vajna wrote: Hi, See commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=9486851 which fixes the dmapper part, and the followup

Re: [PUSHED 3-5][REVIEW 3-5-5] fdo#50988 Draw crashes on loading MS Logical Design Diagram example visio file

2012-06-18 Thread julien2412
Just to tell I found no other issue like this one in libvisio. I searched all the directory with : fgrep -R -10 'iter !=' -- View this message in context:

Difficulties with Flat XML under source control

2012-06-18 Thread Johannes Sixt
I want to place a software manual under source control. It seems most feasible to use a flat XML format, in particular, .fodt. But I have some difficulties because when LO 3.5.4 opens a .fodt and saves it again without making any changes, the resulting file changes nevertheless. I'm writing a

Re: [PATCH] pyuno is broken on mingw on current master

2012-06-18 Thread David Ostrovsky
On 12.06.2012 09:23, Stephan Bergmann wrote: On 06/12/2012 09:17 AM, David Ostrovsky wrote: What do you mean here? Personally, for an experimental platform like mingw, and as you have demonstrated that it does not work right now, I would not bother to make it work prior to gbuild'ification.

Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-18 Thread Cor Nouws
Hi Michael, all, Michael Meeks wrote (15-06-12 19:17) On Sun, 2012-06-10 at 23:07 +0200, Cor Nouws wrote: See fdo#41865 Incidentally - if you want to get this into 3.6 as a late feature you need to be drumming up support for another 2x reviews quickly ;-) - we want to get that lot

Re: [PATCH] pyuno is broken on mingw on current master

2012-06-18 Thread David Tardon
Hi, On Mon, Jun 18, 2012 at 01:15:05AM +0200, David Ostrovsky wrote: On 12.06.2012 09:23, Stephan Bergmann wrote: On 06/12/2012 09:17 AM, David Ostrovsky wrote: What do you mean here? Personally, for an experimental platform like mingw, and as you have demonstrated that it does not work

Re: [PUSHED] Re: [REVIEW-3-6 LATE FEATURE] color scales and data bars in calc

2012-06-18 Thread Jan Holesovsky
Hi Astron, On 2012-06-16 at 00:39 +0200, Stefan Knorr (Astron) wrote: - the menu to open the dialog is currently the only submenu of Format - Conditional Formatting; looks to me as Conditional Formatting... should be flattened for 3.6 (and given to submenu in 3.7 again) - but that is

Re: [PUSHED 3-5][PUSHED-3-5-5] Another crash in libvisio in some circumstances

2012-06-18 Thread Miklos Vajna
On Sat, Jun 16, 2012 at 05:49:24AM +0200, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Looks good. One more needed for 3-5-5. +1, pushed to -3-5-5. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: pyuno on Mac

2012-06-18 Thread Stephan Bergmann
On 06/15/2012 06:59 PM, Norbert Thiebaud wrote: about your fix http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa2006828ff69509e1ead755af906dcd35a992bf after your fixe: n_th@tpamac /Volumes/TBRAM/core $file solver/unxmacxi.pro/lib/pyuno.so solver/unxmacxi.pro/lib/pyuno.so: Mach-O

Re: Cleaning bug list

2012-06-18 Thread Petr Mladek
Joel Madero píše v Pá 15. 06. 2012 v 23:09 -0700: I brainstormed a bit today and I came up with this flowchart. Looking for input. I read through email threads and see that prioritizing bugs has been an interesting discussion but as of now looks to be pretty unsettled. I'm going to make a

[REVIEW:3-5 3-5-5?] fdo#30519 bad slide transitions with cairo

2012-06-18 Thread David Tardon
Hi all, commit 012b43d571aaa4f79b7f6fcfa92939e8d19af492 fixes the Cover/Uncover/Push groups of slide transitions. It also fixes any animation that would use the 'scrollUpdate' shortcut for updating the screen (i.e., when there is exactly one unchanging object moving over unchanging background).

[Libreoffice-commits] .: sc/source

2012-06-18 Thread Fridrich Strba
sc/source/ui/dbgui/validate.cxx | 12 ++-- sc/source/ui/dbgui/validate.src |4 ++-- sc/source/ui/inc/validate.hrc |4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 2ab43129611d24e210c5658aa3f753ed3fa39928 Author: Joel Madero

Re: [PATCH] fdo#43192: : confusing label for data validity criterion

2012-06-18 Thread Fridrich Strba
Hello, Joel, On 15/06/12 16:50, Joel Madero wrote: My first patch so I apologize in advance if I screwed something up. Welcome to the club. You just became LO developer and there was a lot of rejoicing :) https://bugs.freedesktop.org/show_bug.cgi?id=43192 Let me know if anything needs

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 4 commits - canvas/source solenv/gbuild sw/source

2012-06-18 Thread David Tardon
canvas/source/cairo/cairo_spritecanvashelper.cxx | 66 +-- canvas/source/cairo/cairo_spritecanvashelper.hxx | 12 +++- solenv/gbuild/InstallModule.mk |6 +- solenv/gbuild/InstallModuleTarget.mk | 12 ++-- solenv/gbuild/InstallScript.mk

Re: [PATCH] fdo#43192: : confusing label for data validity criterion

2012-06-18 Thread Andras Timar
2012/6/18 Fridrich Strba fridrich.st...@graduateinstitute.ch: Hello, Joel, On 15/06/12 16:50, Joel Madero wrote: My first patch so I apologize in advance if I screwed something up. Welcome to the club. You just became LO developer and there was a lot of rejoicing :)

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - canvas/source

2012-06-18 Thread Fridrich Strba
canvas/source/cairo/cairo_spritecanvashelper.cxx | 56 ++- canvas/source/cairo/cairo_spritecanvashelper.hxx | 12 +++- 2 files changed, 53 insertions(+), 15 deletions(-) New commits: commit 26130d1c29dba3b597c10fc279145cc42286021d Author: David Tardon dtar...@redhat.com

[PUSHED] fdo#43192: : confusing label for data validity criterion

2012-06-18 Thread Fridrich Strba
My bad, was too excited about your contribution and I forgot to modify the subject :) On 18/06/12 11:33, Fridrich Strba wrote: Hello, Joel, On 15/06/12 16:50, Joel Madero wrote: My first patch so I apologize in advance if I screwed something up. Welcome to the club. You just became LO

[PUSHED 3-5][REVIEW 3-5-5?] fdo#30519 bad slide transitions with cairo

2012-06-18 Thread Fridrich Strba
I cherry-picked to 3-5. Two more good souls for 3-5-5 F. On 18/06/12 11:30, David Tardon wrote: Hi all, commit 012b43d571aaa4f79b7f6fcfa92939e8d19af492 fixes the Cover/Uncover/Push groups of slide transitions. It also fixes any animation that would use the 'scrollUpdate' shortcut for

Re: [PATCH 0/6] QuickHelpData comments and clean-ups

2012-06-18 Thread Brad Sowden
Hi Fridrich, On 18/06/12 20:48, Fridrich Strba wrote: Hello, Brad, The attachment is missing on this one :( Could you resend? Sorry, Thunderbird changed my email message-id and the broke the threading :-( The 6 actual patches are now included under the email below which I sent at the

[Libreoffice-commits] .: writerfilter/source

2012-06-18 Thread Miklos Vajna
writerfilter/source/dmapper/NumberingManager.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 94037e30f9e6b4d8724002a2a7c2a1a96dc94386 Author: Miklos Vajna vmik...@suse.cz Date: Mon Jun 18 11:45:07 2012 +0200 dmapper: fix crash in ListLevel::SetParaStyle This

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2012-06-18 Thread Markus Mohrhard
sc/inc/scabstdlg.hxx |2 +- sc/source/filter/oox/formulaparser.cxx|2 +- sc/source/filter/xml/xmlexprt.cxx |2 -- sc/source/ui/attrdlg/scdlgfact.cxx|4 ++-- sc/source/ui/attrdlg/scdlgfact.hxx|2 +-

Re: Help in fixing gradient bug

2012-06-18 Thread Aakriti Gupta
Hi, Which files do I look into for exporting of embedded documents in pdfs, e.g. charts inserted in a presentation to be exported to pdf? This bug seems to be higher on our priority list. On Fri, Jun 15, 2012 at 6:17 PM, Thorsten Behrens t...@documentfoundation.org wrote: Aakriti Gupta wrote:

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - libvisio/libvisio-0.0.17-fdo48601_part2.patch libvisio/makefile.mk

2012-06-18 Thread Markus Mohrhard
libvisio/libvisio-0.0.17-fdo48601_part2.patch | 64 ++ libvisio/makefile.mk |1 2 files changed, 65 insertions(+) New commits: commit 1969514f20cde8728a1d732e0cc3f566ca1400e1 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Mon Jun

Re: [REVIEW 3-5][REVIEW 3-5-5] fdo#48601 second crash?

2012-06-18 Thread Markus Mohrhard
Hey Fridrich, 2012/6/18 Fridrich Strba fridrich.st...@graduateinstitute.ch: Hello, good people, This one http://cgit.freedesktop.org/libreoffice/core/commit/?id=1d1c70d8114a28a0d37315d408fdc3ef25cf44df is putting some belts and braces to avoid out of bond access on a vector in libvisio.

Re: [Libreoffice] [GSoC 2012][svg export filter] Weekly Report #4

2012-06-18 Thread Thorsten Behrens
Marco Cecchetti wrote: I started studying how to support repeated animations and performed several tests. Support is not yet available anyway I have some idea for getting it working. Now to animations and repeated to animations are handled by both the C++ and the JavaScript presentation

[PATCH] Add casts to reduce javac warning messages

2012-06-18 Thread Noel Grandin
Hi This patch removes a few of the javac warning messages i.e. helps to reduce noise in the build logs. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Add-casts-to-reduce-javac-warning-messages.patch Description: application/mbox

[ANN] Please use Gerrit from now on for Patch Review

2012-06-18 Thread Bjoern Michaelsen
Hi all, with: http://sweetshark.livejournal.com/13298.html gerrit is documented and ready to go. Please use it for code review as much as possible now as it simplifies things a lot over manual patch fiddling on mailing lists. I will update the EasyHacks to point to gerrit instead in the next

Re: [PATCH 0/6] QuickHelpData comments and clean-ups

2012-06-18 Thread Fridrich Strba
My bad, just ignore me :) f. On 18/06/12 12:33, Fridrich Strba wrote: Brad, could I request you kindly to send the patches next time as a result of git format-patch? Will do the commit messages for these 6 myself, but it would be better if your original message could be maintained.

Re: [REVIEW 3-5][REVIEW 3-5-5] fdo#48601 second crash?

2012-06-18 Thread Tor Lillqvist
Looks safe to me. Pushed to 3-5. Two more reviews needed for 3-5-5 +1 from me. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-5][REVIEW 3-5-5?] fdo#30519 bad slide transitions with cairo

2012-06-18 Thread Tor Lillqvist
I cherry-picked to 3-5. Two more good souls for 3-5-5 +1 from me. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 6 commits - sw/source

2012-06-18 Thread Fridrich Strba
sw/source/ui/docvw/edtwin.cxx | 139 +++--- 1 file changed, 65 insertions(+), 74 deletions(-) New commits: commit 20def8ddd8a21d22deb250ded21a2348ee0e35f4 Author: Brad Sowden c...@sowden.org Date: Mon Jun 18 20:01:42 2012 +1200 Remove unnecessary temp

[PUSHED] Some doxygen comments for QuickHelpData

2012-06-18 Thread Fridrich Strba
Pushed Thanks On 18/06/12 10:00, Brad Sowden wrote: Change-Id: Id6e91985f6dbdd8244df9bef0f7a938ac8ecbf3a --- sw/source/ui/docvw/edtwin.cxx | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) ___ LibreOffice

[PUSHED] Member variables can be made local

2012-06-18 Thread Fridrich Strba
Pushed to master Cheers F. On 18/06/12 10:01, Brad Sowden wrote: Change-Id: I571eaa936f8d1afb421da3137aa090e916e633ba --- sw/source/ui/docvw/edtwin.cxx | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-)

Re: [PATCH 4/6] Clearer function names

2012-06-18 Thread Fridrich Strba
Pushed, Thanks Fridrich On 18/06/12 10:01, Brad Sowden wrote: Change-Id: I7434842fe8392eeb6e3c5fd8e605ee444f66b017 --- sw/source/ui/docvw/edtwin.cxx | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) ___

[PUSHED] Remove redundant IF clause

2012-06-18 Thread Fridrich Strba
Pushed this one Cheers F. On 18/06/12 10:01, Brad Sowden wrote: ClearCntnt() already sets m_bIsTip and m_bIsAutoText to true. Change-Id: Ic3ad53a7659dbfe4f28f7995976e659f5bd14afb --- sw/source/ui/docvw/edtwin.cxx |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-)

Re: [PATCH 6/6] Remove unnecessary temp variable

2012-06-18 Thread Fridrich Strba
Pushed to master. Thanks for your work. Cheers Fridrich On 18/06/12 10:01, Brad Sowden wrote: The only impact aTmpQHD.Move() has on pQuickHlpData is clearing m_aHelpStrings but this is done anyway in the pQuickHlpData-Stop() Change-Id: Ie730ddb1860461c81558275d54e32846c1495abe ---

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sal/osl

2012-06-18 Thread Stephan Bergmann
sal/osl/unx/salinit.cxx | 32 1 file changed, 32 insertions(+) New commits: commit 942d0591be15d3886efd3c68bb2a5eefb2ed82ef Author: Stephan Bergmann sberg...@redhat.com Date: Mon Jun 18 13:00:08 2012 +0200 fdo#50603: Close fds across a restart of soffice

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sal/osl

2012-06-18 Thread Andras Timar
sal/osl/unx/salinit.cxx | 32 1 file changed, 32 insertions(+) New commits: commit dbc4070cacc85e4021c9f24947e84eeaa7f104f4 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Jun 18 13:00:08 2012 +0200 fdo#50603: Close fds across a restart of soffice

Re: [PUSHED-3-5][PATCH-3-5-5] fdo#50603: Close fds across a restart of soffice on Mac OS X

2012-06-18 Thread Andras Timar
Hi, 2012/6/18 Stephan Bergmann sberg...@redhat.com: Hi all, Via some remote debugging I found out the reason for https://bugs.freedesktop.org/show_bug.cgi?id=50603 Unable to update LibreOffice without resetting user profile is that an soffice restarting itself on Mac OS X (when it finds out

Re: [PATCH] Fixed out of bounds memory access

2012-06-18 Thread Stephan Bergmann
On 06/15/2012 05:45 PM, Marc-André Laverdière wrote: Here is a patch for a small fish I caught while valgrinding. It was accessing memory in the strdup. Was it really? My reading of the original rtl::OUString aUserName; rtl::OString aUser; oslSecurity aSec =

[Libreoffice-commits] .: sc/source

2012-06-18 Thread Stephan Bergmann
sc/source/filter/xml/xmlexprt.cxx | 13 + sc/source/filter/xml/xmlexprt.hxx |2 +- 2 files changed, 6 insertions(+), 9 deletions(-) New commits: commit b0d2e68244c6745dc3fe145579b05f30e40793d5 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Jun 18 13:44:40 2012 +0200

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 3 commits - config_host.mk.in configure.in external/mingw-dlls m4/ax_boost_base.m4 scp2/InstallModule_ooo.mk scp2/source

2012-06-18 Thread Jan Holesovsky
config_host.mk.in |1 configure.in|8 ++ external/mingw-dlls/makefile.mk |1 m4/ax_boost_base.m4 | 50 +++- scp2/InstallModule_ooo.mk |2 + scp2/source/ooo/mingw_dlls.scp |6

Re: [PUSHED 3-5][REVIEW 3-5-5] Fix arguments to Rectangle constructor in GtkSalSystem::GetDisplayScreenPosSizePixel()

2012-06-18 Thread Stephan Bergmann
On 06/18/2012 10:59 AM, Fridrich Strba wrote: Looks pretty simple. I pushed to master, 3-6, 3-5. We need 2 more good souls to push to 3-5-5. Looks good indeed. One more... Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [REVIEW-3-5] MSVC qsort issue

2012-06-18 Thread Eike Rathke
Hi Muthu, On Thursday, 2012-06-14 20:02:38 +0530, Muthu Subramanian K wrote: qsort seems to change the order of the elements even if the elements are sorted. Yes, qsort and std::sort are not stable and preexisting relative ordering is not preserved for equivalent elements. (Technically

Re: [PUSHED] Add casts to reduce javac warning messages

2012-06-18 Thread Stephan Bergmann
On 06/18/2012 11:41 AM, Noel Grandin wrote: This patch removes a few of the javac warning messages i.e. helps to reduce noise in the build logs. Pushed, thanks. (Followed by some further clean up, while we are at it,

Re: fdo#38731 - Papiamentu not avaliable as language

2012-06-18 Thread Eike Rathke
Hi Rob, On Friday, 2012-06-15 23:27:22 +0200, Rob Snelders wrote: I have looked at this bug. The problem consists of 2 parts: - The language-name is updated. Because the country Dutch Antilles is gone and the country has split into Curacao and a part has become the Netherlands. The language

Re: [PATCH 6/6] Remove unnecessary temp variable

2012-06-18 Thread Stephan Bergmann
On 06/18/2012 02:35 PM, Stephan Bergmann wrote: On 06/18/2012 10:01 AM, Brad Sowden wrote: diff --git a/sw/source/ui/docvw/edtwin.cxx b/sw/source/ui/docvw/edtwin.cxx index 04e6e73..9f6d2f2 100644 --- a/sw/source/ui/docvw/edtwin.cxx +++ b/sw/source/ui/docvw/edtwin.cxx @@ -4992,12 +4992,9 @@ void

Re: [PUSHED 3-5][REVIEW 3-5-5] [PUSHED-3-5-5] Fix arguments to Rectangle constructor in GtkSalSystem::GetDisplayScreenPosSizePixel()

2012-06-18 Thread Tor Lillqvist
Looks good indeed.  One more... +1, cherry-picked and pushed to 3-5-5. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Smooth filter - to release notes

2012-06-18 Thread Tomaž Vajngerl
On Mon, Jun 18, 2012 at 9:56 AM, Jan Holesovsky ke...@suse.cz wrote: Hi Tomaž, First of all, thanks for all the work around the better bitmap filters! :-) - I love that: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee41193f3e12ea55237f7681e4b53162a0d421d2 [and around] Can you

gerrit for release branches (bots ftw?)

2012-06-18 Thread Bjoern Michaelsen
Hi all, reviewing patches for a release branch is currently a hassle: submitter: - find cgit link - write to mailing list with cgit link asking for review reviewer: - check out the release branch - cherrypick commit on release branch by exctracting the commit-id from the cgit link - review

Re: Enable CTL for Default?

2012-06-18 Thread Eike Rathke
Hi Christian, On Monday, 2012-06-18 13:28:15 +0200, Christian Lohmaier wrote: I don't agree with the performance statement there is no performance impact AFAIK. All RTL functionality is there even without the option activated. You can open and edit RTL/CTL documents even without that option

Re: Cleaning bug list

2012-06-18 Thread Rainer Bielefeld
Joel Madero schrieb: I brainstormed a bit today and I came up with this flowchart. Hi Joel, great to see that all in a chart, your conclusions and definitions seem plausible. But the chart also shows the limitations of that concept: It's really sophisticated, and no developer will sit at

Re: [PUSHED] [REVIEW 3-5-5] fdo#50896 and typo in fdo#47044

2012-06-18 Thread Eike Rathke
Hi, On Monday, 2012-06-18 11:03:40 +0200, Fridrich Strba wrote: * http://cgit.freedesktop.org/libreoffice/core/commit/?id=02d9bd3b14575442a6532915cdb18bb4a69ad35f I pushed the two commits to 3-6 and this one also to 3-5. WE need more review for 3-5-5 Fine with me, one more review needed.

Re: Enable CTL for Default?

2012-06-18 Thread Eike Rathke
Hi Khaled, On Monday, 2012-06-18 13:39:03 +0200, Khaled Hosny wrote: IMO CTL/Asian options is a remnants of distant past Yes, it is ... and should be killed for good (not to mention that Asian is a so ignorant orientalistic term in this context). ... but it is something that MS bestowed

[Libreoffice-commits] .: sw/source uui/source xmlhelp/source

2012-06-18 Thread Takeshi Abe
sw/source/core/access/acccontext.hxx |2 -- sw/source/core/access/accfrmobjmap.hxx |1 - sw/source/core/inc/SwXMLTextBlocks.hxx |1 - sw/source/core/inc/UndoCore.hxx|1 - sw/source/core/inc/flyfrm.hxx |

Re: Cleaning bug list

2012-06-18 Thread Joel Madero
I'll modify the orientation today or tomorrow and try to see where regression should fit. I think that it has to go in Priority and not in Severity. As for how devs use it, I agree completely that right now it's almost useless but maybe if it becomes more uniform and it actually provides some

[Libreoffice-commits] .: Branch 'libreoffice-3-5-5' - shell/source

2012-06-18 Thread Stephan Bergmann
shell/source/backends/wininetbe/wininetbackend.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 37939e6f03b89c678cdd83f1280f960dddb93bfc Author: David Tardon dtar...@redhat.com Date: Tue Jun 12 09:30:12 2012 +0200 fix typo: = - == Signed-off-by:

Re: [PUSHED] [PUSHED 3-5-5] fdo#50896 and typo in fdo#47044

2012-06-18 Thread Stephan Bergmann
On 06/18/2012 02:08 PM, Stephan Bergmann wrote: On 06/18/2012 11:03 AM, Fridrich Strba wrote: I pushed the two commits to 3-6 and this one also to 3-5. WE need more review for 3-5-5 Rats. Yes, quick, one more please to get this embarrassment out of the way. ;) With Eike's +1 coming in

Re: Enable CTL for Default?

2012-06-18 Thread Joel Madero
I guess with all of this said my question still is, should I mark the bug report as WONTFIX and just have a comment why? It seems like enabling by default isn't the way to go and the time/energy it would take to add a language check might just be too much for a bug that affects such a limited

Re: [PUSHED] [PUSHED 3-5-5] fdo#50896 and typo in fdo#47044

2012-06-18 Thread Eike Rathke
Hi Stephan, On Monday, 2012-06-18 16:16:13 +0200, Stephan Bergmann wrote: With Eike's +1 coming in delayed, hmpf.. X-Greylist: delayed 2260 seconds by postgrey-1.32 at gabe; Mon, 18 Jun 2012 13:30:11 CEST that's enough to actually push it You were 10 minutes faster than me ;)

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 --- Comment #18 from Timur gti...@gmail.com 2012-06-18 07:31:40 PDT --- Can you please explain the relation between this bug and Bug 37361 - LibreOffice 3.5 most annoying bugs? Should unresolved bugs from Bug 37361 at some point (which?) be

[Libreoffice-commits] .: vcl/unx

2012-06-18 Thread Fridrich Strba
vcl/unx/gtk/app/gtkdata.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit a7f69caf25662d72b685a2c3412f3a352a0c5a88 Author: Ruslan Kabatsayev b7.10110...@gmail.com Date: Mon Jun 18 17:23:46 2012 +0400 GTK: don't crash on X errors Change-Id:

[Libreoffice-commits] .: Branch 'features/base-preview' - 0 commits -

2012-06-18 Thread Lionel Elie Mamane
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] GTK: don't crash on X errors

2012-06-18 Thread Fridrich Strba
On 18/06/12 15:27, Ruslan Kabatsayev wrote: Hello, This patch disables GDK's default behaviour of abort() on X errors such as BadAtom etc.. It'll just ignore such errors. Rationale: 1. KDE4 and GEN plugins ignore the X erorrs 2. X errors may be unavoidable in some cases, like when wrong

[Libreoffice-commits] .: basctl/uiconfig chart2/uiconfig dbaccess/uiconfig extensions/source framework/uiconfig reportdesign/uiconfig sc/uiconfig sd/uiconfig starmath/uiconfig sw/uiconfig

2012-06-18 Thread Fridrich Strba
basctl/uiconfig/basicide/menubar/menubar.xml | 2 -- chart2/uiconfig/menubar/menubar.xml | 2 -- dbaccess/uiconfig/dbapp/menubar/menubar.xml | 2 --

Re: [PATCH] A few more improvements to the About dialogue

2012-06-18 Thread Fridrich Strba
I pushed the second patch to master. Nevertheless, the first one does not apply on today's master checkout, any chance you can pull and resend? F. On 18/06/12 15:52, Stefan Knorr wrote: Hi all, I hope it's okay to send multiple related patches to the list like this... Some time ago,

[Libreoffice-commits] Changes to 'features/base-preview'

2012-06-18 Thread Lionel Elie Mamane
New branch 'features/base-preview' available with the following commits: commit e834a95359738961037b7f747f55ac60a0b9e922 Author: Lionel Elie Mamane lio...@mamane.lu Date: Mon Jun 18 16:28:14 2012 +0200 fdo#43967 legacy report designer wizard formats dates improperly 1) Set

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - wizards/com

2012-06-18 Thread Lionel Elie Mamane
wizards/com/sun/star/wizards/common/NumberFormatter.java |5 +++- wizards/com/sun/star/wizards/db/FieldColumn.java | 16 +++ 2 files changed, 12 insertions(+), 9 deletions(-) New commits: commit fec488b9dc3018d421747fb887edee93ad3ed98e Author: Lionel Elie Mamane

[Libreoffice-commits] .: wizards/com

2012-06-18 Thread Lionel Elie Mamane
wizards/com/sun/star/wizards/common/NumberFormatter.java |5 +++- wizards/com/sun/star/wizards/db/FieldColumn.java | 16 +++ 2 files changed, 12 insertions(+), 9 deletions(-) New commits: commit b86f2147e496e3b7ca5a085b302f6144f338aa82 Author: Lionel Elie Mamane

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/unx

2012-06-18 Thread Fridrich Strba
vcl/unx/gtk/app/gtkdata.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 3a15168ae587cdc8f329ae049d0c1d1e9d9de21a Author: Ruslan Kabatsayev b7.10110...@gmail.com Date: Mon Jun 18 17:23:46 2012 +0400 GTK: don't crash on X errors Change-Id:

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - vcl/unx

2012-06-18 Thread Fridrich Strba
vcl/unx/gtk/app/gtkdata.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 058a767706d23c1ab9f3ce89da738c706b9b4e38 Author: Ruslan Kabatsayev b7.10110...@gmail.com Date: Mon Jun 18 17:23:46 2012 +0400 GTK: don't crash on X errors Change-Id:

[REVIEW 3-5-5] GTK: don't crash on X errors

2012-06-18 Thread Fridrich Strba
Hello, I cherry-picked with my signoff to 3-6 and 3-5. We need 2 more people for 3-5-5 F. On Mon, 2012-06-18 at 18:55 +0400, Ruslan Kabatsayev wrote: Thanks for pushing. Would be good if this patch got into 3.5.5 and 3.6 as well. On Mon, Jun 18, 2012 at 6:37 PM, Fridrich Strba

Re: Cleaning bug list

2012-06-18 Thread Petr Mladek
Rainer Bielefeld píše v Po 18. 06. 2012 v 13:21 +0200: Joel Madero schrieb: I brainstormed a bit today and I came up with this flowchart. Hi Joel, great to see that all in a chart, your conclusions and definitions seem plausible. But the chart also shows the limitations of that

  1   2   3   4   >