Re: Revert of hrc cleanup

2012-07-20 Thread Michael Meeks
Hi Thomas, On Wed, 2012-07-18 at 21:33 +0200, Thomas Arnhold wrote: > as Markus stated in dc05a825e71316e6f602e5c8dfcd3d10ecb6252f those > string cleanups aren't save. I've had the illusion, that by compiling > and "quick checking" all of it got tested (mostly by compiling). Ah ... ;-)

Re: [PUSHED] fdo#52293: Spelling error (UI, Localization)

2012-07-20 Thread Eike Rathke
Hi Kevin, On Friday, 2012-07-20 02:00:12 -0700, Kevin Peng wrote: > This patch [aims to] fix the aforementioned bug. It does, thanks. Liked your comment in the bug about the secret calculation ;) Pushed to master with http://cgit.freedesktop.org/libreoffice/core/commit/?id=eccc5f97ba245faadf61c

[Libreoffice-commits] .: sc/source

2012-07-20 Thread Eike Rathke
sc/source/ui/src/scfuncs.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit eccc5f97ba245faadf61cf4577b21d4f8da6460d Author: Kevin Peng Date: Fri Jul 20 01:53:03 2012 -0700 fdo#52293 Changed "discreet" to "discrete" Change-Id: I305883239dbcd6f46d6ed5

[Libreoffice-commits] .: Branch 'feature/mork' - 5 commits - offapi/com sw/inc sw/qa sw/source xmloff/inc xmloff/source

2012-07-20 Thread Fridrich Strba
offapi/com/sun/star/text/textfield/Annotation.idl |5 + sw/inc/docufld.hxx|7 +- sw/qa/core/swdoc-test.cxx |2 sw/source/core/crsr/bookmrk.cxx | 37 sw/source/core/doc/docbm.cxx

[Libreoffice-commits] .: Branch 'feature/mork' - connectivity/Library_mork.mk connectivity/source

2012-07-20 Thread Fridrich Strba
connectivity/Library_mork.mk|3 connectivity/source/drivers/mork/MorkDriver.cxx | 243 ++ connectivity/source/drivers/mork/MorkDriver.hxx | 58 ++ connectivity/source/drivers/mork/MorkParser.cxx | 578 connectivity/source/drivers/mork/M

Re: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import

2012-07-20 Thread Kohei Yoshida
On 07/19/2012 12:31 PM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf that fixes https://bugs.freedesktop.org/show_bug.cgi?id=52205 I reviewed and tested several csv files a

[Libreoffice-commits] .: 5 commits - offapi/com sw/inc sw/qa sw/source xmloff/inc xmloff/source

2012-07-20 Thread Miklos Vajna
offapi/com/sun/star/text/textfield/Annotation.idl |5 + sw/inc/docufld.hxx|7 +- sw/qa/core/swdoc-test.cxx |2 sw/source/core/crsr/bookmrk.cxx | 37 sw/source/core/doc/docbm.cxx

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-07-20 Thread Kohei Yoshida
sc/source/ui/docshell/impex.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6945d1eb7666f90b6b356f97d368c87664c77d88 Author: Eike Rathke Date: Thu Jul 19 18:10:49 2012 +0200 resolved fdo#52205 do not force all text cells in CSV import Do not set S

[Libreoffice-commits] .: Branch 'feature/mork' - 2 commits - config_host.mk.in configure.in mysqlcppconn/mysql_config.pmk solenv/gbuild solenv/inc

2012-07-20 Thread Fridrich Strba
config_host.mk.in |1 - configure.in |7 ++- mysqlcppconn/mysql_config.pmk |6 -- solenv/gbuild/JavaClassSet.mk |3 ++- solenv/inc/settings.mk|2 -- 5 files changed, 4 insertions(+), 15 deletions(-) New commits: commit 992fa41939d6c

[Libreoffice-commits] .: Branch 'feature/mork' - 4 commits - connectivity/Library_mork.mk connectivity/Module_connectivity.mk connectivity/source Repository.mk

2012-07-20 Thread Fridrich Strba
Repository.mk |1 connectivity/Library_mork.mk| 28 ++ connectivity/Module_connectivity.mk |1 connectivity/source/drivers/mork/driver.cxx | 243 connectivity/source/drivers/mork/driver.hxx

[Libreoffice-commits] .: Branch 'libreoffice-3-6-0' - writerfilter/source

2012-07-20 Thread Norbert Thiebaud
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 74 +++--- 1 file changed, 40 insertions(+), 34 deletions(-) New commits: commit 7002d8eadad748486765c2f00d3aed0f9652b987 Author: Caolán McNamara Date: Thu Jul 19 23:34:18 2012 +0100 Resolves: fdo#51772 failure to impo

Re: Revert of hrc cleanup

2012-07-20 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Special attention to translatable resources if there is any in the batch. My recent master build lost some localized string in the navigator. Not lethal, though. Em 20-07-2012 09:24, Thomas Arnhold escreveu: > Ok. To be absolutely sure I bring all my

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - mysqlcppconn/mysql_config.pmk

2012-07-20 Thread Michael Stahl
mysqlcppconn/mysql_config.pmk |6 -- 1 file changed, 6 deletions(-) New commits: commit aeb97e51b05e1dfd6d535704a115213809c707fc Author: Lionel Elie Mamane Date: Fri Jul 20 14:17:54 2012 +0200 fdo#52275: Revert "mysqlcppconn: work around weird gcc issue" This reverts comm

Re: Revert of hrc cleanup

2012-07-20 Thread Thomas Arnhold
Hi Eike, On 07/19/2012 09:29 PM, Eike Rathke wrote: Some values are used as results of calculations, for example for the specific case of the Navigator (SCSTR_CONTENT_GRAPHIC, ...) the resources are obtained in a loop based on SCSTR_CONTENT_ROOT, see sc/source/ui/navipi/content.cxx ScContentTree

[Libreoffice-commits] .: mysqlcppconn/mysql_config.pmk

2012-07-20 Thread Michael Stahl
mysqlcppconn/mysql_config.pmk |6 -- 1 file changed, 6 deletions(-) New commits: commit 9931d736edfedb9b82a270d754f1ee8a2b134ec7 Author: Michael Stahl Date: Fri Jul 20 14:17:54 2012 +0200 fdo#52275: Revert "mysqlcppconn: work around weird gcc issue" This reverts commit d3

[Libreoffice-commits] .: config_host.mk.in configure.in solenv/gbuild solenv/inc

2012-07-20 Thread Stephan Bergmann
config_host.mk.in |1 - configure.in |7 ++- solenv/gbuild/JavaClassSet.mk |3 ++- solenv/inc/settings.mk|2 -- 4 files changed, 4 insertions(+), 9 deletions(-) New commits: commit 1e0971c3dd8bb303176f058bcd53682de9241616 Author: Stephan Be

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-07-20 Thread Miklos Vajna
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 74 +++--- 1 file changed, 40 insertions(+), 34 deletions(-) New commits: commit 5586159e46d5f38e322c88459e1e7beed8133161 Author: Caolán McNamara Date: Thu Jul 19 23:34:18 2012 +0100 Resolves: fdo#51772 failure to impo

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch mdds/makefile.mk

2012-07-20 Thread Daniel Bankston
mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch | 52 ++ mdds/makefile.mk |5 2 files changed, 56 insertions(+), 1 deletion(-) New commits: commit ee1e3004506083a86b6bf9c3dabd21427cf8e935 Author: David Tardon

fdo#32773 LibO thinks comments separate words

2012-07-20 Thread Gerrit
>From Muhammad Haggag : Muhammad Haggag has abandoned this change. Change subject: fdo#32773 LibO thinks comments separate words .. Patch Set 1: Abandoned Change is obsolete following http://cgit.freedesktop.org/libreoffice/c

Re: [PATCH] Change in core[libreoffice-3-6-0]: fdo#38056: ODF import: fix page style attributes:

2012-07-20 Thread Michael Stahl
On 20/07/12 12:34, Miklos Vajna wrote: > On Fri, Jul 20, 2012 at 10:12:58AM +, Gerrit > wrote: >> Hello Miklos Vajna, >> >> I'd like you to do a code review. Please visit > > Now this is really confusing; I already signed off this patch, so I > should not do a code review this time. ;-) i

[Libreoffice-commits] .: Branch 'feature/mork' - 3 commits - idlc/README Repository.mk sc/source tubes/inc tubes/source

2012-07-20 Thread Fridrich Strba
Repository.mk|1 idlc/README |2 - sc/source/ui/collab/contacts.cxx |9 +++ sc/source/ui/collab/sendfunc.cxx | 28 --- sc/source/ui/collab/sendfunc.hxx |3 +- sc/source/ui/docshell/docsh.cxx |2 + tubes/inc/tu

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-07-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 50679, which changed state. Bug 50679 Summary: EDITING: Copying cell(s) with conditional formatting CRASH when paste https://bugs.freedesktop.org/show_bug.cgi?id=50679 What|Old Value |Ne

[Libreoffice-commits] .: 3 commits - idlc/README Repository.mk sc/source tubes/inc tubes/source

2012-07-20 Thread Matus Kukan
Repository.mk|1 idlc/README |2 - sc/source/ui/collab/contacts.cxx |9 +++ sc/source/ui/collab/sendfunc.cxx | 28 --- sc/source/ui/collab/sendfunc.hxx |3 +- sc/source/ui/docshell/docsh.cxx |2 + tubes/inc/tu

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-07-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 50679, which changed state. Bug 50679 Summary: EDITING: Copying cell(s) with conditional formatting CRASH when paste https://bugs.freedesktop.org/show_bug.cgi?id=50679 What|Old Value |Ne

Re: [PATCH] Change in core[libreoffice-3-6-0]: fdo#38056: ODF import: fix page style attributes:

2012-07-20 Thread Miklos Vajna
On Fri, Jul 20, 2012 at 10:12:58AM +, Gerrit wrote: > Hello Miklos Vajna, > > I'd like you to do a code review. Please visit Now this is really confusing; I already signed off this patch, so I should not do a code review this time. ;-) ___ LibreO

Change in core[libreoffice-3-5]: fdo#48335 two RTF export fixes

2012-07-20 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has abandoned this change. Change subject: fdo#48335 two RTF export fixes .. Patch Set 1: Abandoned already in -3-5 -- To view, visit https://gerrit.libreoffice.org/332 To unsubscribe, visit

Change in core[libreoffice-3-5]: fdo#52066 fix RTF import of rectangle shape without text in ...

2012-07-20 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has abandoned this change. Change subject: fdo#52066 fix RTF import of rectangle shape without text in it .. Patch Set 1: Abandoned already in -3-5 -- To view, visit https://gerrit.libreoffic

Change in core[libreoffice-3-5]: fdo#46966 dmapper: fix headery/footery default value

2012-07-20 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has abandoned this change. Change subject: fdo#46966 dmapper: fix headery/footery default value .. Patch Set 1: Abandoned already in -3-5 -- To view, visit https://gerrit.libreoffice.org/331

[PATCH] Change in core[libreoffice-3-6-0]: fdo#38056: ODF import: fix page style attributes:

2012-07-20 Thread Gerrit
>From Michael Stahl : Hello Miklos Vajna, I'd like you to do a code review. Please visit https://gerrit.libreoffice.org/335 to review the following change. Change subject: fdo#38056: ODF import: fix page style attributes: ...

[REVIEW 3.5.6] Cherry pick straightforward patch

2012-07-20 Thread julien2412
Hi, fdo#5 FILEOPEN: CRASH by opening .docx file can be "workarounded" by the commit dfe0baa281d9d4701e9b3846880334213ccb05f5 As David Tardon said on https://bugs.freedesktop.org/show_bug.cgi?id=5#c7, it doesn't solve the problem. Is it ok for the cherry-pick (perhaps with FIXME comment ?

[Libreoffice-commits] Changes to 'feature/mork'

2012-07-20 Thread Fridrich Strba
New branch 'feature/mork' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: desktop/source

2012-07-20 Thread Stephan Bergmann
desktop/source/deployment/registry/dp_backend.cxx | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) New commits: commit 06f20d73da21342046a480a6b22af69901351328 Author: Stephan Bergmann Date: Fri Jul 20 11:10:05 2012 +0200 Fix SAL_LOG area usage Change-Id: If8acc

[PATCH] fdo#52293: Spelling error (UI, Localization)

2012-07-20 Thread Kevin Peng
Hi all, This patch [aims to] fix the aforementioned bug. Kevin -- Kevin Peng kpeng...@fastmail.fm -- http://www.fastmail.fm - Send your email first class 0001-Changed-discreet-to-discrete.patch Description: Binary data ___ LibreOffice mailing li

Re: make check with DEBUGCCPUNIT=TRUE is waiting for console output

2012-07-20 Thread Noel Grandin
Ping? Anybody have any ideas? This is driving me nuts during my testing. On 2012-07-11 13:25, Noel Grandin wrote: OK, I'm closer to figuring this one out. When I do this: $ DEBUGCPPUNIT=TRUE make -s check gdb executes the unit tests, but then, if everything went OK, GDB __doesn't quit__ I

Re: C++11 in LibreOffice

2012-07-20 Thread Michael Meeks
Hi there, On Thu, 2012-07-19 at 11:21 -0500, Yi Ding wrote: > +1 ... > +1 ... > +1 ... Thanks for your encouragement, but this is a developers list :-) which of these do you want to work on ? There is low-hanging fruit everywhere for developers to focus on - which would you like to look i

[Libreoffice-commits] .: mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch mdds/makefile.mk

2012-07-20 Thread David Tardon
mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch | 52 ++ mdds/makefile.mk |5 2 files changed, 56 insertions(+), 1 deletion(-) New commits: commit 42c58d9ce4f33b047feb1e94e60f165360d96209 Author: David Tardon

Re: [GSOC-UPDATE](19.07) Impress Remote

2012-07-20 Thread Michael Meeks
On Thu, 2012-07-19 at 19:00 +0200, Andrzej J. R. Hunt wrote: > I made some good progress today: Great work, hopefully the frustration turned into a deeper understanding & appreciation for valgrind / lifecycle etc. ? :-) > This means that tomorrow I should be able to start work on the var

[Libreoffice-commits] .: pyuno/source

2012-07-20 Thread Stephan Bergmann
pyuno/source/module/pyuno_runtime.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 618376bcb55906913bc76365d7db9b71eb422daa Author: Stephan Bergmann Date: Fri Jul 20 10:32:47 2012 +0200 warning C4702: unreachable code Change-Id: Ie2cc83dde7e0522e0bf669a1dd3d7a8ca

[Libreoffice-commits] .: jvmaccess/util jvmfwk/plugins jvmfwk/source registry/util store/util

2012-07-20 Thread Stephan Bergmann
jvmaccess/util/gcc3.map |9 + jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.map | 31 jvmfwk/source/framework.map |9 + registry/util/reg.map |9 + store/util/store.ma

Re: [PATCH] cleaning before = assignment lotuswordpro/source/filter/xfilter/xfparastyle.cxx

2012-07-20 Thread Stephan Bergmann
On 07/19/2012 11:03 PM, julien2412 wrote: Thank you David for the hint! I re read the "An in-depth explanation" part of http://stackoverflow.com/questions/3279543/what-is-the-copy-and-swap-idiom/3279550#3279550, it's great ! I understood when and above all how the memory is cleaned. About your m

[Libreoffice-commits] .: 2 commits - extensions/source

2012-07-20 Thread David Tardon
extensions/source/config/ldap/ldapaccess.cxx | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) New commits: commit 0d56e73df7decc32f45d375ec8cc9940f8d249f4 Author: David Tardon Date: Fri Jul 20 09:37:27 2012 +0200 WaE: invalid conversion from 'PWCHAR' to 'const sal_Unicod

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - xmloff/source

2012-07-20 Thread Miklos Vajna
xmloff/source/style/PageMasterImportPropMapper.cxx | 51 + 1 file changed, 51 insertions(+) New commits: commit bb406ff1ce016c96cc735e0c20ae51f7dac235b5 Author: Michael Stahl Date: Thu Jul 19 12:12:14 2012 +0200 fdo#38056: ODF import: fix page style attributes:

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - xmloff/source

2012-07-20 Thread Miklos Vajna
xmloff/source/style/PageMasterImportPropMapper.cxx | 51 + 1 file changed, 51 insertions(+) New commits: commit 6a05f22cd3253ae5c45495d0c081e1f44a3ff756 Author: Michael Stahl Date: Thu Jul 19 12:12:14 2012 +0200 fdo#38056: ODF import: fix page style attributes:

<    1   2