HardHacks

2012-08-24 Thread Rainer Bielefeld
Hi all, it seems FDO ate my first mail to libo-qa and libo mailing lists? Here is the list of bugs we selected during QA Call from a long list: ID OS Component - Summary 38913 Linux Libreoffice - CRASH when loadi

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Rainer Bielefeld changed: What|Removed |Added Depends on||54018 --- Comment #93 from Rainer Bie

[Libreoffice-commits] .: sal/qa

2012-08-24 Thread Libreoffice Gerrit user
sal/qa/rtl/uuid/rtl_Uuid.cxx | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) New commits: commit 5e7249f9958aeb0407e8502b500d6865e5af8750 Author: Kohei Yoshida Date: Sat Aug 25 00:23:33 2012 -0400 Perhaps this will fix the windows build? Change-Id: Ia57ab6bfa9

[GSoC] testing - The Summation

2012-08-24 Thread Artur Dorda
Hello everybody, It's the end of the official GSoC part and the time to say a few words about my impressions, and the rest. I am... lucky and I had a great pleasure, being able to work on LibreOffice during this year's Google Summer of Code. The experience, which was truly priceless. I think the

[PUSHED] fdo#39625 Make existing cppunittests work

2012-08-24 Thread Gerrit
>From Kohei Yoshida : Kohei Yoshida has submitted this change and it was merged. Change subject: fdo#39625 Make existing cppunittests work .. fdo#39625 Make existing cppunittests work Make rtl uuid cppunit work - removed call

[Libreoffice-commits] .: sal/CppunitTest_sal_rtl_uuid.mk sal/Module_sal.mk sal/qa

2012-08-24 Thread Libreoffice Gerrit user
sal/CppunitTest_sal_rtl_uuid.mk | 27 +++ sal/Module_sal.mk |1 sal/qa/rtl/uuid/makefile.mk | 68 sal/qa/rtl/uuid/rtl_Uuid.cxx| 13 +-- 4 files changed, 37 insertions(+), 72 deletions(-) New commits: commit

[PUSHED] removed commented out code in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Kohei Yoshida : Kohei Yoshida has submitted this change and it was merged. Change subject: removed commented out code in sc/source/ui/undo .. removed commented out code in sc/source/ui/undo This is a follow-up patch of 0

[Libreoffice-commits] .: sc/source

2012-08-24 Thread Libreoffice Gerrit user
sc/source/ui/undo/undoblk.cxx |1 - sc/source/ui/undo/undoblk3.cxx |4 sc/source/ui/undo/undodat.cxx |9 - sc/source/ui/undo/undotab.cxx |2 +- 4 files changed, 1 insertion(+), 15 deletions(-) New commits: commit 9d6eedf05b550ca3d6f98dc9f77c06a3594165c4 Author: Phi

[PUSHED] remove ascii-art and blank lines in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Kohei Yoshida : Kohei Yoshida has submitted this change and it was merged. Change subject: remove ascii-art and blank lines in sc/source/ui/undo .. remove ascii-art and blank lines in sc/source/ui/undo This is a follow-u

[Libreoffice-commits] .: sc/source

2012-08-24 Thread Libreoffice Gerrit user
sc/source/ui/undo/refundo.cxx |5 sc/source/ui/undo/undobase.cxx | 12 - sc/source/ui/undo/undoblk.cxx | 17 -- sc/source/ui/undo/undoblk2.cxx |6 sc/source/ui/undo/undoblk3.cxx | 301 - sc/source/ui/undo/undocell.cxx | 21 -- sc/source/ui

[PATCH] worked on comments in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Philipp Riemer : Philipp Riemer has uploaded a new change for review. Change subject: worked on comments in sc/source/ui/undo .. worked on comments in sc/source/ui/undo - re-indented some - removed exclamation marks - dro

[PATCH] removed commented out code in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Philipp Riemer : Philipp Riemer has uploaded a new change for review. Change subject: removed commented out code in sc/source/ui/undo .. removed commented out code in sc/source/ui/undo This is a follow-up patch of 06f6112

[PATCH] remove ascii-art and blank lines in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Philipp Riemer : Philipp Riemer has uploaded a new change for review. Change subject: remove ascii-art and blank lines in sc/source/ui/undo .. remove ascii-art and blank lines in sc/source/ui/undo This is a follow-up patc

[PATCH] fixed method header indentation in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Philipp Riemer : Philipp Riemer has uploaded a new change for review. Change subject: fixed method header indentation in sc/source/ui/undo .. fixed method header indentation in sc/source/ui/undo This is a follow-up patch

[PATCH] Correction of translation in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Albert Thuswaldner : Albert Thuswaldner has uploaded a new change for review. Change subject: Correction of translation in sc/source/ui/undo .. Correction of translation in sc/source/ui/undo Change-Id: Ia749ec1e9a34e364bb

[Libreoffice-commits] .: sc/source

2012-08-24 Thread Libreoffice Gerrit user
sc/source/ui/undo/refundo.cxx |2 - sc/source/ui/undo/undobase.cxx | 14 ++-- sc/source/ui/undo/undoblk.cxx | 45 +++-- sc/source/ui/undo/undoblk2.cxx |4 +-- sc/source/ui/undo/undoblk3.cxx | 30 +-- sc/source/ui/u

Re: [Libreoffice] [GSoC 2012][svg export filter] final result

2012-08-24 Thread Thorsten Behrens
Marco Cecchetti wrote: > I have just learned to have successfully passed the final GSoC > evaluation [...] > Hi Marco, it is well-deserved. We thank you for this wonderful feature - congrats to another successful GSoC term! Cheers, -- Thorsten pgp6aDE9SNWe8.pgp Description: PGP signature

[PATCH] Change in core[libreoffice-3-5]: fdo#49901: SwView::ExecSearch: fix Replace All cursor:

2012-08-24 Thread Gerrit
>From Michael Stahl : Michael Stahl has uploaded a new change for review. Change subject: fdo#49901: SwView::ExecSearch: fix Replace All cursor: .. fdo#49901: SwView::ExecSearch: fix Replace All cursor: Because the "fix" for i#

[PATCH] Change in core[libreoffice-3-6]: fdo#49901: SwView::ExecSearch: fix Replace All cursor:

2012-08-24 Thread Gerrit
>From Michael Stahl : Michael Stahl has uploaded a new change for review. Change subject: fdo#49901: SwView::ExecSearch: fix Replace All cursor: .. fdo#49901: SwView::ExecSearch: fix Replace All cursor: Because the "fix" for i#

[Libreoffice-commits] .: 4 commits - solenv/gdb sw/source

2012-08-24 Thread Libreoffice Gerrit user
solenv/gdb/libreoffice/sw.py |6 sw/source/core/txtnode/ndhints.cxx | 38 +- sw/source/ui/uiview/viewsrch.cxx | 46 ++--- 3 files changed, 51 insertions(+), 39 deletions(-) New commits: commit aad3cc3db08c40e62ce2d7f

[Libreoffice] [GSoC 2012][svg export filter] final result

2012-08-24 Thread Marco Cecchetti
Hi all, I have just learned to have successfully passed the final GSoC evaluation, I'd like to thanks Thorsten and all the community for your help and support. As I've already said in a previous mail, I'll go on fixing and improving the svg text export implementation in my spare time, I'm sure t

[PATCH] sax: com.sun.star.xml.sax.FastSerializer seems to be unused

2012-08-24 Thread Gerrit
>From Matúš Kukan : Matúš Kukan has uploaded a new change for review. Change subject: sax: com.sun.star.xml.sax.FastSerializer seems to be unused .. sax: com.sun.star.xml.sax.FastSerializer seems to be unused Change-Id: I826da0

[PUSHED] Translation of comments from german in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Eike Rathke : Eike Rathke has submitted this change and it was merged. Change subject: Translation of comments from german in sc/source/ui/undo .. Translation of comments from german in sc/source/ui/undo Change-Id: Ic7f2

Re: [ANN] LibreOffice 3.6.1 RC2 test builds available for smoketesting

2012-08-24 Thread Jan Holesovsky
Hi QA guys, Thorsten Behrens píše v Pá 24. 08. 2012 v 17:11 +0200: > If you've a bit of time, please give them a try & report *critical* > bugs not yet in bugzilla here, so we can incorporate them into the > release notes. Please note that it takes approximately 24 hours to > populate the mirrors

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread John Smith
On Fri, Aug 24, 2012 at 10:07 PM, Philipp Riemer wrote: > > As far as I learned in my Softw. Eng. courses, the main intent of this > type of code coverage is _not_ to show which parts are under test but > primarily to point out which parts are not tested at all so far. > Yes, of course. > > And

(24.08) Impress Remote Update

2012-08-24 Thread Andrzej J. R. Hunt
Hi everyone, Unfortunately my bluetooth dongle didn't materialise, so instead I worked on storage of authenticated servers: I'm still figuring out how settings storage in LO works -- I spent the large part of the day getting the storage working -- it also took quite some time to realise that

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread Philipp Riemer
2012/8/24 John Smith : > On Fri, Aug 24, 2012 at 5:28 PM, Stephan Bergmann wrote: >> In a sense, even during the tests, very much of our code is executed "by >> accident" rather than due to dedicated test code calling it: Especially the >> subsequentcheck stuff contains checks that are not simple

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 36149, which changed state. Bug 36149 Summary: CRASH hovering over Menu "File > Send" if no JRE is available and MediaWiki Publisher installed https://bugs.freedesktop.org/show_bug.cgi?id=36149 What|Old V

Re: [FIXED] Re: master regression: PPT load ...

2012-08-24 Thread bfo
Michael Meeks-2 wrote > > it should be fixed in the next build iteration. > Hi. Checked with: LO 3.7.0.0.alpha0+ Build ID: 6737f12 Windows XP Professional SP3 Could not reproduce. All good. Best regards. -- View this message in context: http://nabble.documentfoundation.org/master-regressi

[PATCH] Translation of comments from german in sc/source/ui/undo

2012-08-24 Thread Gerrit
>From Albert Thuswaldner : Albert Thuswaldner has uploaded a new change for review. Change subject: Translation of comments from german in sc/source/ui/undo .. Translation of comments from german in sc/source/ui/undo Change-Id:

[Libreoffice-commits] .: chart2/source

2012-08-24 Thread Libreoffice Gerrit user
chart2/source/tools/DataSourceHelper.cxx | 12 1 file changed, 12 insertions(+) New commits: commit a581d31b227623e09d2970a91214fda398f98eda Author: Rafael Dominguez Date: Fri Aug 24 12:30:38 2012 -0430 Highlight X errorbars data range when a chart is selected. Cha

[Libreoffice-commits] .: 3 commits - configure.in desktop/inc desktop/source

2012-08-24 Thread Libreoffice Gerrit user
configure.in | 16 +++- desktop/inc/app.hxx|4 desktop/source/deployment/misc/dp_misc.cxx |6 +++--- 3 files changed, 10 insertions(+), 16 deletions(-) New commits: commit 2198fc2711bfb3e1025517f2d61ec8ae7d424c20 Aut

Re: [PUSHED] [PATCH] Object Catalog in Dialog Editor

2012-08-24 Thread Noel Power
Bah, I meant to reply to this but got hung up with something else and forgot On 21/08/12 17:33, János Uray wrote: the Layout class has some virtual methods with no implementation, this sounds like these need to be pure virtual making Layout an abstract class ( which makes sense ) Whe

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread John Smith
On Fri, Aug 24, 2012 at 5:28 PM, Stephan Bergmann wrote: > On 08/19/2012 09:14 PM, John Smith wrote: >> >> - First you run a plain make in the top level directory to build LO >> (with analysis stuff enabled). >> - then you create a 'baseline' with lcov (sort of create a 'before >> snapshot' of LO)

[Libreoffice-commits] .: clucene/UnpackedTarball_clucene.mk config_host.mk.in configure.in ooo.lst.in

2012-08-24 Thread Libreoffice Gerrit user
clucene/UnpackedTarball_clucene.mk |2 +- config_host.mk.in |1 + configure.in |2 ++ ooo.lst.in |2 +- 4 files changed, 5 insertions(+), 2 deletions(-) New commits: commit d7a5df7e3dea928a2748d6eae9e7263cd23e76fd Auth

Re: [GSOC] Calc Performance Project End

2012-08-24 Thread Markus Mohrhard
Hey Daniel, 2012/8/21 Daniel Bankston : > I will be a better student and software development > professional because of my work on LibreOffice this summer. I hope that > LibreOffice is a little better because of my work. It is. You did an amazing work this summer and I hope that we can see some

[Libreoffice-commits] .: sc/inc sc/source

2012-08-24 Thread Libreoffice Gerrit user
sc/inc/cell.hxx |4 ++-- sc/inc/document.hxx |6 -- sc/source/core/data/cell.cxx | 11 ++- sc/source/core/data/documen4.cxx |5 +++-- sc/source/core/data/documen7.cxx |5 +++-- sc/source/filter/xml/xmlsubti.cxx |2 +- sc/sour

Announcing LibreOffice HardHacks!

2012-08-24 Thread Rainer Bielefeld
Hi all, and here is the list of bugs we selected during QA Call from a long list: ID OS Component - Summary 38913 Linux Libreoffice - CRASH when loading Danish dictionary at startup citing msvcr90.

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread Stephan Bergmann
On 08/19/2012 09:14 PM, John Smith wrote: - First you run a plain make in the top level directory to build LO (with analysis stuff enabled). - then you create a 'baseline' with lcov (sort of create a 'before snapshot' of LO) - *then* you run all your tests (whatever they may be) - then you re-run

[Libreoffice-commits] .: 2 commits - cppuhelper/source desktop/inc desktop/source offapi/com

2012-08-24 Thread Libreoffice Gerrit user
cppuhelper/source/defaultbootstrap.cxx | 26 - desktop/inc/app.hxx|1 desktop/source/app/app.cxx | 219 +++-- desktop/source/app/check_ext_deps.cxx | 38 +- desktop/so

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread Stephan Bergmann
On 08/24/2012 12:41 PM, John Smith wrote: I did have one test fail. See the 'make check failure' thread: http://nabble.documentfoundation.org/make-check-failure-td4002979.html Could that explain the omission ? of course it could, i wasn't connecting those threads :) Thats good. Well then at l

[ANN] LibreOffice 3.6.1 RC2 test builds available for smoketesting

2012-08-24 Thread Thorsten Behrens
Hi *, for 3.6.1 RC2, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try & report *critical* bugs not yet

Re: No output from ./autogen.sh --help and other getting started issues (Ubuntu)

2012-08-24 Thread Stephan Bergmann
On 08/24/2012 11:47 AM, B.J. Herbison wrote: Issue 3: The Libux dependency page says "Get upstream Junit at ...". OK, I got the file, what do I do now? I presume it needs to go somewhere other than my downloads directory. Call autogen.sh with --with-junit= (the default --with-junit=yes look

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Roman Eisele changed: What|Removed |Added Depends on|52028 | -- Configure bugmail: https://bugs.free

[Libreoffice-commits] .: dictionaries/ru_RU

2012-08-24 Thread Libreoffice Gerrit user
dictionaries/ru_RU/README_ru_RU.txt | 10 ++ dictionaries/ru_RU/ru_RU.aff|1 + 2 files changed, 11 insertions(+) New commits: commit f795b16970b65e977eb8ffc3fa33d94dd8e1e75b Author: László Németh Date: Fri Aug 24 16:37:16 2012 +0200 fdo#35001 (add TRY for better s

[Libreoffice-commits] .: configure.in

2012-08-24 Thread Libreoffice Gerrit user
configure.in |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 628aad2aec5e33dcf00b573891c122ad91438bc4 Author: Norbert Thiebaud Date: Fri Aug 24 09:21:10 2012 -0500 restore the 'initialization of warn' Change-Id: I72ed0955bf6d47e04be7c182994ba12

Re: autogen.sh error on no warnings

2012-08-24 Thread Norbert Thiebaud
On Fri, Aug 24, 2012 at 9:02 AM, Ruslan Kabatsayev wrote: > Hi Norbert, > > Your fix is not solving all the problem: now autogen fails without > indication why. See the message: > >>If you want to run the smoketest, issue: >>make check >> >>Error running configure at ./autogen.sh line 187. > This

Re: autogen.sh error on no warnings

2012-08-24 Thread Ruslan Kabatsayev
Well, in fact, testing for presence of warn in a way I suggested won't work, so either ||true should be used, or exit 0 at the end On Fri, Aug 24, 2012 at 6:02 PM, Ruslan Kabatsayev wrote: > Hi Norbert, > > Your fix is not solving all the problem: now autogen fails without > indication why. See t

[PUSHED] Change in core[libreoffice-3-6]: Use correct intro bitmap, as passed to configure

2012-08-24 Thread Gerrit
>From Miklos Vajna : Miklos Vajna has submitted this change and it was merged. Change subject: Use correct intro bitmap, as passed to configure .. Use correct intro bitmap, as passed to configure Fix typo that had intro bitmap

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - config_host.mk.in

2012-08-24 Thread Libreoffice Gerrit user
config_host.mk.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4ba96f77df9c3e04c674a655807e1686670da5f1 Author: Thorsten Behrens Date: Fri Aug 24 14:45:41 2012 +0200 Use correct intro bitmap, as passed to configure Fix typo that had intro bitmap al

[PUSHED] Change in core[libreoffice-3-6]: fdo#49441: don't overwrite the first element in the sequence

2012-08-24 Thread Gerrit
>From Eike Rathke : Eike Rathke has submitted this change and it was merged. Change subject: fdo#49441: don't overwrite the first element in the sequence .. fdo#49441: don't overwrite the first element in the sequence regressi

Re: autogen.sh error on no warnings

2012-08-24 Thread Ruslan Kabatsayev
Hi Norbert, Your fix is not solving all the problem: now autogen fails without indication why. See the message: >If you want to run the smoketest, issue: >make check > >Error running configure at ./autogen.sh line 187. This is because you redirect error to /dev/null, but don't prevent cat error s

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - fpicker/source

2012-08-24 Thread Libreoffice Gerrit user
fpicker/source/office/OfficeFilePicker.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 500b4069b66aa897d3ec2a3015d8e061680a8d66 Author: Ivan Timofeev Date: Fri Aug 24 16:25:02 2012 +0400 fdo#49441: don't overwrite the first element in the sequence

[PATCH] Change in core[libreoffice-3-6]: Use correct intro bitmap, as passed to configure

2012-08-24 Thread Gerrit
>From Thorsten Behrens : Thorsten Behrens has uploaded a new change for review. Change subject: Use correct intro bitmap, as passed to configure .. Use correct intro bitmap, as passed to configure Fix typo that had intro bitmap

Re: autogen.sh error on no warnings

2012-08-24 Thread Norbert Thiebaud
On Fri, Aug 24, 2012 at 7:34 AM, Ruslan Kabatsayev wrote: > Hello, > > When I have no warnings from configure script, I get an error from > "cat warn" line saying "No such file or directory". I guess "cat warn" > should be changed to something like "[ -e warn ] && cat warn", or warn > should be cr

[Libreoffice-commits] .: configure.in

2012-08-24 Thread Libreoffice Gerrit user
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b5077b293b945edfcd84b6911a2c1b9cb234a129 Author: Norbert Thiebaud Date: Fri Aug 24 08:45:23 2012 -0500 be quiet if there is no 'warn' file Change-Id: I44ce29c41c914c57e5c0e4036e327447efb5b26

Re: 'make check' failure

2012-08-24 Thread Stephan Bergmann
On 08/24/2012 11:55 AM, John Smith wrote: On Fri, Aug 24, 2012 at 10:46 AM, Stephan Bergmann wrote: The unoapi tests involving anything related to accessibility have historically been very fragile (things like expecting a certain GUI element has focus at a certain moment, which can fail as soon

[Libreoffice-commits] .: solenv/bin

2012-08-24 Thread Libreoffice Gerrit user
solenv/bin/concat-deps.c |1 - 1 file changed, 1 deletion(-) New commits: commit 9c907513be0f30d47d7fc61bf537677c63e19ba1 Author: Tor Lillqvist Date: Fri Aug 24 15:53:17 2012 +0300 Remove debugging output Change-Id: Ibd80b49eba4b259027d57845b8ebba3e35908e82 diff --git a/sole

[Libreoffice-commits] .: config_host.mk.in

2012-08-24 Thread Libreoffice Gerrit user
config_host.mk.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 14a4096a76cbe05d364f013d183c1d001849a97e Author: Thorsten Behrens Date: Fri Aug 24 14:45:41 2012 +0200 Use correct intro bitmap, as passed to configure Fix typo that had intro bitmap al

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/source

2012-08-24 Thread Libreoffice Gerrit user
vcl/inc/vcl/layout.hxx|7 ++ vcl/source/window/dialog.cxx |4 - vcl/source/window/layout.cxx | 105 -- vcl/source/window/tabpage.cxx |6 +- 4 files changed, 64 insertions(+), 58 deletions(-) New commits: commit 0cfefc22cef81d664867916

[PATCH] Change in core[libreoffice-3-6]: fdo#49441: don't overwrite the first element in the sequence

2012-08-24 Thread Gerrit
>From Ivan Timofeev : Ivan Timofeev has uploaded a new change for review. Change subject: fdo#49441: don't overwrite the first element in the sequence .. fdo#49441: don't overwrite the first element in the sequence regression f

autogen.sh error on no warnings

2012-08-24 Thread Ruslan Kabatsayev
Hello, When I have no warnings from configure script, I get an error from "cat warn" line saying "No such file or directory". I guess "cat warn" should be changed to something like "[ -e warn ] && cat warn", or warn should be created at the beginning of configure. CCing Norbert Thiebaud as git-bla

[Libreoffice-commits] .: fpicker/source

2012-08-24 Thread Libreoffice Gerrit user
fpicker/source/office/OfficeFilePicker.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cb0aa85747fa6ada9a7dc4b32e5c5bf3d3850f35 Author: Ivan Timofeev Date: Fri Aug 24 16:25:02 2012 +0400 fdo#49441: don't overwrite the first element in the sequence

[Libreoffice-commits] .: solenv/gbuild

2012-08-24 Thread Libreoffice Gerrit user
solenv/gbuild/AllLangZip.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e19be74ff56422ba908a4e7a70dccda6a94c7026 Author: David Tardon Date: Fri Aug 24 14:11:42 2012 +0200 build for en-US if no langs are specified Change-Id: I21323d275f8381ecffa937

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread John Smith
On Thu, Aug 23, 2012 at 8:41 PM, Michael Stahl wrote: > On 23/08/12 18:09, John Smith wrote: >> Hi, >> >> >> I just finished a first full run of lcov. There was one 'make check' >> failure though, and there were a lot of 'warnings' running lcov that >> may need some further investigation. Also, th

[Libreoffice-commits] .: solenv/gbuild

2012-08-24 Thread Libreoffice Gerrit user
solenv/gbuild/UnpackedTarball.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 4b00567f578190fe2d0413cb25538f518c439b66 Author: David Tardon Date: Fri Aug 24 13:42:47 2012 +0200 it seems unzip on MacOS X does not know this opt Change-Id: I48d86df772655229a08653e6c8f

[Libreoffice-commits] .: l10ntools/source xmlhelp/source

2012-08-24 Thread Libreoffice Gerrit user
l10ntools/source/help/LuceneHelper.hxx|8 xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx |6 ++ 2 files changed, 14 insertions(+) New commits: commit 715e2109f60b016f661d98a59aef674e0951a2ad Author: Caolán McNamara Date: Fri Aug 24 11:01:51 2012 +01

Re: gbuild support for external projects

2012-08-24 Thread David Tardon
On Tue, Aug 21, 2012 at 09:00:45AM +0200, David Tardon wrote: > Hi all, > > I have created a new gbuild class UnpackedTarball that handles preparing > sources for external project: unpacking, patching and a bit more > (required by clucene). It is based on the custom target from module > clucene, w

[Libreoffice-commits] .: extras/Package_newfiles.mk

2012-08-24 Thread Libreoffice Gerrit user
extras/Package_newfiles.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 768d02c93c51fb606cf7221d0fd7a0c9dd3e363d Author: David Tardon Date: Fri Aug 24 13:32:40 2012 +0200 soffice.html has been removed Change-Id: Id564b3a34524a754261211d15abaadbdb1898061 diff --git

Re: [REVIEW-3-6][REVIEW-3-5] fix for fdo#49255 FORMATTING: row height not preserved after FILESAVE and reopen

2012-08-24 Thread Noel Power
Hi Ivan On 24/08/12 11:54, Ivan Timofeev wrote: Hi Noel, On 24.08.2012 14:24, Noel Power wrote: please excuse my old school use of the mail-list, Looking at http://wiki.documentfoundation.org/Development/gerrit/SubmitPatch "Only the last line is special and will push all patches in your curre

Re: No output from ./autogen.sh --help and other getting started issues (Ubuntu)

2012-08-24 Thread B.J. Herbison
John Smith wrote > > On Fri, Aug 24, 2012 at 11:47 AM, B.J. Herbison wrote: >> $ ./autogen.sh --help > Im not sure, but arent you supposed to run './autogen.sh' without that > help flag, like you did there with '--help' ? So that it creates the > configure script for you ? > Thank you.

Re: Usage of memset to eradicate string content

2012-08-24 Thread Michael Stahl
On 24/08/12 12:53, Caolán McNamara wrote: > On Thu, 2012-08-23 at 21:00 +0200, Arnaud Versini wrote: >> Hi everyone, >> >> I noticed in the code some annihilation of O[U]String content by using >> memset or rtl_zeroMemory directly on the content as a password >> security. It breaks encapsulation an

[PATCH] Change in core[libreoffice-3-5]: SwPageBreakWin: memory leak

2012-08-24 Thread Gerrit
>From Ivan Timofeev : Ivan Timofeev has uploaded a new change for review. Change subject: SwPageBreakWin: memory leak .. SwPageBreakWin: memory leak Change-Id: Ibb543b8da8c89c7fa3799fada03c787dabe2b3cb (cherry picked from commi

[PATCH] Change in core[libreoffice-3-6]: SwPageBreakWin: memory leak

2012-08-24 Thread Gerrit
>From Ivan Timofeev : Ivan Timofeev has uploaded a new change for review. Change subject: SwPageBreakWin: memory leak .. SwPageBreakWin: memory leak Change-Id: Ibb543b8da8c89c7fa3799fada03c787dabe2b3cb (cherry picked from commi

Re: [REVIEW-3-6][REVIEW-3-5] fix for fdo#49255 FORMATTING: row height not preserved after FILESAVE and reopen

2012-08-24 Thread Ivan Timofeev
Hi Noel, On 24.08.2012 14:24, Noel Power wrote: please excuse my old school use of the mail-list, Looking at http://wiki.documentfoundation.org/Development/gerrit/SubmitPatch "Only the last line is special and will push all patches in your current branch to the review queue for the master bran

Re: Usage of memset to eradicate string content

2012-08-24 Thread Caolán McNamara
On Thu, 2012-08-23 at 21:00 +0200, Arnaud Versini wrote: > Hi everyone, > > I noticed in the code some annihilation of O[U]String content by using > memset or rtl_zeroMemory directly on the content as a password > security. It breaks encapsulation and the string immutability, not so > good. I thin

Re: No output from ./autogen.sh --help and other getting started issues (Ubuntu)

2012-08-24 Thread John Smith
On Fri, Aug 24, 2012 at 11:47 AM, B.J. Herbison wrote: > $ ./autogen.sh --help Im not sure, but arent you supposed to run './autogen.sh' without that help flag, like you did there with '--help' ? So that it creates the configure script for you ? Just my 2$ Regards, John Smith. _

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread John Smith
>> I did have one test fail. See the 'make check failure' thread: >> http://nabble.documentfoundation.org/make-check-failure-td4002979.html >> Could that explain the omission ? > > of course it could, i wasn't connecting those threads :) > Thats good. Well then at least that makes me fairly confide

[Libreoffice-commits] .: 2 commits - sfx2/source sw/source

2012-08-24 Thread Libreoffice Gerrit user
sfx2/source/control/thumbnailview.cxx |1 + sw/source/ui/docvw/PageBreakWin.cxx |1 + 2 files changed, 2 insertions(+) New commits: commit 5dc11d57f050c5e4c58843b18d76877c1005d067 Author: Ivan Timofeev Date: Fri Aug 24 14:35:10 2012 +0400 ThumbnailView: memory leak Chan

[Libreoffice-commits] .: Branch 'feature/svg-export' - filter/source

2012-08-24 Thread Libreoffice Gerrit user
filter/source/svg/presentation_engine.js | 14 - filter/source/svg/svgexport.cxx | 41 --- filter/source/svg/svgwriter.cxx | 381 --- 3 files changed, 262 insertions(+), 174 deletions(-) New commits: commit b42e10c2d8001f6fde3171f7b2d2f94367043b2

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread Michael Stahl
On 24/08/12 12:11, John Smith wrote: > On Thu, Aug 23, 2012 at 8:41 PM, Michael Stahl wrote: >> so looking at a few bits where i'm familiar with the tests tests like: >> >> http://dev-builds.libreoffice.org/lcov_reports/master~2012-08-22_09.11.23/sax/source/tools/converter.cxx.gcov.html >> >> it

[REVIEW-3-6][REVIEW-3-5] fix for fdo#49255 FORMATTING: row height not preserved after FILESAVE and reopen

2012-08-24 Thread Noel Power
please excuse my old school use of the mail-list, Looking at http://wiki.documentfoundation.org/Development/gerrit/SubmitPatch "Only the last line is special and will push all patches in your current branch to the review queue for the master branch (Adjust accordingly, if you want to submit a

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-24 Thread John Smith
On Thu, Aug 23, 2012 at 8:41 PM, Michael Stahl wrote: > On 23/08/12 18:09, John Smith wrote: >> Hi, >> >> >> I just finished a first full run of lcov. There was one 'make check' >> failure though, and there were a lot of 'warnings' running lcov that >> may need some further investigation. Also, th

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-08-24 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlimprt.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit e093e553185ed8beff83ef784f0ed5de95c2bc8f Author: Noel Power Date: Fri Aug 24 11:10:33 2012 +0100 Revert "fix for fdo#49255" This reverts commit 9efd8deb867c89baf0f5df4

Re: 'make check' failure

2012-08-24 Thread Matúš Kukan
On 24 August 2012 11:55, John Smith wrote: > BTW, I just re-ran 'make check' on slightly newer sources, and got > some more failures towards the end (including some core dump, too) > Maybe someone should take a look at the output ? That's probably because you are between http://cgit.freedesktop.

Re: 'make check' failure

2012-08-24 Thread Michael Stahl
On 24/08/12 10:51, Noel Grandin wrote: > > On 2012-08-24 10:46, Stephan Bergmann wrote: >> >>> quickly tried a 'make >>> /usr/local/src/libreoffice/workdir/unxlngi6.pro/JunitTest/sc_unoapi/user' >>> >>> as suggested in the logfile and that just gave me a 'nothing to do for >>> foo' response. Can

[Libreoffice-commits] .: Makefile.top

2012-08-24 Thread Libreoffice Gerrit user
Makefile.top |8 1 file changed, 8 insertions(+) New commits: commit 01a6b0b0eb2103df594881e4e5ac3607f1177998 Author: Michael Stahl Date: Fri Aug 24 11:55:28 2012 +0200 make it possible to run JunitTest and CppunitTest from Makefile.top Change-Id: Ib0286466403a045742

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-08-24 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlimprt.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 9efd8deb867c89baf0f5df410b87e8310fff524b Author: Noel Power Date: Fri Aug 24 10:31:45 2012 +0100 fix for fdo#49255 This patch disables row height calculations ( and us

Re: 'make check' failure

2012-08-24 Thread John Smith
On Fri, Aug 24, 2012 at 10:46 AM, Stephan Bergmann wrote: > > The unoapi tests involving anything related to accessibility have > historically been very fragile (things like expecting a certain GUI element > has focus at a certain moment, which can fail as soon as other apps are > running in paral

No output from ./autogen.sh --help and other getting started issues (Ubuntu)

2012-08-24 Thread B.J. Herbison
I'm trying to learn how to debug LibreOffice because of bug 53839 and I'm having problems following the instructions from https://wiki.documentfoundation.org/Development/Native_Build . Current blocker: After the following commands: $ git clone git://anongit.freedesktop.org/libreoffice/core libo

[Libreoffice-commits] .: Branch 'feature/gbuild_external' - hsqldb/Package_hsqldb.mk

2012-08-24 Thread Libreoffice Gerrit user
hsqldb/Package_hsqldb.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 241a1feeb2ab79c6cf0b2c1389bede532a4cfc5f Author: David Tardon Date: Fri Aug 24 11:04:43 2012 +0200 yeah, i cannot type Change-Id: I86048a389036fe219849e862b655c9dad72c117c d

[Libreoffice-commits] .: Branch 'feature/gbuild_external' - hsqldb/Module_hslqdb.mk hsqldb/Module_hsqldb.mk

2012-08-24 Thread Libreoffice Gerrit user
hsqldb/Module_hslqdb.mk | 20 hsqldb/Module_hsqldb.mk | 20 2 files changed, 20 insertions(+), 20 deletions(-) New commits: commit 24809442c96a890f018d29dea5e4b7cd371b4c90 Author: David Tardon Date: Fri Aug 24 10:57:17 2012 +0200 i cannot type

[Libreoffice-commits] .: sc/source

2012-08-24 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlimprt.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 629cd5e1fcdf780cedf7fd88ed7d02492be31411 Author: Noel Power Date: Fri Aug 24 09:49:02 2012 +0100 fix for fdo#49255 Change-Id: I5af8bc0b511bdf838343d7b71f310df8d8dd8473 diff --git a/sc/

Re: 'make check' failure

2012-08-24 Thread Noel Grandin
On 2012-08-24 10:46, Stephan Bergmann wrote: quickly tried a 'make /usr/local/src/libreoffice/workdir/unxlngi6.pro/JunitTest/sc_unoapi/user' as suggested in the logfile and that just gave me a 'nothing to do for foo' response. Can I do a 'make clean' for just that test ? I assume you forg

Re: 'make check' failure

2012-08-24 Thread Stephan Bergmann
On 08/23/2012 06:20 PM, John Smith wrote: On Thu, Aug 23, 2012 at 11:45 AM, Michael Stahl wrote: reading the log you posted no you don't get a core file because soffice.bin didn't actually crash. Ok, so how do we go about getting more detailed info that can assist in solving the issue, then ?

[Libreoffice-commits] .: Branch 'feature/gbuild_external' - 3 commits - hsqldb/ExternalProject_hsqldb.mk hsqldb/Makefile hsqldb/makefile.mk hsqldb/Module_hslqdb.mk hsqldb/Package_hsqldb.mk hsqldb/prj

2012-08-24 Thread Libreoffice Gerrit user
Makefile.top |2 Module_tail_build.mk |3 + RepositoryModule_ooo.mk |1 hsqldb/ExternalProject_hsqldb.mk | 36 hsqldb/Makefile |7 ++ hsqldb/Module_hslqdb.mk | 20 +++ hsqldb/Package_hsqldb.mk

Re: [Libreoffice-commits] Revert "installer: Use hashref for replace_all_ziplistvariables_in_rtffile"

2012-08-24 Thread Stephan Bergmann
On 08/23/2012 07:00 PM, Tim Retout wrote: On Aug 23, 2012 9:13 AM, "Stephan Bergmann" mailto:sberg...@redhat.com>> wrote: > On 08/23/2012 09:59 AM, Libreoffice Gerrit user wrote: >> commit 52755d6d2cf1c6addaf3c91b93bb86d66b730409 >> Author: Stephan Bergmann mailto:sberg...@redhat.com>> >> Dat

[PUSHED] Change in core[libreoffice-3-6]: gbuild: also in libmerge case library needs to depend on all...

2012-08-24 Thread Gerrit
>From Tomáš Chvátal : Tomáš Chvátal has submitted this change and it was merged. Change subject: gbuild: also in libmerge case library needs to depend on all headers .. gbuild: also in libmerge case library needs to depend on

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - solenv/gbuild

2012-08-24 Thread Libreoffice Gerrit user
solenv/gbuild/LinkTarget.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 21f5b9370a76894865d16d610ea36fcf420635cd Author: Matúš Kukan Date: Thu Aug 23 23:19:10 2012 +0200 gbuild: also in libmerge case library needs to depend on all headers Change

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-08-24 Thread Libreoffice Gerrit user
sw/source/core/doc/docnew.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 311c1b76a1d0aee201b6d060dc533a3d1d587d55 Author: Cédric Bosdonnat Date: Fri Aug 24 10:00:27 2012 +0200 Revert "initialize member": the commit to fix isn't in 3.6 This reverts commit 7f18b80

  1   2   >