[PATCH] Bookmark.ui and Numberformat.ui

2012-12-02 Thread Gokul Swaminathan
Dear Mr. Caolan, manually converted the bookmark and numberformat widgets. Regards, Gokul Swaminathan +966568449815 Motah Program, KACST http://www.motah.org.sa Warning: This message and its attachment, if any, are confidential and may contain information protected

Re: [API] Some more cleanup ideas

2012-12-02 Thread Noel Grandin
On 2012-12-02 22:03, Michael Stahl wrote: ... what i'd really like to have though is a C++ keyword plus "error if there is not actually a base class method with that parameter signature" Here we go, http://stackoverflow.com/questions/497630/safely-override-c-virtual-functions there is a new C

Re: Efficient string concatenation

2012-12-02 Thread Norbert Thiebaud
On Sun, Dec 2, 2012 at 10:59 PM, Norbert Thiebaud wrote: > vaguely related... since we are talking about performance... why > *_new_WithLength() in strtmpl.cxx is doing a memset on the whole newly > allocated buffer... > surely the allocated buffer will be filled with something soon > enough... al

Re: Efficient string concatenation

2012-12-02 Thread Norbert Thiebaud
Patch 0001 it seems to me that addData via the different addDataHelper, do _not_ add the final binary 0, like rtl_stringbuffer_insert() for instance is doing so: +#ifdef RTL_FAST_STRING +template< typename T1, typename T2 > +OStringBuffer( const OStringConcat< T1, T2 >& c ) +{ +

Re: Efficient string concatenation

2012-12-02 Thread Norbert Thiebaud
On Sun, Dec 2, 2012 at 4:56 PM, Lubos Lunak wrote: > in pathc 0001: +#ifdef RTL_FAST_STRING +template< typename T1, typename T2 > +OStringBuffer( const OStringConcat< T1, T2 >& c ) +{ +const int l = c.length(); +rtl_String* buffer = NULL; +rtl_string_new_WithL

Re: [API] Some more cleanup ideas

2012-12-02 Thread Noel Grandin
Sunday, 2 December 2012, Michael Stahl wrote: > > what i'd really like to have though is a C++ keyword with semantics of > "just use the same > exception specification as the base class method" ... plus "error if > there is not actually a base class method with that parameter > signature", while we

[Libreoffice-commits] .: 4 commits - sc/inc sc/source tools/inc vcl/inc vcl/source

2012-12-02 Thread Libreoffice Gerrit user
sc/inc/scmod.hxx |7 ++ sc/source/ui/app/scdll.cxx|3 - sc/source/ui/app/scmod.cxx| 86 -- sc/source/ui/condformat/condformatdlg.cxx | 26 ++--- sc/source/ui/condformat/condformatmgr.cxx |5 +

Re: Efficient string concatenation

2012-12-02 Thread Norbert Thiebaud
On Sun, Dec 2, 2012 at 6:55 PM, Norbert Thiebaud wrote: Sorry fro previous post. mishap... > On Sun, Dec 2, 2012 at 4:56 PM, Lubos Lunak wrote: >> >> Hello, >> >> The work is based on threads [1] and [2] and occassionally seeing in the >> commits that people doing string cleanups sometimes ch

Re: Efficient string concatenation

2012-12-02 Thread Norbert Thiebaud
On Sun, Dec 2, 2012 at 4:56 PM, Lubos Lunak wrote: > > Hello, > > The work is based on threads [1] and [2] and occassionally seeing in the > commits that people doing string cleanups sometimes change ugly code to only > slightly less ugly code. With the new feature enabled, any string > concaten

Re: Build error libxmlsec

2012-12-02 Thread Marcos Souza
Hi Caolán! After some days, and pulling again, now xmlsec is building again! Thanks a lot for the quick answer! 2012/11/30 Caolán McNamara > On Wed, 2012-11-28 at 19:02 -0200, Marcos Souza wrote: > > Hi guys, > > > > I'm getting this error when trying to build the master: > > checking for gnu

[Libreoffice-commits] .: 4 commits - offapi/com offapi/type_reference offapi/UnoApi_offapi.mk sd/source sfx2/source sw/source

2012-12-02 Thread Libreoffice Gerrit user
offapi/UnoApi_offapi.mk |4 - offapi/com/sun/star/util/XArchiver.idl | 61 --- offapi/com/sun/star/util/XCancelManager.idl | 52 --- offapi/com/sun/star/util/XSimpleErrorHandler.idl | 42 --- offapi/c

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Christian Lohmaier changed: What|Removed |Added CC||lohma...@gmx.de Alias|

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Christian Lohmaier changed: What|Removed |Added CC||lohma...@gmx.de Alias|

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Christian Lohmaier changed: What|Removed |Added CC||lohma...@gmx.de Alias|

4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?

2012-12-02 Thread Cor Nouws
Hi all, After the few initial mails about this, and looking at 'the' agenda, I propose the following: Have either a) a LibreOffice 4.0 Test Week from Monday 10 - Sunday 16th or b) a LibreOffice 4.0 Test marathon from Thursday 13 - Wednesday 19th (A full week from 17-23 would be to close

[Libreoffice-commits] .: solenv/inc

2012-12-02 Thread Libreoffice Gerrit user
solenv/inc/wntmsc.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 814f2072943dfe8befead0bba2f2168c1061ff4e Author: Tor Lillqvist Date: Mon Dec 3 00:32:15 2012 +0200 Add -wd4986 here, too diff --git a/solenv/inc/wntmsc.mk b/solenv/inc/wntmsc.mk index f87822

[PATCH] fdo#57215: Fixed wrong text rotation in SVG Export

2012-12-02 Thread Horacio Fernandes (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1227 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/1227/1 fdo#57215: Fixed wrong text rotation in SVG Export Added text rotation to "non-positioned characters" in SVG Exp

[Libreoffice-commits] .: solenv/gbuild

2012-12-02 Thread Libreoffice Gerrit user
solenv/gbuild/platform/com_MSC_defs.mk | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) New commits: commit 3e6bc1522fe7ef734f5ed51e4bffea62d96e6707 Author: Tor Lillqvist Date: Sun Dec 2 11:32:17 2012 +0200 More -wd fixups diff --git a/solenv/gbuild/platform/com_MSC_de

[Libreoffice-commits] .: sdext/CppunitTest_pdfimport.mk sdext/Executable_pdf2xml.mk sdext/Executable_pdfunzip.mk sdext/Executable_xpdfimport.mk sdext/Library_minimizer.mk sdext/Library_presenter.mk sd

2012-12-02 Thread Libreoffice Gerrit user
sdext/CppunitTest_pdfimport.mk |1 + sdext/Executable_pdf2xml.mk|1 + sdext/Executable_pdfunzip.mk |1 + sdext/Executable_xpdfimport.mk |5 + sdext/Library_minimizer.mk |4 sdext/Library_presenter.mk |4 sdext/StaticLibrar

[Libreoffice-commits] .: 2 commits - pyuno/CustomTarget_zipcore.mk solenv/gbuild

2012-12-02 Thread Libreoffice Gerrit user
pyuno/CustomTarget_zipcore.mk | 14 -- solenv/gbuild/gbuild.mk |4 +++- 2 files changed, 7 insertions(+), 11 deletions(-) New commits: commit 3cfbc3409a0bacbdd6572be2c39c004611778bfc Author: Michael Stahl Date: Sun Dec 2 22:15:46 2012 +0100 gbuild: call gb_External

[Libreoffice-commits] .: libwps/StaticLibrary_wps.mk

2012-12-02 Thread Libreoffice Gerrit user
libwps/StaticLibrary_wps.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 918e2682a3b7b9af1f4a3ec3a38c3735062bd8c9 Author: Michael Stahl Date: Sun Dec 2 21:36:26 2012 +0100 libwps: tinderbox says this wants to use boost... Change-Id: I9ee40fd845aa6af045e49fa4f69165

[Libreoffice-commits] .: offapi/com offapi/type_reference offapi/UnoApi_offapi.mk

2012-12-02 Thread Libreoffice Gerrit user
offapi/UnoApi_offapi.mk|2 - offapi/com/sun/star/util/DiskFullException.idl | 40 - offapi/com/sun/star/util/FileIOException.idl | 39 offapi/type_reference/types.rdb|binary 4 files changed, 81 dele

Adding hyphenation patterns for Swedish

2012-12-02 Thread Niklas Johansson
I thought I would add Swedish hyphenation patterns to the next release of LibreOffice. The plan was to do it together with an update of the spelling dictionary that is planed in mid January. Since Swedish doesn't have any patterns bundled today, will there be any problems with the feature freeze?

Re: [API] Some more cleanup ideas

2012-12-02 Thread Michael Stahl
On 30/11/12 18:53, Lubos Lunak wrote: > On Friday 30 of November 2012, Stephan Bergmann wrote: >> On 11/29/2012 06:42 PM, Thorsten Behrens wrote: >>> With SAL_THROW & exception specs on api headers removed, there's a >>> very nice & substantial cleanup task possible subsequently, that >>> removes i

[Libreoffice-commits] .: 2 commits - codemaker/source forms/Library_frm.mk i18npool/CppunitTest_i18npool_test_textsearch.mk i18npool/Executable_gencoll_rule.mk i18npool/Executable_genindex_data.mk i18

2012-12-02 Thread Libreoffice Gerrit user
Library_merged.mk|8 -- RepositoryExternal.mk| 16 ++--- codemaker/source/cppumaker/cpputype.cxx | 65 +++ codemaker/source/cppumaker/cpputype.hxx |6 ++ forms/Library_frm.mk

[Libreoffice-commits] .: dbaccess/source

2012-12-02 Thread Libreoffice Gerrit user
dbaccess/source/ui/querydesign/QueryDesignView.cxx | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) New commits: commit 63614919195934a764eacb509d75d15f8b243a48 Author: Lionel Elie Mamane Date: Sun Dec 2 18:55:44 2012 +0100 WaE: explicitly do nothing when nothing ne

[PATCH] Change in core[libreoffice-3-6]: fdo#42165 make nested joins as per strict ANSI SQL

2012-12-02 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1225 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1225/1 fdo#42165 make nested joins as per strict ANSI SQL Change-Id: I605d3811b27c33e35670306bb03b5a796ab72bc0 --- M db

[PATCH] Change in core[libreoffice-3-6]: Catch all exceptions to respect specification

2012-12-02 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1226 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1226/1 Catch all exceptions to respect specification In particular, getMaxRows() can throw SQLException Change-Id: I1f

[Libreoffice-commits] .: 5 commits - connectivity/source dbaccess/source

2012-12-02 Thread Libreoffice Gerrit user
connectivity/source/drivers/jdbc/JStatement.cxx| 14 - dbaccess/source/ui/inc/TableConnectionData.hxx |3 - dbaccess/source/ui/querydesign/QueryDesignView.cxx | 56 + 3 files changed, 50 insertions(+), 23 deletions(-) New commits: commit c25bb400bbfe20b3b13

[Libreoffice-commits] .: 3 commits - sc/source

2012-12-02 Thread Libreoffice Gerrit user
sc/source/ui/condformat/condformatdlgentry.cxx | 14 ++ sc/source/ui/inc/condformatdlgentry.hxx|3 ++- 2 files changed, 16 insertions(+), 1 deletion(-) New commits: commit d05351723055dd56e8732c4ac2104cd8111e2a54 Author: Markus Mohrhard Date: Sun Dec 2 17:36:46 2012 +

Is fdo#51638 fixed with I6a4c7024da154104d985bca25b26a8243174ec8d ?

2012-12-02 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Looking at I6a4c7024da154104d985bca25b26a8243174ec8d I wonder if it fixes fdo#51638? Seems the same issue... - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation The Document Foundation, Zimmerstr. 69, 10117 Berlin,

[Libreoffice-commits] .: RepositoryExternal.mk

2012-12-02 Thread Libreoffice Gerrit user
RepositoryExternal.mk |2 -- 1 file changed, 2 deletions(-) New commits: commit ff7735d7a1e0aa9ed753553cf20acf10fbd3f81b Author: David Tardon Date: Sun Dec 2 17:02:44 2012 +0100 fix build with internal libxml2 Change-Id: I2dbef5bbe93cd8561ae0fba24f8d30771747098c diff --git a

[Libreoffice-commits] .: idlc/source

2012-12-02 Thread Libreoffice Gerrit user
idlc/source/idlcproduce.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f728eda90912ee0e2072e422dcf7eb6589d24497 Author: Luboš Luňák Date: Sun Dec 2 16:15:22 2012 +0100 unlink() doesn't work that well with URLs Change-Id: I1d0cbd8b8cbbd3ea5c73d

Re: random number generators for calc

2012-12-02 Thread Markus Mohrhard
On Sun, Dec 02, 2012 at 11:47:01AM +, tino wrote: > > > ... looking at random.cxx it appears to use a MD5 hash to generate the > > random bytes; initialization is via seconds/nanoseconds of current time > > and thread-id. since the cryptographic hash implementations in sal/rtl > > don't look

Saving/Loading UOF-standard

2012-12-02 Thread Rob Snelders
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi All, The file-format UOF is supported by LibreOffice. But it doesn't work (anymore?) [1]. The loading of the file doesn't work. I don't know if the files saved are of the correct format (as I can't load what I save). It doesn't seem to a much used

License statement

2012-12-02 Thread Christine Koppelt
All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3 dual license. 2012/11/28 Rob Snelders : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Christine, > > My journey home wasn't good.. as the trains didn't ride when I got back > in the Netherlands.

fdo#56877 - CRASH when profile contains a invalid RecentlyUs...

2012-12-02 Thread Rob Snelders (via Code Review)
Rob Snelders has abandoned this change. Change subject: fdo#56877 - CRASH when profile contains a invalid RecentlyUsedMasterPages .. Patch Set 1: Abandoned pushed in a new commit -- To view, visit https://gerrit.libreoffice.o

[PATCH] fdo#56877 CRASH when profile contains invalid RecentlyUsedMa...

2012-12-02 Thread Rob Snelders (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1224 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/1224/1 fdo#56877 CRASH when profile contains invalid RecentlyUsedMasterpages Change-Id: Ia875d6b04b5ce6a026a57aaef2c17f

[PATCH] fdo#56877 - CRASH when profile contains a invalid RecentlyUs...

2012-12-02 Thread Rob Snelders (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1223 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1223/1 fdo#56877 - CRASH when profile contains a invalid RecentlyUsedMasterPages Change-Id: I5c67f4382edc5f2771fd790256

[Libreoffice-commits] .: officecfg/Configuration_officecfg.mk

2012-12-02 Thread Libreoffice Gerrit user
officecfg/Configuration_officecfg.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 5e0bd1f73ae267c317eb625fbfe7bb61e82dfb0f Author: David Tardon Date: Sun Dec 2 14:27:59 2012 +0100 recover lost config. spool module ctlseqcheck Change-Id: I22809a29ea085459c4a6e73791

[Libreoffice-commits] .: desktop/inc desktop/source

2012-12-02 Thread Libreoffice Gerrit user
desktop/inc/app.hxx|3 ++- desktop/source/app/app.cxx | 24 +--- 2 files changed, 7 insertions(+), 20 deletions(-) New commits: commit 1a8f7865450047e6e5b01598c5658026f392388e Author: Caolán McNamara Date: Sun Dec 2 12:47:48 2012 + ensure lockfile do

[PUSHED] Remove unused method from desktop

2012-12-02 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1221 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1221 To unsubscribe,

[Libreoffice-commits] .: desktop/source unusedcode.easy

2012-12-02 Thread Libreoffice Gerrit user
desktop/source/deployment/inc/lockfile.hxx |3 --- desktop/source/deployment/misc/lockfile.cxx |9 - unusedcode.easy |1 - 3 files changed, 13 deletions(-) New commits: commit 1eafd90aee0c945b941db99d70a25d1b633c1401 Author: Marcos Paulo de Souza

Re: random number generators for calc

2012-12-02 Thread tino
> of course it doesn't have fancy features like ranges or non-uniform > distribution... That's ok, I wouldn't use that against it, because these things are independent. Any uniform int generator can easily be extended to ranges, and uniform [0,1] distribution. And at least in theory, any non-unifo

[PATCH] fdo#36800-Find & replace does not search single cell

2012-12-02 Thread Abdulelah Alarifi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1222 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/1222/1 fdo#36800-Find & replace does not search single cell Change-Id: I91015a8eec99b0772d9bae001b58567eacaa4a6f --- M

[Libreoffice-commits] .: 2 commits - extras/CustomTarget_autocorr.mk filter/Configuration_filter.mk filter/CustomTarget_svg.mk i18npool/CustomTarget_localedata.mk officecfg/CustomTarget_registry.mk re

2012-12-02 Thread Libreoffice Gerrit user
Repository.mk |8 ++ RepositoryExternal.mk | 81 + extras/CustomTarget_autocorr.mk |5 - filter/Configuration_filter.mk|9 +- filter/CustomTarget_svg.mk|4 - i18npool/CustomTarget_localedata.mk

[Libreoffice-commits] .: 2 commits - solenv/gbuild

2012-12-02 Thread Libreoffice Gerrit user
solenv/gbuild/platform/com_MSC_defs.mk | 129 ++--- 1 file changed, 119 insertions(+), 10 deletions(-) New commits: commit f02ac6e7c8da9e6e3b2263f028637723a8cf4829 Author: Tor Lillqvist Date: Sun Dec 2 11:19:39 2012 +0200 Don't disable warnings that supprted M

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on|34555 | -- You are receiving this mail beca