Re: Wrong platform check for Xinerama support

2013-01-02 Thread Tor Lillqvist
> And even Windows NT has a POSIX layer... You mean "subsystem". (It's not as if there was a "POSIX layer" hiding below the Win32 layer or something.) Nowadays it is called the "Subsystem for Unix applications" (SUA), but LibreOffice has nothing to do with that, and can't have. SUA can be complete

Re: Wrong platform check for Xinerama support

2013-01-02 Thread Noel Grandin
The XINE check from here: http://xine.cvs.sourceforge.net/viewvc/xine/xine-ui/configure.ac?revision=1.134&view=markup looks like this: dnl dnl Checks for Xinerama extension dnl AC_ARG_ENABLE([xinerama], AS_HELP_STRING([--disable-xinerama], [Don't build support for xinerama (default: check)]

Re: Wrong platform check for Xinerama support

2013-01-02 Thread Lionel Elie Mamane
On Thu, Jan 03, 2013 at 09:12:12AM +0200, Tor Lillqvist wrote: >> if test "$_os" = "Linux" -o "$_os" = "FreeBSD" -o "$_os" = "MirBSD" -o >> "$_os" = "OpenBSD" #etc, etc; >>UNIX_X11=true || POSIX_OS=true >> fi >> >> and then test UNIX_X11 (or POSIX_OS). > I doubt we need any separate flag for

Re: Wrong platform check for Xinerama support

2013-01-02 Thread Tor Lillqvist
> if test "$_os" = "Linux" -o "$_os" = "FreeBSD" -o "$_os" = "MirBSD" -o "$_os" > = "OpenBSD" #etc, etc; >UNIX_X11=true || POSIX_OS=true > fi > > and then test UNIX_X11 (or POSIX_OS). I doubt we need any separate flag for POSIXness, because basically anything that isn't Windows is "POSIX", su

Re: Wrong platform check for Xinerama support

2013-01-02 Thread Lionel Elie Mamane
On Wed, Jan 02, 2013 at 01:50:33PM +0100, Francois Tigeot wrote: > configure.in / configure.ac also contains some fishy platform checks in > the Xinerama support check: > ... > elif test "$_os" = "Linux" -o "$_os" = "FreeBSD"; then > if test "$x_libraries" = "default_x_libraries"; then >

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/filter/excel/xichart.cxx |2 +- sc/source/filter/oox/defnamesbuffer.cxx |1 + 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit f204cd9b52ec7af3e0d20f5c88f09737b38b9e7d Author: Kohei Yoshida Date: Thu Jan 3 00:27:08 2013 -0500 fdo#58539: Check for

[Libreoffice-commits] .: sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/filter/excel/xichart.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 329f3cd02546dfe58bf00f6ad3b71bc84a8d4320 Author: Kohei Yoshida Date: Thu Jan 3 00:27:08 2013 -0500 fdo#58539: Check for mxValueLink being NULL before dereferencing. Or

[Libreoffice-commits] .: sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/filter/oox/defnamesbuffer.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 7a8a3e46978b3397ca8aba38917bd5dbc808c9b8 Author: Kohei Yoshida Date: Wed Jan 2 23:56:43 2013 -0500 fdo#58539: Properly initialize a member pointer value. Or else it would crash wh

Re: [PATCH] Get rid of nsinstall hackery

2013-01-02 Thread Mat M
Hi Peter, Two caveats I want to submit : what happens if --disable-python is here ? And this thread [1] has never come to a solution about ssl API, but your change may conflict with one of the scenarios if the python version is not enough. [1] http://lists.freedesktop.org/archives/libreoff

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 3 commits - sc/qa sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx | 44 +++ sc/source/core/tool/scmatrix.cxx |2 + sc/source/ui/unoobj/dapiuno.cxx | 12 -- 3 files changed, 56 insertions(+), 2 deletions(-) New commits: commit b060b43f093dce23222fd99375b1c6bd433703d9 Author: Ko

[Libreoffice-commits] .: nss/nss.windows.patch

2013-01-02 Thread Libreoffice Gerrit user
nss/nss.windows.patch | 11 +++ 1 file changed, 11 insertions(+) New commits: commit 58e76a64b46791406277d574deecb081f230b910 Author: Luboš Luňák Date: Thu Jan 3 02:52:50 2013 +0100 one more place for forcing windows path in nss build diff --git a/nss/nss.windows.patch b/nss

[Libreoffice-commits] .: nss/nss.windows.patch nss/UnpackedTarball_nss.mk

2013-01-02 Thread Libreoffice Gerrit user
nss/UnpackedTarball_nss.mk |1 + nss/nss.windows.patch | 11 +++ 2 files changed, 12 insertions(+) New commits: commit dfbcb34441fed0d38e7c86f32d659ba8ab52640f Author: Luboš Luňák Date: Thu Jan 3 02:35:40 2013 +0100 force nss build to pass windows path to cl.exe

[Libreoffice-commits] .: xmloff/source

2013-01-02 Thread Libreoffice Gerrit user
xmloff/source/style/xmlnumfi.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 5693934456f917861af7cb02734578b049a46940 Author: Markus Mohrhard Date: Thu Jan 3 02:18:25 2013 +0100 limit the number of imported digits, fdo#58539 This should fix the

Re: How to set the temp directory when building LibreOffice ?

2013-01-02 Thread Ruslan Kabatsayev
Hi, I've just sent a message on similar topic :) On Thu, Jan 3, 2013 at 1:11 AM, Jean-Baptiste Faure wrote: > Hi all, > > When building LibreOffice, a lot of files are created in the standard > temp directory (/tmp for me under Ubuntu). Many of these files are not > removed when the build has be

[Libreoffice-commits] .: nss/ExternalPackage_nss.mk

2013-01-02 Thread Libreoffice Gerrit user
nss/ExternalPackage_nss.mk |2 ++ 1 file changed, 2 insertions(+) New commits: commit 96e7e3564b473944218ea2f5440c70399e978e14 Author: Luboš Luňák Date: Thu Jan 3 02:00:58 2013 +0100 add missing nss windows libs diff --git a/nss/ExternalPackage_nss.mk b/nss/ExternalPackage_nss.mk

[Libreoffice-commits] .: sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlsubti.cxx |2 ++ sc/source/filter/xml/xmlsubti.hxx |2 +- 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit fa1b00095011def26cc291e74948817632e3545d Author: Markus Mohrhard Date: Thu Jan 3 01:41:45 2013 +0100 don't overflow column number d

[Libreoffice-commits] .: 2 commits - distro-configs/LibreOfficeMinGW.conf sc/Library_scfilt.mk

2013-01-02 Thread Libreoffice Gerrit user
distro-configs/LibreOfficeMinGW.conf |1 + sc/Library_scfilt.mk |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 669c27ca0575e046b37db7ecc0a3d24ed2001a62 Author: Luboš Luňák Date: Thu Jan 3 00:39:02 2013 +0100 system-zlib for mingw dif

[PATCH] Get rid of nsinstall hackery

2013-01-02 Thread Peter Foley (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1534 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1534/1 Get rid of nsinstall hackery This removes the need for using NSS Build Tools on windows. It also removes the nee

Junk *.tmp files in /tmp after compilation

2013-01-02 Thread Ruslan Kabatsayev
Hi all, Each time after LibO compilation (doing it from scratch, i.e. having "git pull&&git clean -xdf" done before if that matters) I discover about 400 files with names like "luxy1e20.tmp" in my /tmp. Shouldn't these temp files have been removed automatically? Regards, Ruslan __

[Libreoffice-commits] .: configure.ac

2013-01-02 Thread Libreoffice Gerrit user
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2ed074578b00582e40cf6380f629570d1eee3f71 Author: Tor Lillqvist Date: Wed Jan 2 23:58:51 2013 +0200 Unbreak build with just the NDK without a 64-bit add-on tool-chain Change-Id: I05c558b557cf

How to set the temp directory when building LibreOffice ?

2013-01-02 Thread Jean-Baptiste Faure
Hi all, When building LibreOffice, a lot of files are created in the standard temp directory (/tmp for me under Ubuntu). Many of these files are not removed when the build has been completed with success. I think it would be cleaner if these temporary files was created in a subdirectory of /tmp.

[Libreoffice-commits] .: sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/ui/unoobj/dapiuno.cxx | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) New commits: commit c27e334661b62897a81a450ea9188f80e053261e Author: Kohei Yoshida Date: Wed Jan 2 16:03:35 2013 -0500 fdo#58539: Avoid throwing exception not specified in the signature.

[Libreoffice-commits] .: nss/ExternalPackage_nss.mk

2013-01-02 Thread Libreoffice Gerrit user
nss/ExternalPackage_nss.mk |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit ebaaefcbf34d037aa8091ffbef3b7f8adc7a9ac5 Author: Luboš Luňák Date: Wed Jan 2 21:56:30 2013 +0100 try to sort out libsqlite3 handling in nss diff --git a/nss/ExternalPackage_

[Libreoffice-commits] .: sc/qa sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx | 10 ++ sc/source/core/tool/scmatrix.cxx |2 ++ 2 files changed, 12 insertions(+) New commits: commit 79f1ef44e77074d8f5a1d32e0447118e5b9c4e70 Author: Kohei Yoshida Date: Wed Jan 2 15:49:24 2013 -0500 fdo#58539: Resizing matrix should also r

[PATCH] fdo#40465 fix to maintain focus whilst zooming

2013-01-02 Thread Winfried Donkers (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1533 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1533/1 fdo#40465 fix to maintain focus whilst zooming Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8 --- M dictio

[Libreoffice-commits] .: sc/qa

2013-01-02 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx | 34 ++ 1 file changed, 34 insertions(+) New commits: commit c1f9efa4ac8a406cf10f3b5585f45ee0114621e4 Author: Kohei Yoshida Date: Wed Jan 2 14:07:09 2013 -0500 fdo#56278: Write a unit test for this. The reported bug descript

[Libreoffice-commits] .: sal/inc sw/qa sw/source

2013-01-02 Thread Libreoffice Gerrit user
sal/inc/sal/log-areas.dox|1 + sw/qa/extras/rtfimport/rtfimport.cxx |1 - sw/source/core/crsr/crstrvl.cxx |2 +- sw/source/core/unocore/unostyle.cxx |2 +- sw/source/ui/app/docsh2.cxx |1 - sw/source/ui/ribbar/workctrl.cxx |4 +--- 6 files cha

First steps finding regression bug(s)

2013-01-02 Thread Joren
Hi, I'm not that familiar with the source code of LibreOffice. The last past weeks I'm helping the QA-team. I try now to take a little step forward and try to comprehend a bit of the source code. I would like to help core developers point at regressions (find the erroneous commit). In first

[Libreoffice-commits] .: 2 commits - configure.ac python3/ExternalProject_python3.mk

2013-01-02 Thread Libreoffice Gerrit user
configure.ac |4 +++- python3/ExternalProject_python3.mk |2 +- 2 files changed, 4 insertions(+), 2 deletions(-) New commits: commit b24f82fda9558a8b07a6df9ac898d0e166113a10 Author: Tor Lillqvist Date: Wed Jan 2 20:53:59 2013 +0200 Can't build the NPAPI plugi

Re: build failure with ICU 4.8

2013-01-02 Thread Eike Rathke
Hi Ivan, On Monday, 2012-12-31 12:20:13 +0400, Ivan Timofeev wrote: > ICU 4.8 does not know Conditional_Japanese_Starter (only ICU 49 does), I > think we should put that conditional stuff from > http://cgit.freedesktop.org/libreoffice/core/commit/?id=92a9b7780c6e13a4da3b12794342edbc4c09ef51 > bac

[Libreoffice-commits] .: config_host.mk.in configure.ac i18npool/CustomTarget_breakiterator.mk i18npool/qa i18npool/source

2013-01-02 Thread Libreoffice Gerrit user
config_host.mk.in |2 ++ configure.ac|8 i18npool/CustomTarget_breakiterator.mk | 18 +- i18npool/qa/cppunit/test_breakiterator.cxx |7 +++ i18npool/source/breakiterator/data/line.txt |3

[Libreoffice-commits] .: nss/ExternalPackage_nss.mk

2013-01-02 Thread Libreoffice Gerrit user
nss/ExternalPackage_nss.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 3b1102ad193d55b98c7c72e706173353c35bb1b6 Author: Luboš Luňák Date: Wed Jan 2 18:25:31 2013 +0100 looks like libnsssysinit is linux-only diff --git a/nss/ExternalPackage_nss.mk b/nss/ExternalPackage_

[Libreoffice-commits] .: configure.ac

2013-01-02 Thread Libreoffice Gerrit user
configure.ac | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) New commits: commit 2210bade74626de68e51adb9759b81f62d7c0b01 Author: Tor Lillqvist Date: Wed Jan 2 15:18:11 2013 +0200 Check also for a (self-built) 64-bit NDK tool-chain Also make the --

[Libreoffice-commits] .: sal/inc

2013-01-02 Thread Libreoffice Gerrit user
sal/inc/sal/log-areas.dox |1 + 1 file changed, 1 insertion(+) New commits: commit 49fc6c6b85e4902dc9b776d82ec17ea7c01a8dd1 Author: Miklos Vajna Date: Wed Jan 2 18:07:52 2013 +0100 sal: missing jvmfwk in log-areas diff --git a/sal/inc/sal/log-areas.dox b/sal/inc/sal/log-areas.dox ind

[Libreoffice-commits] .: nss/ExternalPackage_nss.mk

2013-01-02 Thread Libreoffice Gerrit user
nss/ExternalPackage_nss.mk | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) New commits: commit e912ea714ec40c5046d1c1425c1e58fd6e689df1 Author: Luboš Luňák Date: Wed Jan 2 18:06:18 2013 +0100 try to fix nss on macosx diff --git a/nss/ExternalPackage_nss.

Re: [Libreoffice-commits] .: 2 commits - pyuno/CustomTarget_python_shell.mk pyuno/CustomTarget_pyversion.mk pyuno/Executable_python_wrapper.mk pyuno/Module_pyuno.mk pyuno/zipcore

2013-01-02 Thread Lubos Lunak
On Tuesday 01 of January 2013, Libreoffice Gerrit user wrote: > commit 085e0adf53baff298059980a54758d81b08bb059 > Author: David Tardon > Date: Tue Jan 1 11:47:56 2013 +0100 > > just pass the define through -D > > I am constantly amazed at the creativity of the original makefile > wri

[PUSHED] convert nss to gbuild

2013-01-02 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1529 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1529 To unsubscribe, visit

[Libreoffice-commits] .: config_host.mk.in configure.ac libxmlsec/xmlsec1-configure.patch nss/ExternalPackage_nss.mk nss/ExternalProject_nss.mk nss/Makefile nss/makefile.mk nss/Module_nss.mk nss/nss-c

2013-01-02 Thread Libreoffice Gerrit user
RepositoryExternal.mk| 10 - config_host.mk.in|3 configure.ac |6 libxmlsec/xmlsec1-configure.patch| 21 ++ nss/ExternalPackage_nss.mk | 78 ++ nss/ExternalProject_nss.mk | 80 ++

Re: Wrong indentation which leads to segfault in sc/source/ui/docshell/docfunc.cxx

2013-01-02 Thread Lubos Lunak
On Tuesday 01 of January 2013, John LeMoyne Castle wrote: > Julien, > > Looks to me like a very nice catch ... ... > The next version (2011.07.05) > http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docfunc.cxx >?r=2b88f6d32f572792597ccbb15276b9db52db7d10 is a commit labelled > "chang

[Libreoffice-commits] .: configure.ac external/Package_mingw_dlls.mk m4/mingw.m4

2013-01-02 Thread Libreoffice Gerrit user
configure.ac | 14 +++--- external/Package_mingw_dlls.mk |2 +- m4/mingw.m4|2 +- 3 files changed, 9 insertions(+), 9 deletions(-) New commits: commit dc277bc6a1c357fe725db2c567d3e1cf16fb7806 Author: Luboš Luňák Date: Wed Jan 2 17:04:3

Re: [PUSHED: 4.0, 3.6] fdo#47466 FORMATTING: Autoformat empty rows causes app to crash

2013-01-02 Thread Petr Mladek
julien2412 píše v Út 01. 01. 2013 v 10:37 -0800: > Hello, > > I don't reproduce the problem with 4.0 sources (I don't know why) but I can > reproduce it with 3.6 sources. I guess that you are just lucky with 4.0. It probably modifies an allocated memory, so it does not crash but it might cause an

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/ui/docshell/docfunc.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 5fe2b0eee8058a64745a7a51fdd2ac5e102300ee Author: Julien Nabet Date: Tue Jan 1 16:23:16 2013 +0100 fdo#47466 FORMATTING: Autoformat empty rows causes app to crash Thank you John LeMoyn

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/ui/docshell/docfunc.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 10536938a1f96c985b6deb6683ff1e1b64d040e7 Author: Julien Nabet Date: Tue Jan 1 16:23:16 2013 +0100 fdo#47466 FORMATTING: Autoformat empty rows causes app to crash Thank you John LeMoyn

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-01-02 Thread Libreoffice Gerrit user
sc/source/ui/docshell/docfunc.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit fbbbcdde585636aea0db1741a0a0ddcc7e0358f3 Author: Julien Nabet Date: Tue Jan 1 16:23:16 2013 +0100 fdo#47466 FORMATTING: Autoformat empty rows causes app to crash Thank you John LeMoyn

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Joren De Cuyper changed: What|Removed |Added CC||joren.libreoffice@telenet.b

[Libreoffice-commits] .: config_host.mk.in

2013-01-02 Thread Libreoffice Gerrit user
config_host.mk.in |1 - 1 file changed, 1 deletion(-) New commits: commit ca3aba4cdf766cf33b0dbbe495c9e6f57f069822 Author: Tor Lillqvist Date: Wed Jan 2 15:59:00 2013 +0200 DBGHELP_DLL is set in download.lst included at the end Change-Id: I5465c9176b0b53f9a148fe50373f38c71f17

Re: linux / solaris vs other *nix file handling in sal/osl/unx/file.c

2013-01-02 Thread Riccardo Magliocchetti
Hi, Il 02/01/2013 12:39, Francois Tigeot ha scritto: Hi, On Wed, Jan 02, 2013 at 12:03:16PM +0100, Riccardo Magliocchetti wrote: Il 01/01/2013 14:36, Riccardo Magliocchetti ha scritto: does anyone know why linux and solaris are using pread / pwrite syscalls while other unixes are using read

[PUSHED] Change if-statements to switch

2013-01-02 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1497 Approvals: Tomáš Chvátal: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1497 To unsubscribe, visi

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Petr Mladek changed: What|Removed |Added Depends on||58863 --- Comment #68 from Petr Mladek --

[Libreoffice-commits] .: svx/source

2013-01-02 Thread Libreoffice Gerrit user
svx/source/items/pageitem.cxx | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) New commits: commit ce9deff347ebdb1ab6faced894e8de9979eabb0e Author: Werner Koerner Date: Sat Dec 29 12:56:02 2012 +0100 Change if-statements to switch The bit-values do overla

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Petr Mladek changed: What|Removed |Added Depends on||58943 --- Comment #67 from Petr Mladek --

Re: [PATCH] Stop disabling graphite on non-WINNT and non-Linux platforms

2013-01-02 Thread Riccardo Magliocchetti
Il 02/01/2013 13:22, Francois Tigeot ha scritto: configure.ac checks if the operating system family is Linux or WINNT and refuses to enable graphite support if this is not the case. I'm using graphite on DragonFly and FreeBSD ports also enable it with a local patch; the Linux or WINNT check shou

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - solenv/gbuild

2013-01-02 Thread Libreoffice Gerrit user
solenv/gbuild/UI.mk | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) New commits: commit afa240330b51fb3607cfa6390aeb4e085cd1c525 Author: David Tardon Date: Wed Jan 2 13:51:20 2013 +0100 only package .ui translations that can be produced

[Libreoffice-commits] .: solenv/gbuild

2013-01-02 Thread Libreoffice Gerrit user
solenv/gbuild/UI.mk | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) New commits: commit 76091d814ca084ba66fcb9db8bc4565c47ee16a5 Author: David Tardon Date: Wed Jan 2 13:51:20 2013 +0100 only package .ui translations that can be produced

Wrong platform check for Xinerama support

2013-01-02 Thread Francois Tigeot
configure.in / configure.ac also contains some fishy platform checks in the Xinerama support check: ... elif test "$_os" = "Linux" -o "$_os" = "FreeBSD"; then if test "$x_libraries" = "default_x_libraries"; then XINERAMALIB=`$PKG_CONFIG --variable=libdir xinerama` ... I'm not too

Re: linux / solaris vs other *nix file handling in sal/osl/unx/file.c

2013-01-02 Thread Francois Tigeot
Hi, On Wed, Jan 02, 2013 at 12:03:16PM +0100, Riccardo Magliocchetti wrote: > Il 01/01/2013 14:36, Riccardo Magliocchetti ha scritto: > > > >does anyone know why linux and solaris are using pread / pwrite syscalls > >while other unixes are using read + lseek? The code is at least > >FileHandle_Imp

RE: [libreoffice-dev] - ScalcBT.cxx C++ using new uno bootsrap is slow

2013-01-02 Thread Rai, Neeraj
Hi Guys, I tried to modified my original slow example to use array updates (setDataArray) based on the example in the wiki. http://wiki.openoffice.org/wiki/Calc/API/Programming When I call setDataArray(arr1), the program terminates with error on screen "***Error couldn't get sheet" The relevant

Re: Questions about function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx

2013-01-02 Thread Julien Nabet
On 29/12/2012 19:31, Markus Mohrhard wrote: Hey, In function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx, what's the use to process "bHOver" variable in while (bVOver) ? It is unused. Just copy pasted code from the bHOver case. Ok, here's the change: https://gerrit.libreoffice.org/git

Re: Addin exceptions in SvStream

2013-01-02 Thread Jack Leigh
On 30/12/12 15:41, Marc-André Laverdière wrote: @Lubos. I started writing a plug-in. I have a problem with compiling, however. It somehow doesn't find the headers on my system. This is the autogen.sh I use (I tried with and without --includedir, and --includedir=/usr/) ./autogen.sh CC=clang CXX=c

[libreoffice-dev] - ScalcBT.cxx C++ using new uno bootsrap is slow

2013-01-02 Thread Rai, Neeraj
Hi , Hope this is the right forum for the question below. If not, please point me in the right direction. I have written a new version of Scalc.java in C++, this time using UNO bootstrap mentioned in examples/DevelopersGuide/Components/CppComponents. The last version I wrote used examples/cpp/D

[PUSHED] Change in core[libreoffice-3-6]: fdo#47553: UniscribeLayout: adjust mnSubStringMin

2013-01-02 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1467 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1467 To unsubscribe, visit

[PATCH] Stop disabling graphite on non-WINNT and non-Linux platforms

2013-01-02 Thread Francois Tigeot
configure.ac checks if the operating system family is Linux or WINNT and refuses to enable graphite support if this is not the case. I'm using graphite on DragonFly and FreeBSD ports also enable it with a local patch; the Linux or WINNT check should be removed. Patch vs -master attached. -- Fra

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/win

2013-01-02 Thread Libreoffice Gerrit user
vcl/win/source/gdi/winlayout.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit 49dcb4794c838d5f1cf61060f216fc67f36c1618 Author: Michael Stahl Date: Sat Dec 22 01:53:09 2012 +0100 fdo#47553: UniscribeLayout: adjust mnSubStringMin ... to actual minimum so th

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 --- Comment #66 from mike.h...@onepoyle.net --- Would like to suggest adding https://bugs.freedesktop.org/show_bug.cgi?id=58943 This regression results in significant visual differences where a user has depended on derived formats for calculated

[PUSHED] fix 'DEBUGCPPUNIT=TRUE make subsequenttest'

2013-01-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1532 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1532 To unsubscribe, visi

[Libreoffice-commits] .: configure.ac

2013-01-02 Thread Libreoffice Gerrit user
configure.ac |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 8620f8b51dcc2c9f50364d42e756fd8b11bdc1e3 Author: Luboš Luňák Date: Wed Jan 2 13:09:00 2013 +0100 fix use of MINGW_SYSROOT This got broken in a084ea60680372efb7998f7369c9fc99eb85c50a

[Libreoffice-commits] .: solenv/gbuild

2013-01-02 Thread Libreoffice Gerrit user
solenv/gbuild/CppunitTest.mk |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 265feeb31ffc08cd4ccbe48398cd41d9cf1e2a25 Author: Noel Grandin Date: Wed Jan 2 13:32:09 2013 +0200 fix 'DEBUGCPPUNIT=TRUE make subsequenttest' When running a unit test

[PATCH] fix 'DEBUGCPPUNIT=TRUE make subsequenttest'

2013-01-02 Thread Noel Grandin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1532 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/1532/1 fix 'DEBUGCPPUNIT=TRUE make subsequenttest' When running a unit test under GDB, we do not want to prefix the cpp

[PUSHED] Paren fix for Ubu 10.04 build (and fdo#58417 ?)

2013-01-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1531 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1531 To unsubscribe, visi

[Libreoffice-commits] .: linguistic/source

2013-01-02 Thread Libreoffice Gerrit user
linguistic/source/lngsvcmgr.cxx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit 252136551f2c032b62f9650a06389f2b4fe6e6c1 Author: LeMoyne Castle Date: Tue Jan 1 12:47:35 2013 -0700 Paren fix for Ubu 10.04 build (and fdo#58417 ?) The form:

Re: linux / solaris vs other *nix file handling in sal/osl/unx/file.c

2013-01-02 Thread Riccardo Magliocchetti
Il 01/01/2013 14:36, Riccardo Magliocchetti ha scritto: Hello, does anyone know why linux and solaris are using pread / pwrite syscalls while other unixes are using read + lseek? The code is at least FileHandle_Impl::writeAt which AFAIU is the base for the osl_* file functions. [snip] If the

[PATCH] Paren fix for Ubu 10.04 build (and fdo#58417 ?)

2013-01-02 Thread LeMoyne Castle (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1531 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/1531/1 Paren fix for Ubu 10.04 build (and fdo#58417 ?) The form: OuterCtor( InnerCtor(array[i]).method() ) with explici

Re: [REVIEW] domain-mapper import speedup patch ...

2013-01-02 Thread Miklos Vajna
Hi Michael, On Fri, Dec 21, 2012 at 04:55:44PM +, Michael Meeks wrote: > I attach a prototype patch. It passes make check and make slowcheck in > sw/ (not tried subsequentcheck). That makes a lot of sense, we also do something similar for section properties in http://opengrok.libreoff

Re: [SOLVED] Re: Question about operator = overloaded in reportdesign module

2013-01-02 Thread Lionel Elie Mamane
On Sun, Dec 30, 2012 at 09:58:30PM +0100, Julien Nabet wrote: > On 30/12/2012 21:48, Markus Mohrhard wrote: >>>Cppcheck reported this: >>>[reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style) >>>'OXMLComponent::operator=' should return 'OXMLComponent&'. >>>[reportdesign/source/filter/xml/x

[PUSHED] docx import: don't apply complex font size to non-complex fo...

2013-01-02 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1454 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1454 To unsubscribe, visit

[Libreoffice-commits] .: writerfilter/source

2013-01-02 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/DomainMapper.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 73731b01cd65defdf9b42a9754bede3ba84221d7 Author: Pierre-Eric Pelloux-Prayer Date: Thu Dec 20 15:39:37 2012 +0100 docx import: don't apply complex font size to non-complex font