[Libreoffice-commits] .: vcl/source

2013-01-10 Thread Libreoffice Gerrit user
vcl/source/app/dbggui.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 9b0ab09b45142bc26d51e16613d06bb415dc0d0c Author: Tor Lillqvist Date: Fri Jan 11 09:41:50 2013 +0200 No "core dumps" on Windows, and not on iOS or Android either Change-Id: Ie5d3257d3a2898

Re: replacing OUString::valueOf(static_cast) ??

2013-01-10 Thread Noel Grandin
On 2013-01-10 20:03, Lubos Lunak wrote: That is not what I meant. What I wrote in my previous mail is that if these valueOf() issues are to be fixed, it's better to fix it completely rather than just slightly reduce the problem. And for that it would be better to remove the original valueOf()

Re: Need confirmation about non-clearing of Character Styles

2013-01-10 Thread David Tardon
Hi, On Thu, Jan 10, 2013 at 06:40:02PM +0100, Fernand Vanrie wrote: > Michael plaese see also my reply to Caloán > >On 10/01/13 14:25, Caolán McNamara wrote: > >resetting the character styles should be as easy as setting "Default" > >char style on the whole document, so i'm not sure if another opt

Re: gmake: CXXFLAGS override gb_Library_add_cxxflags

2013-01-10 Thread David Tardon
Hi, On Wed, Jan 09, 2013 at 03:41:38PM +0100, Petr Mladek wrote: > PS: I have troubles to understand the related gbuild code. It seems that > both CXXFLAGS and gb_Library_add_cxxflags are added to the T_CXXFLAGS > variable, see: > > --- cut solenv/gbuild/LinkTarget.mk --- > $(call gb_LinkTarget_g

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58069, which changed state. Bug 58069 Summary: FILESAVE in different path structure destroys relative hyperlinks https://bugs.freedesktop.org/show_bug.cgi?id=58069 What|Removed |Added

[PUSHED] Change in core[libreoffice-4-0]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-10 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1635 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1635 To unsubscribe, vi

[Libreoffice-commits] .: slideshow/source

2013-01-10 Thread Libreoffice Gerrit user
slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 90ef2f1d636cc2f3397b820d0ed61f48d4b4ea36 Author: Tor Lillqvist Date: Fri Jan 11 07:09:00 2013 +0200 I meant -1 of course, not -127

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit cae060de53cbfc0737a75ed156aec8c383a14918 Author: Kohei Yoshida Date: Thu Jan 10 23:48:17 2013 -0500 fdo#59084: Sync dimension members after reloading the group data.

[Libreoffice-commits] .: sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 6e0b18ddde4310f85d3d6b7c27a93f78b541d976 Author: Kohei Yoshida Date: Fri Jan 11 00:04:13 2013 -0500 Makes no sense to 'continue' at the end of the block. Change-Id: I

[PATCH] Change in core[libreoffice-4-0]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1635 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/1635/1 fdo#59084: Sync dimension members after reloading the group data. Else the syncing would end up syncing to the o

[PUSHED] Change in core[libreoffice-4-0]: fdo#58069: Invalidate sheet stream cache when directory path...

2013-01-10 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1634 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1634 To unsubscribe, vi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/inc sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/inc/document.hxx |1 + sc/source/core/data/document.cxx | 11 +++ sc/source/ui/docshell/docsh.cxx | 38 +- 3 files changed, 49 insertions(+), 1 deletion(-) New commits: commit 31664fbc882652f6b308fa5aab1eac48e9d0ad0a Author: Koh

[Libreoffice-commits] .: 2 commits - sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/source/core/data/dpfilteredcache.cxx | 12 +++- sc/source/ui/docshell/dbdocfun.cxx |7 --- 2 files changed, 15 insertions(+), 4 deletions(-) New commits: commit 3db92283955741b490dc2d4f9e1782b179fee894 Author: Kohei Yoshida Date: Thu Jan 10 23:48:17 2013 -0500 fd

[PUSHED] Change in core[libreoffice-4-0]: Resolves: fdo#58301 make sure ScrollBar OptimalSize is up to...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1630 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1630 To unsubscribe, visi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - vcl/inc vcl/source

2013-01-10 Thread Libreoffice Gerrit user
vcl/inc/vcl/scrbar.hxx|3 ++- vcl/source/control/scrbar.cxx | 11 +-- 2 files changed, 11 insertions(+), 3 deletions(-) New commits: commit c5c22a10d41ae79b43edbf36962245c824a32e17 Author: Caolán McNamara Date: Tue Dec 4 16:16:14 2012 + Resolves: fdo#58301 make

[PUSHED] Change in core[libreoffice-4-0]: Resolves: fdo#59112 re-scroll to current entry when dialog r...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1628 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1628 To unsubscribe, visi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/source/ui/dbgui/sortkeydlg.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 90fe1b210025c19e885b093bf2f556d5b62f9dd4 Author: Caolán McNamara Date: Thu Jan 10 13:49:20 2013 + Resolves: fdo#59112 re-scroll to current entry when dialog resized Change-Id: I964

[PUSHED] Change in core[libreoffice-4-0]: - fdo#46460 - Missing Circles and Ovals toolbar

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1627 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1627 To unsubscribe, visi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - officecfg/registry

2013-01-10 Thread Libreoffice Gerrit user
officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d32d05c70bc8e6389e80b33f5a7156ff7836f6da Author: Rob Snelders Date: Thu Dec 20 21:40:22 2012 +0100 - fdo#46460 - Missing Circles and Ovals tool

Re: Crash on Right-click on misspelled word

2013-01-10 Thread Terrence Enger
On Wed, 2013-01-09 at 11:37 +0100, Samuel Mehrbrodt wrote: > In my build (Jan 7th, I755ea5b2ec7b6357a7fd2c86ec8479737696042b) I have > a crash in Writer when I right-click on a misspelled word. > Do I need to update or is this a bug that is still there? > Samuel, Well, my latest build is master

[Libreoffice-commits] .: Mesa/README

2013-01-10 Thread Libreoffice Gerrit user
Mesa/README |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit c5ade001383bf6fd0c339b73a5d29634de5e4062 Author: Tor Lillqvist Date: Fri Jan 11 00:04:02 2013 +0200 Update, not all of this is from "Mesa" Change-Id: I7696b6ab6b8c9a4dea99a47f091aefd643b982

[Libreoffice-commits] .: slideshow/source

2013-01-10 Thread Libreoffice Gerrit user
slideshow/source/engine/OGLTrans/generic/OGLTrans_Shaders.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 294ec42e765ae478c00b3a2051e04224c30f47a4 Author: Tor Lillqvist Date: Fri Jan 11 00:03:34 2013 +0200 Copy/paste error Change-Id: I9e4ba84eb1cc

[Libreoffice-commits] .: slideshow/source

2013-01-10 Thread Libreoffice Gerrit user
slideshow/source/engine/OGLTrans/win/UNUSED |4 1 file changed, 4 insertions(+) New commits: commit ab4a0f1165e43d5052603a1c66a07585edd2919e Author: Tor Lillqvist Date: Thu Jan 10 23:59:06 2013 +0200 Add note that these files are unused Change-Id: I7fd226bf61d9983d843453

Re: gmake: CXXFLAGS override gb_Library_add_cxxflags

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Matúš Kukan wrote: > On 10 January 2013 09:16, Stephan Bergmann wrote: > > Ah, so Petr's "IMHO, it would make sense to use CXXFLAGS after the > > default global flags but before the source file specific flags" sounds > > reasonable to me. > > See https://gerrit.libr

[Libreoffice-commits] .: oox/inc sc/inc sd/inc svtools/inc svx/inc sw/inc vcl/inc writerfilter/inc

2013-01-10 Thread Libreoffice Gerrit user
oox/inc/pch/precompiled_oox.hxx |2 - sc/inc/pch/precompiled_sc.hxx |2 - sd/inc/pch/precompiled_sd.hxx |7 ++-- svtools/inc/pch/precompiled_svt.hxx | 31 ++--- svx/inc/pch/precompiled_svx.hxx

Inlining acquire and release in osl/mutex.

2013-01-10 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Inlining acquire and release in osl/mutex. .. Patch Set 2: Abandoned -- To view, visit https://gerrit.libreoffice.org/1276 To unsubscribe, visit https://gerrit.libreoff

Use less RTTI in PDFParse by adding more virtual functions.

2013-01-10 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change. Change subject: Use less RTTI in PDFParse by adding more virtual functions. .. Patch Set 3: Abandoned -- To view, visit https://gerrit.libreoffice.org/1035 To unsubscribe, visit https:

[PATCH] Change in core[libreoffice-4-0]: fdo#58069: Invalidate sheet stream cache when directory path...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1634 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1634/1 fdo#58069: Invalidate sheet stream cache when directory path changes. To properly regenerate hyperlinks (among o

RE: [libreoffice-dev] - questions about calc extension

2013-01-10 Thread Rai, Neeraj
Hi Michael, That's loads of good info. Looking at your link below and browsing around, I realised what Stephen meant when he used "EasyHacks" in one of the replies. For now I'll stick with the 3.6.4.3 and refer to release notes as I upgrade to newer versions. Thanks Neeraj -Original Messag

[Libreoffice-commits] .: sc/inc sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/inc/document.hxx |1 + sc/source/core/data/document.cxx | 11 +++ sc/source/ui/docshell/docsh.cxx | 38 +- 3 files changed, 49 insertions(+), 1 deletion(-) New commits: commit 831d1b6e62e91e67f171bd00305651043731d496 Author: Koh

[PATCH] Remove useless callback in unix socket implementation

2013-01-10 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1633 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1633/1 Remove useless callback in unix socket implementation Change-Id: Ibe46e2f1628f4d2e4840429703e0d5a69059a188 --- M

Re: gmake: CXXFLAGS override gb_Library_add_cxxflags

2013-01-10 Thread Matúš Kukan
On 10 January 2013 09:16, Stephan Bergmann wrote: > Ah, so Petr's "IMHO, it would make sense to use CXXFLAGS after the default > global flags but before the source file specific flags" sounds reasonable to > me. See https://gerrit.libreoffice.org/#/c/1632/ for a reasonable easy way to do this. It

[PATCH] append library specific compile flags at the end

2013-01-10 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1632 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/1632/1 append library specific compile flags at the end Change-Id: If9d4640b59dd411734a581c66f9310d31ab9fbb7 --- M sole

Re: Developer Input for Bugs

2013-01-10 Thread Kohei Yoshida
On 01/10/2013 02:18 PM, Joel Madero wrote: 59209 New option 'Ignore system input language' has no help. I just confirmed this. -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.f

Developer Input for Bugs

2013-01-10 Thread Joel Madero
Hi All, In order for QA team to meet our goal of having all bugs against 4.0 triaged by next week we're going to need some devs to get involved for the more technical ones or ones that we just need other input. I'm going to keep this thread updated with a list, here is a very short list to be

RE: [libreoffice-dev] - questions about calc extension

2013-01-10 Thread Rai, Neeraj
Hi Kohei, Using unlockController/lock brought down the time from 12sec to 3sec. Using DataArray brought it down to 14ms! Thanks for the tips. Great thing about starting with bad code is that I get to feel happy when it improves :-) Hi Michael, Who would have thought it was a script :-) Maybe

Re: Failure to build 3.6 branch

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Alexander Thurgood wrote: > Le 10/01/13 12:24, Caolán McNamara a écrit : > > I wonder if that file has grown too big for your toolchain. Try > > splitting up the file into two and see if you can get it to compile that > > way. > > Unfortunately, you have lost me ther

Re: Need confirmation about non-clearing of Character Styles

2013-01-10 Thread Fernand Vanrie
Caolán , thanks for the background and your atention to this problem OK but ...its still very confusing for most users they can clear all "direct formating" in the right place, the formating menu they can clear "Paragraph formating" produced by a style using the Formating Toolbar option wh

Re: replacing OUString::valueOf(static_cast) ??

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Noel Grandin wrote: > You are correct, we are indeed talking past each other. > If you go back to the very first message in this thread, the patch > mentioned there will perhaps help to establish come context. > > But I will try to explain again. > > The constructors

[REVIEW-4-0] oxygen-gtk support version ...

2013-01-10 Thread Michael Meeks
Hi there, On Wed, 2013-01-09 at 21:08 +0400, Ruslan Kabatsayev wrote: > >> gtk_init_check( &nParams, &pCmdLineAry ); > >> +g_setenv("LibreOffice_Version","4.0.0.0",true); ... > >> Of course, "4.0.0.0" should be replaced by some variable, name of > >> which I currently don't know. But how

Re: Need confirmation about non-clearing of Character Styles

2013-01-10 Thread Fernand Vanrie
Michael plaese see also my reply to Caloán On 10/01/13 14:25, Caolán McNamara wrote: On Thu, 2013-01-10 at 10:55 +0100, Fernand Vanrie wrote: Sinds all or editors use LO 3.6.2 (before OO3.3) We have complains about the fact that parts of the text, who are formated with a Character Style, can n

[Libreoffice-commits] .: 2 commits - config/config_version.h.in configure.ac vcl/inc vcl/source vcl/unx

2013-01-10 Thread Libreoffice Gerrit user
config/config_version.h.in | 14 ++ configure.ac | 18 ++ vcl/inc/svdata.hxx |5 + vcl/source/app/svapp.cxx |4 vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |4 vcl

Re: replacing OUString::valueOf(static_cast) ??

2013-01-10 Thread Noel Grandin
On Thu, Jan 10, 2013 at 5:31 PM, Lubos Lunak wrote: > On Thursday 10 of January 2013, Noel Grandin wrote: > > On 2013-01-10 15:55, Lubos Lunak wrote: > > > - There's no need for valueOfChar(). There is already OUString ctor > from > > > sal_Unicode, so the valueOf() overload for it is just making

Re: Failure to build 3.6 branch

2013-01-10 Thread Alexander Thurgood
Le 10/01/13 12:24, Caolán McNamara a écrit : > I wonder if that file has grown too big for your toolchain. Try > splitting up the file into two and see if you can get it to compile that > way. > Unfortunately, you have lost me there. I wouldn't know how to do that. I'm only trying to build at al

[PATCH] Change in core[libreoffice-4-0]: fdo#58531: Register cells with external references at compil...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1631 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/1631/1 fdo#58531: Register cells with external references at compile time. In the old code, we would do this during int

[Libreoffice-commits] .: sc/inc sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/inc/compiler.hxx |1 + sc/inc/externalrefmgr.hxx|4 ++-- sc/source/core/tool/compiler.cxx | 31 +++ 3 files changed, 34 insertions(+), 2 deletions(-) New commits: commit 3d78fe6b23eb3d6552bf5ed65f3a8ead081533d1 Author: Kohei Yoshida D

[REVIEW 4.0] BitmapEx* -> BitmapEx [was: Re: LATE FEATURE: Personas in LibreOffice]

2013-01-10 Thread Jan Holesovsky
Hi Michael, Michael Meeks píše v Út 08. 01. 2013 v 14:21 +: > But +1 from me for the -4-0 branch - assuming we can get another couple > of reviews. As a quibble, I'd prefer to see BitmapEx's instead of > BitmapEx*'s being used in the settings - which would simplify the code > and make i

Re: Need confirmation about non-clearing of Character Styles

2013-01-10 Thread Caolán McNamara
On Thu, 2013-01-10 at 15:10 +0100, Michael Stahl wrote: > There should be some button to reset formatting that leaves character > styles intact, and that should be the "most easily accessible" option. > ... hyperlinks should not be touched by any "reset formatting" ... And that's what we've got w

Re: [libreoffice-dev] - questions about calc extension

2013-01-10 Thread Michael Stahl
On 10/01/13 16:42, Rai, Neeraj wrote: > Hi Stephan, > > I am unable to find XDesktop2. Your sample below looks really simple > and right way to go. I am working with release version 3.6.4.3 - > built it from tar files. XDesktop2 was only added a month ago, so it's only in 4.0. of course when usi

minutes of ESC call ...

2013-01-10 Thread Michael Meeks
* Present: + Fridrich, Stephan, Andras, Joel, Caolan, Markus, Norbert, Bjoern, Thorsten, Ahmad, Astron, Michael M, Eike, Michael S, Petr, Cedric. * Completed Action Items + need to rename the MIGRATED flag and unwind / test re-migration (Michael)

License Statement for Contributions

2013-01-10 Thread Lester Kakol
Hello, All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Cheers, -Lester Kakol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffi

[Libreoffice-commits] .: basegfx/inc

2013-01-10 Thread Libreoffice Gerrit user
basegfx/inc/basegfx/polygon/b2dpolypolygoncutter.hxx | 104 --- 1 file changed, 68 insertions(+), 36 deletions(-) New commits: commit 9a11737360528249437bccbb374201453f5cddfe Author: Thorsten Behrens Date: Thu Jan 10 17:50:02 2013 +0100 Doxygenify helpful basegfx comments

Re: Doing massive source changes

2013-01-10 Thread Lubos Lunak
On Saturday 05 of January 2013, Michael Meeks wrote: > On Fri, 2013-01-04 at 15:12 +0100, Lubos Lunak wrote: > Having said that - it is something we really want to do; can we drop > the published easy hack bug in this regard (or just close it) to avoid > the drip of patches there ? I'm not

Re: [libreoffice-dev] - questions about calc extension

2013-01-10 Thread Michael Meeks
> > What's your hunch about how long it should take to update 60K cells with > > {getCellByPosition(ii,jj) and setValue() } ? It should be ~instant - sub-second anyhow; it's an analog of loading values from ODS. Kohei's suggestions are great: > On Thu, 2013-01-10 at 10:59 -0500, Kohei Y

[Libreoffice-commits] .: src/docrecord.py src/docstream.py

2013-01-10 Thread Miklos Vajna
src/docrecord.py | 39 +++ src/docstream.py |5 - 2 files changed, 43 insertions(+), 1 deletion(-) New commits: commit 867beebfcbb643f924e54f95e7238e975f334db5 Author: Miklos Vajna Date: Thu Jan 10 17:25:10 2013 +0100 dump PlfLst diff --git a

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58275, which changed state. Bug 58275 Summary: Install fails if .NET Framework 4.0 (Client) is not present https://bugs.freedesktop.org/show_bug.cgi?id=58275 What|Removed |Added ---

Re: [libreoffice-dev] - questions about calc extension

2013-01-10 Thread Kohei Yoshida
On 01/10/2013 10:50 AM, Rai, Neeraj wrote: Hi Michael, Appreciate your feedback. I ran callgrind but no output on screen and 0 bytes files generated. I can run it on non-LO exe. I'll compile LO with --enable-debug and see if situation improves. Please advise if other steps might be needed. Wh

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#58301 make sure ScrollBar OptimalSize is up to...

2013-01-10 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1630 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/1630/1 Resolves: fdo#58301 make sure ScrollBar OptimalSize is up to date if the scrollbar sizes haven't been calculated

Re: Extending Dictionaries

2013-01-10 Thread Petr Mladek
Samuel Mehrbrodt píše v Čt 03. 01. 2013 v 23:30 +0100: > I just sent you a list of words directly. > > Can we document this somewhere in the Wiki, how to add new words to a > dictionary? I guess there are more people wanting to do this. I have created https://wiki.documentfoundation.org/Developm

RE: [libreoffice-dev] - questions about calc extension

2013-01-10 Thread Rai, Neeraj
Hi Michael, Appreciate your feedback. I ran callgrind but no output on screen and 0 bytes files generated. I can run it on non-LO exe. I'll compile LO with --enable-debug and see if situation improves. Please advise if other steps might be needed. What's your hunch about how long it should take

Re: gb_COMPILERNOOPTFLAGS does not even obey the user passed CFLAGS

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Tomáš Chvátal wrote: > 2013/1/10 Lubos Lunak : > >> As written in subject the variable is used on multiple targets and it > >> ignores the user defined cflags/cxxflags. > >> This should never happen and all our targets should take into effect the > >> user defined op

[PATCH] Change in core[libreoffice-4-0]: fdo#57938 SwPaM::HasReadonlySel: commented text ranges are n...

2013-01-10 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1629 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/1629/1 fdo#57938 SwPaM::HasReadonlySel: commented text ranges are not read-only (cherry picked from commit fd0da52d371c

RE: [libreoffice-dev] - questions about calc extension

2013-01-10 Thread Rai, Neeraj
Hi Stephan, I am unable to find XDesktop2. Your sample below looks really simple and right way to go. I am working with release version 3.6.4.3 - built it from tar files. I don't mind upgrading to latest tip, but I had trouble building the git checkout version. Being fairly new to this large and

Re: replacing OUString::valueOf(static_cast) ??

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Noel Grandin wrote: > On 2013-01-10 15:55, Lubos Lunak wrote: > > - There's no need for valueOfChar(). There is already OUString ctor from > > sal_Unicode, so the valueOf() overload for it is just making an obvious > > thing complicated. Code using it can be converte

[Libreoffice-commits] .: sw/source

2013-01-10 Thread Libreoffice Gerrit user
sw/source/core/crsr/pam.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit fd0da52d371ca13d66be3b04d89f9d9cf73baddd Author: Miklos Vajna Date: Thu Jan 10 16:21:55 2013 +0100 fdo#57938 SwPaM::HasReadonlySel: commented text ranges are not read-only diff

Re: [libreoffice-l10n] Translation of the names of the keys on Windows

2013-01-10 Thread Adolfo Jayme Barrientos
On Tue, Jan 8, 2013 at 7:44 AM, Jesús Corrius wrote: > If you want to implement this, but you are not a developer, just send me > the name of the keys with its translation and I will apply the changes > myself. Hi, I was wondering if you could add a Spanish translation: static const struct KeysN

[Libreoffice-commits] .: cppcanvas/source

2013-01-10 Thread Libreoffice Gerrit user
cppcanvas/source/mtfrenderer/emfplus.cxx | 45 +++ 1 file changed, 45 insertions(+) New commits: commit da09115cffeca384ab91ffe4d7af4d8eab6cee82 Author: Radek Doulik Date: Thu Jan 10 15:58:30 2013 +0100 implemented EmfPlusRecordTypeFillPie record Cha

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - config_host.mk.in configure.ac solenv/gbuild

2013-01-10 Thread Libreoffice Gerrit user
config_host.mk.in |1 + configure.ac| 19 +++ solenv/gbuild/gbuild.mk |4 3 files changed, 24 insertions(+) New commits: commit f0fd3bd8f8a13f6cbe2a27018b83eee24a694c09 Author: Tomas Chvatal Date: Mon Dec 10 10:41:35 2012 +0100 Add configur

Re: [libreoffice-marketing] Latest Hardware and OS

2013-01-10 Thread Rainer Bielefeld
Tom Davies schrieb: At the moment those devices are probably not seen as good things to use to edit documents. Hi all, of course (nearby) nobody will use an Android Handy to write a Novel or similar; nevertheless, yesterday in the omnibus, I watched a young woman and was fascinated concer

Re: replacing OUString::valueOf(static_cast) ??

2013-01-10 Thread Stephan Bergmann
On 01/10/2013 02:55 PM, Lubos Lunak wrote: On Thursday 10 of January 2013, Noel Grandin wrote: https://gerrit.libreoffice.org/#/c/1625/ Can we please keep the discussion still here? Gerrit may be fine for pointing out technical details in the code, but it's not very suitable for discussions

Re: Need confirmation about non-clearing of Character Styles

2013-01-10 Thread Michael Stahl
On 10/01/13 14:25, Caolán McNamara wrote: > On Thu, 2013-01-10 at 10:55 +0100, Fernand Vanrie wrote: >> Sinds all or editors use LO 3.6.2 (before OO3.3) >> >> We have complains about the fact that parts of the text, who are >> formated with a Character Style, can not been "cleared" to >> no-formati

Re: replacing OUString::valueOf(static_cast) ??

2013-01-10 Thread Noel Grandin
On 2013-01-10 15:55, Lubos Lunak wrote: On Thursday 10 of January 2013, Noel Grandin wrote: Created a proof-of-concept patch along with some unit tests and pushed to gerrit: https://gerrit.libreoffice.org/#/c/1625/ Can we please keep the discussion still here? Gerrit may be fine for pointin

Re: gb_COMPILERNOOPTFLAGS does not even obey the user passed CFLAGS

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Tomáš Chvátal wrote: > Hi guys, > > As written in subject the variable is used on multiple targets and it > ignores the user defined cflags/cxxflags. > This should never happen and all our targets should take into effect the > user defined options too. > > I am not s

Re: replacing OUString::valueOf(static_cast) ??

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Noel Grandin wrote: > On 2013-01-09 19:58, Michael Meeks wrote: > > At least in my mind :-) but we're starting to bike-shed here... I > > didn't see anyone volunteering to do the actual batch cleanup there > > ;-) Regards, Michael. > > Created a proof-of-concept patc

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#59112 re-scroll to current entry when dialog r...

2013-01-10 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1628 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/1628/1 Resolves: fdo#59112 re-scroll to current entry when dialog resized Change-Id: I96486f6edad11520bf9bb43b700b1716d

[Libreoffice-commits] .: sc/source

2013-01-10 Thread Libreoffice Gerrit user
sc/source/ui/dbgui/sortkeydlg.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 2c403c7f36561410418ebb9f86664e46a8c1c968 Author: Caolán McNamara Date: Thu Jan 10 13:49:20 2013 + Resolves: fdo#59112 re-scroll to current entry when dialog resized Change-Id: I964

gb_COMPILERNOOPTFLAGS does not even obey the user passed CFLAGS

2013-01-10 Thread Tomáš Chvátal
Hi guys, As written in subject the variable is used on multiple targets and it ignores the user defined cflags/cxxflags. This should never happen and all our targets should take into effect the user defined options too. I am not sure which variable I should append there, so could anyone check if

[Libreoffice-commits] .: 4 commits - bridges/Module_bridges.mk cross_tail_build/Makefile Makefile.in solenv/bin solenv/gbuild tail_build/Makefile

2013-01-10 Thread Libreoffice Gerrit user
Makefile.in | 11 ++-- bridges/Module_bridges.mk |2 cross_tail_build/Makefile |1 solenv/bin/build.pl |2 solenv/gbuild/Module.mk | 61 +--

[Libreoffice-commits] .: 3 commits - configure.ac

2013-01-10 Thread Libreoffice Gerrit user
configure.ac | 109 +-- 1 file changed, 61 insertions(+), 48 deletions(-) New commits: commit 417943f071cc6c7ebe4dad69dfdec411cc7de975 Author: Tor Lillqvist Date: Thu Jan 10 15:41:02 2013 +0200 Get rid of last actual TABs in this fi

Re: Need confirmation about non-clearing of Character Styles

2013-01-10 Thread Caolán McNamara
On Thu, 2013-01-10 at 10:55 +0100, Fernand Vanrie wrote: > Sinds all or editors use LO 3.6.2 (before OO3.3) > > We have complains about the fact that parts of the text, who are > formated with a Character Style, can not been "cleared" to > no-formating, > not by "Clear Direct Formating (cntrl+M)"

Re: FYI: Make for faster windows build

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Michael Meeks wrote: > On Wed, 2013-01-09 at 20:01 +0100, Lubos Lunak wrote: > > Looks what I found under the tree! Faster make for Cygwin. Granted, I had > > put it there first, but still nice. > > Nice work ! :-) > > I'd love to see a configure option:

Re: FYI: Make for faster windows build

2013-01-10 Thread Lubos Lunak
On Thursday 10 of January 2013, Noel Grandin wrote: > I think the WINDOWS32 #define is for building a "native" windows binary. > (There is also stuff in there for building under AmigaOS and DOS, the > gnumake code is pretty grotty) > > The cywin stuff is probably using a #ifdef CYGWIN. I don't se

Re: WITH_MOZAB4WIN needing msvc?80.dll

2013-01-10 Thread Michael Stahl
On 10/01/13 14:01, Lubos Lunak wrote: > > Hello, > > as far as I understand it, the current problem with > W2008R2_20-With-Symbol-Bytemark-Hosting [*] , is caused by needing > specifically *80 msvc dlls for WITH_MOZAB4WIN (grep under scp2 for the > only 'msvcp' there). Does somebody have any

[PUSHED] Fix some errors and remove duplicate code on Presenter

2013-01-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1474 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1474 To unsubscribe, vi

[PUSHED] fdo#57422 - presenter console RTL support needs completion

2013-01-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1284 Approvals: Faisal al-otaibi: Looks good to me, but someone else must approve Caolán McNamara: Verified; Looks good to me, approved -- T

[Libreoffice-commits] .: sdext/source

2013-01-10 Thread Libreoffice Gerrit user
sdext/source/presenter/PresenterToolBar.cxx | 162 +++- 1 file changed, 41 insertions(+), 121 deletions(-) New commits: commit b0a827aa839afefd580c438ea72a7e5ca0b88aea Author: Faisal M. Al-Otaibi Date: Sun Dec 23 12:18:20 2012 +0300 Fix some errors and remove dupl

[Libreoffice-commits] .: sdext/source

2013-01-10 Thread Libreoffice Gerrit user
sdext/source/presenter/PresenterSlideSorter.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit eb0d07d3f2937315700dabf72d366f5ef4d4200d Author: Abdulelah Alarifi Date: Wed Dec 12 13:26:55 2012 +0300 fdo#57422 - presenter console RTL support needs comp

Re: [libreoffice-l10n] Translation of the names of the keys on Windows

2013-01-10 Thread Martin Srebotnjak
Hi, here is the Slovenian replacement table, please add it to the code: static const struct KeysNameReplacement aImplReplacements_Slovenian[] = { { KEY_ESC, "Ubežnica" }, { KEY_BACK, "Vračalka" }, { KEY_ENTER, "Vnašalka" }, { KEY_SPACEBAR, "Preslednica" }, { KEY_HOME, "Začetek" }, { KEY_UP,

WITH_MOZAB4WIN needing msvc?80.dll

2013-01-10 Thread Lubos Lunak
Hello, as far as I understand it, the current problem with W2008R2_20-With-Symbol-Bytemark-Hosting [*] , is caused by needing specifically *80 msvc dlls for WITH_MOZAB4WIN (grep under scp2 for the only 'msvcp' there). Does somebody have any idea why it's specifically this version and if it'

[Libreoffice-commits] .: slideshow/Library_OGLTrans.mk slideshow/source

2013-01-10 Thread Libreoffice Gerrit user
slideshow/Library_OGLTrans.mk |2 slideshow/source/engine/OGLTrans/win/OGLTrans_Shaders.cxx | 142 -- 2 files changed, 1 insertion(+), 143 deletions(-) New commits: commit 6312695ad694598951f2cdd4ac26c53457fedb79 Author: Tor Lillqvist Date: Thu Jan

[PUSHED] - fdo#46460 - Missing Circles and Ovals toolbar

2013-01-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1456 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1456 To unsubscribe, vi

[PATCH] Change in core[libreoffice-4-0]: - fdo#46460 - Missing Circles and Ovals toolbar

2013-01-10 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1627 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/1627/1 - fdo#46460 - Missing Circles and Ovals toolbar Change-Id: I08f2cef9c16ac998663f634653dad37a201f50c5 Reviewed-on

[Libreoffice-commits] .: officecfg/registry

2013-01-10 Thread Libreoffice Gerrit user
officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dcd974c3ca70065ba1d984ad6bd5514848cd58a9 Author: Rob Snelders Date: Thu Dec 20 21:40:22 2012 +0100 - fdo#46460 - Missing Circles and Ovals tool

[PUSHED] Change in core[libreoffice-3-6]: Always default-select English dictionary

2013-01-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1613 Approvals: Caolán McNamara: Verified; Looks good to me, approved Eike Rathke: Looks good to me, approved -- To view, visit https://gerr

[PUSHED] Change in core[libreoffice-4-0]: Always default-select English dictionary

2013-01-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1614 Approvals: Caolán McNamara: Verified; Looks good to me, approved Eike Rathke: Looks good to me, approved -- To view, visit https://gerr

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - setup_native/source

2013-01-10 Thread Libreoffice Gerrit user
setup_native/source/packinfo/spellchecker_selection.pl |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 86ca8cfe7ff5bfb889f3d65b1647839965fc88a7 Author: Stephan Bergmann Date: Wed Jan 9 15:09:58 2013 +0100 Always default-select English dictionary It

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - setup_native/source

2013-01-10 Thread Libreoffice Gerrit user
setup_native/source/packinfo/spellchecker_selection.pl |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 9299707ce09077f10c49ec836e26f6197ed20a1a Author: Stephan Bergmann Date: Wed Jan 9 15:09:58 2013 +0100 Always default-select English dictionary It

[PUSHED] Added Table Properties Widget

2013-01-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1511 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1511 To unsubscribe, vi

[PUSHED] Change in core[libreoffice-4-0]: fdo#58909: Missing BAK_EXTENSIONS bootstrap variable

2013-01-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1626 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1626 To unsubscribe, vi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - desktop/source scp2/source

2013-01-10 Thread Libreoffice Gerrit user
desktop/source/deployment/manager/dp_manager.cxx |2 +- scp2/source/ooo/common_brand.scp |8 scp2/source/ooo/profileitem_ooo.scp |9 + 3 files changed, 18 insertions(+), 1 deletion(-) New commits: commit 147ce2ebeeac686d0a8e9e3d6d804aeba0f

  1   2   >