[PATCH] Remove unneeded #include

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1637 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/1637/1 Remove unneeded #include Change-Id: Ic0c82079aeb586af97c864aebf966f01643ebfd6 --- M

[PATCH] Use member initializer list in constructor

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1640 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/1640/1 Use member initializer list in constructor Change-Id: I8d4f8b95909b91917b456f49d7a3ac270703cc96 --- M

[PATCH] Remove unused class members

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1638 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/1638/1 Remove unused class members Change-Id: I44fe6ad3dacc65e28256aca98588b7dfe92d73ae --- M sw/inc/hhcwrp.hxx M

[PATCH] Character conversion: do not destroy sequence while iteratin...

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1636 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/1636/1 Character conversion: do not destroy sequence while iterating on it Change-Id:

[PATCH] Remove unused #define

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1641 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/1641/1 Remove unused #define Change-Id: Ic92663d13892d7e4978b5f3a10ed7f473e091835 --- M sw/source/ui/lingu/hhcwrp.cxx

[PATCH] Use forward declaration instead of (doubled) #include

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1642 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1642/1 Use forward declaration instead of (doubled) #include Change-Id: I1cfb65a809e5dd56fb395c2f801bce5e5d75acfe ---

[PATCH] Prefix class data members

2013-01-11 Thread Matteo Casalin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1639 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/1639/1 Prefix class data members Change-Id: I6734df58b589088809c712c3906f0cee3fd6a103 --- M sw/inc/hhcwrp.hxx M

[Libreoffice-commits] .: 2 commits - configure.ac

2013-01-11 Thread Libreoffice Gerrit user
configure.ac |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit fee278b222f1a8d15706b78cc0e39a1300c19186 Author: Tor Lillqvist t...@iki.fi Date: Fri Jan 11 10:16:43 2013 +0200 Warning is now unnecessary as there are no real TABs any more here

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/core/doc/docedt.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 36c5abb012e48f0c7e8b8b0d50e562b423e43869 Author: Matteo Casalin matteo.casa...@gmx.com Date: Mon Jan 7 23:41:15 2013 +0100 Remove unneeded #include Change-Id:

[PUSHED] Remove unneeded #include

2013-01-11 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1637 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1637 To unsubscribe,

[Libreoffice-commits] .: 2 commits - avmedia/source canvas/source cui/source desktop/source extensions/source framework/source scp2/source sd/source sfx2/source slideshow/source solenv/gbuild solenv/i

2013-01-11 Thread Libreoffice Gerrit user
avmedia/source/inc/mediamisc.hxx |2 - canvas/source/cairo/cairo_devicehelper.cxx|2 - canvas/source/cairo/cairo_quartz_cairo.cxx|2 - canvas/source/cairo/cairo_textlayout.cxx |

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/core/doc/docedt.cxx | 27 --- 1 file changed, 27 deletions(-) New commits: commit 2c1eca7bd70ff5f66132aeb8d3919a1362fb3e57 Author: Miklos Vajna vmik...@suse.cz Date: Fri Jan 11 10:19:53 2013 +0100 sw: more unused includes in docedt diff --git

[Libreoffice-commits] .: sw/inc

2013-01-11 Thread Libreoffice Gerrit user
sw/inc/hhcwrp.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1af49927f56c97baf4dec4d0a54faff251126db7 Author: Matteo Casalin matteo.casa...@gmx.com Date: Fri Jan 11 08:12:12 2013 +0100 Use forward declaration instead of (doubled) #include

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/ui/lingu/hhcwrp.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit bbab2d865996e7f3ed52f4d70358bb16bb73a81b Author: Matteo Casalin matteo.casa...@gmx.com Date: Fri Jan 11 08:00:16 2013 +0100 Remove unused #define Change-Id:

[PUSHED] Use forward declaration instead of (doubled) #include

2013-01-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1642 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1642 To unsubscribe,

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/core/txtnode/txtedt.cxx | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) New commits: commit a0477d991661de605aec4fec87ca52e32ec8f743 Author: Matteo Casalin matteo.casa...@gmx.com Date: Mon Jan 7 22:20:59 2013 +0100 Character conversion: do not

[Libreoffice-commits] .: sw/inc sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/inc/hhcwrp.hxx |3 --- sw/source/ui/lingu/hhcwrp.cxx |8 +--- 2 files changed, 1 insertion(+), 10 deletions(-) New commits: commit 9d3789af2b509a8a8a1c9a923218d67104f11f3f Author: Matteo Casalin matteo.casa...@gmx.com Date: Mon Jan 7 23:42:10 2013 +0100 Remove

[PUSHED] Character conversion: do not destroy sequence while iteratin...

2013-01-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1636 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1636 To unsubscribe,

[PUSHED] Remove unused class members

2013-01-11 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1638 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1638 To unsubscribe,

[Libreoffice-commits] .: sd/source

2013-01-11 Thread Libreoffice Gerrit user
sd/source/ui/annotations/annotationmanager.cxx | 127 - 1 file changed, 62 insertions(+), 65 deletions(-) New commits: commit 8bb976bae46a88ae3534078ec22ba8a25da68249 Author: Matteo Casalin matteo.casa...@gmx.com Date: Fri Jan 11 10:15:40 2013 +0100 Fix format

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/filter/ww8/rtfexport.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit c031fde0518257b3272d5baa3de29ba5a0a90a89 Author: Miklos Vajna vmik...@suse.cz Date: Fri Jan 11 10:30:18 2013 +0100 RtfExport::WriteInfo: use config_version.h diff --git

[Libreoffice-commits] .: 2 commits - sal/osl

2013-01-11 Thread Libreoffice Gerrit user
sal/osl/unx/socket.c | 14 -- sal/osl/unx/sockimpl.h |4 sal/osl/w32/socket.cxx | 10 -- sal/osl/w32/sockimpl.h |4 4 files changed, 32 deletions(-) New commits: commit 69f2f50c99ba218b185d94b118b38ea92b6560a0 Author: Stephan Bergmann

[PUSHED] Remove useless callback in unix socket implementation

2013-01-11 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1633 -- To view, visit https://gerrit.libreoffice.org/1633 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[Libreoffice-commits] 4 commits - bin/tinbuild2 bin/tinbuild_internals.sh README.tinbuild2

2013-01-11 Thread Libreoffice Gerrit user
README.tinbuild2 | 282 +++--- bin/tinbuild2 | 28 bin/tinbuild_internals.sh |6 3 files changed, 199 insertions(+), 117 deletions(-) New commits: commit 57b2c1cf905f327d8a81c730091ca65bbda49cda Author: Norbert Thiebaud

[Libreoffice-commits] bin/tinbuild_internals.sh

2013-01-11 Thread Libreoffice Gerrit user
bin/tinbuild_internals.sh | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) New commits: commit 279429cc7b1fbfd291cac15de574508b3ab1d2ae Author: Norbert Thiebaud nthieb...@gmail.com Date: Wed Jan 9 20:31:09 2013 -0600 allow thr next_priority setting to survice the

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - vcl/inc vcl/source

2013-01-11 Thread Libreoffice Gerrit user
vcl/inc/vcl/settings.hxx | 10 +- vcl/source/app/settings.cxx | 38 +++--- vcl/source/window/dockingarea.cxx |8 vcl/source/window/menu.cxx| 12 ++-- 4 files changed, 30 insertions(+), 38 deletions(-) New

Re: [PUSHED 4.0] BitmapEx* - BitmapEx [was: Re: LATE FEATURE: Personas in LibreOffice]

2013-01-11 Thread Miklos Vajna
On Thu, Jan 10, 2013 at 06:10:30PM +0100, Jan Holesovsky ke...@suse.cz wrote: Ah right, can you please cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=0721b5b83e34de1e2fcb320d6a7deae1ad109d61 to libreoffice-4-0? :-) Makes sense, pushed to -4-0. signature.asc

REMINDER: Release 3.6.5.1 from libreoffice-3-6 branch

2013-01-11 Thread Petr Mladek
Hi, please note that the commit deadline for 3.6.5.1 (aka rc1) is on Monday, January 14, 2013. The tag and branch libreoffice-3-6-5 is going to be created the day after. Only commits with 3 reviewers will be allowed for that branch. IMPORTANT: If there are not found serious regressions, we

[Libreoffice-commits] .: 3 commits - o3tl/inc sw/inc sw/source

2013-01-11 Thread Libreoffice Gerrit user
o3tl/inc/o3tl/sorted_vector.hxx| 12 +++- sw/inc/ndhints.hxx |2 - sw/source/core/txtnode/ndhints.cxx | 52 ++--- sw/source/ui/shells/textsh1.cxx|1 4 files changed, 21 insertions(+), 46 deletions(-) New commits: commit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - o3tl/inc sw/source

2013-01-11 Thread Libreoffice Gerrit user
o3tl/inc/o3tl/sorted_vector.hxx| 12 - sw/source/core/txtnode/ndhints.cxx | 48 + 2 files changed, 18 insertions(+), 42 deletions(-) New commits: commit cdd0555aefa0a01d0d90fed8640811c5601f314e Author: Michael Stahl mst...@redhat.com Date:

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-11 Thread Jean-Noël Rouvignac
2013/1/10 Lubos Lunak l.lu...@suse.cz Unless all you want to convert is only places which do the explicit cast, this will need a (fairly simple) Clang plugin. Sure, if you feel like writing one. Actually, I'd prefer to write a howto about that first, whenever I get to doing that,

[Libreoffice-commits] .: src/docrecord.py

2013-01-11 Thread Miklos Vajna
src/docrecord.py | 78 +++ 1 file changed, 78 insertions(+) New commits: commit c3e2a6ffa100fb6267aca568cab282b78fcd160f Author: Miklos Vajna vmik...@suse.cz Date: Fri Jan 11 11:31:44 2013 +0100 dump LVL and LVLF diff --git

[Libreoffice-commits] bin/tinbuild_internals.sh

2013-01-11 Thread Libreoffice Gerrit user
bin/tinbuild_internals.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 27cd6c50aeee137fd93e6dce3fd246d2fc2a2554 Author: Norbert Thiebaud nthieb...@gmail.com Date: Fri Jan 11 04:53:55 2013 -0600 tb2: the way to report success/failed in gerrit

Re: Need confirmation about non-clearing of Character Styles

2013-01-11 Thread mariosv
Seeing David's proposed option, maybe an easy way: - Select the paragraph or the text to clear the format. - Copy - Paste special as unformatted text. -- View this message in context:

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/core/crsr/pam.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 5a0dc1d1fdeac4b06b39ea616374d3f81b6be8a9 Author: Miklos Vajna vmik...@suse.cz Date: Thu Jan 10 16:21:55 2013 +0100 fdo#57938 SwPaM::HasReadonlySel: commented text ranges are not

[PUSHED] Change in core[libreoffice-4-0]: fdo#57938 SwPaM::HasReadonlySel: commented text ranges are n...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1629 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1629 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - cppcanvas/source

2013-01-11 Thread Libreoffice Gerrit user
cppcanvas/source/mtfrenderer/emfplus.cxx | 45 +++ 1 file changed, 45 insertions(+) New commits: commit 7850822b27981ce46d16532267975b3a91f91102 Author: Radek Doulik r...@novell.com Date: Thu Jan 10 15:58:30 2013 +0100 implemented EmfPlusRecordTypeFillPie

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58699, which changed state. Bug 58699 Summary: Impress remote doesn't close https://bugs.freedesktop.org/show_bug.cgi?id=58699 What|Removed |Added

[Libreoffice-commits] .: src/docrecord.py src/docstream.py test/doc

2013-01-11 Thread Miklos Vajna
src/docrecord.py | 67 +- src/docstream.py |5 +++- test/doc/list.doc |binary test/doc/list.rtf | 49 +++ test/doc/test.py |6 5 files changed, 120 insertions(+), 7 deletions(-) New

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-11 Thread Michael Meeks
On Fri, 2013-01-11 at 08:46 +0200, Noel Grandin wrote: That seems like it would have some backwards compatibility issues, but I suppose we could mark them as deprecated for a time before actually removing them. Sure - well, since they're in-lined I think this is prolly a sensible

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/inc sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/inc/compiler.hxx |1 + sc/inc/externalrefmgr.hxx|4 ++-- sc/source/core/tool/compiler.cxx | 31 +++ 3 files changed, 34 insertions(+), 2 deletions(-) New commits: commit 260f1b19ce7340b02fce5aea948caa61ee128f44 Author: Kohei Yoshida

[PUSHED] Change in core[libreoffice-4-0]: fdo#58531: Register cells with external references at compil...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1631 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1631 To unsubscribe, visit

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-11 Thread Jan Holesovsky
Hi Noel, Noel Grandin píše v Pá 11. 01. 2013 v 08:46 +0200: - There's no need for valueOfChar(). There is already OUString ctor from sal_Unicode, so the valueOf() overload for it is just making an obvious thing complicated. Code using it can be converted to use the ctor instead. I've

[Libreoffice-commits] .: src/docrecord.py src/docstream.py

2013-01-11 Thread Miklos Vajna
src/docrecord.py | 21 + src/docstream.py |5 - 2 files changed, 25 insertions(+), 1 deletion(-) New commits: commit 614d9656f45bb48580eee2453b13b351b12a0bcd Author: Miklos Vajna vmik...@suse.cz Date: Fri Jan 11 13:02:56 2013 +0100 dump SttbListNames diff

[Libreoffice-commits] .: 2 commits - config/config_version.h.in configure.ac sc/source sw/source vcl/inc

2013-01-11 Thread Libreoffice Gerrit user
config/config_version.h.in | 12 configure.ac |8 sc/source/filter/xml/xmlstyle.cxx |6 +++--- sw/source/filter/ww8/rtfexport.cxx | 12 +++- vcl/inc/svdata.hxx |3 --- 5 files changed, 30 insertions(+),

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-11 Thread Noel Grandin
On 2013-01-11 14:02, Jan Holesovsky wrote: Noel Grandin píše v Pá 11. 01. 2013 v 08:46 +0200: - There's no need for valueOfChar(). There is already OUString ctor from sal_Unicode, so the valueOf() overload for it is just making an obvious thing complicated. Code using it can be converted to

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-11 Thread Jan Holesovsky
Hi Noel, Noel Grandin píše v Pá 11. 01. 2013 v 14:12 +0200: Or did you mean something different? OK, in that case, I'll drop the valueOfChar() methods. If others agree too - would you please mark the valueOf( sal_Unicode ) and valueOf( sal_Bool ) as deprecated when you are at that? [And

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Depends on||58998 ---

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-11 Thread Stephan Bergmann
On 01/11/2013 01:02 PM, Jan Holesovsky wrote: - It's a question if we really need 'OUString::valueOfBool( foo )' instead of simply 'foo ? OUString( true ) : OUString( false )' (such a pity the string literals handling doesn't allow foo ? true : false' ). I wonder how many places in the code

[Libreoffice-commits] .: apache-commons/ExternalProject_apache_commons_codec.mk apache-commons/ExternalProject_apache_commons_httpclient.mk apache-commons/ExternalProject_apache_commons_lang.mk apache

2013-01-11 Thread Libreoffice Gerrit user
apache-commons/ExternalProject_apache_commons_codec.mk |5 - apache-commons/ExternalProject_apache_commons_httpclient.mk |5 - apache-commons/ExternalProject_apache_commons_lang.mk |5 - apache-commons/ExternalProject_apache_commons_logging.mk|5 - config_host.mk.in

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-11 Thread Lubos Lunak
On Friday 11 of January 2013, Noel Grandin wrote: On 2013-01-10 15:55, Lubos Lunak wrote: - There's no need for valueOfChar(). There is already OUString ctor from sal_Unicode, so the valueOf() overload for it is just making an obvious thing complicated. Code using it can be converted to use

sal: add timeout option when using pipe in connect mode

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: sal: add timeout option when using pipe in connect mode .. Patch Set 1: Abandoned Not needed anymore. -- To view, visit

[PATCH] sw unit test: add call to CalcLayout before using the layout

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1645 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1645/1 sw unit test: add call to CalcLayout before using the layout Change-Id:

[PATCH] doc export: add unit test for bug i106749

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1646 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/1646/1 doc export: add unit test for bug i106749 Change-Id: I1df4cbb013d94cff7ae5195427044b1e1b2d8895 --- A

[PATCH] docx export: invalid sectPr added at the beginning of the do...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1647 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1647/1 docx export: invalid sectPr added at the beginning of the doc This reverts commit

[PATCH] sw unit test: layout dump must be resetted in 'reload' metho...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1643 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/1643/1 sw unit test: layout dump must be resetted in 'reload' method Otherwise tests relying on layout dumps will

[PATCH] docx export: add test case for paragraph mark export

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1650 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/1650/1 docx export: add test case for paragraph mark export Change-Id: I2701ee12221460f8ff19397ea215cc1484648d18 --- A

[PATCH] doc export: add unit test for fdo#56513

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1644 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/1644/1 doc export: add unit test for fdo#56513 Change-Id: Ie87648368f877af56878bc83fe3d5ece66f77304 --- A

[PATCH] docx export: also export rPr in pPr (paragraph mark stylin...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1649 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/1649/1 docx export: also export rPr in pPr (paragraph mark styling) Change-Id:

[PATCH] sax: add methods to duplicate current top marker and reapply...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1648 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/1648/1 sax: add methods to duplicate current top marker and reapply it later The need for this is ooxml: we need to

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/filter/ww8/rtfexport.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3527efa7e078ce11ac537d8f8591b159c05e760f Author: Tor Lillqvist t...@iki.fi Date: Fri Jan 11 15:43:56 2013 +0200 Output version number as text, not binary Change-Id:

Writing new Clang plugins (Re: replacing OUString::valueOf(static_castsal_Int32) ??)

2013-01-11 Thread Lubos Lunak
On Friday 11 of January 2013, Jean-Noël Rouvignac wrote: 2013/1/10 Lubos Lunak l.lu...@suse.cz Unless all you want to convert is only places which do the explicit cast, this will need a (fairly simple) Clang plugin. Sure, if you feel like writing one. Actually, I'd prefer

Re: Failure to build 3.6 branch

2013-01-11 Thread Alexander Thurgood
Le 10/01/13 19:06, Lubos Lunak a écrit : Hi Lubos, I'd rather guess simply a bug in the compiler (since it's on Mac, it's the old gcc-4.0.1, right?). Try if the file compiles successfully with 'make DEBUG=1', that will disable optimizations. No, it is actually gcc 4.2.1, but I'll try

[Libreoffice-commits] .: 3 commits - compilerplugins/clang compilerplugins/README writerfilter/source

2013-01-11 Thread Libreoffice Gerrit user
compilerplugins/README |2 +- compilerplugins/clang/plugin.cxx|5 ++--- writerfilter/source/ooxml/model.xml |5 - 3 files changed, 3 insertions(+), 9 deletions(-) New commits: commit 03910bdfd964ee34bdd93fda3339908cad2b01f4 Author: Luboš Luňák l.lu...@suse.cz

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58531, which changed state. Bug 58531 Summary: FILEOPEN: Reload no longer refreshes external links in 4.0 https://bugs.freedesktop.org/show_bug.cgi?id=58531 What|Removed |Added

Re: Writing new Clang plugins (Re: replacing OUString::valueOf(static_castsal_Int32) ??)

2013-01-11 Thread Jean-Noël Rouvignac
2013/1/11 Lubos Lunak l.lu...@suse.cz On Friday 11 of January 2013, Jean-Noël Rouvignac wrote: 2013/1/10 Lubos Lunak l.lu...@suse.cz Unless all you want to convert is only places which do the explicit cast, this will need a (fairly simple) Clang plugin. Sure, if you

[Libreoffice-commits] .: sal/osl

2013-01-11 Thread Libreoffice Gerrit user
sal/osl/all/log.cxx | 36 1 file changed, 24 insertions(+), 12 deletions(-) New commits: commit 4fbf6df784529d48cf194a2d9c495ffb47933d59 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jan 11 15:46:47 2013 +0100 Fix workaround for thead-unsafe

Re: [PATCH] doc export: add unit test for bug i106749

2013-01-11 Thread Korrawit Pruegsanusak
Hello all, On Fri, Jan 11, 2013 at 8:44 PM, Pierre-Eric Pelloux-Prayer (via Code Review) ger...@gerrit.libreoffice.org wrote: I have submitted a patch for review: https://gerrit.libreoffice.org/1646 doc export: add unit test for bug i106749 IMHO it's great to have many unit tests as

[PATCH] Change in core[libreoffice-3-6]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1651 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/1651/1 fdo#59084: Sync dimension members after reloading the group data. Else the syncing would end up syncing to the

[Libreoffice-commits] .: sw/inc sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/inc/hhcwrp.hxx | 32 ++--- sw/source/ui/lingu/hhcwrp.cxx | 232 +- 2 files changed, 132 insertions(+), 132 deletions(-) New commits: commit 6704bb8eb0ac93da96cf58aac28c4f04e794dfd6 Author: Matteo Casalin matteo.casa...@gmx.com Date: Thu

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/ui/lingu/hhcwrp.cxx | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) New commits: commit 40cfbd62e9f3aa52036a339cbbc9e542647017d3 Author: Matteo Casalin matteo.casa...@gmx.com Date: Thu Jan 10 23:36:51 2013 +0100 Use member initializer list

[PUSHED] Prefix class data members

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1639 Approvals: Noel Power: Verified; Looks good to me, approved Michael Stahl: Verified; Looks good to me, approved -- To view, visit

[PUSHED] Use member initializer list in constructor

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1640 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1640 To unsubscribe, visit

Re: [PATCH] doc export: add unit test for bug i106749

2013-01-11 Thread Michael Meeks
Hi Korrawit, On Fri, 2013-01-11 at 21:58 +0700, Korrawit Pruegsanusak wrote: Do we have a license to use this file? (no offense of course! :) I'm most concerned about the source files; having said that this is not an appropriate forum to raise legal concerns - please spam the legal@

[Libreoffice-commits] .: cui/source

2013-01-11 Thread Libreoffice Gerrit user
cui/source/tabpages/chardlg.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit eccae3ee63cc561c0b0ace0b95e9a2344081bb9c Author: Takeshi Abe t...@fixedpoint.jp Date: Sat Jan 12 00:42:38 2013 +0900 Drop deserted m_aTransparentText Its usage was gone with

Re: Failure to build 3.6 branch

2013-01-11 Thread Alexander Thurgood
Le 11/01/13 14:57, Alexander Thurgood a écrit : I'd rather guess simply a bug in the compiler (since it's on Mac, it's the old gcc-4.0.1, right?). Try if the file compiles successfully with 'make DEBUG=1', that will disable optimizations. No joy, still fails at exactly the same place,

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1975fe4be8347d244643a0fbab20357485d41522 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jan 10 23:48:17 2013 -0500 fdo#59084: Sync dimension members after reloading

[Libreoffice-commits] .: 2 commits - formula/inc formula/source sc/inc sc/qa sc/source sc/util

2013-01-11 Thread Libreoffice Gerrit user
formula/inc/formula/compiler.hrc | 42 ++--- formula/inc/formula/errorcodes.hxx |3 formula/inc/formula/opcode.hxx |2 formula/source/core/api/FormulaCompiler.cxx| 77 +++-- formula/source/core/api/token.cxx | 22 +-

[PUSHED] fdo#56124 add functions IFERROR and IFNA to calc as in ODFF1...

2013-01-11 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1522 Objections: Eike Rathke: Do not submit -- To view, visit https://gerrit.libreoffice.org/1522 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-3-6]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1651 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1651 To unsubscribe, visit

Re: Extending Dictionaries

2013-01-11 Thread Samuel Mehrbrodt
Thanks! I've extended it a bit and added a list of Contacts with the Maintainers of the Dictionaries found in the READMEs. I hope that this will encourage people to help update the dictionaries. But the list is not complete, and there may be errors, so everyone feel free to update or correct

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/inc/swmodeltestbase.hxx |5 + 1 file changed, 5 insertions(+) New commits: commit 58aeb8e6aadd8511a700ec1c289bdc229f7592c9 Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Date: Thu Jan 10 16:29:58 2013 +0100 sw unit test: layout dump must be resetted in

[PUSHED] sw unit test: layout dump must be resetted in 'reload' metho...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1643 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1643 To unsubscribe, visit

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/ww8export/data/fdo56513.doc |binary sw/qa/extras/ww8export/ww8export.cxx |9 + 2 files changed, 9 insertions(+) New commits: commit 40e0a5d73a5b7a0f23015ee481a94639400f581d Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Date: Thu Jan 10 16:10:53 2013

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/inc/swmodeltestbase.hxx |1 + 1 file changed, 1 insertion(+) New commits: commit 87c66e9e3d7ab1351fac8db9aad80ed01e7634b6 Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Date: Thu Jan 10 18:41:05 2013 +0100 sw unit test: add call to CalcLayout before using the

[PUSHED] doc export: add unit test for fdo#56513

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1644 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1644 To unsubscribe, visit

[PUSHED] sw unit test: add call to CalcLayout before using the layout

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1645 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1645 To unsubscribe, visit

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/ww8export/data/new-page-styles.doc |binary sw/qa/extras/ww8export/ww8export.cxx|9 + 2 files changed, 9 insertions(+) New commits: commit 1874df3041789729478ef99ff156ccee489c6a7a Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Date: Thu Jan 10

[PUSHED] doc export: add unit test for bug i106749

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1646 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1646 To unsubscribe, visit

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/core/undo/unins.cxx | 21 + 1 file changed, 21 insertions(+) New commits: commit f132eaa5a6ec6fd3051442bda9caf94a3341c680 Author: Miklos Vajna vmik...@suse.cz Date: Fri Jan 11 17:32:18 2013 +0100 fdo#53487 SwUndoInsert: take care of fieldmarks when deleting

[Libreoffice-commits] .: writerfilter/source

2013-01-11 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/DomainMapperTableHandler.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 194ba3a2cacbb5438dfcb8fb35167055e01ca251 Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Date: Fri Jan 11 17:40:39 2013 +0100 docx import: fix

[Libreoffice-commits] .: scripting/source

2013-01-11 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7a7e19c166df326c45f76a142b478b0629f784c9 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jan 11 18:29:14 2013 +0100 fdo#59249: String literal needs a b prefix in

[Libreoffice-commits] .: scripting/source

2013-01-11 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit ac56d9373a66378a04048993ed5aec65cf39f149 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jan 11 18:32:04 2013 +0100 Can't convert 'Enum' resp. 'bytes' object to str

[PATCH] Change in core[libreoffice-4-0]: fdo#53487 SwUndoInsert: take care of fieldmarks when deletin...

2013-01-11 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1652 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/1652/1 fdo#53487 SwUndoInsert: take care of fieldmarks when deleting field chars The problem was that while

[Libreoffice-commits] .: 2 commits - sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx | 146 +++-- sc/source/ui/inc/dbdocfun.hxx |2 sc/source/ui/view/dbfunc3.cxx |2 sc/source/ui/view/gridwin2.cxx |2 4 files changed, 146 insertions(+), 6 deletions(-) New commits: commit

[PATCH] Change in core[libreoffice-4-0]: Let's not return here to prevent memory leak.

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1653 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/1653/1 Let's not return here to prevent memory leak. There are several heap objects that are deleted at the end of the

Re: [REVIEW 4-0] Re: Adding hyphenation patterns for Swedish

2013-01-11 Thread Niklas Johansson
Thank you for creating the patch, I hope that I'll be able to do it myself the next time. :) Regards, Niklas Johansson Petr Mladek skrev 2013-01-10 12:19: Hi Niklas, I have added the dictionary into master, see

[PATCH] Change in core[libreoffice-3-6]: Let's not return here to prevent memory leak.

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1654 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1654/1 Let's not return here to prevent memory leak. There are several heap objects that are deleted at the end of the

[Libreoffice-commits] .: 2 commits - sw/inc sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/inc/hhcwrp.hxx | 32 ++--- sw/source/ui/lingu/hhcwrp.cxx | 240 +- 2 files changed, 136 insertions(+), 136 deletions(-) New commits: commit f902073e4790ab3de1d48758d4e38ba583809030 Author: Matteo Casalin matteo.casa...@gmx.com Date: Fri

[Libreoffice-commits] .: scripting/source

2013-01-11 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 9dec0c79011a0c09068d86fba9387c67da84a39b Author: Michael Stahl mst...@redhat.com Date: Fri Jan 11 19:07:08 2013 +0100 fdo#59249: mailmerge.py: some more bytes vs. str

  1   2   3   4   >