[Libreoffice-commits] .: 3 commits - setup_native/source

2013-01-14 Thread Libreoffice Gerrit user
setup_native/source/packinfo/spellchecker_selection.txt |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit b920a2a8682b21f29c63a269e6383647025cf635 Author: Andras Timar Date: Tue Jan 15 08:24:57 2013 +0100 fdo#59370 Default dictionaries set for Russian UI

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 3 commits - setup_native/source

2013-01-14 Thread Libreoffice Gerrit user
setup_native/source/packinfo/spellchecker_selection.txt |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 60b49d7213258cfc5cce0ffbb8ee8f8d426fe0b6 Author: Andras Timar Date: Tue Jan 15 08:29:16 2013 +0100 fdo#59380 Default dictionaries set for Spanish UI

[PATCH] Change in core[libreoffice-3-6]: one more improvement around cond format rendering, fdo#57896

2013-01-14 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1684 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/1684/1 one more improvement around cond format rendering, fdo#57896 Change-Id: I5eb267ec2d1666edd53f5b9d58fd2a0cec044aa

[Libreoffice-commits] .: ru_RU/description.xml

2013-01-14 Thread Libreoffice Gerrit user
ru_RU/description.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a272609545d3153107828949911fc04c1e87b329 Author: Andras Timar Date: Tue Jan 15 08:10:38 2013 +0100 fdo#59371 update version number of ru dictionary to the date of last change Change

[Libreoffice-commits] .: dictionaries

2013-01-14 Thread Libreoffice Gerrit user
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6833cf12a077dd07103c58a3bb2407d751a33767 Author: Andras Timar Date: Tue Jan 15 08:10:38 2013 +0100 Updated core Project: dictionaries a272609545d3153107828949911fc04c1e87b329 diff --git a/dicti

[PUSHED] Change in core[libreoffice-4-0]: fdo#58854 'Insert' button was untranslatable

2013-01-14 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1680 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1680 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/uiconfig

2013-01-14 Thread Libreoffice Gerrit user
sw/uiconfig/swriter/ui/inserttable.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fa16c2d432c6054edd2dede556876f5455b7e26b Author: Andras Timar Date: Mon Jan 14 22:12:03 2013 +0100 fdo#58854 'Insert' button was untranslatable Change-Id: Iedb17e216

[Libreoffice-commits] .: 2 commits - vcl/aqua

2013-01-14 Thread Libreoffice Gerrit user
vcl/aqua/source/a11y/aqua11ywrapper.mm | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) New commits: commit 107504d938a4b6893e8d3d30adab7b47a726d314 Author: Norbert Thiebaud Date: Tue Jan 15 00:41:31 2013 -0600 WaE: nil is not a BOOL Cha

[Libreoffice-commits] .: sc/qa

2013-01-14 Thread Libreoffice Gerrit user
sc/qa/unit/subsequent_filters-test.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 253f9c5680e9a7b4bb5f2312c3a58eda0f77a820 Author: Markus Mohrhard Date: Tue Jan 15 05:58:21 2013 +0100 with the new recalc of matrix with errors, this assert is no longer tru

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 --- Comment #196 from chtfn --- Add "Bug 37960 - Shift click to select multiple drawings does not work if picture there" because: - Not in mab3.5 - Has been around since 3.4.0 release - Importance: "high - major" - Very basic editing action is br

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 chtfn changed: What|Removed |Added Depends on||37960 -- You are receiving this mail because: Y

[PATCH] Change in core[libreoffice-4-0]: for error value in matrix force recalc, fdo#59293

2013-01-14 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1683 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/1683/1 for error value in matrix force recalc, fdo#59293 Change-Id: I202526bb3cf6e0f6c55913b44a15694e0794e273 --- M sc/

[Libreoffice-commits] .: sc/source

2013-01-14 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlcelli.cxx | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) New commits: commit 7f4269b9798c348b1ede4ad0d777f6a0977b7e16 Author: Markus Mohrhard Date: Tue Jan 15 05:13:17 2013 +0100 for error value in matrix force recalc, f

[PATCH] fdo#57950: Remove some chained appends in shell

2013-01-14 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1682 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/1682/1 fdo#57950: Remove some chained appends in shell And remove some *STRINGPARAM macros. Change-Id: Idebee475e4b383

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 SteveBell changed: What|Removed |Added Depends on||53924 -- You are receiving this mail becaus

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 --- Comment #79 from SteveBell --- Nominating Bug 53924 https://bugs.freedesktop.org/show_bug.cgi?id=53924 It is on MAB 3.6 already. Still valid for LO 4.0RC1. -- You are receiving this mail because: You are on the CC list for the bug. ___

delete style when pressing DEL + fix type

2013-01-14 Thread Joren De Cuyper (via Code Review)
Joren De Cuyper has abandoned this change. Change subject: delete style when pressing DEL + fix type .. Patch Set 1: Abandoned isn't a bug, my bad -- To view, visit https://gerrit.libreoffice.org/1681 To unsubscribe, visit ht

[PATCH] delete style when pressing DEL + fix type

2013-01-14 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1681 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/1681/1 delete style when pressing DEL + fix type Change-Id: I6748aad9f9214bb9ef1ec84d35db731c756056a3 --- M sfx2/source

Re: [master] installer issue in Windows

2013-01-14 Thread Mat M
Re Le Mon, 14 Jan 2013 20:15:24 +0100, Mat M a écrit: Le Mon, 14 Jan 2013 11:15:50 +0100, Michael Meeks a écrit: On Sun, 2013-01-13 at 01:53 +0100, Mat M wrote: Trying to build from 484bb96aa975, I got an error when doing install sets. Here is the short error message from instsetoo_native

[PATCH] Change in core[libreoffice-4-0]: fdo#58854 'Insert' button was untranslatable

2013-01-14 Thread Andras Timar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1680 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/1680/1 fdo#58854 'Insert' button was untranslatable Change-Id: Iedb17e216083fdb8990fe9dc663b27eaa352ecf3 --- M sw/uicon

[Libreoffice-commits] .: sw/uiconfig

2013-01-14 Thread Libreoffice Gerrit user
sw/uiconfig/swriter/ui/inserttable.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9ad64e2c8c9e8b192bb97fcf0ef40061ec379f40 Author: Andras Timar Date: Mon Jan 14 22:12:03 2013 +0100 fdo#58854 'Insert' button was untranslatable Change-Id: Iedb17e216

[Libreoffice-commits] .: sc/qa

2013-01-14 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 25f5a30c85f960dfdfe918531f9c788fe307cb2f Author: Kohei Yoshida Date: Mon Jan 14 16:08:39 2013 -0500 Keep this simple. No need to wrap literals with OUString any more. Change-Id:

[Libreoffice-commits] .: sc/CppunitTest_sc_ucalc.mk sc/qa

2013-01-14 Thread Libreoffice Gerrit user
sc/CppunitTest_sc_ucalc.mk |2 ++ sc/qa/unit/ucalc.cxx |2 +- 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit 230072a6be455c45ec37229caa97563e08f7d7b4 Author: Kohei Yoshida Date: Mon Jan 14 16:06:24 2013 -0500 Figured out why testFuncMATCH was failing. Fi

[Libreoffice-commits] .: sc/qa sfx2/inc sfx2/source

2013-01-14 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx| 97 +++- sfx2/inc/sfx2/objsh.hxx |6 ++ sfx2/source/doc/objstor.cxx |6 ++ 3 files changed, 98 insertions(+), 11 deletions(-) New commits: commit 1712337d4dbdca7453a8ff701d429637edb9934b Author: Kohei Yoshida Dat

Re: Need confirmation about non-clearing of Character Styles

2013-01-14 Thread Cor Nouws
Hi all, Sorry fr being late here... Michael Stahl wrote (10-01-13 15:10) My understanding is a) that its intentional, see http://lists.freedesktop.org/archives/ooo-build/2010-February/000540.html and the commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e690e0909459d46c53d17e7939

Re: [master] installer issue in Windows

2013-01-14 Thread Mat M
Hi Michael Le Mon, 14 Jan 2013 11:15:50 +0100, Michael Meeks a écrit: Hi Mat, On Sun, 2013-01-13 at 01:53 +0100, Mat M wrote: Trying to build from 484bb96aa975, I got an error when doing install sets. Here is the short error message from instsetoo_native: Ah - that is annoying

[Libreoffice-commits] .: 2 commits - scripting/source wizards/source

2013-01-14 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |6 - wizards/source/importwizard/API.xba | 11 - wizards/source/importwizard/DialogModul.xba | 157 +-- wizards/source/importwizard/FilesModul.xba | 10 - wizards/source/importwizard/ImportDialog.xdl | 15

[Libreoffice-commits] .: source/text

2013-01-14 Thread Libreoffice Gerrit user
source/text/shared/autopi/01130100.xhp | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) New commits: commit 89d2680dda47ae81b2a50a0e9e1239f90b99cdb7 Author: Michael Stahl Date: Mon Jan 14 19:38:19 2013 +0100 help: Document Converter: remove obsolete StarOffice forma

[Libreoffice-commits] .: helpcontent2

2013-01-14 Thread Libreoffice Gerrit user
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c5192576bfe0d61302cc2fcbf870e8ec6d870d8e Author: Michael Stahl Date: Mon Jan 14 19:38:19 2013 +0100 Updated core Project: help 89d2680dda47ae81b2a50a0e9e1239f90b99cdb7 diff --git a/helpcontent2

[PUSHED] Change in core[libreoffice-4-0]: fdo#59249: mailmerge.py: adapt to changes in smtplib:

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1669 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1669 To unsubscribe, visit h

[PUSHED] Change in core[libreoffice-4-0]: fdo#57938 SwPaM::HasReadonlySel allow editing before comment...

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1673 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1673 To unsubscribe, visit h

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - scripting/source

2013-01-14 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) New commits: commit e523186e59632ef824eb3262edd0c63e388af6e8 Author: Michael Stahl Date: Mon Jan 14 12:37:29 2013 +0100 fdo#59249: mailmerge.py: adapt to changes in smtp

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/source/core/crsr/pam.cxx |9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit f39fa5aad48dc93bf24a328297635e5e46a65cff Author: Miklos Vajna Date: Mon Jan 14 10:55:55 2013 +0100 fdo#57938 SwPaM::HasReadonlySel allow editing before commented text ranges

[PUSHED] Change in core[libreoffice-4-0]: Template Manager: show folders with 4 previews inside a roun...

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1678 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1678 To unsubscribe, visit h

[PUSHED] Change in core[libreoffice-4-0]: Template Manager: filter the results when opening the dialog

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1675 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1675 To unsubscribe, visit h

[PUSHED] Change in core[libreoffice-4-0]: Template Manager: removed All category

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1674 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1674 To unsubscribe, visit h

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sfx2/inc sfx2/source

2013-01-14 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/templatecontaineritem.hxx | 13 +- sfx2/source/control/templateabstractview.cxx | 16 ++ sfx2/source/control/templatecontaineritem.cxx | 156 +++--- sfx2/source/control/templatelocalview.cxx | 18 ++- sfx2/source/control/thumbnailviewitem.cxx

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sfx2/source

2013-01-14 Thread Libreoffice Gerrit user
sfx2/source/control/templateabstractview.cxx | 21 +++-- sfx2/source/doc/templatedlg.cxx |5 ++--- sfx2/source/doc/templatedlg.hrc |1 - sfx2/source/doc/templatedlg.src |5 - 4 files changed, 21 insertions(+), 11 deletions(-)

[PUSHED] Modify constructor, remove setters + unused define

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1665 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1665 To unsubscribe, visit h

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 4 commits - reportdesign/inc reportdesign/source sc/inc sc/source sd/source starmath/source sw/source

2013-01-14 Thread Libreoffice Gerrit user
reportdesign/inc/ReportDefinition.hxx |3 -- reportdesign/source/core/api/ReportDefinition.cxx | 24 +++--- sc/inc/xmlwrap.hxx|2 - sc/source/filter/xml/xmlwrap.cxx | 14 +--- sd/source/filter/xml/sdxm

[Libreoffice-commits] .: sdext/source

2013-01-14 Thread Libreoffice Gerrit user
sdext/source/pdfimport/tree/pdfiprocessor.cxx | 14 +++--- sdext/source/pdfimport/tree/pdfiprocessor.hxx | 23 --- 2 files changed, 11 insertions(+), 26 deletions(-) New commits: commit 460c55f620a1bab7aa8f740dc85a60ce0cdf583c Author: Julien Nabet Date: Sun Jan

[PATCH] Resolves: fdo#44718 Add Unicode 2034 (Triple Prime) to OpenS...

2013-01-14 Thread Mathias Hasselmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1679 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/1679/1 Resolves: fdo#44718 Add Unicode 2034 (Triple Prime) to OpenSymbol This adds glyphs for prime (U+2032), double pr

RE: strange behaviour of SwCrsrShell::aVisArea

2013-01-14 Thread Winfried Donkers
Hi Cedric, >I don't know that area of the code too well, but this smells pretty bad. >May be looking at what changes the aVisArea to these (false) values >would help. Thank you for your reply. I started collecting more traces; the present situation is that the strange behaviour is probably caus

Re: Stepping back from The Document Foundation

2013-01-14 Thread Michael Meeks
Hi Florian, So - first, this belongs on the discuss list - please follow up there and not on the developers list where it is out of scope. On Sun, 2013-01-13 at 16:54 +0100, Florian Monfort wrote: > And that has consequences: we're too slow -acting.. As a foundation - IMHO we're

[PUSHED] Change in core[libreoffice-3-6]: fdo#59366: Document Conversion wizard: enable "StarOffice" a...

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1677 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1677 To unsubscribe, visit h

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - wizards/source

2013-01-14 Thread Libreoffice Gerrit user
wizards/source/importwizard/Main.xba |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 959ce73b266d3639ff1ced9cb980adf5fe643ad5 Author: Michael Stahl Date: Mon Jan 14 17:27:26 2013 +0100 fdo#59366: Document Conversion wizard: enable "StarOffice" again:

[Libreoffice-commits] .: sw/qa writerfilter/source

2013-01-14 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo44053.rtf | 15 +++ sw/qa/extras/rtfimport/rtfimport.cxx | 13 ++ writerfilter/source/dmapper/DomainMapperTableManager.cxx | 31 --- writerfilter/source/dmapper/DomainMapperTableManager.hxx |3 - write

[PATCH] Change in core[libreoffice-4-0]: Template Manager: show folders with 4 previews inside a roun...

2013-01-14 Thread Bosdonnat Cedric (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1678 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/1678/1 Template Manager: show folders with 4 previews inside a rounded rect The previous display had the inconvenient t

[PATCH] Change in core[libreoffice-3-6]: fdo#59366: Document Conversion wizard: enable "StarOffice" a...

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1677 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/1677/1 fdo#59366: Document Conversion wizard: enable "StarOffice" again: The createBF_MigrateFilterIfPossible function

[PUSHED] Change in core[libreoffice-4-0]: fdo#59248: Remove remaining dangling view of ViewHandler.py

2013-01-14 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1670 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1670 To unsubscribe, vi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - wizards/com

2013-01-14 Thread Libreoffice Gerrit user
wizards/com/sun/star/wizards/text/TextDocument.py |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit b5c1b435378e1e4c99416eb865477123ab596c85 Author: Stephan Bergmann Date: Mon Jan 14 14:03:40 2013 +0100 fdo#59248: Remove remaining dangling view of ViewHandle

[PUSHED] Change in core[libreoffice-4-0]: Resolves: fdo#58324 keep both halves of surrogate pairs if g...

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1676 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1676 To unsubscribe, visi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - vcl/generic

2013-01-14 Thread Libreoffice Gerrit user
vcl/generic/glyphs/gcach_layout.cxx | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) New commits: commit 700da51c5629f3b6a9b7c8e651cabbeb66960731 Author: Caolán McNamara Date: Mon Jan 14 16:00:58 2013 + Resolves: fdo#58324 keep both halves of surrogate pairs if

[Libreoffice-commits] .: 3 commits - desktop/source Repository.mk sal/inc sal/rtl sal/typesconfig

2013-01-14 Thread Libreoffice Gerrit user
Repository.mk |1 desktop/source/migration/migration.cxx |7 sal/inc/sal/types.h|1 sal/rtl/source/locale.cxx | 41 --- sal/typesconfig/typesconfig.c | 445 - 5 files changed, 15 in

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2013-01-14 Thread Stephan Bergmann
On 01/14/2013 12:42 AM, Marc-André Laverdière wrote: Quick question: is this code security-sensitive at all? No. sal/typesconfig/typesconfig.c turns out to be dead code; I'll removed it. Stephan ___ LibreOffice mailing list LibreOffice@lists.freed

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#58324 keep both halves of surrogate pairs if g...

2013-01-14 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1676 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/1676/1 Resolves: fdo#58324 keep both halves of surrogate pairs if glyph isn't found Change-Id: I8fda443bb224a7a99b99261

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-14 Thread Andras Timar
Hi, On Mon, Jan 14, 2013 at 3:31 PM, Rene Engelhard wrote: > On Mon, Jan 14, 2013 at 02:02:45PM +, Noel Power wrote: >> On 14/01/13 13:16, Eike Rathke wrote: >> >Hi Noel, >> > >> >On Monday, 2013-01-14 12:49:42 +, Noel Power wrote: >> [...] >> >^ >> >I meant to write 4-0-1 there..

[PATCH] Change in core[libreoffice-4-0]: Template Manager: filter the results when opening the dialog

2013-01-14 Thread Bosdonnat Cedric (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1675 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/1675/1 Template Manager: filter the results when opening the dialog Conflicts: sfx2/source/control/templateabst

[PATCH] Change in core[libreoffice-4-0]: Template Manager: removed All category

2013-01-14 Thread Bosdonnat Cedric (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1674 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/1674/1 Template Manager: removed All category Change-Id: I073b9601c82a464f705df30cfd7e760c212eb7ca --- M sfx2/source/do

[PATCH] Change in core[libreoffice-4-0]: fdo#57938 SwPaM::HasReadonlySel allow editing before comment...

2013-01-14 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1673 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1673/1 fdo#57938 SwPaM::HasReadonlySel allow editing before commented text ranges (cherry picked from commit 50b6dc0099

[PUSHED] sax: add methods to duplicate current top marker and reapply...

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1648 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1648 To unsubscribe, visit h

[PUSHED] docx export: also export rPr in (paragraph mark stylin...

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1649 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1649 To unsubscribe, visit h

[Libreoffice-commits] .: sax/inc sax/source

2013-01-14 Thread Libreoffice Gerrit user
sax/inc/sax/fshelper.hxx|2 ++ sax/source/tools/fastserializer.cxx | 14 ++ sax/source/tools/fastserializer.hxx |3 +++ sax/source/tools/fshelper.cxx | 10 ++ 4 files changed, 29 insertions(+) New commits: commit 1f2c079dd2bc9a2f5aa3597a8222bde307

[Libreoffice-commits] .: sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 8c178a50334109b34ef456ca6aa51cd3d98699ae Author: Pierre-Eric Pelloux-Prayer Date: Fri Jan 11 14:38:12 2013 +0100 docx export: also export rPr in (paragraph mark styling)

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - dictionaries

2013-01-14 Thread Libreoffice Gerrit user
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0dadee9bf62aad09e94b336b16bf93ee01d955ff Author: Andras Timar Date: Mon Jan 14 11:41:58 2013 +0100 Updated core Project: dictionaries e16148c25580961b6fd2f246eb8f8dbce07b7208 update Swe

[PUSHED] Change in core[libreoffice-4-0]: docx export: add missing arg to impl_pageBorders call

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1672 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1672 To unsubscribe, visi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5be5a6960fb454912896284d11314fafe60b2792 Author: Pierre-Eric Pelloux-Prayer Date: Mon Jan 14 14:49:01 2013 +0100 docx export: add missing arg to impl_pageBorders call

[PUSHED] docx export: invalid sectPr added at the beginning of the do...

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1647 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1647 To unsubscribe, visit h

[Libreoffice-commits] .: sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/source/filter/ww8/wrtww8.cxx |4 +--- sw/source/filter/ww8/ww8atr.cxx | 11 ++- 2 files changed, 11 insertions(+), 4 deletions(-) New commits: commit ee9f23bb94b4c2c8c4db6466ecca272a092e9492 Author: Pierre-Eric Pelloux-Prayer Date: Thu Jan 10 18:45:42 2013 +0100 docx expo

[PATCH] Change in core[libreoffice-4-0]: docx export: add missing arg to impl_pageBorders call

2013-01-14 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1672 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/1672/1 docx export: add missing arg to impl_pageBorders call The missing argument could cause data loss due to ill-form

fdo#56098 Paste Special options after cut incorrect

2013-01-14 Thread Winfried Donkers (via Code Review)
Winfried Donkers has abandoned this change. Change subject: fdo#56098 Paste Special options after cut incorrect .. Patch Set 1: Abandoned Patch has been submitted again under gerrit #1671, this time without submodule noise. -

[PATCH] fdo#56098 Paste Special options after cut incorrect

2013-01-14 Thread Winfried Donkers (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1671 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1671/1 fdo#56098 Paste Special options after cut incorrect Change-Id: Icf6aa698e69a2271cf68f420ceaec4aaffe94ad0 --- M s

[Libreoffice-commits] .: 2 commits - sw/inc sw/qa sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/inc/pam.hxx |3 ++- sw/qa/core/swdoc-test.cxx |2 +- sw/source/core/crsr/pam.cxx |4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) New commits: commit e85b4e8531125c5b437db515981a344138b8fdd5 Author: Miklos Vajna Date: Mon Jan 14 15:54:05 2013 +0100 d

[Libreoffice-commits] .: sw/qa

2013-01-14 Thread Libreoffice Gerrit user
sw/qa/core/swdoc-test.cxx | 22 ++ 1 file changed, 22 insertions(+) New commits: commit bf670bcd5e60eae95a6bd297391799f13e55db9d Author: Miklos Vajna Date: Mon Jan 14 15:23:49 2013 +0100 fdo#57938 testcase Change-Id: I5a219011952f37861b0688e17afca1b3b07fdc31

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-14 Thread Rene Engelhard
On Mon, Jan 14, 2013 at 02:02:45PM +, Noel Power wrote: > On 14/01/13 13:16, Eike Rathke wrote: > >Hi Noel, > > > >On Monday, 2013-01-14 12:49:42 +, Noel Power wrote: > [...] > >^ > >I meant to write 4-0-1 there.. > somehow I read it as that > >>pushed to 4.0, further reviews needed

Re: [PUSHED 4-0 3-6] Missing parenthesis in ucb/source/ucp/file/bc.cxx

2013-01-14 Thread Eike Rathke
Hi julien2412, On Sunday, 2013-01-13 07:01:09 -0800, julien2412 wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a2dd3feaea16a765956aecacdd6cc21ab5404a5b, > I added missing parenthesis because according to > http://en.cppreference.com/w/cpp/language/operator_precedence, AND bitwis

Re: strange behaviour of SwCrsrShell::aVisArea

2013-01-14 Thread Cedric Bosdonnat
On Mon, 2013-01-14 at 14:01 +0100, Winfried Donkers wrote: > SwCrsrShell::CrsrIsVisible() returns sal_True, zoom % is 60, > SwCrsrShell::aVisArea.Top(), Bottom() give 170460 and 188635. > > I then move the cursor one line down and back (no scrolling), zoom to > 55% and back to 60%. > > The visibl

Re: Stepping back from The Document Foundation

2013-01-14 Thread Eike Rathke
Hi Florian, On Sunday, 2013-01-13 16:54:52 +0100, Florian Monfort wrote: > I've decided recently that I would stop watching Document Foundation > activities. Indeed I've found myself completely overloaded with work from > School and Red Hat, so I cannot properly contribute. That's fine, unfortun

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-14 Thread Noel Power
On 14/01/13 13:16, Eike Rathke wrote: Hi Noel, On Monday, 2013-01-14 12:49:42 +, Noel Power wrote: [...] ^ I meant to write 4-0-1 there.. somehow I read it as that pushed to 4.0, further reviews needed for 4-0-0 Well, thanks, but, hum.. We don't have a 4-0-0 branch yet, so being

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - ucb/source

2013-01-14 Thread Libreoffice Gerrit user
ucb/source/ucp/file/bc.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 12dd56b7aac28aa29ba0d89c008f3b87b63aa739 Author: Julien Nabet Date: Sun Jan 13 15:52:23 2013 +0100 Add missing parenthesis Like this since 29/06/2001 (5ef2de612d973bc747ff4a107

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - ucb/source

2013-01-14 Thread Libreoffice Gerrit user
ucb/source/ucp/file/bc.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit af46de550494aed4cfaf1a0dde4c0d170d66b03f Author: Julien Nabet Date: Sun Jan 13 15:52:23 2013 +0100 Add missing parenthesis Like this since 29/06/2001 (5ef2de612d973bc747ff4a107

[PATCH] Change in core[libreoffice-4-0]: fdo#59248: Remove remaining dangling view of ViewHandler.py

2013-01-14 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1670 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/1670/1 fdo#59248: Remove remaining dangling view of ViewHandler.py ...that had been left behind by d6308705133ccde121dc

[Libreoffice-commits] .: sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b1859c3a6d32dff66550c33831df241035d91aa9 Author: Pierre-Eric Pelloux-Prayer Date: Mon Jan 14 14:49:01 2013 +0100 docx export: add missing arg to impl_pageBorders call

[Libreoffice-commits] .: sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/source/core/crsr/pam.cxx |9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit 50b6dc0099ff61050b82a2e37e70d643151e7ce7 Author: Miklos Vajna Date: Mon Jan 14 10:55:55 2013 +0100 fdo#57938 SwPaM::HasReadonlySel allow editing before commented text ranges

[Libreoffice-commits] .: wizards/com

2013-01-14 Thread Libreoffice Gerrit user
wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.py |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit a6f5e5238ca4536eff6c52cf10e52bd116723d72 Author: Stephan Bergmann Date: Mon Jan 14 14:27:58 2013 +0100 Fix one more use of removed ViewHandler.py

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-14 Thread Eike Rathke
Hi Noel, On Monday, 2013-01-14 12:49:42 +, Noel Power wrote: > >The attached patch implements the much requested IFERROR and IFNA > >spreadsheet functions on the 4-0 branch. I would like to have them as > >late feature in 4-0-0 if possible though string freeze was announced > >already, so 3 r

[Libreoffice-commits] .: sfx2/source

2013-01-14 Thread Libreoffice Gerrit user
sfx2/source/doc/objstor.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 3495f4817b80c3fc9846ed2bddfc492d39f01679 Author: Stephan Bergmann Date: Mon Jan 14 14:11:53 2013 +0100 Work around "may be used uninitialized" warnings Change-Id: Ib31ebaf

Re: replacing OUString::valueOf(static_cast) ??

2013-01-14 Thread Noel Grandin
On 2013-01-11 15:32, Lubos Lunak wrote: Following this, what the developer really wants is to create a string from a number. So OUString::fromNumber() seems like the obvious name for it. And it should take numbers of any kind, as it doesn't really matter, in the common case "give me this nu

[Libreoffice-commits] .: wizards/com

2013-01-14 Thread Libreoffice Gerrit user
wizards/com/sun/star/wizards/text/TextDocument.py |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 155600869800a0b51f9787b8a1879d3c680342c3 Author: Stephan Bergmann Date: Mon Jan 14 14:03:40 2013 +0100 fdo#59248: Remove remaining dangling view of ViewHandle

strange behaviour of SwCrsrShell::aVisArea

2013-01-14 Thread Winfried Donkers
Hi all, I'm trying to enhance the patch for fdo#40465 as the patch results in behaviour that in some cases is a regression. When zooming I want to know if the cursor is visible. The function SwCrsrShell::CrsrIsVisible() some times returns sal_False when the cursor absolutely is visible in the vi

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-14 Thread Noel Power
On 12/01/13 18:13, Eike Rathke wrote: Hi, The attached patch implements the much requested IFERROR and IFNA spreadsheet functions on the 4-0 branch. I would like to have them as late feature in 4-0-0 if possible though string freeze was announced already, so 3 reviews would be needed. At least 4

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - formula/inc formula/source sc/inc sc/qa sc/source sc/util

2013-01-14 Thread Libreoffice Gerrit user
formula/inc/formula/compiler.hrc | 42 ++--- formula/inc/formula/errorcodes.hxx |3 formula/inc/formula/opcode.hxx |2 formula/source/core/api/FormulaCompiler.cxx| 79 +++-- formula/source/core/api/token.cxx | 22 +- fo

[PUSHED] Fixes image drop shadow export to DOCX.

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1655 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1655 To unsubscribe, visit h

[Libreoffice-commits] .: sw/source

2013-01-14 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) New commits: commit 18be0ce63bbff4132c198e29a34cf3e5a27369d5 Author: Eilidh McAdam Date: Fri Jan 11 18:16:45 2013 +0100 Fixes image drop shadow export to DOCX.

[PATCH] Change in core[libreoffice-4-0]: fdo#59249: mailmerge.py: adapt to changes in smtplib:

2013-01-14 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1669 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1669/1 fdo#59249: mailmerge.py: adapt to changes in smtplib: Apparently the login() method in Python 3.3 expects str ar

[PUSHED] append library specific compile flags at the end

2013-01-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1632 Approvals: Noel Power: Verified; Looks good to me, approved Norbert Thiebaud: Verified -- To view, visit https://gerrit.libreoffice.org

[Libreoffice-commits] .: 2 commits - scripting/source

2013-01-14 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) New commits: commit 1a5b3d8e4d88aa27647cc7b99623dd6f6e706bbc Author: Michael Stahl Date: Mon Jan 14 12:37:29 2013 +0100 fdo#59249: mailmerge.py: adapt to change

[Libreoffice-commits] .: solenv/gbuild

2013-01-14 Thread Libreoffice Gerrit user
solenv/gbuild/LinkTarget.mk | 16 solenv/gbuild/platform/com_GCC_class.mk | 12 ++-- solenv/gbuild/platform/com_MSC_class.mk |4 ++-- 3 files changed, 16 insertions(+), 16 deletions(-) New commits: commit fabae54c51c25dcb28febe8181de8a5ee360ce1b Author

Re: [PUSHED][REVIEW-4-0] oxygen-gtk support version ...

2013-01-14 Thread Noel Power
On 14/01/13 11:07, Ruslan Kabatsayev wrote: Hi, On Fri, Jan 11, 2013 at 10:45 PM, Noel Power wrote: On 10/01/13 17:41, Michael Meeks wrote: Hi there, I cleaned up the version bits (as well as I could in a back-portable way for 4.0 - really we should drive this all from one setting

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 3 commits - config/config_version.h.in configure.ac solenv/gbuild vcl/inc vcl/source vcl/unx

2013-01-14 Thread Libreoffice Gerrit user
config/config_version.h.in | 14 ++ configure.ac | 18 +- solenv/gbuild/platform/com_GCC_defs.mk |4 +++- solenv/gbuild/platform/com_MSC_class.mk |1 + vcl/inc/svdata.hxx |5 + vcl/so

  1   2   >