Re: Is there a guideline on reviewing patches?

2013-01-24 Thread Thorsten Behrens
LOH KOK HOE wrote: > I would like to know how could I download the patches in order for > me to test at least one round on my local PC so that I could ensure > the code is something what we want it to fix. > https://wiki.documentfoundation.org/Development/gerrit/PatchReview#Getting_a_patch > But i

including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Bjoern Michaelsen
Hi all, is there any objection to deploying the Ubuntu fonts: http://font.ubuntu.com/ with LibreOffice on Windows and OSX? That would make them available for use in default templates etc. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.f

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2013-01-24 Thread Libreoffice Gerrit user
sw/source/core/doc/docdesc.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit f5dc652c6d3157d41d20dc1baf3cfc92907dc6b0 Author: Michael Stahl Date: Wed Jan 23 19:23:14 2013 +0100 fdo#59428: SwDoc::ChgPageDesc: always copy to first-pagedesc .

[Libreoffice-commits] .: chart2/source

2013-01-24 Thread Libreoffice Gerrit user
chart2/source/controller/drawinglayer/DrawViewWrapper.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit d71e8fb17bd008751909ef2fabc6ff4f1e2db187 Author: Stephan Bergmann Date: Thu Jan 24 09:57:35 2013 +0100 Unused #include Change-Id: Ib6a4e79d539f79911840acf783b5

Re: Issues building LibreOffice 4.0.0.1

2013-01-24 Thread Stephan Bergmann
On 01/24/2013 12:33 AM, Henrik /KaarPoSoft wrote: On 01/23/2013 04:54 PM, Stephan Bergmann wrote: On 01/23/2013 08:31 AM, Henrik /KaarPoSoft wrote: I have attached the last 100 lines of build output leading to the error. /tmp/cc7x3xJF.ltrans0.ltrans.o:(.data.rel.ro._ZTI27SvxForbiddenCharacte

[Libreoffice-commits] .: configure.ac

2013-01-24 Thread Libreoffice Gerrit user
configure.ac | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) New commits: commit be6b5a214a365dedb8351014a90604d30b3bd4ac Author: Fridrich Å trba Date: Thu Jan 24 10:10:49 2013 +0100 Detect ICU by pkg-config first and fallback on icu-config only after diff -

Re: vm2/gerrit configuration deployed

2013-01-24 Thread Florian Effenberger
Hi Norbert, Norbert Thiebaud wrote on 2013-01-24 00:42: It seem that the mail system is rejecting some of gerrit's outgoing email... an overzealous spam filter maybe ? [2013-01-23 09:12:33,412] ERROR com.google.gerrit.server.git.MergeOp : I did a quick grep on /var/log/mail.log, and it seems

Re: [REVIEW 4-0-0 ] [PUSHED 4-0 ]mab fdo#59325

2013-01-24 Thread Noel Power
On 23/01/13 20:46, Noel Power wrote: for some reason I don't see that gerrit mailed the list for this one https://gerrit.libreoffice.org/#/c/1828/ please review for 4-0 ( and additional 2 review & cherrypick for 4-0-0 ) Since Markus pushed the patch to 4-0 I was able to cherry-pick for 4-0-0

Re: Google developer account

2013-01-24 Thread Florian Effenberger
Hi, Robinson Tryon wrote on 2013-01-23 20:39: Looks like the minutes from the board meeting haven't been posted yet -- could you please give us a quick rundown of what the board has decided? (Information about Android support has arguably been*the* hottest topic on the Ask.LO site) the minut

[Libreoffice-commits] .: desktop/source

2013-01-24 Thread Libreoffice Gerrit user
desktop/source/offacc/acceptor.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 59afa90803feb09d60e65c6d8f1e8486daad4085 Author: Stephan Bergmann Date: Thu Jan 24 10:25:20 2013 +0100 Improve debug error reporting Change-Id: I6798f7f855ed65a7628b4

Re: including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Tor Lillqvist
> with LibreOffice on Windows and OSX? That would make them available for use in > default templates etc. If the Ubuntu typeface is so unique as they say (i.e. instantly recognisable) (or even worse, subconsciously recognised), wouldn't using it in templates then be an endorsement of Ubuntu? Isn't

[Libreoffice-commits] .: sc/source

2013-01-24 Thread Libreoffice Gerrit user
sc/source/ui/view/cellsh1.cxx | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) New commits: commit c2a249f371eb8ac3bf70d92947efeb145566536b Author: Winfried Donkers Date: Mon Jan 14 16:05:33 2013 +0100 fdo#56098 Paste Special options after cut incorrect Chang

Re: Duplicate code? Call for #define xxx_PAGETYPE_xxx

2013-01-24 Thread Thorsten Behrens
Christina Roßmanith wrote: > I had a look at cui/source/tabpages/tpline.cxx and found two > identical blocks in > sal_Bool SvxLineTabPage::FillItemSet( SfxItemSet& rAttrs ) around > lines 767 and 871. Could someone confirm (and maybe explain) that > this is intentional. > Some mismerge - feel free

[Libreoffice-commits] .: svx/source

2013-01-24 Thread Libreoffice Gerrit user
svx/source/tbxctrls/tbunosearchcontrollers.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1b375d580fb32739cc3b6625400337fa7380cdab Author: Joren De Cuyper Date: Fri Jan 18 00:37:14 2013 +0100 fdo#59101 - [Feature Request] Make Find hotkey (Ctrl+F) a toggl

[Libreoffice-commits] .: configure.ac

2013-01-24 Thread Libreoffice Gerrit user
configure.ac | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) New commits: commit 535006f3657feb2a64b50fb879e73294ab726852 Author: Andras Timar Date: Thu Jan 24 10:50:26 2013 +0100 fix MSM name for x64 in the VC90 case Change-Id: I69ff4f69e3ef93ed36cd

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

2013-01-24 Thread Libreoffice Gerrit user
sc/source/ui/docshell/docsh.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit bb40a72b5c811189ef783246c94a8ad226f7f347 Author: Markus Mohrhard Date: Tue Jan 22 23:50:47 2013 +0100 reset automatic row height flag after import, fdo#59193 Change-Id: Ied9cb4a2b6a17d

[Libreoffice-commits] .: helpcontent2

2013-01-24 Thread Libreoffice Gerrit user
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0261744be26bb1b67aa4b9fde7365f6414584f4a Author: Caolán McNamara Date: Wed Jan 23 21:28:03 2013 + Updated core Project: help 17a2d59b68e705ae92509ea65bacacc2015f3127 diff --git a/helpconte

[Libreoffice-commits] .: helpers/help_hid.lst source/text

2013-01-24 Thread Libreoffice Gerrit user
helpers/help_hid.lst|1 source/text/swriter/01/05090100.xhp | 56 ++-- 2 files changed, 28 insertions(+), 29 deletions(-) New commits: commit 17a2d59b68e705ae92509ea65bacacc2015f3127 Author: Caolán McNamara Date: Wed Jan 23 21:28:03 2013

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - instsetoo_native/util solenv/inc

2013-01-24 Thread Libreoffice Gerrit user
instsetoo_native/util/openoffice.lst |8 solenv/inc/minor.mk |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit fb422f088e249328bac0267dc6ee7b94146e3bd5 Author: Andras Timar Date: Thu Jan 24 11:11:05 2013 +0100 Bump for 3.6-8

Re: including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Stefan Knorr (Astron)
Hi Björn, Tor, On 24 January 2013 10:27, Tor Lillqvist wrote: >> with LibreOffice on Windows and OSX? That would make them available for use >> in >> default templates etc. Personally, I'd love to see it in LibreOffice, especially because it is one of the very few opensource fonts that covers s

[Libreoffice-commits] .: oox/source

2013-01-24 Thread Libreoffice Gerrit user
oox/source/mathml/importutils.cxx | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) New commits: commit a577418d9f9fe0e622f60a5b61a6fadc98d819a9 Author: Miklos Vajna Date: Thu Jan 24 11:14:21 2013 +0100 oox: drop no longer needed STR() macro Change-Id:

Re: including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Stefan Knorr (Astron)
Hi Tor, On 24 January 2013 10:27, Tor Lillqvist wrote: > If the Ubuntu typeface is so unique as they say (i.e. instantly > recognisable) (or even worse, subconsciously recognised), wouldn't > using it in templates then be an endorsement of Ubuntu? Isn't > LibreOffice supposed to be vendor-neutral

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/inc sc/source xmloff/source

2013-01-24 Thread Libreoffice Gerrit user
sc/inc/unonames.hxx |1 + sc/source/ui/unoobj/chart2uno.cxx |8 +++- xmloff/source/chart/SchXMLTools.cxx | 30 +- 3 files changed, 33 insertions(+), 6 deletions(-) New commits: commit 8a4272347298d8e4eab2fd685a4993709d888762 Author: Kohe

[Libreoffice-commits] .: helpcontent2

2013-01-24 Thread Libreoffice Gerrit user
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8874f901355925920794021c4d07dffa559652f3 Author: Caolán McNamara Date: Thu Jan 24 10:33:14 2013 + Updated core Project: help 3b379c4c53bbf69335694f214ca17393b9465ec1 diff --git a/helpconte

[Libreoffice-commits] .: source/text

2013-01-24 Thread Libreoffice Gerrit user
source/text/shared/01/05030600.xhp | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) New commits: commit 3b379c4c53bbf69335694f214ca17393b9465ec1 Author: Caolán McNamara Date: Thu Jan 24 10:33:14 2013 + update help ids for background page

[Libreoffice-commits] .: 3 commits - sfx2/source sw/uiconfig vcl/source

2013-01-24 Thread Libreoffice Gerrit user
sfx2/source/appl/sfxhelp.cxx | 15 ++- sw/uiconfig/swriter/ui/formattablepage.ui |7 +++ vcl/source/window/builder.cxx |8 ++-- 3 files changed, 27 insertions(+), 3 deletions(-) New commits: commit 4b4cb23d22f99efc445be974c05030b23bc7d3d0 Aut

[Libreoffice-commits] .: cui/source cui/uiconfig

2013-01-24 Thread Libreoffice Gerrit user
cui/source/tabpages/backgrnd.cxx |4 +++- cui/uiconfig/ui/backgroundpage.ui |2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) New commits: commit 557f75e7e1c1603f4fed9f0535c9cfda2a447569 Author: Caolán McNamara Date: Thu Jan 24 10:51:00 2013 + set mnemonic widgets for b

A step-by-step guide to converting a simple .src dialog to .ui format

2013-01-24 Thread Caolán McNamara
Here's a hopefully helpful step-by-step tutorial for converting a simple dialog from .src to .ui * Tutorial step #1 initial .ui prototype http://cgit.freedesktop.org/libreoffice/core/commit/?id=230b9c2b37ad9f2726d74780716a5f654cc9b0f6 * Tutorial step #2 improve .ui prototype http://cgit.freedeskt

[Libreoffice-commits] .: sfx2/source

2013-01-24 Thread Libreoffice Gerrit user
sfx2/source/dialog/templdlg.cxx | 105 1 file changed, 76 insertions(+), 29 deletions(-) New commits: commit 439ac45925039aa7a537feedab3e731e8a60a8e5 Author: Joren De Cuyper Date: Thu Jan 17 15:28:37 2013 +0100 fdo#46718 Delete multiple styles at

Re: including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Rene Engelhard
Hi, On Thu, Jan 24, 2013 at 11:13:43AM +0100, Stefan Knorr (Astron) wrote: > On 24 January 2013 10:27, Tor Lillqvist wrote: > >> with LibreOffice on Windows and OSX? That would make them available for > >> use in > >> default templates etc. And why should that be needed? > Personally, I'd love

[Libreoffice-commits] .: svx/source

2013-01-24 Thread Libreoffice Gerrit user
svx/source/table/tablelayouter.cxx | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) New commits: commit a01a537602204f2831b3caf78b7cb23c5e9194eb Author: K_Karthikeyan Date: Sun Jan 20 10:12:24 2013 +0300 Replace the frequent functioncalls The function getHorizo

[Libreoffice-commits] .: sc/CppunitTest_sc_outlineobj.mk sc/Module_sc.mk sc/qa test/inc test/Library_subsequenttest.mk test/Package_inc.mk test/source

2013-01-24 Thread Libreoffice Gerrit user
sc/CppunitTest_sc_outlineobj.mk | 129 sc/Module_sc.mk |1 sc/qa/extras/scoutlineobj.cxx | 108 ++ sc/qa/extras/testdocuments/ScOutlineObj.ods |binary test/Library_subsequenttest.mk |1 test/Packag

[Libreoffice-commits] .: xmloff/source

2013-01-24 Thread Libreoffice Gerrit user
xmloff/source/chart/SchXMLTools.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c1760a241b3f0362338d09460ac7dd2e1f2b25aa Author: Tor Lillqvist Date: Thu Jan 24 13:27:17 2013 +0200 WaE: 'bVal' may be used uninitialized in this function Seen in the

Re: How to force RTL layout in a non-RTL locale?

2013-01-24 Thread Caolán McNamara
On Wed, 2013-01-23 at 12:47 -0200, Rodolfo wrote: > I'm trying to finish my patch, partially implemented here: > https://gerrit.libreoffice.org/1785 > > Does anybody know how to set up my layout for RTL in order I can do my tests? SAL_RTL_ENABLED=1 ./swriter C. _

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/source

2013-01-24 Thread Libreoffice Gerrit user
vcl/source/gdi/bitmapex.cxx | 18 ++ 1 file changed, 18 insertions(+) New commits: commit f03352a1c98d150d7954b8684498f834dd67e036 Author: Thorsten Behrens Date: Wed Jan 23 11:42:55 2013 +0100 Fix fdo#59616 - ensure BitmapEx has same-sized subbitmaps Lots of cod

Re: "Need help for "Bug 59397 - UI: Use more precise wording at 'Find & Replace - More Options - Styles' "

2013-01-24 Thread Caolán McNamara
On Sun, 2013-01-20 at 23:51 +0530, Vishv Brahmbhatt wrote: > I am planning to create a separate CheckBox(with modified Text) for > "calc" ,similar to which is defined in the src file and then create a > function similiar to aLayoutBtn in this cxx file and make necessary > changes at the change lin

[Libreoffice-commits] .: solenv/bin

2013-01-24 Thread Libreoffice Gerrit user
solenv/bin/modules/installer/windows/property.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3c0f360995741c16e93f49b1a1e771d0f4e40dc7 Author: Michael Stahl Date: Thu Jan 24 12:52:55 2013 +0100 fdo#59798: MSI installer spurious space in version number

How could I apply SSH for Gerrit?

2013-01-24 Thread LOH KOK HOE
I am currently following this tutorial > https://wiki.documentfoundation.org/Development/gerrit on setting up the gerrit on my local PC. I have the SSH key pair generated, and put my public key in this site > https://gerrit.libreoffice.org/, under Settings Page, SSH Public Key section. When I issue

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - translations

2013-01-24 Thread Libreoffice Gerrit user
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4441433d971ece91a2982ca716e0f71f08ef3473 Author: Andras Timar Date: Thu Jan 24 13:15:09 2013 +0100 Updated core Project: translations b459c32203abec7989162636299772a7aebe34ed diff --git a/trans

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - translations

2013-01-24 Thread Libreoffice Gerrit user
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 688e658fb35ce7af824ed2cc8e8d44ba1e29a770 Author: Andras Timar Date: Thu Jan 24 13:15:09 2013 +0100 Updated core Project: translations 6f2a3172d7a0d735caa61c045bf02004bee7ba85 diff --git a/trans

[Libreoffice-commits] .: sw/source

2013-01-24 Thread Libreoffice Gerrit user
sw/source/core/text/portxt.cxx |4 ++-- sw/source/core/txtnode/fntcache.cxx |8 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit e029e7394b972fd72930c8c475f3768dd99fe673 Author: Caolán McNamara Date: Thu Jan 24 12:26:28 2013 + Resolves: fdo#5

[Libreoffice-commits] .: solenv/bin

2013-01-24 Thread Libreoffice Gerrit user
solenv/bin/modules/installer/windows/property.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit e2d60ae0bf885a39bb392729797b0fc6ec3a5fe5 Author: Michael Stahl Date: Thu Jan 24 13:33:13 2013 +0100 fdo#59798: fix SDK MSI version "LOdev 4.1 SDK.0.0

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58562, which changed state. Bug 58562 Summary: EDITING: copy and paste of CHART from Calc looses Y values https://bugs.freedesktop.org/show_bug.cgi?id=58562 What|Removed |Added

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - translations

2013-01-24 Thread Libreoffice Gerrit user
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e2d6bdbee8c30df0bee1cb7e0389747cb6bc19ed Author: Andras Timar Date: Thu Jan 24 13:47:21 2013 +0100 Updated core Project: translations 176cb9549621b2ca75614902cddad9562ce620a9 diff --git a/trans

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - translations

2013-01-24 Thread Libreoffice Gerrit user
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5a3d41b7660c5f7418c658514d95b5cff7cf8175 Author: Andras Timar Date: Thu Jan 24 13:51:30 2013 +0100 Updated core Project: translations 1455a06dbf7a9ae2d8a283ec480bbc13f76d3964 diff --git a/trans

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - solenv/bin

2013-01-24 Thread Libreoffice Gerrit user
solenv/bin/modules/installer/windows/property.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 72f0e26b6a5f7b3bb32d713227de189e0a7a2b4f Author: Michael Stahl Date: Thu Jan 24 12:52:55 2013 +0100 fdo#59798: MSI installer spurious space in version number

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - solenv/bin

2013-01-24 Thread Libreoffice Gerrit user
solenv/bin/modules/installer/windows/property.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit c6a1ebfd96e0d05bd6b93d49dd3fdebc518c9328 Author: Michael Stahl Date: Thu Jan 24 13:33:13 2013 +0100 fdo#59798: fix SDK MSI version "LOdev 4.1 SDK.0.0

[Libreoffice-commits] .: sfx2/inc sfx2/source

2013-01-24 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/basedlgs.hxx |8 +--- sfx2/source/dialog/basedlgs.cxx |6 +- 2 files changed, 6 insertions(+), 8 deletions(-) New commits: commit 04f21f9ad6c4b5be606f3c62fd10b3f1c2df283a Author: Caolán McNamara Date: Thu Jan 24 12:53:52 2013 + SingleTabDlgImpl::m_p

[Libreoffice-commits] .: libcmis/libcmis-0.3.0-proxy.patch libcmis/UnpackedTarball_cmis.mk ucb/source

2013-01-24 Thread Libreoffice Gerrit user
libcmis/UnpackedTarball_cmis.mk |1 libcmis/libcmis-0.3.0-proxy.patch | 1088 ++ ucb/source/ucp/cmis/cmis_content.cxx |9 ucb/source/ucp/cmis/cmis_repo_content.cxx |9 4 files changed, 1107 insertions(+) New commits: commit 7744ed9

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2013-01-24 Thread Libreoffice Gerrit user
sw/source/core/text/portxt.cxx |4 ++-- sw/source/core/txtnode/fntcache.cxx |8 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit f3a0e72261419554d0cd3984a0e8f800ed587d49 Author: Caolán McNamara Date: Thu Jan 24 12:26:28 2013 + Resolves: fdo#5

[Libreoffice-commits] .: 3 commits - chart2/source cui/source dbaccess/source extensions/source sc/source sd/source sfx2/inc sfx2/source sfx2/uiconfig sfx2/UI_sfx.mk svx/source sw/source

2013-01-24 Thread Libreoffice Gerrit user
chart2/source/controller/dialogs/dlg_NumberFormat.cxx |2 chart2/source/controller/dialogs/dlg_NumberFormat.hxx |2 cui/source/customize/acccfg.cxx |2 cui/source/customize/macropg.cxx |2 cui/source/dialogs/SpellDialog.cxx

Re: [RESOLVED] Additional number formats dialog screwed in master

2013-01-24 Thread Caolán McNamara
On Mon, 2013-01-21 at 10:39 +0100, Alex Thurgood wrote: > Hi all, > > While playing around with date formatting in a Writer document in my > master build , I came across something which is probably the result of > UI rework. The additional number formats dialog appears to have been > replaced by a

Re: [RESOLVED] Additional number formats dialog screwed in master

2013-01-24 Thread Alexander Thurgood
Le 24/01/13 15:32, Caolán McNamara a écrit : > Should be fixed now. The tabpages of various dialogs are often shared > between dialogs so missed the other use of that one. Definitely bring > any others like that to my attention. C. OK, will keep an eye open for it. Alex ___

Re: How could I apply SSH for Gerrit?

2013-01-24 Thread Norbert Thiebaud
On Thu, Jan 24, 2013 at 6:08 AM, LOH KOK HOE wrote: > I am currently following this tutorial > > https://wiki.documentfoundation.org/Development/gerrit on setting up the > gerrit on my local PC. I have the SSH key pair generated, and put my public > key in this site > https://gerrit.libreoffice.or

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 --- Comment #88 from David --- I'm nominating bug 59714. Footnotes with headers enabled in a large document make it unusable and will cause it to crash. This bug is keeping me from being able to upgrade from version 3.4.6 and is very likely rela

[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - sc/source

2013-01-24 Thread Libreoffice Gerrit user
sc/source/ui/docshell/docsh.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit a6050279eb4e70cb82cfcae2e04b6fce07583149 Author: Markus Mohrhard Date: Tue Jan 22 23:50:47 2013 +0100 reset automatic row height flag after import, fdo#59193 Change-Id: Ied9cb4a2b6a17d

[Libreoffice-commits] .: drawinglayer/source

2013-01-24 Thread Libreoffice Gerrit user
drawinglayer/source/primitive2d/metafileprimitive2d.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 59bce03256c5c00616cf63ace140cb91fdd46aa7 Author: Julien Nabet Date: Sun Jan 20 23:20:57 2013 +0100 Resolves: fdo#49784 CRASH when FILEOPEN particular doc

[Libreoffice-commits] .: sc/source

2013-01-24 Thread Libreoffice Gerrit user
sc/source/core/data/cell.cxx | 52 +-- sc/source/core/data/cell2.cxx | 79 -- 2 files changed, 56 insertions(+), 75 deletions(-) New commits: commit 5af61a8bb6fa890349334b6a22eb02a0dd79a90a Author: Philipp Weissenbacher Date:

[Libreoffice-commits] .: sfx2/source

2013-01-24 Thread Libreoffice Gerrit user
sfx2/source/doc/templatedlg.cxx |8 1 file changed, 8 insertions(+) New commits: commit 23baf527ffc9c082dcbc6a328019760725cc0c08 Author: Cédric Bosdonnat Date: Thu Jan 24 16:50:32 2013 +0100 Template Manager: remote repositories only for experimental mode Change-Id:

[Libreoffice-commits] .: 2 commits - cui/source cui/uiconfig formula/source sd/source sfx2/inc

2013-01-24 Thread Libreoffice Gerrit user
cui/source/tabpages/backgrnd.cxx |4 +--- cui/uiconfig/ui/backgroundpage.ui |2 -- formula/source/ui/dlg/formula.cxx |5 ++--- sd/source/ui/dlg/animobjs.cxx |3 +++ sfx2/inc/sfx2/basedlgs.hxx| 10 ++ 5 files changed, 16 insertions(+), 8 deletions(-) New comm

Re: [Libreoffice-ux-advise] LATE FEATURE: Personas in LibreOffice

2013-01-24 Thread Stefan Knorr (Astron)
Hi Michel, Kendy, * sorry this comes so late... * tldr: The background image UI should really go if it won't work. On 18 January 2013 10:03, Jan Holesovsky wrote: >> May i make some suggestions on the pref panel ? >> - why not keep the "own image" to select an image in local hd ? Hm ... well,

Re: Cppcheck: Same expression in testzipimpl.cxx

2013-01-24 Thread Caolán McNamara
On Sun, 2013-01-20 at 09:43 -0800, julien2412 wrote: > Hello, > > Cppcheck reported this: > shell/qa/zip/testimpl/testzipimpl.cxx > 52 bool TestZipImpl::test_directory() > 53 { > 54 ZipFile::DirectoryPtr_t contents = zipFile.GetDirectory(); > 55 vector &stringVector = *

[Libreoffice-commits] .: sc/qa

2013-01-24 Thread Libreoffice Gerrit user
sc/qa/unit/subsequent_filters-test.cxx | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) New commits: commit 585b080046eca4d2bb60c92e5cf6bf5e644e7590 Author: Kohei Yoshida Date: Thu Jan 24 11:40:16 2013 -0500 calling loadDoc is simpler. Change-Id: I6a50782525

Re: [Libreoffice-ux-advise] LATE FEATURE: Personas in LibreOffice

2013-01-24 Thread Adolfo Jayme Barrientos
No, I don’t agree on removing the feature from 4.0. We should improve its rough edges instead of going the easy way. On Thu, Jan 24, 2013 at 10:28 AM, Stefan Knorr (Astron) wrote: > Hi Michel, Kendy, > > * sorry this comes so late... * > > tldr: The background image UI should really go if it won'

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Adolfo Jayme Barrientos
On Thu, Jan 24, 2013 at 4:57 AM, Rene Engelhard wrote: > I don't. Distro specific font... They can ship it if they want. What does it mean “distro-specific”? > Yeah, For that reason it's /supposed to be in) non-free in Debian, see > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603157. > > We

Windows magic auto-accelerator evil ?

2013-01-24 Thread Caolán McNamara
Quite a while ago we added code to add mnemonic's to "ok"/"cancel" buttons if the translation/english didn't have them http://cgit.freedesktop.org/libreoffice/core/commit/?id=58f16ff09672f3e37156d0fc5e79e310b2c49c08 but... // Windows (apparently) has some magic auto-accelerator evil around // ok /

[Libreoffice-commits] .: shell/qa

2013-01-24 Thread Libreoffice Gerrit user
shell/qa/zip/testimpl/testzipimpl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c2f58887eca4b0fce0b56f0763ee5be0d04e671f Author: Julien Nabet Date: Thu Jan 24 18:57:26 2013 +0100 Fix Same expression on both sides of '==' Change-Id: I37ef5de92296

Development Budget Request (was: Re: Funding Wishlist)

2013-01-24 Thread Thorsten Behrens
Request for Budget == Rationale - With the gerrit review infrastructure firmly in place, the next logical evolution is to test-build (almost) every patch submitted - thus providing developers, that cannot build on all platforms locally, with the safety that their change do

[SOLVED] Re: Cppcheck: Same expression in testzipimpl.cxx

2013-01-24 Thread julien2412
Thank you Caolán, I pushed the fix (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2f58887eca4b0fce0b56f0763ee5be0d04e671f) -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-Same-expression-in-testzipimpl-cxx-tp4030658p4031526.html Sent from the Dev ma

Re: Windows magic auto-accelerator evil ?

2013-01-24 Thread Andras Timar
Hi, On Thu, Jan 24, 2013 at 6:50 PM, Caolán McNamara wrote: > Quite a while ago we added code to add mnemonic's to "ok"/"cancel" > buttons if the translation/english didn't have them > http://cgit.freedesktop.org/libreoffice/core/commit/?id=58f16ff09672f3e37156d0fc5e79e310b2c49c08 > but... > // W

Re: Windows magic auto-accelerator evil ?

2013-01-24 Thread Kohei Yoshida
On 01/24/2013 12:50 PM, Caolán McNamara wrote: Quite a while ago we added code to add mnemonic's to "ok"/"cancel" buttons if the translation/english didn't have them http://cgit.freedesktop.org/libreoffice/core/commit/?id=58f16ff09672f3e37156d0fc5e79e310b2c49c08 but... // Windows (apparently) has

Fwd: [libreoffice-users] Re: LibreOffice 3.6.4 Romanian installer translation is HORRIBLY broken

2013-01-24 Thread Joel Madero
I am forwarding this from the user list as I think that it's valid to be on the development list. Best Regards, Joel -- Forwarded message -- From: zugu Date: Thu, Jan 24, 2013 at 10:18 AM Subject: [libreoffice-users] Re: LibreOffice 3.6.4 Romanian installer translation is HORRIB

Re: [libreoffice-users] Re: LibreOffice 3.6.4 Romanian installer translation is HORRIBLY broken

2013-01-24 Thread Andras Timar
Hi, I read the whole thread. I don't think we should do anything about it. Localization of LibreOffice is a community effort. If the given native language community is unhappy about the quality, they can come and help to improve it. I used to work in the localization industry for many years. I rea

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Rene Engelhard
On Thu, Jan 24, 2013 at 10:56:29AM -0600, Adolfo Jayme Barrientos wrote: > On Thu, Jan 24, 2013 at 4:57 AM, Rene Engelhard wrote: > > I don't. Distro specific font... They can ship it if they want. > > What does it mean “distro-specific”? "Ubuntu fonts". If it wasn't distro-specific it wouldn't

[Libreoffice-commits] .: sc/CppunitTest_sc_subsequent_filters_test.mk sc/inc sc/qa

2013-01-24 Thread Libreoffice Gerrit user
sc/CppunitTest_sc_subsequent_filters_test.mk |1 sc/inc/address.hxx |2 sc/qa/unit/data/ods/chart-import-basic.ods |binary sc/qa/unit/subsequent_filters-test.cxx | 77 ++- 4 files changed, 78 insertions(+), 2 deletions(-) New

Re: Windows magic auto-accelerator evil ?

2013-01-24 Thread Caolán McNamara
On Thu, 2013-01-24 at 13:10 -0500, Kohei Yoshida wrote: > On 01/24/2013 12:50 PM, Caolán McNamara wrote: > > The obvious solution would seem to just change our English "OK" "Cancel" > > button source strings to a simple "~OK"/"~Cancel" which lets us remove > > the problematic code and shift the sel

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Rene Engelhard
Hi, On Thu, Jan 24, 2013 at 09:15:22PM +0100, Rene Engelhard wrote: > > > We shouldn't include non-free stuff here. > > > > Yeah, it’s considered “non-free” by Debian, but we can apply the same > > logic to the other “non-free” fonts added to LibreOffice, such as Open > > Sans, Source {Code|Sans}

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Rene Engelhard
Hi, On Thu, Jan 24, 2013 at 09:15:22PM +0100, Rene Engelhard wrote: > > these from shipping in LibreOffice, Debian packaging should be the > > place where these fonts are removed. Because its *Debian policy* which And sorry, that is wrong. the DFSG is (mostly) deintical with the Open Source Defin

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Rene Engelhard
On Thu, Jan 24, 2013 at 10:56:29AM -0600, Adolfo Jayme Barrientos wrote: > logic to the other “non-free” fonts added to LibreOffice, such as Open > Sans, Source {Code|Sans} Pro and PT Serif. But instead of removing This shows that you don't know what you're talking about, too: - I assume with PT

Re: Windows magic auto-accelerator evil ?

2013-01-24 Thread Kohei Yoshida
On 01/24/2013 03:19 PM, Caolán McNamara wrote: Plan b) gordian knot chopping, how about then I tweak thing to have two translations for the OK and Cancel Button strings e.g. SV_BUTTONTEXT_OK and SV_BUTTONTEXT_OK_NO_MNEMONIC and have the ifdef for windows select between the two, which still remov

[Libreoffice-commits] .: helpcontent2

2013-01-24 Thread Libreoffice Gerrit user
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4ef25c4bcc43ed02f17d1b45c9e0669f701dc2fe Author: Caolán McNamara Date: Thu Jan 24 21:07:38 2013 + Updated core Project: help c2d6b6a6c24b44bccab184368759052b366e82dc diff --git a/helpconte

[Libreoffice-commits] .: source/text

2013-01-24 Thread Libreoffice Gerrit user
source/text/shared/01/05030500.xhp | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) New commits: commit c2d6b6a6c24b44bccab184368759052b366e82dc Author: Caolán McNamara Date: Thu Jan 24 21:07:38 2013 + update help ids for border page .ui

[Libreoffice-commits] .: 2 commits - cui/uiconfig vcl/inc vcl/source

2013-01-24 Thread Libreoffice Gerrit user
cui/uiconfig/ui/borderpage.ui | 13 + vcl/inc/vcl/button.hxx|2 +- vcl/source/control/button.cxx | 32 +++- 3 files changed, 29 insertions(+), 18 deletions(-) New commits: commit 092ead3edfd51964312ab538652af6b080051b51 Author: Caolán McNam

[Libreoffice-commits] .: sw/uiconfig

2013-01-24 Thread Libreoffice Gerrit user
sw/uiconfig/swriter/ui/tablecolumnpage.ui |8 1 file changed, 8 insertions(+) New commits: commit 0057803c228e10bc1247ebb35c28cfc9ffc4cc5c Author: Caolán McNamara Date: Thu Jan 24 21:16:15 2013 + add mnemonic widgets to table columns page Change-Id: Ib8ef7bb6f1e

[Libreoffice-commits] .: helpcontent2

2013-01-24 Thread Libreoffice Gerrit user
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7b9d0da45727f03081471653efe08157f58b2224 Author: Caolán McNamara Date: Thu Jan 24 21:34:08 2013 + Updated core Project: help f2d63b153483caab5009d0d4d2eab9a1bac77f82 diff --git a/helpconte

[Libreoffice-commits] .: 2 commits - source/text

2013-01-24 Thread Libreoffice Gerrit user
source/text/swriter/01/05040500.xhp |5 + source/text/swriter/01/05090200.xhp | 35 ++- 2 files changed, 19 insertions(+), 21 deletions(-) New commits: commit f2d63b153483caab5009d0d4d2eab9a1bac77f82 Author: Caolán McNamara Date: Thu Jan 24 21:34:08 2

Re: Issues building LibreOffice 4.0.0.1

2013-01-24 Thread Henrik /KaarPoSoft
On 01/24/2013 10:09 AM, Stephan Bergmann wrote: On 01/24/2013 12:33 AM, Henrik /KaarPoSoft wrote: On 01/23/2013 04:54 PM, Stephan Bergmann wrote: On 01/23/2013 08:31 AM, Henrik /KaarPoSoft wrote: I have attached the last 100 lines of build output leading to the error. /tmp/cc7x3xJF.ltrans0.

Re: A step-by-step guide to converting a simple .src dialog to .ui format

2013-01-24 Thread Caolán McNamara
On Thu, 2013-01-24 at 10:51 +, Caolán McNamara wrote: > Here's a hopefully helpful step-by-step tutorial for converting a simple > dialog from .src to .ui FWIW, seeing some confusion on the matter, "ui-previewer" can be found in the "program" dir of your office install after installation, i.e.

[Libreoffice-commits] .: filter/source

2013-01-24 Thread Libreoffice Gerrit user
filter/source/msfilter/escherex.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 2823789bec0c029d9714aff0ed65923e23177ef9 Author: Michael Stahl Date: Thu Jan 24 23:12:38 2013 +0100 fdo#58204: PPT export: fix text rotation in shapes: EscherPropert

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Adolfo Jayme Barrientos
On Thu, Jan 24, 2013 at 2:24 PM, Rene Engelhard wrote: > Becaudse *you* don't care about what "Open Source" is doesn't mean that all > the > people who care should do stuff to clean it up. Hello, Rene Engelhard. It is the first time you and I talk to each other, and we had never met face-to-face

[Libreoffice-commits] .: sc/source

2013-01-24 Thread Libreoffice Gerrit user
sc/source/filter/excel/xecontent.cxx | 18 ++--- sc/source/filter/excel/xeextlst.cxx |3 + sc/source/filter/excel/xeformula.cxx |9 sc/source/filter/excel/xeroot.cxx| 51 +++ sc/source/filter/excel/xestream.cxx

[Libreoffice-commits] .: sc/source

2013-01-24 Thread Libreoffice Gerrit user
sc/source/filter/oox/formulabase.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 0adb958c451660ec0eea012480b6327dd2aefeb4 Author: Eike Rathke Date: Fri Jan 25 00:31:03 2013 +0100 non-dbgutil build [-Werror=unused-parameter], fdo#59819 Change-Id: I8eaa67bc2ab609bb

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Norbert Thiebaud
On Thu, Jan 24, 2013 at 4:51 PM, Adolfo Jayme Barrientos wrote: > Now, going on-topic: the UFL does not forbid LibreOffice from > including Ubuntu [1], we are not renaming it, and honestly, calling it > “distro-specific” based on just the name, is throwing bullshit. There > is a cola beverage name

[REVIEW 4-0 4-0-0] resolved fdo#59819 write correct OOXML function name mapping

2013-01-24 Thread Eike Rathke
Hi, I'd like to have https://gerrit.libreoffice.org/1854 reviewed for 4-0 and 4-0-0 rc3, resolves https://bugs.freedesktop.org/show_bug.cgi?id=59819 FILESAVE: .xlsx: new functions (AVERAGEIF,AVERAGEIFS,COUNTIFS,SUMIFS,IFERROR,IFNA) lead to warning in Excel 2013, and IFNA is not accepted Thanks

[Libreoffice-commits] .: 2 commits - cui/uiconfig vcl/source

2013-01-24 Thread Libreoffice Gerrit user
cui/uiconfig/ui/personalization_tab.ui | 23 ++- vcl/source/window/builder.cxx |1 + 2 files changed, 11 insertions(+), 13 deletions(-) New commits: commit fbfba66ac4990875e90f7af56113ca453d83f069 Author: Caolán McNamara Date: Fri Jan 25 00:17:46 2013 +

[Libreoffice-commits] .: sd/source

2013-01-24 Thread Libreoffice Gerrit user
sd/source/ui/dlg/animobjs.cxx |2 ++ sd/source/ui/dlg/animobjs.src |6 ++ sd/source/ui/inc/animobjs.hrc |1 + sd/source/ui/inc/animobjs.hxx |3 +++ 4 files changed, 12 insertions(+) New commits: commit 5d743ce2d1f548fafd34e31ada411df7f7e2fea1 Author: Joel Madero Date: Thu J

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Joren De Cuyper changed: What|Removed |Added Depends on||58480 -- You are receiving this mail

[Libreoffice-commits] .: filter/inc filter/source

2013-01-24 Thread Libreoffice Gerrit user
filter/inc/filter/msfilter/svxmsbas.hxx |8 filter/source/msfilter/svxmsbas2.cxx|8 2 files changed, 8 insertions(+), 8 deletions(-) New commits: commit 0d6e43bd788c075675b549ff4f63f706406cefa5 Author: Ricardo Montania Date: Thu Jan 24 17:03:19 2013 -0200 Str

Re: [Libreoffice-ux-advise] including Ubuntu fonts in Windows/OSX installers

2013-01-24 Thread Adolfo Jayme Barrientos
On Thu, Jan 24, 2013 at 5:41 PM, Norbert Thiebaud wrote: > If the name was so inconsequential, why did the author choose a > license that forbid _changing_ the name ? > > It is one thing to get distros to cooperate together one large project > like libreoffice, it is quite another to purposefully

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - libcmis/libcmis-0.3.0-proxy.patch libcmis/UnpackedTarball_cmis.mk ucb/source

2013-01-24 Thread Libreoffice Gerrit user
libcmis/UnpackedTarball_cmis.mk |1 libcmis/libcmis-0.3.0-proxy.patch | 1088 ++ ucb/source/ucp/cmis/cmis_content.cxx |9 ucb/source/ucp/cmis/cmis_repo_content.cxx |9 4 files changed, 1107 insertions(+) New commits: commit 28530d7

  1   2   >