[Libreoffice-commits] core.git: sd/source

2013-03-12 Thread Tor Lillqvist
sd/source/filter/eppt/pptx-text.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0451325ae7456da5812564428d73b0226606450f Author: Tor Lillqvist Date: Wed Mar 13 08:05:39 2013 +0200 WaE: enumeration value not handled in switch So just switch on the

[Libreoffice-commits] core.git: vcl/source

2013-03-12 Thread Tor Lillqvist
vcl/source/app/dbggui.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b125dd74a238242d2c2414f5d3d6c32bedf3cff9 Author: Tor Lillqvist Date: Wed Mar 13 07:32:31 2013 +0200 Avoid misleading leading zeros in hex digit The hex literal 0x0001 is

[Libreoffice-commits] core.git: vcl/source

2013-03-12 Thread Thomas Arnhold
vcl/source/app/dbggui.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 94a5f6b6703d103d76a6954083ba25202506a5bd Author: Thomas Arnhold Date: Wed Mar 13 04:28:39 2013 +0100 fix mac build Change-Id: Ib7aa2ffd351e85e76c84cd03c2a3b31c6b2c87ac diff --g

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/inc sc/source

2013-03-12 Thread Kohei Yoshida
sc/inc/column.hxx |8 ++- sc/source/core/data/column.cxx | 84 +--- sc/source/core/data/column2.cxx | 10 sc/source/core/data/column3.cxx | 28 ++--- 4 files changed, 82 insertions(+), 48 deletions(-) New commits: commit a1

Re: Code modifications Bug 60724

2013-03-12 Thread Joel Madero
Hey Steven, First, thank you so much for joining our great community, any help is always appreciated. IMO your best bet is to actually commit the changes via our repository with these instructions: https://wiki.documentfoundation.org/Development#Sending_patches_directly_to_gerrit.libreoffice.org

[Libreoffice-commits] core.git: sw/source

2013-03-12 Thread Oliver-Rainer Wittmann
sw/source/core/layout/fly.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit c083e0f22e2d5bcd7d3e686b18be5f415ffebdc6 Author: Oliver-Rainer Wittmann Date: Tue Jul 10 10:34:43 2012 + #119952# - method - do not provide width of text frame inclusive marg

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 6c/ecd60ceff2c5064bcca677514d06d6e410654d

2013-03-12 Thread Xisco Fauli
6c/ecd60ceff2c5064bcca677514d06d6e410654d |1 + 1 file changed, 1 insertion(+) New commits: commit 8be31ac66aa00de13a8e6e8109682d938ebb0912 Author: Xisco Fauli Date: Wed Mar 13 01:23:36 2013 +0100 Notes added by 'git notes add' diff --git a/6c/ecd60ceff2c5064bcca677514d06d6e410654d

[PUSHED] fdo#34800 Comments added to footer are placed at the right t...

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2572 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2572 To unsubscribe, vis

[PATCH libreoffice-4-0] Resolves: #i120773 Numbering lost when saving or opening a p...

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2692 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2692/1 Resolves: #i120773 Numbering lost when saving or opening a ppt file * subversion/main/editeng/inc/editeng/svxenu

[Libreoffice-commits] core.git: sw/source

2013-03-12 Thread Joren De Cuyper
sw/source/ui/docvw/PostItMgr.cxx | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) New commits: commit 868f3485126827f6baf7179d1c2c3c20812cac9b Author: Joren De Cuyper Date: Wed Mar 6 18:10:26 2013 +0100 fdo#34800 Comments added to footer are placed at the

Code modifications Bug 60724

2013-03-12 Thread Steven Meyer
Hello, My name is Steven and I'd like to start contributing to LibreOffice. Below are some modifications (spelling corrections) that I would like to commit to the master branch. All modifications are contributed under LGPLv3+ / MPL. diff --git a/editeng/inc/editeng/splwrap.hxx b/editeng/inc/edi

Re: Simplified Libreoffice API

2013-03-12 Thread Rodolfo
Just to be clear: for me, I don't want a 'simplified'/user-friendly API for, e.g., MS Excel compability. I just want it to know how to use it, without these so-long-and-not-so-comprehensible-detailed-and-not-clear steps needed by now. Even if it wouldn't be so powerful UNO API seems to be. Creati

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2651 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2651 To unsubscribe, vis

[Libreoffice-commits] core.git: oox/source sw/source

2013-03-12 Thread Radu Ioan
oox/source/ppt/animationspersist.cxx | 12 ++--- oox/source/ppt/commonbehaviorcontext.cxx |7 --- oox/source/ppt/pptshape.cxx | 25 +-- sw/source/filter/ww8/ww8toolbar.cxx | 66 +++ 4 files changed, 53 insertions(+), 57 deletions(

[PUSHED] Polishing 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2676 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2676 To unsubscribe, vis

[Libreoffice-commits] core.git: unotools/source vcl/aqua vcl/generic vcl/source

2013-03-12 Thread Chr . Rossmanith
unotools/source/misc/fontdefs.cxx |8 +++- vcl/aqua/source/gdi/atsui/salatsuifontutils.cxx |2 +- vcl/generic/fontmanager/fontsubst.cxx |6 +++--- vcl/generic/glyphs/glyphcache.cxx |6 +++--- vcl/source/gdi/outdev3.cxx

[PUSHED] solenv: remove versionlist.hrc

2013-03-12 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2677 Approvals: Michael Stahl: Looks good to me, approved David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://ge

[Libreoffice-commits] core.git: config_host/config_version.h.in configure.ac solenv/CustomTarget_versionlist.mk solenv/gbuild solenv/inc solenv/Module_solenv.mk solenv/Package_inc.mk

2013-03-12 Thread Matúš Kukan
config_host/config_version.h.in|1 configure.ac |8 +++ solenv/CustomTarget_versionlist.mk | 41 - solenv/Module_solenv.mk|5 solenv/Package_inc.mk | 32 so

Re: Question on call to IsCrookAllowed in SdrDragView::BegDragObj

2013-03-12 Thread Thorsten Behrens
Philippe Jung wrote: > Trying to implement crop Image in writer, I reached the "case > SDRDRAG_CROP" code in SdrDragView::BegDragObj. > Nice, would be cool to have that! > This part of code calls new SdrDragCrop if and only if > IsCrookAllowed(true) or IsCrookAllowed(false) > > This basically m

[Libreoffice-commits] core.git: editeng/inc

2013-03-12 Thread Fridrich Štrba
editeng/inc/editeng/svxenum.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c7bcb98de0df8e18d4b97bd67a273c6685fee261 Author: Fridrich Å trba Date: Tue Mar 12 23:47:58 2013 +0100 Oops Change-Id: Idc22c05ff2425702fb7a5ab25b3413f967238569 diff --git

[Libreoffice-commits] core.git: android/CustomTarget_android_desktop.mk android/CustomTarget_docloader.mk android/CustomTarget_lo4android.mk android/CustomTarget_sdremote.mk

2013-03-12 Thread Tor Lillqvist
android/CustomTarget_android_desktop.mk |8 ++-- android/CustomTarget_docloader.mk |8 ++-- android/CustomTarget_lo4android.mk |8 ++-- android/CustomTarget_sdremote.mk|8 ++-- 4 files changed, 24 insertions(+), 8 deletions(-) New commits: commit

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 39/e9cae1ac9b7944c9df0642a193b042a1b68266

2013-03-12 Thread Fridrich Štrba
39/e9cae1ac9b7944c9df0642a193b042a1b68266 |1 + 1 file changed, 1 insertion(+) New commits: commit 59901e5949413c8646caf69fad768b99d8704af4 Author: Fridrich Å trba Date: Tue Mar 12 23:39:31 2013 +0100 Notes added by 'git notes add' diff --git a/39/e9cae1ac9b7944c9df0642a193b042a1b682

[Libreoffice-commits] core.git: editeng/inc filter/source sd/source

2013-03-12 Thread Zhe Wang
editeng/inc/editeng/svxenum.hxx | 14 filter/source/msfilter/svdfppt.cxx | 57 sd/source/filter/eppt/epptso.cxx|5 +++ sd/source/filter/eppt/pptx-text.cxx | 44 +++ 4 files changed, 120 insertions(+) New comm

Re: scalc UNO api compilation question about header files

2013-03-12 Thread Neeraj Rai
understood. Thanks for clarifying this and other issues earlier. I can build my example on centos 6 with your help. Neeraj On Tue, Mar 12, 2013 at 4:08 AM, Stephan Bergmann wrote: > On 03/12/2013 03:19 AM, Neeraj Rai wrote: > >> Since I misunderstood a few things before, I wanted to confirm that

Re: About coverity 705732 (svdundo.cxx from svx module)

2013-03-12 Thread Thorsten Behrens
Julien Nabet wrote: > I noticed several things: > 1) we could replace "if (pText1)" by "if (pNewText)". Of course if blocks > must be changed > 2) if pText1 corresponds to a new OutlinerParaObject and !pText, it seems > there's a leak > Yeps. > 3) why pObj->ActionChanged() and ImpShowPageOfThisOb

mdds 0.7.0 on master

2013-03-12 Thread Kohei Yoshida
Hi there, FYI, the master branch now requires mdds 0.7.0 to build. This should not be a problem for those who use internal mdds, but for those who use the system mdds, please be aware of this. Actually, at the moment, it should build fine with mdds 0.6.0, but soon I'll start using bits that are o

LibreOffice Compile Error

2013-03-12 Thread Güner Kaan ALKIM
Hi, I have got a problem. I compiled libreoffice on Ubuntu 12.04. When everythings finished, I take a error message. My terminal output is cpp: line 19, Fatal error: Cannot open include file "accessibility/helper/accessiblestrings.hrc" #include make[1]: *** [/home/kaan/core/workdir/unx

[Libreoffice-commits] core.git: padmin/source

2013-03-12 Thread Caolán McNamara
padmin/source/adddlg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5908e9012491d53bba8670d37088e78153915e8d Author: Caolán McNamara Date: Tue Mar 12 21:43:33 2013 + Len() != isEmpty() Change-Id: I249c0cd072c51c07fddac730791468952a0757af di

[Libreoffice-commits] core.git: padmin/source

2013-03-12 Thread Caolán McNamara
padmin/source/cmddlg.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit d20da2c6094df58235ee865d88f3ba9e9e76166b Author: Caolán McNamara Date: Tue Mar 12 21:40:17 2013 + Len() != isEmpty() Change-Id: Ia8ba54ec3a99e7d72a6c97fa4082f9e605b6

[Libreoffice-commits] core.git: padmin/source

2013-03-12 Thread Caolán McNamara
padmin/source/cmddlg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1125882c0963a592ffe5b3e99c013e10f3ea3d5f Author: Caolán McNamara Date: Tue Mar 12 21:38:20 2013 + Len() != isEmpty() Change-Id: I42151d1f406ad43fae3c720c5c2663789a23cf8e di

[Libreoffice-commits] core.git: padmin/source

2013-03-12 Thread Caolán McNamara
padmin/source/adddlg.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 0b226da01318ce4af7d7a58829ef6bb41d640f61 Author: Caolán McNamara Date: Tue Mar 12 21:35:58 2013 + Len() != isEmpty() Change-Id: I56e29f20b4c4eaf73b98c1190040629ca36066e4

[Libreoffice-commits] core.git: vcl/source

2013-03-12 Thread Caolán McNamara
vcl/source/app/dbggui.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit e04fd835296e6fbe56e3a539038198a993b9bc13 Author: Caolán McNamara Date: Tue Mar 12 21:28:57 2013 + fix dbgutil build Change-Id: Icc541fdcf854a2e8f660c3d8c03448c5

[PUSHED] Translate German comments

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2691 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2691 To unsubscribe, vis

[PUSHED] coverity#704143: Resource leak in object

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2686 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2686 To unsubscribe, vis

[PATCH] Translate German comments

2013-03-12 Thread Philipp Weissenbacher (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2691 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/2691/1 Translate German comments Change-Id: I0b386fd0c7cb0382fa3a5187389369966365b1fb --- M sw/source/core/draw/dobjfac

[PUSHED] fdo#38838: Replaced some String with OUString

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2675 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2675 To unsubscribe, vis

[Libreoffice-commits] core.git: sw/source

2013-03-12 Thread Philipp Weissenbacher
sw/source/core/draw/dobjfac.cxx | 11 ++- sw/source/core/para/paratr.cxx | 30 -- 2 files changed, 14 insertions(+), 27 deletions(-) New commits: commit 26bb45921a2eac1da79ed7f53f5f39575b998f61 Author: Philipp Weissenbacher Date: Tue Mar 12 21:42:13 201

[Libreoffice-commits] core.git: extensions/source

2013-03-12 Thread Julien Nabet
extensions/source/abpilot/datasourcehandling.cxx |4 extensions/source/abpilot/datasourcehandling.hxx |1 + 2 files changed, 5 insertions(+) New commits: commit 634baa8702df8050bba5b6f3dcff64047b328cfe Author: Julien Nabet Date: Tue Mar 12 19:53:39 2013 +0100 coverity#704143:

[Libreoffice-commits] core.git: padmin/source

2013-03-12 Thread elixir
padmin/source/adddlg.cxx | 97 ++--- padmin/source/adddlg.hxx |2 padmin/source/cmddlg.cxx | 68 +++ padmin/source/helper.cxx | 12 ++--- padmin/source/helper.hxx |5 -- padmin/source/newppdlg.cxx | 11 +

[PUSHED] Replace XubString with OUString (vcl/ilstbox)

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2690 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2690 To unsubscribe, vis

[PUSHED] Replace XubString with OUString (dbggui.cxx)

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2688 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2688 To unsubscribe, vis

[Libreoffice-commits] core.git: vcl/inc vcl/source

2013-03-12 Thread Chr . Rossmanith
vcl/inc/ilstbox.hxx| 24 vcl/source/control/ilstbox.cxx | 22 +++--- 2 files changed, 23 insertions(+), 23 deletions(-) New commits: commit d2ffd0799fcaef0603b76984bf024ab1ba54b095 Author: Chr. Rossmanith Date: Tue Mar 12 22:02:14 2013 +

[Libreoffice-commits] core.git: vcl/inc vcl/source

2013-03-12 Thread Chr . Rossmanith
vcl/inc/dbggui.hxx|3 vcl/source/app/dbggui.cxx | 146 +++--- 2 files changed, 74 insertions(+), 75 deletions(-) New commits: commit 8905062428705cd9a321ec225ac32547712e3787 Author: Chr. Rossmanith Date: Tue Mar 12 22:00:34 2013 +0100

[PUSHED] coverity#705734: Resource leak

2013-03-12 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2689 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2689 To unsubscribe, vi

[ABANDONED] coverity#704153: Resource leak in object

2013-03-12 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704153: Resource leak in object .. Patch Set 1: Abandoned Thank you for your quick feedback Caolán. -- To view, visit https://gerrit.libreoffice.org/2687 To uns

[Libreoffice-commits] core.git: svx/source

2013-03-12 Thread Julien Nabet
svx/source/xml/xmlxtexp.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit b926b0af7cf769fb8a018ccc89d7169eb32d6954 Author: Julien Nabet Date: Tue Mar 12 21:47:09 2013 +0100 coverity#705734: Resource leak Change-Id: I04eba87de232958650c649c6ec18acb6b699b0ff Revi

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/inc sc/source

2013-03-12 Thread Kohei Yoshida
sc/inc/table.hxx |3 +++ sc/source/core/data/table2.cxx |9 + 2 files changed, 12 insertions(+) New commits: commit 651ee7089bfff730c31384ed3316e7096d18c623 Author: Kohei Yoshida Date: Tue Mar 12 16:39:03 2013 -0400 Accessor in ScTable. Change-Id: Id

[PATCH] Replace XubString with OUString (vcl/ilstbox)

2013-03-12 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2690 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/2690/1 Replace XubString with OUString (vcl/ilstbox) Change-Id: Ia2cefe1649538d411ae858e21a3145ca01fff2ee --- M vcl/inc

[PATCH] coverity#705734: Resource leak

2013-03-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2689 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/2689/1 coverity#705734: Resource leak Change-Id: I04eba87de232958650c649c6ec18acb6b699b0ff --- M svx/source/xml/xmlxtex

[PATCH] Replace XubString with OUString (dbggui.cxx)

2013-03-12 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2688 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2688/1 Replace XubString with OUString (dbggui.cxx) Change-Id: I080f6671eaa923790fd41d4ed9f147c44c721442 --- M vcl/sour

About coverity 705732 (svdundo.cxx from svx module)

2013-03-12 Thread julien2412
Hello, Scan coverity reported this: leaked_storage: Variable "pText1" going out of scope leaks the storage it points to. See http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdundo.cxx#1137 1137 void SdrUndoObjSetText::Redo() 1138 { 1139 // copy text for Undo, because the

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread julien2412
The following discussion is interesting but shows that it's not a quick and/or easy fix for casual contributor like me. So I let the experts keep on about this and determine if there's something to change or not. Thank you for your feedback about this Michael, Tor and Matúš Julien -- View this

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Tor Lillqvist
> Only c++ components have prefixes. Sure, and what this code does is load a native (C++) library (component). > and still not all off them, > stoc/util/bootstrap.component is one of the last(if not the last), a > little more complicated. Hmm, indeed, so maybe this code is intended then to load

[Libreoffice-commits] core.git: wizards/com

2013-03-12 Thread Xisco Fauli
wizards/com/sun/star/wizards/agenda/CGAgenda.py |3 +- wizards/com/sun/star/wizards/common/ConfigSet.py | 26 --- 2 files changed, 16 insertions(+), 13 deletions(-) New commits: commit 58b8c60758cea0249735d8208bd3cd55759722fb Author: Xisco Fauli Date: Tue Mar 12 20:5

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Matúš Kukan
On 12 March 2013 20:41, Tor Lillqvist wrote: >> http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) > > I wonder if that native method actually gets used. If it does, it is > to load 3rd-party native UNO components (in extensions) from Java, as > all our own UNO c

[Libreoffice-commits] core.git: 2 commits - dbaccess/source qadevOOo/tests

2013-03-12 Thread Michael Stahl
dbaccess/source/core/dataaccess/ModelImpl.cxx |4 qadevOOo/tests/java/mod/_dbaccess/ORowSet.java |4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) New commits: commit 97346bdddf4c7f5bd156e60b83223bc547d5d6f5 Author: Michael Stahl Date: Tue Mar 12 20:48:47 2013 +0100

[Libreoffice-commits] core.git: Branch 'feature/smaller-base-cell' - 0 commits -

2013-03-12 Thread Unknown
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - 6 commits - sc/inc sc/source

2013-03-12 Thread Kohei Yoshida
sc/inc/column.hxx | 15 - sc/source/core/data/column.cxx | 63 sc/source/core/data/column2.cxx |4 ++ sc/source/core/data/column3.cxx | 16 ++ 4 files changed, 91 insertions(+), 7 deletions(-) New commits: commit 07

Re: Problems amending commit

2013-03-12 Thread Philipp Weissenbacher
Hi Ruslan, That did it. Thanks! On 5 March 2013 09:08, Ruslan Kabatsayev wrote: > Hi, > > On Tue, Mar 5, 2013 at 2:28 AM, Philipp Weissenbacher > wrote: > > Hi all, > > > > I have problems incorporating the changes suggested by Thomas Arnhold in > > Change-Id: I98c1ffcb. > > > > I tried the f

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Tor Lillqvist
> That native > com.sun.star.comp.helper.SharedLibraryLoader.component_getFactory() > method doesn't take any prefix argument, it always looks for a symbol > called exactly "component_getFactory". Forgot to mention, first it looks for a symbol called "component_getImplementationEnvironment", no p

[Libreoffice-commits] core.git: configure.ac download.lst

2013-03-12 Thread Kohei Yoshida
configure.ac |2 +- download.lst |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 4613d78e6aceabafbc4dd066c7c0a55d728b6763 Author: Kohei Yoshida Date: Tue Mar 12 15:45:19 2013 -0400 Updated mdds to 0.7.0. Change-Id: I5e4a4b80a0f83aefcd85cf5e76cc

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - configure.ac download.lst

2013-03-12 Thread Kohei Yoshida
configure.ac |2 +- download.lst |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit c94731b93c189e225cd0e8f91a6f29cd71fc1645 Author: Kohei Yoshida Date: Tue Mar 12 15:45:19 2013 -0400 Updated mdds to 0.7.0. Change-Id: I5e4a4b80a0f83aefcd85cf5e76cc

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Tor Lillqvist
> http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) I wonder if that native method actually gets used. If it does, it is to load 3rd-party native UNO components (in extensions) from Java, as all our own UNO components use a prefix, don't they? That native com.s

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Michael Meeks
Hi there, On Tue, 2013-03-12 at 12:21 -0700, julien2412 wrote: > leaked_storage: Variable "lib" going out of scope leaks the storage it > points to. line 236 > (see > http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) > I just thought adding > osl_unloadModule(l

About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread julien2412
Hello, Scan coverity detected this: leaked_storage: Variable "lib" going out of scope leaks the storage it points to. line 236 (see http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) I just thought adding osl_unloadModule(lib) just before line 235, so last line

[PATCH] coverity#704153: Resource leak in object

2013-03-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2687 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/2687/1 coverity#704153: Resource leak in object Change-Id: I24fe7c8f7667bc4d847d025106673255813ddaf6 --- M package/sour

[Libreoffice-commits] core.git: 2 commits - config_host/config_kde4.h.in configure.ac vcl/Library_vclplug_kde4.mk vcl/unx

2013-03-12 Thread Luboš Luňák
config_host/config_kde4.h.in | 10 ++ configure.ac |9 +++-- vcl/Library_vclplug_kde4.mk | 11 +++ vcl/unx/kde4/KDEXLib.cxx |9 +++-- 4 files changed, 35 insertions(+), 4 deletions(-) New commits: commit 42bbe3a96ff4dfe4e2d34d522fd67c386a6c

[PATCH] coverity#704143: Resource leak in object

2013-03-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2686 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/2686/1 coverity#704143: Resource leak in object Change-Id: I6bf9fc6e65de857d4d05df0c7be64dc6ec38dc07 --- M extensions/s

[Libreoffice-commits] core.git: vcl/aqua

2013-03-12 Thread Eike Rathke
vcl/aqua/source/gdi/atsui/salatsuifontutils.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit ba3f6551ce47c690267485f3f6f2b6004aae435c Author: Eike Rathke Date: Tue Mar 12 19:51:16 2013 +0100 maybe fix MacOSX build Change-Id: I5a3842e95e45ee80a2

About coverity 704144 (XSLTFilter)

2013-03-12 Thread julien2412
Hello, Scan coverity detected this: Resource leak in object (CTOR_DTOR_LEAK)1. alloc_fn: Calling allocation function "osl_createCondition()". [show details] (see http://opengrok.libreoffice.org/xref/core/filter/source/xsltfilter/XSLTFilter.cxx#164) osl_createCondition in unx part calls a malloc f

[Libreoffice-commits] core.git: tools/source

2013-03-12 Thread Thomas Arnhold
tools/source/fsys/tempfile.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f965bc80986ecf8b5edd153cc8b072eddf916a03 Author: Thomas Arnhold Date: Tue Mar 12 16:27:38 2013 +0100 fix merge conflict Change-Id: I015a0065a88022ad4ff93711f1faae2874ccf506

[PUSHED] tempfile: Creating tempfiles in a given folder is not used

2013-03-12 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2558 -- To view, visit https://gerrit.libreoffice.org/2558 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[Libreoffice-commits] core.git: tools/inc tools/source unotools/source

2013-03-12 Thread Thomas Arnhold
tools/inc/tools/tempfile.hxx | 17 ++--- tools/source/fsys/tempfile.cxx | 95 +++-- unotools/source/ucbhelper/tempfile.cxx |1 3 files changed, 31 insertions(+), 82 deletions(-) New commits: commit a548924aece3dc99b2aa36b5c9b0fa52de9951ae Aut

[Libreoffice-commits] core.git: Changes to 'feature/formula-core-rework'

2013-03-12 Thread Luboš Luňák
New branch 'feature/formula-core-rework' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'feature/pivot-table-result-tree'

2013-03-12 Thread Kohei Yoshida
New branch 'feature/pivot-table-result-tree' available with the following commits: commit 0ece22f211bdd7a1c46ed21a146654914a41b041 Author: Kohei Yoshida Date: Mon Mar 11 17:16:54 2013 -0400 fdo#60300: Work-in-progress change to rework pivot table core. The idea is to avoid parsing

PATCH

2013-03-12 Thread Vishal Subbiah
0001-removed-EESelectionMode.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removal finished of CreateFromAscii

2013-03-12 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2685 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2685 To unsubscribe, visit

[Libreoffice-commits] core.git: vcl/aqua

2013-03-12 Thread Luboš Luňák
vcl/aqua/source/gdi/atsui/salatsuifontutils.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e75fba46b0080df4fb415bdefacf74a167b6cb6e Author: Luboš Luňák Date: Tue Mar 12 18:37:58 2013 +0100 fix incorrectly applied patch Change-Id: Ia35a4dc3c199

[Libreoffice-commits] core.git: vcl/unx vcl/workben

2013-03-12 Thread Ricardo Montania
vcl/unx/generic/app/salinst.cxx |6 +++--- vcl/workben/outdevgrind.cxx |3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) New commits: commit 08b9817b778a64b63a83744ac8b309bbed743f00 Author: Ricardo Montania Date: Tue Mar 12 14:23:48 2013 -0300 Removal finished of Create

[PATCH] Removal finished of CreateFromAscii

2013-03-12 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2685 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/2685/1 Removal finished of CreateFromAscii Change-Id: I7bb590fef530c64adbe473cffa9e09b2e4507daf --- M vcl/unx/generic/a

[Libreoffice-commits] core.git: connectivity/inc dbaccess/inc oox/inc sal/inc sc/inc sd/inc starmath/inc svtools/inc svx/inc sw/inc vcl/inc writerfilter/inc xmloff/inc

2013-03-12 Thread Luboš Luňák
connectivity/inc/pch/precompiled_file.hxx |7 +++ connectivity/inc/pch/precompiled_flat.hxx |7 +++ dbaccess/inc/pch/precompiled_dbu.hxx |7 +++ oox/inc/pch/precompiled_oox.hxx |8 sal/inc/pch/precompiled_sal.hxx

[Libreoffice-commits] core.git: 3 commits - dbaccess/source reportbuilder/java reportdesign/source sal/inc xmloff/inc xmloff/source

2013-03-12 Thread Lionel Elie Mamane
dbaccess/source/core/dataaccess/ModelImpl.cxx |4 - reportbuilder/java/org/libreoffice/report/SDBCReportDataFactory.java |9 +- reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java | 40 +++

[Libreoffice-commits] core.git: vcl/unx

2013-03-12 Thread Caolán McNamara
vcl/unx/gtk/window/gtkframe.cxx | 32 1 file changed, 32 deletions(-) New commits: commit b1beaf3f7a7d332890ea3877b657cd014562cf33 Author: Caolán McNamara Date: Tue Mar 12 16:33:01 2013 + Resolves: rhbz#920697, #i110881#, rhbz#623191 presentation no

[Libreoffice-commits] core.git: 2 commits - solenv/bin

2013-03-12 Thread Luboš Luňák
solenv/bin/update_pch.sh | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) New commits: commit 7ac75351f16358fd0f9d83162eda25cca6de2622 Author: Luboš Luňák Date: Tue Mar 12 17:23:18 2013 +0100 mention that temporary edits in autogenerated pch headers are ok C

WPXStringStream

2013-03-12 Thread Ivan
Hello, I am a freelance developer. And I have just found some remarks in this project. 1)There is a error in function: WPXInputStream *WPXStringStream::getDocumentOLEStream(const char *name); "if (!d->buffer.empty())" The first line in this function shouldn't have '!' symbol. (line 443 in f

[Libreoffice-commits] core.git: sc/qa

2013-03-12 Thread Noel Power
sc/qa/extras/macros-test.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 15366dbf24311734a8eae4fb7e7dadaeec12ee56 Author: Noel Power Date: Tue Mar 12 16:05:39 2013 + re-enable testStarBasic() & testVba() in for Windows ( macosx later ) Change-

Re: --enable-pch option is broken?

2013-03-12 Thread Lubos Lunak
On Sunday 10 of March 2013, Peter Foley wrote: > David, > > Should be fixed now. > you can just run ./solenv/bin/update_pch.sh to auto-regenerate all the pch > files. > Maybe a note should be added somewhere to run it whenever header files are > moved around? That is not necessary, as it was the

[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 57061, which changed state. Bug 57061 Summary: Not all personal data imported during install from /3 User Profile https://bugs.freedesktop.org/show_bug.cgi?id=57061 What|Removed |Added

[PUSHED libreoffice-4-0] fdo#61564 when WrappedTargetException not in specification, ...

2013-03-12 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2684 Approvals: Eike Rathke: Looks good to me, approved Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerri

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - dbaccess/source

2013-03-12 Thread Lionel Elie Mamane
dbaccess/source/core/dataaccess/documentcontainer.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 6b26441f4b01f4e01390b9a5b4710d0932751a93 Author: Lionel Elie Mamane Date: Sat Mar 2 08:10:14 2013 +0100 fdo#61564 when WrappedTargetException not in spec

Re: [PATCH] add pch support to gcc

2013-03-12 Thread Lubos Lunak
On Monday 11 of March 2013, Michael Meeks wrote: > Hi Peter, > > On Sun, 2013-03-10 at 21:50 +, Peter Foley (via Code Review) wrote: > > add pch support to gcc > > Sounds interesting :-) Any performance numbers and/or rough anecdotes > of goodness to go with that ? I'd be interested too

Pivot Table data provider extension framework (removal possibility)

2013-03-12 Thread Kohei Yoshida
Hi there, I'd like to ask whether someone actually uses this Pivot Table data provider extension framework, because I'd like to remove this if nobody is using it, or only few people are using it. Currently, Calc's pivot table supports 4 different backends. They are: 1. cell range on sheet 2

[Libreoffice-commits] core.git: 6 commits - desktop/inc desktop/Library_libreoffice.mk desktop/Library_sofficeapp.mk desktop/Module_desktop.mk desktop/source Repository.mk smoketest/Executable_libtest

2013-03-12 Thread Michael Meeks
Repository.mk |2 desktop/Library_libreoffice.mk| 32 ++ desktop/Library_sofficeapp.mk |5 + desktop/Module_desktop.mk |6 + desktop/inc/liblibreoffice.hxx| 29 + desktop/inc/liblibreoffice_impl.hxx | 27 +

[PATCH libreoffice-4-0] fdo#61564 when WrappedTargetException not in specification, ...

2013-03-12 Thread Lionel Elie Mamane (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2684 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/2684/1 fdo#61564 when WrappedTargetException not in specification, do not throw it! Change-Id: Id3c995557f320b1d0241f0e

Re: gmake instructions for running an individual unit test appear to be out of date

2013-03-12 Thread Matúš Kukan
On 12 March 2013 16:18, Lubos Lunak wrote: > On Tuesday 12 of March 2013, Matúš Kukan wrote: >> On 12 March 2013 15:20, Noel Grandin wrote: >> > to rerun just this failed test without all others, run: >> > make /home/noel/libo/workdir/unxlngx6/JunitTest/sfx2_complex/done >> > >> > Whe

[Libreoffice-commits] core.git: connectivity/source

2013-03-12 Thread Lionel Elie Mamane
connectivity/source/commontools/AutoRetrievingBase.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 6ea685090806a2a2f39b8d5ec6a749eaf9b1856e Author: Lionel Elie Mamane Date: Tue Mar 12 16:26:15 2013 +0100 janitorial: readability Change-Id: Iaab09

need help with shell / configure

2013-03-12 Thread Matúš Kukan
Hi, With ./configure --build=x86_64-unknown-linux-gnu --host=arm-unknown-linux-gnueabihf I get: ... checking which languages to be built... en-US checking for alternative branding images directory... ./configure: 35560: ./configure.lineno: Syntax error: "(" unexpected configure: error:

[PUSHED libreoffice-4-0] Resolves: #i119658#, some Chinese numbering formats not supp...

2013-03-12 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2682 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2682 To unsubscribe, visi

[PUSHED libreoffice-4-0] Package fonts to the fonts subpackage

2013-03-12 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2683 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2683 To unsubscribe, visi

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - writerfilter/source

2013-03-12 Thread Jian Fang Zhang
writerfilter/source/dmapper/ConversionHelper.cxx |4 1 file changed, 4 insertions(+) New commits: commit 775c3ddd47e0619a7f0ebed6dbcba3d5b41a708e Author: Jian Fang Zhang Date: Mon Sep 3 07:50:59 2012 + Resolves: #i119658#, some Chinese numbering formats not supported

  1   2   >