Re: Code pointers for replace HSQLDB for Firebird

2013-03-21 Thread David Ostrovsky
On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote: Hi guys! As suggested by Cecric and Muthu, I'm here to ask some code pointers to work in the HSQLDB replacement for Firebird. I'm reading https://bugs.freedesktop.org/show_bug.cgi?id=51781 from Lionel, and trying to understand

[PATCH] Don't complain about missing colon in empty DSN

2013-03-21 Thread Mathias Hasselmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2885 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/2885/1 Don't complain about missing colon in empty DSN Empty datasource names occur with the datasource wizard's first

Build failure on master with Linux 32 bit in localize.cxx

2013-03-21 Thread Alex Thurgood
Hi all, FYI As of last night, I'm now getting a build failure in localize.cxx with my build from master, both on make dev-install, and after make clean/make : [build CXX] l10ntools/source/localize.cxx [build CXX] l10ntools/source/propmerge.cxx

[Libreoffice-commits] core.git: dbaccess/source

2013-03-21 Thread Mathias Hasselmann
dbaccess/source/core/misc/dsntypes.cxx |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit 4f6514eb0904f79b7c2db0958dc580bcf716911c Author: Mathias Hasselmann math...@openismus.com Date: Wed Mar 20 00:33:03 2013 +0100 Don't complain about missing colon in

[ANN] LibreOffice 3.6.6 RC1 test builds available

2013-03-21 Thread Fridrich Strba
Hi *, for the upcoming new version 3.6.6, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 3.6.6, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.6_release

[PUSHED] Don't complain about missing colon in empty DSN

2013-03-21 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2885 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2885 To unsubscribe,

[Libreoffice-commits] core.git: connectivity/Library_tdeab1.mk

2013-03-21 Thread Timothy Pearson
connectivity/Library_tdeab1.mk |4 1 file changed, 4 insertions(+) New commits: commit 3e33adc4b09c38f95adc1761cc444c938ce22370 Author: Timothy Pearson kb9...@pearsoncomputing.net Date: Wed Mar 20 22:51:14 2013 + Fix single core builds when TDE integration is enabled

[PUSHED] Fix single core builds when TDE integration is enabled

2013-03-21 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2882 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2882 To unsubscribe,

[Libreoffice-commits] core.git: sd/source

2013-03-21 Thread Urs Fässler
sd/source/core/stlsheet.cxx | 113 +-- sd/source/filter/eppt/eppt.cxx |6 +- sd/source/filter/eppt/epptso.cxx |9 +-- 3 files changed, 48 insertions(+), 80 deletions(-) New commits: commit 08416ff716119dca888087bd38fd9662f4e85f7a Author: Urs

Openismus GmbH license statement

2013-03-21 Thread Murray Cumming
Here's the general licensing statement for contributions by Openismus Gmbh to LibreOffice: Our company preference is to contribute code to open source projects under the terms of that project's existing license. Therefore, all contributions past, present, and future (while this choice of

[Libreoffice-commits] core.git: sw/qa

2013-03-21 Thread David Ostrovsky
sw/qa/complex/writer/VarFields.java | 97 1 file changed, 67 insertions(+), 30 deletions(-) New commits: commit bb59e2e22161fcf66e3c71f58f5b160a24c9 Author: David Ostrovsky da...@ostrovsky.org Date: Thu Mar 21 10:21:51 2013 +0100 fdo#55814

[PATCH] Add builder support for a few dbaui controls

2013-03-21 Thread Mathias Hasselmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2886 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/2886/1 Add builder support for a few dbaui controls This adds the needed methods and catalog definitions for

[PATCH] Remove ResId support for a few dbaui controls

2013-03-21 Thread Mathias Hasselmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2888 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2888/1 Remove ResId support for a few dbaui controls This removes the ResId constructors of dbaui::OpenDocumentButton

[PATCH] Disable database wizard's next-button if needed

2013-03-21 Thread Mathias Hasselmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2889 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/2889/1 Disable database wizard's next-button if needed This disables the database wizard's next-button if the current

[Libreoffice-commits] core.git: sc/source

2013-03-21 Thread Lennard Wasserthal
sc/source/ui/drawfunc/fudraw.cxx | 15 +++ sc/source/ui/drawfunc/futext.cxx | 22 -- sc/source/ui/inc/fudraw.hxx |1 + 3 files changed, 36 insertions(+), 2 deletions(-) New commits: commit b71d3ad1fd71092e4cc85f5bb96b3bc3347e55d2 Author: Lennard

[PUSHED] fdo#55430 allowing click-from-textmode without causing fdo#6...

2013-03-21 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2786 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2786 To unsubscribe,

Re: fdo#55814: unit test is missing

2013-03-21 Thread David Ostrovsky
Hi Miklos, On Mon, 2013-03-18 at 11:18 +0100, Miklos Vajna wrote: Hi David, On Sat, Mar 09, 2013 at 02:29:54PM +0100, David Ostrovsky david.ostrov...@gmx.de wrote: I wonder why we don't have any unit test for that part of code? We do have one:

[Libreoffice-commits] core.git: sc/source

2013-03-21 Thread Stephan Bergmann
sc/source/ui/drawfunc/fudraw.cxx |2 +- sc/source/ui/drawfunc/futext.cxx |2 +- sc/source/ui/inc/fudraw.hxx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 7a09d361498abad7d4aba4762e569e27d39e15ad Author: Stephan Bergmann sberg...@redhat.com Date:

Re: NumericBox unsafe double conversion

2013-03-21 Thread Jan Holesovsky
Hi Tamás, Zolnai Tamás píše v St 20. 03. 2013 v 22:33 +0100: Yes, I give it a try. Great, thanks a lot! :-) I think the mentioned multiplication is in MetricField::ConvertDoubleValue(), which not need to change, as I see. So whenever we are converting to and from double, there is the risk

[Libreoffice-commits] core.git: sw/source

2013-03-21 Thread Julien Nabet
sw/source/core/text/porglue.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dc0111e5fdc9ecf991420e99b08260ed4f0d2bdb Author: Julien Nabet serval2...@yahoo.fr Date: Wed Mar 20 22:27:22 2013 +0100 coverity#704931 Explicit null dereferenced

[PUSHED] coverity#704931 Explicit null dereferenced

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2881 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2881 To unsubscribe, visit

Re: Code pointers for replace HSQLDB for Firebird

2013-03-21 Thread Lionel Elie Mamane
On Thu, Mar 21, 2013 at 08:26:42AM +0100, David Ostrovsky wrote: On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote: Hi guys! As suggested by Cecric and Muthu, I'm here to ask some code pointers to work in the HSQLDB replacement for Firebird. I'm reading

[Libreoffice-commits] core.git: sw/source

2013-03-21 Thread Philipp Riemer
sw/source/core/access/acccontext.hxx | 12 sw/source/core/access/accfootnote.hxx |9 +++-- sw/source/core/access/accgraphic.hxx |9 +++-- sw/source/core/access/accheaderfooter.hxx |9 +++-- sw/source/core/access/acctable.cxx|4 +---

[PUSHED] reduce space needed by comments in sw/source/core

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2880 -- To view, visit https://gerrit.libreoffice.org/2880 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Lionel Elie Mamane
On Wed, Mar 20, 2013 at 05:45:30PM +0100, Andreas Radke wrote: We are running in a bug with the current package file lists making Calc and Base to fail to load without having Writer installed. Check https://bugs.archlinux.org/task/34332 and https://bugs.archlinux.org/task/34378. It turns

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Rene Engelhard
Hi, On Thu, Mar 21, 2013 at 10:53:42AM +0100, Lionel Elie Mamane wrote: It turns out that Calc and Base now need /usr/lib/libreoffice/share/registry/writer.xcd present on the system. Is this a wanted change or a bug? Speaking of base, my guess is (but I'd be happy for a tester to

[Libreoffice-commits] core.git: vcl/unx

2013-03-21 Thread Thorsten Behrens
vcl/unx/generic/plugadapt/salplug.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bf5e1575e81195d1931a6eadd15ab27cc39aadec Author: Thorsten Behrens tbehr...@suse.com Date: Thu Mar 21 11:27:58 2013 +0100 Fix force-choosing gtk3 backend. Extra

Re: Code pointers for replace HSQLDB for Firebird

2013-03-21 Thread Marcos Souza
Hi David, 2013/3/21 David Ostrovsky d.ostrov...@idaia.de On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote: Hi guys! As suggested by Cecric and Muthu, I'm here to ask some code pointers to work in the HSQLDB replacement for Firebird. I'm reading

Re: Code pointers for replace HSQLDB for Firebird

2013-03-21 Thread Marcos Souza
Hi Lionel! 2013/3/21 Lionel Elie Mamane lio...@mamane.lu On Thu, Mar 21, 2013 at 08:26:42AM +0100, David Ostrovsky wrote: On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote: Hi guys! As suggested by Cecric and Muthu, I'm here to ask some code pointers to work in the HSQLDB

[Libreoffice-commits] core.git: 6 commits - configure.ac openssl/ExternalProject_openssl.mk sal/osl solenv/gbuild tools/inc tools/source

2013-03-21 Thread Tor Lillqvist
configure.ac|4 +++- openssl/ExternalProject_openssl.mk |2 +- sal/osl/w32/profile.cxx |2 +- solenv/gbuild/platform/com_MSC_class.mk |8 +++- solenv/gbuild/platform/com_MSC_defs.mk |7 ++- tools/inc/tools/stream.hxx

[Libreoffice-commits] core.git: vcl/ios

2013-03-21 Thread Luboš Luňák
vcl/ios/source/gdi/salgdicommon.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 1c3c38122a020a998a92dd15a0870c576a66a8aa Author: Luboš Luňák l.lu...@suse.cz Date: Thu Mar 21 12:17:00 2013 +0100 avoid Wundef / fix endian detection diff --git

[Libreoffice-commits] core.git: solenv/gbuild

2013-03-21 Thread Luboš Luňák
solenv/gbuild/WinResTarget.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 27388c9483b5e00b593ac126092c5bbb131492b0 Author: Luboš Luňák l.lu...@suse.cz Date: Thu Mar 21 12:26:15 2013 +0100 do not pass -isystem to winres In mingw build, the

[Libreoffice-commits] core.git: basic/qa

2013-03-21 Thread Noel Power
basic/qa/basic_coverage/da-DK/cdbl-2.vb | 14 ++ 1 file changed, 14 insertions(+) New commits: commit f69acf929b4a8131370ab05ab0886334e1fc566d Author: Noel Power noel.po...@suse.com Date: Thu Mar 21 11:08:27 2013 + another variation of the localised Cdbl test

[Libreoffice-commits] core.git: bridges/Library_cpp_uno.mk

2013-03-21 Thread Tomas Chvatal
bridges/Library_cpp_uno.mk |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 7e1053381f6ab8ee7710a6ea90f51d77efcf6edd Author: Tomas Chvatal tchva...@suse.cz Date: Thu Mar 21 12:48:01 2013 +0100 Fix -mno-avx calls by removing weird OS check.

[Libreoffice-commits] core.git: bridges/Library_cpp_uno.mk

2013-03-21 Thread Tomas Chvatal
bridges/Library_cpp_uno.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 452d7b60c48d0cb5a02e9fdb7271f87cf0ac6de2 Author: Tomas Chvatal tchva...@suse.cz Date: Thu Mar 21 12:50:07 2013 +0100 Fix typo in previous commit. Change-Id:

[Libreoffice-commits] core.git: 5 commits - sd/inc sd/source

2013-03-21 Thread Stephan Bergmann
sd/inc/sddllapi.h |1 - sd/source/filter/html/htmlex.cxx |6 +++--- sd/source/filter/html/htmlex.hxx |4 +--- sd/source/filter/html/htmlpublishmode.hxx | 28 sd/source/filter/html/pubdlg.cxx |4

[Libreoffice-commits] core.git: sd/inc

2013-03-21 Thread Stephan Bergmann
sd/inc/sdpage.hxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit e71c2752e76ee7acc3c4ac2d700bce17aff9b601 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Mar 21 13:17:21 2013 +0100 Revert sd::HeaderFooterSettings: try to make MSVC tinderboxes

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - android/sdremote

2013-03-21 Thread Michael Meeks
android/sdremote/src/org/libreoffice/impressremote/communication/SlideShow.java | 11 +- 1 file changed, 10 insertions(+), 1 deletion(-) New commits: commit 5c94a1ed371e140c91c0687acc719566055cca3e Author: Michael Meeks michael.me...@suse.com Date: Tue Feb 19 16:26:52 2013 +

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Petr Mladek
Rene Engelhard píše v Čt 21. 03. 2013 v 11:04 +0100: Hi, On Thu, Mar 21, 2013 at 10:53:42AM +0100, Lionel Elie Mamane wrote: It turns out that Calc and Base now need /usr/lib/libreoffice/share/registry/writer.xcd present on the system. Is this a wanted change or a bug?

[PATCH] Move setupwizard modify handler code.

2013-03-21 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2890 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/2890/1 Move setupwizard modify handler code. Move setupwizard code into the conditional below it. You can only work on

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Lionel Elie Mamane
On Thu, Mar 21, 2013 at 01:34:51PM +0100, Petr Mladek wrote: Rene Engelhard píše v Čt 21. 03. 2013 v 11:04 +0100: On Thu, Mar 21, 2013 at 10:53:42AM +0100, Lionel Elie Mamane wrote: It turns out that Calc and Base now need /usr/lib/libreoffice/share/registry/writer.xcd present on the system.

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Eike Rathke
Hi Philipp, On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) wrote: remove/add blank lines in sw/source/core I'd prefer if such mere cosmetical changes would not be done; while inserting a blank line mostly is ok for readability, removing a blank line mostly for the

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Rene Engelhard
hi, On Thu, Mar 21, 2013 at 01:34:51PM +0100, Petr Mladek wrote: I think that it is also the other way around. AFAIK, you could not use data sources in Writer without Base. True. That's why we invented http://packages.debian.org/libreoffice-base-core BTW: I wonder if embeded objects are can

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Stephan Bergmann
On 03/20/2013 05:45 PM, Andreas Radke wrote: We are running in a bug with the current package file lists making Calc and Base to fail to load without having Writer installed. Check https://bugs.archlinux.org/task/34332 and https://bugs.archlinux.org/task/34378. It turns out that Calc and Base

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Michael Meeks
Hi Eike, On Thu, 2013-03-21 at 14:31 +0100, Eike Rathke wrote: On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) wrote: remove/add blank lines in sw/source/core I'd prefer if such mere cosmetical changes would not be done; while inserting a blank line mostly is ok

Re: [LibreOffice-QA] Conference Call - March 22nd, 2013 - UPDATED TIME (1300 UTC)

2013-03-21 Thread Joel Madero
Hi All, I hope this isn't a problem for anyone. I forgot two weeks ago we had daylight savings time here in the States so 1400 UTC is 7am here, I wouldn't be able to make it as I have work. Unless there are complaints, *let's do 1300 UTC starting tomorrow.* Again the time has changed to

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/inc sc/source

2013-03-21 Thread Kohei Yoshida
sc/inc/cell.hxx |3 -- sc/source/core/data/cell.cxx |8 - sc/source/ui/docshell/docfunc.cxx | 53 -- sc/source/ui/inc/docfunc.hxx |5 --- 4 files changed, 69 deletions(-) New commits: commit

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0-2' - desktop/source

2013-03-21 Thread Stephan Bergmann
desktop/source/migration/services/oo3extensionmigration.cxx | 54 desktop/source/migration/services/oo3extensionmigration.hxx |6 - 2 files changed, 21 insertions(+), 39 deletions(-) New commits: commit c09c5a1e42b898a1d1558377695f609c4426d50c Author: Stephan Bergmann

[PUSHED libreoffice-4-0-2] deb#703486: Keep migrating more user extensions after one fa...

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2878 Approvals: Noel Power: Verified; Looks good to me, approved Fridrich Strba: Looks good to me, but someone else must approve -- To

[Libreoffice-commits] core.git: setup_native/source

2013-03-21 Thread Stephan Bergmann
setup_native/source/packinfo/packinfo_office.txt |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 4e69b35674882d8d675a677940805b187cad0bc3 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Mar 21 15:57:18 2013 +0100 Missing dependency of librelogo on

[Libreoffice-commits] core.git: rsc/source

2013-03-21 Thread Miklos Vajna
rsc/source/rsc/rsc.cxx |9 - 1 file changed, 4 insertions(+), 5 deletions(-) New commits: commit 3b00a7f87b8d428dc8c3d1d0ddb84b74bb2343d4 Author: Miklos Vajna vmik...@suse.cz Date: Thu Mar 21 16:10:06 2013 +0100 RscCmdLine: don't use obsolete DirEntry Change-Id:

[Libreoffice-commits] core.git: rsc/source

2013-03-21 Thread Michael Meeks
rsc/source/tools/rsctools.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 5c4bf7a6029da36853fbae1513c9c5ed993059a3 Author: Michael Meeks michael.me...@suse.com Date: Thu Mar 21 15:21:28 2013 + stop uninitialized memory leaking into resource files.

Re: [LibreOffice-QA] Conference Call - March 22nd, 2013 - UPDATED TIME (1300 UTC)

2013-03-21 Thread Florian Reisinger
Well, I am at School -- 13:30 or 13:20 would be the earliest possible hour for me... Liebe Grüße, / Yours, Florian Reisinger Am 21.03.2013 um 15:15 schrieb Joel Madero jmadero@gmail.com: Hi All, I hope this isn't a problem for anyone. I forgot two weeks ago we had daylight savings time

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - rsc/source

2013-03-21 Thread Michael Meeks
rsc/source/tools/rsctools.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 94ccdf065e910a4f3bb247e5482ece9d85d3c1ab Author: Michael Meeks michael.me...@suse.com Date: Thu Mar 21 15:21:28 2013 + stop uninitialized memory leaking into resource files.

[PATCH libreoffice-4-0-2] resolved rhbz#919020 Basic CDbl() and CSng() scan localized ...

2013-03-21 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2893 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/2893/1 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number Code wrongly replaced decimal separator with

[PATCH libreoffice-3-6] fixed a possible crasher

2013-03-21 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2894 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/2894/1 fixed a possible crasher Change-Id: I3b67ba1a8896b4b291e009b4ad680e1342ba9460 --- M

[PATCH libreoffice-3-6-6] fixed a possible crasher

2013-03-21 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2895 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/2895/1 fixed a possible crasher Change-Id: I3b67ba1a8896b4b291e009b4ad680e1342ba9460 --- M

[PATCH] unit test for i#116701

2013-03-21 Thread Korrawit Pruegsanusak (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2896 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/2896/1 unit test for i#116701 Change-Id: Id9a9532d0e02b478f7913bc4a687c38f79a3a322 --- M svl/qa/unit/svl.cxx 1 file

Re: Pivot Table data provider extension framework (removal possibility)

2013-03-21 Thread Kohei Yoshida
On Wed, Mar 20, 2013 at 5:20 AM, Eike Rathke er...@redhat.com wrote: Hi Kohei, On Thursday, 2013-03-14 09:26:55 -0400, Kohei Yoshida wrote: I believe the same functionality can be achieve via database connectivity, by having such external data provider register as a database, and use it

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - basic/source

2013-03-21 Thread Eike Rathke
basic/source/sbx/sbxscan.cxx | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) New commits: commit 88a2e6260c7e5eb9d96129c7391b9ed2ba8272ba Author: Eike Rathke er...@redhat.com Date: Thu Mar 21 16:34:56 2013 +0100 fixed a possible crasher Change-Id:

[PUSHED libreoffice-3-6] fixed a possible crasher

2013-03-21 Thread Petr Mladek (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2894 Approvals: Petr Mladek: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2894 To unsubscribe, visit

[PUSHED] remove unused code svtools/bmpmaker

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2868 Approvals: Noel Power: Verified; Looks good to me, approved LibreOffice gerrit bot: Verified Thomas Arnhold: Verified; Looks good to

Re: Pivot Table data provider extension framework (removal possibility)

2013-03-21 Thread Kohei Yoshida
On 03/12/2013 11:41 AM, Kohei Yoshida wrote: Hi there, I'd like to ask whether someone actually uses this Pivot Table data provider extension framework, because I'd like to remove this if nobody is using it, or only few people are using it. I have a cunning idea. Since one of the difficulties

Minutes of ESC call

2013-03-21 Thread Jan Holesovsky
Present: Eike, Kendy, Petr, Astron, Kohei, Eilidh, Cedric, Fridrich, Stephan * Completed Action Items + none :-( * Pending Action Items + Bugzilla attachments not set to autodetect (Bjoern) + [ pinging Tollef ] + disable Rhino / Beanshell unless in

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Andreas Radke
Am Thu, 21 Mar 2013 14:55:37 +0100 schrieb Stephan Bergmann sberg...@redhat.com: However, for the two archlinux issues mentioned above, I would assume that this things are packaged differently there, and share/registry/librelogo.xcd erroneously ends up in some core package? Which would make

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Kohei Yoshida
On 03/21/2013 09:31 AM, Eike Rathke wrote: Hi Philipp, On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) wrote: remove/add blank lines in sw/source/core I'd prefer if such mere cosmetical changes would not be done; while inserting a blank line mostly is ok for

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/source

2013-03-21 Thread Kohei Yoshida
sc/source/filter/lotus/op.cxx | 31 ++- sc/source/filter/qpro/qpro.cxx | 11 ++- sc/source/filter/starcalc/scflt.cxx |3 ++- 3 files changed, 22 insertions(+), 23 deletions(-) New commits: commit 36b194405ee3509dccee33263a9c610aaaf16e93

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6-6' - basic/source

2013-03-21 Thread Eike Rathke
basic/source/sbx/sbxscan.cxx | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) New commits: commit 636d6ff34b2a3740d96bcb6f19b549e64614ac95 Author: Eike Rathke er...@redhat.com Date: Thu Mar 21 16:34:56 2013 +0100 fixed a possible crasher Change-Id:

[PUSHED libreoffice-3-6-6] fixed a possible crasher

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2895 Approvals: Noel Power: Verified; Looks good to me, approved Petr Mladek: Verified; Looks good to me, but someone else must approve

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Stephan Bergmann
On 03/21/2013 05:39 PM, Andreas Radke wrote: Am Thu, 21 Mar 2013 14:55:37 +0100 schrieb Stephan Bergmann sberg...@redhat.com: However, for the two archlinux issues mentioned above, I would assume that this things are packaged differently there, and share/registry/librelogo.xcd erroneously ends

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Lubos Lunak
On Thursday 21 of March 2013, Eike Rathke wrote: Hi Philipp, On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) wrote: remove/add blank lines in sw/source/core I'd prefer if such mere cosmetical changes would not be done; while inserting a blank line mostly is ok

[PATCH libreoffice-4-0] Missing dependency of librelogo on writer

2013-03-21 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2897 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/2897/1 Missing dependency of librelogo on writer ...at least due to dependency of librelogo.xcd on writer.xcd, see

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Stephan Bergmann
On 03/21/2013 02:55 PM, Stephan Bergmann wrote: And indeed, at least with the official generic Linux downloads from http://www.libreoffice.org/download libobasis4.0-librelogo-4.0.1.2-2 (containing share/registry/librelogo.xcd) only depends on libobasis4.0-core01 but not on libobasis4.0-writer.

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Tor Lillqvist
I think there is still so much to do before arguing about spaces or other similar matter of taste details that have very little practical consequences. The practical consequence of inconsistent spacing/alignment, excessive vertical whitespace, pointless ASCII graphics etc is that developers

[PATCH libreoffice-4-0-2] Missing dependency of librelogo on writer

2013-03-21 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2898 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/2898/1 Missing dependency of librelogo on writer ...at least due to dependency of librelogo.xcd on writer.xcd, see

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - setup_native/source

2013-03-21 Thread Stephan Bergmann
setup_native/source/packinfo/packinfo_office.txt |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 110253379015ec0cbb2bbaf99fde9e2c546f8d06 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Mar 21 15:57:18 2013 +0100 Missing dependency of librelogo on

[PUSHED libreoffice-4-0] Missing dependency of librelogo on writer

2013-03-21 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2897 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2897 To unsubscribe,

[Libreoffice-commits] core.git: 3 commits - dbaccess/source tools/inc vcl/source

2013-03-21 Thread Chris
dbaccess/source/ui/dlg/dbwizsetup.cxx | 10 +- tools/inc/tools/debug.hxx |5 ++--- vcl/source/glyphs/graphite_features.cxx |5 +++-- 3 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 3c61c08757208fb9735814dd62ac80f23cf51b86 Author: Chris

[PUSHED] Move setupwizard modify handler code.

2013-03-21 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2890 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2890 To unsubscribe,

[PATCH] basic: Remove non working AboutStarBasic

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2899 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/2899/1 basic: Remove non working AboutStarBasic The content of this function was commented out since the first import.

[PATCH] clean up DBG_ERRORn

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2900 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/2900/1 clean up DBG_ERRORn Those were DBG_ERRORn before and were falsely changed to OSL_TRACE by me. See:

[Libreoffice-commits] core.git: 2 commits - graphite/graphite2.patch python3/ExternalPackage_python3.mk python3/ExternalProject_python3.mk python3/python-3.3.0-msvc-x64.patch.1

2013-03-21 Thread Tor Lillqvist
graphite/graphite2.patch | 17 python3/ExternalPackage_python3.mk| 43 +- python3/ExternalProject_python3.mk|4 - python3/python-3.3.0-msvc-x64.patch.1 | 133 ++ 4 files changed, 175 insertions(+), 22 deletions(-) New

[Libreoffice-commits] core.git: basic/source

2013-03-21 Thread Eike Rathke
basic/source/comp/scanner.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit caecf6102f5042908c915afe89834ab7d3a4a4cb Author: Eike Rathke er...@redhat.com Date: Thu Mar 21 19:30:36 2013 +0100 SbiScanner::NextSym: check status after

[Libreoffice-commits] core.git: basic/qa

2013-03-21 Thread Eike Rathke
basic/qa/cppunit/test_scanner.cxx | 11 +++ 1 file changed, 11 insertions(+) New commits: commit cafa2b948bd78905b5890f917403e6fabff3b6dd Author: Eike Rathke er...@redhat.com Date: Thu Mar 21 19:43:53 2013 +0100 added unit test for 10e308 math overflow Change-Id:

Re: need help debugging unopkg error on centos 6.3

2013-03-21 Thread Michael Stahl
On 21/03/13 17:40, Neeraj Rai wrote: Hi Michael, I ran it with strace but I'm not sure I can interpret the output . I don't see any mention of osl_executeProcess. strace only traces system calls; presumably osl_executeProcess would result in clone and some variant of exec on Linux. I

Re: [4.0] Calc+Base fail without registry/writer.xcd from Writer package

2013-03-21 Thread Andreas Radke
Am Thu, 21 Mar 2013 18:04:15 +0100 schrieb Stephan Bergmann sberg...@redhat.com: On 03/21/2013 05:39 PM, Andreas Radke wrote: Am Thu, 21 Mar 2013 14:55:37 +0100 schrieb Stephan Bergmann sberg...@redhat.com: However, for the two archlinux issues mentioned above, I would assume that this

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Thomas Arnhold
On 21.03.2013 15:06, Michael Meeks wrote: So I'd say that these huge spews of ascii-art don't serve a useful purpose: //- and bulky content-free comments (which we still have plenty of) should clearly take be a higher priority

[Libreoffice-commits] core.git: python3/ExternalProject_python3.mk

2013-03-21 Thread Michael Stahl
python3/ExternalProject_python3.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c49d0ba320faff58c0c9baefe5c1a182593fe22b Author: Michael Stahl mst...@redhat.com Date: Thu Mar 21 20:02:25 2013 +0100 python3: fix typo in

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/inc sc/source

2013-03-21 Thread Kohei Yoshida
sc/inc/column.hxx |3 ++ sc/inc/document.hxx | 12 +++ sc/inc/table.hxx |3 ++ sc/source/core/data/column.cxx| 17 sc/source/core/data/column3.cxx | 10 + sc/source/core/data/document.cxx | 27

[Libreoffice-commits] core.git: rsc/source

2013-03-21 Thread Michael Stahl
rsc/source/rsc/rsc.cxx |9 + 1 file changed, 5 insertions(+), 4 deletions(-) New commits: commit 3b5497f258fce37eebfc33536bfabb9016575cb5 Author: Michael Stahl mst...@redhat.com Date: Thu Mar 21 20:35:45 2013 +0100 Revert RscCmdLine: don't use obsolete DirEntry This

[Libreoffice-commits] core.git: vcl/source

2013-03-21 Thread Tor Lillqvist
vcl/source/filter/jpeg/jpeg.cxx |2 +- vcl/source/filter/jpeg/jpeg.h |2 +- vcl/source/filter/jpeg/jpegc.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 3159f9cd6113c7f3fe8c210c56be886bb0b897e8 Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Mar

Re: [LibreOffice-QA] Conference Call - March 22nd, 2013 - UPDATED TIME (1300 UTC)

2013-03-21 Thread Bjoern Michaelsen
On Thu, Mar 21, 2013 at 07:15:39AM -0700, Joel Madero wrote: Hi All, I hope this isn't a problem for anyone. I forgot two weeks ago we had daylight savings time here in the States so 1400 UTC is 7am here, I wouldn't be able to make it as I have work. Unless there are complaints, *let's do

[Libreoffice-commits] core.git: Repository.mk

2013-03-21 Thread Thomas Arnhold
Repository.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 211a9a9cdcc34316e40c893179d7d3d0c160cfe4 Author: Thomas Arnhold tho...@arnhold.org Date: Thu Mar 21 19:46:23 2013 +0100 rscdep is dead 18d37cf9fb21dd809ec79135ce93f9a55512c9b3 Change-Id:

Re: [LibreOffice-QA] Conference Call - March 22nd, 2013 - UPDATED TIME (1300 UTC)

2013-03-21 Thread Joel Madero
On Thu, Mar 21, 2013 at 1:24 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: On Thu, Mar 21, 2013 at 07:15:39AM -0700, Joel Madero wrote: Hi All, I hope this isn't a problem for anyone. I forgot two weeks ago we had daylight savings time here in the States so 1400 UTC is

Re: [LibreOffice-QA] Conference Call - March 22nd, 2013 - UPDATED TIME (1300 UTC)

2013-03-21 Thread Joel Madero
On Thu, Mar 21, 2013 at 8:23 AM, Florian Reisinger reisi...@gmail.comwrote: Well, I am at School -- 13:30 or 13:20 would be the earliest possible hour for me... Sorry Florian for the inconvenience. I've been told that next weekend (9 days) is the time change for you guys and then the time

[Libreoffice-commits] core.git: bridges/Module_bridges.mk solenv/gbuild

2013-03-21 Thread Bjoern Michaelsen
bridges/Module_bridges.mk |2 - solenv/gbuild/extensions/post_SpeedUpTargets.mk | 43 2 files changed, 31 insertions(+), 14 deletions(-) New commits: commit c7f09e4fd4932f60c2e233d676537b6e786a7cfd Author: Bjoern Michaelsen

[PUSHED] introduce gb_Module_SKIPTARGETS

2013-03-21 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2742 Approvals: Björn Michaelsen: Verified; Looks good to me, approved Matúš Kukan: Looks good to me, approved -- To view, visit

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-03-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 55814, which changed state. Bug 55814 Summary: Condition for hidden section replaced by 0 https://bugs.freedesktop.org/show_bug.cgi?id=55814 What|Removed |Added

Re: [PATCH libreoffice-4-0] fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may ...

2013-03-21 Thread Miklos Vajna
Hi David, On Wed, Mar 20, 2013 at 04:11:28PM +0100, d.ostrov...@idaia.de wrote: on 3.6 branch too. Could you please submit it? Sure, I just did so. Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list

[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - 3 commits - sc/source

2013-03-21 Thread Kohei Yoshida
sc/source/ui/collab/sendfunc.cxx |5 - sc/source/ui/collab/sendfunc.hxx |3 sc/source/ui/docshell/docfunc.cxx | 35 - sc/source/ui/inc/docfunc.hxx |3 sc/source/ui/inc/undocell.hxx | 41 ++- sc/source/ui/undo/undocell.cxx| 138

  1   2   3   4   >