[Libreoffice-commits] core.git: i18npool/source

2013-04-23 Thread Lior Kaplan
i18npool/source/localedata/data/locale.dtd |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7e404210fc76b58d81e6f5a7468ac03ca53dd2e7 Author: Lior Kaplan Date: Wed Apr 24 09:49:04 2013 +0300 Update reference to lang.h due to global headers move Followup

[Libreoffice-commits] core.git: i18npool/source

2013-04-23 Thread Lior Kaplan
i18npool/source/localedata/data/locale.dtd |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d0d55e073039ced034dc4f7714f273e4337bc89a Author: Lior Kaplan Date: Wed Apr 24 09:28:42 2013 +0300 Update reference to lang.h whiche moved to l18nlangtag module

[PATCH] install javadoc files using filelist

2013-04-23 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3588 to look at the new patch set (#3). Change subject: install javadoc files using filelist .. install javadoc

[PUSHED] install javadoc files using filelist

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3588 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3588 To unsubscribe, visit

Re: lots of warnings after header changes

2013-04-23 Thread Jonathan Aquilina
confirmed after make clean on mac as well but interestingly enough my build is still running. On Wed, Apr 24, 2013 at 7:47 AM, Jean-Baptiste Faure < jbf.fa...@sud-ouest.org> wrote: > Le 24/04/2013 06:49, Jonathan Aquilina a écrit : > > Hey guys im building master on mac and im getting alot of wa

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/CustomTarget_javadoc.mk odk/CustomTarget_odkcommon.mk odk/Module_odk.mk odk/Package_javadoc.mk scp2/source

2013-04-23 Thread David Tardon
odk/CustomTarget_check.mk |1 odk/CustomTarget_javadoc.mk| 22 +++-- odk/CustomTarget_odkcommon.mk |1 odk/Module_odk.mk |1 odk/Package_javadoc.mk | 148 + scp2/source/sdkoo/module_sdkoo.scp |

Re: lots of warnings after header changes

2013-04-23 Thread Jean-Baptiste Faure
Le 24/04/2013 06:49, Jonathan Aquilina a écrit : > Hey guys im building master on mac and im getting alot of warnings The same for me on Ubuntu 12.04 x86-64 even after a make clean and a make distclean. Best regards. JBF > > Jonathan-Aquilinas-iMac:core eagles051387$ time make > /usr/bin/make -

[PUSHED] clean up install. of C++ docs

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3587 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3587 To unsubscribe, visit

[PUSHED] fix indentation

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3586 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3586 To unsubscribe, visit

[PATCH] clean up install. of C++ docs

2013-04-23 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3587 to look at the new patch set (#2). Change subject: clean up install. of C++ docs .. clean up install. of C

[Libreoffice-commits] core.git: odk/CustomTarget_check.mk odk/CustomTarget_doxygen.mk odk/CustomTarget_odkcommon.mk odk/Module_odk.mk odk/Zip_cppdocs.mk scp2/InstallModule_sdkoo.mk scp2/source

2013-04-23 Thread David Tardon
odk/CustomTarget_check.mk |1 + odk/CustomTarget_doxygen.mk|5 + odk/CustomTarget_odkcommon.mk |1 - odk/Module_odk.mk |5 - odk/Zip_cppdocs.mk | 20 scp2/InstallModule_sdkoo.mk|6

[Libreoffice-commits] core.git: odk/CustomTarget_doxygen.mk

2013-04-23 Thread David Tardon
odk/CustomTarget_doxygen.mk | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 753dba331c6305eadb904f6daa356e787090329a Author: David Tardon Date: Tue Apr 23 18:59:29 2013 +0200 fix indentation Change-Id: I59614470c0560187870b19e18903ed79b7b3

[PUSHED] gbuild: fix generated deps for API headers

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3506 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3506 To unsubscribe, visit

[PUSHED] gbuild: do not deliver UNO API headers

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3505 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3505 To unsubscribe, visit

[PUSHED] gbuild: drop empty use_packages calls

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3503 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3503 To unsubscribe, visit

[PUSHED] gbuild: drop uses of removed packages

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3502 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3502 To unsubscribe, visit

[PUSHED] move sal_inc headers to include/

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3501 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3501 To unsubscribe, visit

[PUSHED] Revert "add extra inc. dir for URE headers"

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3500 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3500 To unsubscribe, visit

[PUSHED] move URE headers to include/

2013-04-23 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3499 Approvals: David Tardon: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3499 To unsubscribe, visit

[Libreoffice-commits] core.git: solenv/gbuild

2013-04-23 Thread David Tardon
solenv/gbuild/UnoApi.mk | 11 +++ 1 file changed, 11 insertions(+) New commits: commit 1b2f3b9c64c7903dfa56953b91db4f5f105e4e7d Author: David Tardon Date: Sat Apr 20 09:59:13 2013 +0200 gbuild: fix generated deps for API headers This should be reverted after some time,

Re: Build LibreOffice on Mac OS X

2013-04-23 Thread Tor Lillqvist
On Wednesday, April 24, 2013, Jonathan Aquilina wrote: > Raphael make sure you have the command line tools installed through xcode > as well. > > Where do you think the /usr/bin/clang he mentioned comes from? --tml ___ LibreOffice mailing list LibreOffi

Re: Different Gerrit workflows -- was Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread David Ostrovsky
On Tue Apr 23 18:19:55 PDT 2013, Norbert Thiebaud wrote: >If you think that that list is missing someone(s) that are >very present on IRC and could help cover the request, I'm all ears. can you please add Stephan and Lionel? >but adding 200 peoples to that list is not something I consider viable

lots of warnings after header changes

2013-04-23 Thread Jonathan Aquilina
Hey guys im building master on mac and im getting alot of warnings Jonathan-Aquilinas-iMac:core eagles051387$ time make /usr/bin/make -j 4 -rs -f /Users/eagles051387/core/Makefile.gbuild /Users/eagles051387/core/basebmp/Library_basebmp.mk:27: [WARN ] !!! [WARN ] !!! gb_LinkTarget_set_include: in

[PATCH] gbuild: fix generated deps for API headers

2013-04-23 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3506 to look at the new patch set (#4). Change subject: gbuild: fix generated deps for API headers .. gbuild: f

[PATCH] install javadoc files using filelist

2013-04-23 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3588 to look at the new patch set (#2). Change subject: install javadoc files using filelist .. install javadoc

[PATCH] gbuild: fix generated deps for API headers

2013-04-23 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3506 to look at the new patch set (#3). Change subject: gbuild: fix generated deps for API headers .. gbuild: f

Re: Build LibreOffice on Mac OS X

2013-04-23 Thread Jonathan Aquilina
Raphael make sure you have the command line tools installed through xcode as well. On Wed, Apr 24, 2013 at 12:06 AM, wrote: > Hi, > > New report about building LibreOffice on a clean Mac OS X 10.7/XCode 4.5. > > 10.6 SDK is from Xcode 4.3.2 dmg. > > I switch to Libro 4 from git://gerrit.libreof

Re: Different Gerrit workflows -- was Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Norbert Thiebaud
On Tue, Apr 23, 2013 at 4:49 PM, Bjoern Michaelsen wrote: > I see you contemplating about integrating it in the UI and semi-automatic > triggering, but how is that blocking enabling it I see to allow committers do > to manual triggering via ssh (after checking the queue). What am I missing? You

Re: XDocumentTemplates behaviour

2013-04-23 Thread Rafael Dominguez
Ok gonna do that then On Thu, Apr 18, 2013 at 3:01 AM, Miklos Vajna wrote: > Hi, > > On Wed, Apr 10, 2013 at 06:47:56PM -0430, Rafael Dominguez < > venccsra...@gmail.com> wrote: > > So my question is that is it possible to change the behaviour of > > storeTemplate to call storeAsURL instead of

[PATCH libreoffice-4-0] fdo#63711 Calc: fix Catalan and Hungarian hyphenation

2013-04-23 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3591 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/3591/1 fdo#63711 Calc: fix Catalan and Hungarian hyphenation Change-Id: Ib9b3a63ad48ab9a8c109a97f4053c0fc4aca8a28 --- M

[Libreoffice-commits] core.git: icon-themes/crystal icon-themes/galaxy icon-themes/hicontrast icon-themes/human icon-themes/industrial icon-themes/oxygen

2013-04-23 Thread Zolnai Tamás
dev/null |binary icon-themes/crystal/cmd/lc_dbquerypropertiesdialog.png|binary icon-themes/crystal/cmd/sc_dbquerypropertiesdialog.png|binary icon-themes/galaxy/cmd/lc_dbquerypropertiesdialog.png |binary icon-themes/galaxy/cmd/sc_dbqu

[PATCH libreoffice-4-0] fdo#40102 show full footnote text in index tooltip

2013-04-23 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3590 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/3590/1 fdo#40102 show full footnote text in index tooltip Change-Id: I35acdaf4f62df7a1d375aed663c270e78ea70779 --- M sw

Re: Build LibreOffice on Mac OS X

2013-04-23 Thread foss
Hi, New report about building LibreOffice on a clean Mac OS X 10.7/XCode 4.5. 10.6 SDK is from Xcode 4.3.2 dmg. I switch to Libro 4 from git://gerrit.libreoffice.org/core Here the present compilers : Apple clang version 2.1 (tags/Apple/clang-163.7.1) (based on LLVM 3.0svn) /usr/bin/clang g

Re: Different Gerrit workflows -- was Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Bjoern Michaelsen
On Tue, Apr 23, 2013 at 11:21:07AM -0500, Norbert Thiebaud wrote: > On Tue, Apr 23, 2013 at 9:07 AM, Bjoern Michaelsen > wrote: > > > > with so far no arguments against it. Lets make the decision on the ESC call. > > Really ? Have I been too diplomatic about it ? Seems so ;) I see you contempla

[PUSHED] gbuild: drop unneeded package

2013-04-23 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3504 -- To view, visit https://gerrit.libreoffice.org/3504 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PATCH] gbuild: drop unneeded package

2013-04-23 Thread Michael Stahl (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3504 to look at the new patch set (#2). Change subject: gbuild: drop unneeded package .. gbuild: drop unneeded

[Libreoffice-commits] core.git: 2 commits - padmin/Module_padmin.mk padmin/Package_inc.mk padmin/Package_padmin.mk scp2/source sd/Module_sd.mk sd/Package_inc.mk

2013-04-23 Thread David Tardon
padmin/Module_padmin.mk |2 +- padmin/Package_inc.mk| 23 --- padmin/Package_padmin.mk | 26 ++ scp2/source/ooo/common_brand.scp |6 +++--- sd/Module_sd.mk |1 - sd/Package_inc.mk

Re: [GSoC] Enhanced database ranges, some clarification needed.

2013-04-23 Thread Akash Shetye
Hey again, Thanks for the reply, it really helps to know and discuss the task before putting in a proposal. Sorry for the quick and dirty solution, well thats what came to my mind right away. :P. So here is what I gather so far: *Alternating colors in database ranges "**very similar to the Format

Finished: [ANN] global header move on Tuesday 2013-04-23 between 1200UTC and 2000UTC

2013-04-23 Thread Bjoern Michaelsen
On Tue, Apr 23, 2013 at 04:26:23PM +0200, Bjoern Michaelsen wrote: > On Tue, Apr 23, 2013 at 02:25:35PM +0200, Bjoern Michaelsen wrote: > > On Thu, Apr 18, 2013 at 10:46:26PM +0200, Bjoern Michaelsen wrote: > > > - I will rebase the script against master on 2013-04-23 1200 UTC and again > > > exe

[PATCH libreoffice-4-0] fdo#60280: sw: restore anti-aliasing for all OLE objects

2013-04-23 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3589 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3589/1 fdo#60280: sw: restore anti-aliasing for all OLE objects The OLE case in SwNoTxtFrm::PaintPicture() was mis-merg

[Libreoffice-commits] core.git: sw/source

2013-04-23 Thread Michael Stahl
sw/source/core/doc/notxtfrm.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 954d695827431a5badd1a993d8f364c669ca9c9c Author: Michael Stahl Date: Tue Apr 23 22:27:57 2013 +0200 fdo#60280: sw: restore anti-aliasing for all OLE objects The OLE case

[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 60280, which changed state. Bug 60280 Summary: PRINTING of TABLE borders, borders around paragraphs and footer, some graphic elements suppressed by OLE objects in document https://bugs.freedesktop.org/show_bug.cgi?id=602

[PUSHED] execute move of global headers

2013-04-23 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3465 -- To view, visit https://gerrit.libreoffice.org/3465 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PUSHED] move global headers script

2013-04-23 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3367 -- To view, visit https://gerrit.libreoffice.org/3367 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

Bugs that need triaged ASAP - Potential Regressions within Release

2013-04-23 Thread Joel Madero
This is a list of bugs that get highest priority for getting triaged[1]. This will help us tremendously. For procedures on how to correctly triage the bug please see link[2]. [1] https://bugs.freedesktop.org/report.cgi?x_axis_field=resolution&y_axis_field=version&z_axis_field=&query_format=report

PATCH made available under the MPL/LGPLv3+

2013-04-23 Thread Ota Chasák
Hello, I have repaired bug 60791. Please let me know, if I can push the changes, or sending a diff is OK. Thank you Ota Chasák 60791--repaired-time-countdown.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedes

Customizing LO: "finalized" options and the key icon

2013-04-23 Thread Andreas Heinlein
Hello, I am currently checking some custom extensions at our site for compatibility with LO 4. We are currently using OO.o 3.3 and want to migrate. One extension sets several options and locks them down using "finalized=true", for example "RemovePersonalInfoOnSaving". This used to be shown w

problem with make debugrun

2013-04-23 Thread Alex Liu
All the other steps seem to be ok except I'm warned on the missing solver directory among others. http://www.libreoffice.org/developers-2/ I get this error on: make debugrun home/alexliu01/libreoffice/solver/unxlngi6.pro/installation/opt/program/soffice.bin No such file or directoryAnd goes i

Re: [PROPOSAL] enable gerrit buildbot trigger for all in group commiter

2013-04-23 Thread David Ostrovsky
On Sun, 2013-04-21 at 19:02 -0500, Norbert Thiebaud wrote: > On Sun, Apr 21, 2013 at 4:06 PM, Bjoern Michaelsen > wrote: > > > > Opinions? > > as of now the only way to do that is to give buildbot admin ACL so i changed that [1]. Now there are two ACLs: `Priority` : * get * put * verify * test-

Improvements in text formatting inside comments?

2013-04-23 Thread Sameer Deshmukh
Hello all, I was going through this GSoC idea: https://wiki.documentfoundation.org/Development/GSoC/Ideas#Comments_improvements I completely agree that the printing of comments at the bottom of the document/page is an issue, since I am also affected by it. But can someone please elaborate on 'b

[PATCH]fdo#55846 Comboboxes werent displayed in vertical toolbars

2013-04-23 Thread Janit Anjaria
Hey! I am hereby submitting my patch. Any suggestions would be appreciated. Regards, Janit 0001-fdo-55846-Comboboxes-weren-t-displayed-when-the-tool.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://

[PATCH] install javadoc files using filelist

2013-04-23 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3588 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3588/1 install javadoc files using filelist Change-Id: I434508057dbfab9410d8f7fc3844c45cd4201b11 --- M odk/CustomTarget

[PATCH] clean up install. of C++ docs

2013-04-23 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3587 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/3587/1 clean up install. of C++ docs Change-Id: I51841a8c92cb73912757fcc0766b11d8f9be4b77 --- M odk/CustomTarget_check.

[PATCH] fix indentation

2013-04-23 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3586 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/3586/1 fix indentation Change-Id: I59614470c0560187870b19e18903ed79b7b35d90 --- M odk/CustomTarget_doxygen.mk 1 file ch

[Libreoffice-commits] core.git: oox/source

2013-04-23 Thread Lionel Elie Mamane
oox/source/dump/dumperbase.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fbd11a2a940230f43f42defda57dbf852f83c627 Author: Lionel Elie Mamane Date: Tue Apr 23 20:09:47 2013 +0200 fixup nanosecond precision Change-Id: Id62d3b994ece9cdf3b5f085e94f6

Re: Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Kohei Yoshida
On 04/23/2013 12:46 PM, Norbert Thiebaud wrote: On Mon, Apr 22, 2013 at 12:06 PM, Michael Stahl wrote: well... all of the abstractions in gbuild don't help much for external libraries. But in that case the said library did not have to be external at all. one cannot have it both ways: create

[Libreoffice-commits] core.git: oox/source

2013-04-23 Thread Lionel Elie Mamane
oox/source/dump/dumperbase.cxx | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) New commits: commit 3810c9cc78ae8a4e96c216b725cd400f97934b45 Author: Lionel Elie Mamane Date: Tue Apr 23 19:27:52 2013 +0200 fixup nanosecond precision Change-Id: I9ab4c

Re: Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Norbert Thiebaud
On Mon, Apr 22, 2013 at 12:06 PM, Michael Stahl wrote: > > well... all of the abstractions in gbuild don't help much for external > libraries. But in that case the said library did not have to be external at all. one cannot have it both ways: create a 'somewhat' independent project, managed compl

[PATCH libreoffice-4-0-3] fixed out of bounds vector access

2013-04-23 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3585 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3585/1 fixed out of bounds vector access in ScColumn::FindNextVisibleRowWithContent() if starting from the position all

[PATCH libreoffice-4-0] fixed out of bounds vector access

2013-04-23 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3584 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/3584/1 fixed out of bounds vector access in ScColumn::FindNextVisibleRowWithContent() if starting from the position all

[Libreoffice-commits] core.git: 2 commits - android/experimental cppuhelper/source

2013-04-23 Thread Tor Lillqvist
android/experimental/desktop/native-code.cxx | 14 +++--- cppuhelper/source/shlib.cxx |3 ++- 2 files changed, 9 insertions(+), 8 deletions(-) New commits: commit b5fea2f46a1f33af2198e7da0bad027589fce5d2 Author: Tor Lillqvist Date: Tue Apr 23 19:30:58 2013 +0300

[Libreoffice-commits] core.git: sc/source

2013-04-23 Thread Eike Rathke
sc/source/core/data/column2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3874bad70ea48deed91b9966b3d35782b5584f7d Author: Eike Rathke Date: Tue Apr 23 18:09:43 2013 +0200 fixed out of bounds vector access in ScColumn::FindNextVisibleRowWithCont

Re: Different Gerrit workflows -- was Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Norbert Thiebaud
On Tue, Apr 23, 2013 at 9:07 AM, Bjoern Michaelsen wrote: > > with so far no arguments against it. Lets make the decision on the ESC call. Really ? Have I been too diplomatic about it ? Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop

[PATCH] install gen. IDL docs using filelist

2013-04-23 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3571 to look at the new patch set (#3). Change subject: install gen. IDL docs using filelist .. install gen. ID

[PATCH] add test for missing module-ix.html

2013-04-23 Thread David Tardon (via Code Review)
David Tardon has uploaded a new patch set (#2). Change subject: add test for missing module-ix.html .. add test for missing module-ix.html Change-Id: Ibdbe04028ad9648af011da51b562cc6aa5e4849b --- M odk/CustomTarget_check.mk 1 fi

[Libreoffice-commits] core.git: forms/source

2013-04-23 Thread Noel Grandin
forms/source/component/FormsCollection.hxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit a5f675c3d3254f03da8fbf42028a9c6b048df635 Author: Noel Grandin Date: Tue Apr 23 17:57:24 2013 +0200 fix, forget SAL_CALL again Change-Id: Ib13362c1a7

[PATCH] comments and code reformat

2013-04-23 Thread Maxime de Roucy (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3582 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/3582/1 comments and code reformat Change-Id: Ib4e45cb85c9e5e5ffa6476c939300c6795412b1a --- M sw/inc/doc.hxx M sw/inc/re

[PATCH libreoffice-4-0] fdo#61820: Avoid crasher when file URL contains unicode byte...

2013-04-23 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3581 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/3581/1 fdo#61820: Avoid crasher when file URL contains unicode bytes. This is a cherry-pick of 6374df20c2a8378209cce21c

[Libreoffice-commits] website.git: Branch 'update' - check.php

2013-04-23 Thread Michael Meeks
check.php | 157 +++--- 1 file changed, 91 insertions(+), 66 deletions(-) New commits: commit 0ed65fbe361503d7e33c642cfa66d24d5fff04c9 Author: Michael Meeks Date: Tue Apr 23 15:31:17 2013 +0100 add a hash -> version map, and an algo

[PUSHED libreoffice-4-0] Base: fix incorrect field removal in criterion inside query ...

2013-04-23 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3564 -- To view, visit https://gerrit.libreoffice.org/3564 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - connectivity/source

2013-04-23 Thread Olivier Ploton
connectivity/source/parse/sqlnode.cxx |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) New commits: commit ade0bd686190aa7016c2d0e1dab231cb15365fde Author: Olivier Ploton Date: Wed Dec 12 22:04:38 2012 +0100 Base: fix incorrect field removal in criterion inside query desi

[Libreoffice-commits] core.git: touch/inc

2013-04-23 Thread Tor Lillqvist
touch/inc/touch/libotouch.hxx | 15 --- 1 file changed, 15 deletions(-) New commits: commit a143098e3f5c8e90d7f14d444193b93d05b6cede Author: Tor Lillqvist Date: Tue Apr 23 18:01:34 2013 +0300 Just remove this unused file Change-Id: I68dbaf17d874d180fb9eda4082a26099a

[ABANDONED] Try one approach to compile a class as one compilation unit

2013-04-23 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: Try one approach to compile a class as one compilation unit .. Patch Set 1: Abandoned OK, the consensus seems to be that trying hard to preserve git log continuity at th

[PATCH libreoffice-4-0] fdo#62643 sw: fix autocomplate wrt. adding to a partially fi...

2013-04-23 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3580 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/3580/1 fdo#62643 sw: fix autocomplate wrt. adding to a partially finished word This partially reverts commits 1eee77f2c

[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 62643, which changed state. Bug 62643 Summary: EDITING Word completion: when adding to a partly finished word, word completion ignores the word part that already is there and creates non sense https://bugs.freedesktop.o

[PUSHED libreoffice-4-0] fdo#62147: sw: ODF import: apply styles in cells with string...

2013-04-23 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3575 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3575 To unsubscribe, visit

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sw/source

2013-04-23 Thread Michael Stahl
sw/source/filter/xml/xmltbli.cxx | 18 +++--- sw/source/filter/xml/xmltbli.hxx |3 ++- 2 files changed, 17 insertions(+), 4 deletions(-) New commits: commit 00a8e4604802cecfb87d62a5edc9ef314400ebb4 Author: Michael Stahl Date: Tue Apr 23 00:17:03 2013 +0200 fdo#62147: sw:

Re: Empty Advanced options page on Windows

2013-04-23 Thread Caolán McNamara
On Wed, 2013-04-17 at 08:49 -0400, Kohei Yoshida wrote: > Hi there, > > > I just completed my Windows build of the master branch and noticed > that, the Advanced options page is for some reason totally blank. If > my attachment goes through, you can see it in the attached screenshot. > > > Doe

Re: [ANN] global header move on Tuesday 2013-04-23 between 1200UTC and 2000UTC

2013-04-23 Thread Bjoern Michaelsen
On Tue, Apr 23, 2013 at 02:25:35PM +0200, Bjoern Michaelsen wrote: > On Thu, Apr 18, 2013 at 10:46:26PM +0200, Bjoern Michaelsen wrote: > > - I will rebase the script against master on 2013-04-23 1200 UTC and again > > execute and trigger the build on gerrit > > The 1200UTC last sanity is runnin

[Libreoffice-commits] core.git: Library_merged.mk vcl/Library_vcl.mk

2013-04-23 Thread Matúš Kukan
Library_merged.mk |1 + vcl/Library_vcl.mk | 14 ++ 2 files changed, 3 insertions(+), 12 deletions(-) New commits: commit 88b325aac5750561e76c6f5a4099b846af1a195b Author: Matúš Kukan Date: Tue Apr 23 16:15:41 2013 +0200 libmerged: add harfbuzz external Change

Re: Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Bjoern Michaelsen
On Tue, Apr 23, 2013 at 04:56:10PM +0300, Tor Lillqvist wrote: > Why? Gbuild works great. It is clearly good enough and much better > than what we had before. Good enough is not the same as "best > possible" though. Oh, than its just that we have different scopes in our view on the issue, I should

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - scp2/source

2013-04-23 Thread Andras Timar
scp2/source/ooo/vc_redist.scp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b5931a228e8a61f32f8b6249844c486ef9eb501c Author: Andras Timar Date: Tue Apr 23 14:51:02 2013 +0200 do not install 64-bit MSVCRT on 32-bit Windows Change-Id: I73a97ecc302

Re: Different Gerrit workflows -- was Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Bjoern Michaelsen
On Tue, Apr 23, 2013 at 02:43:20PM +0200, Stephan Bergmann wrote: > On 04/21/2013 01:04 PM, David Ostrovsky wrote: > >So back to your use case: the content of your feature branch can be put > >on Gerrit for *only* verification (not wasting days or weeks but only 2 > >hours) with *one* command: > >g

Re: [ANN] global header move on Tuesday 2013-04-23 between 1200UTC and 2000UTC

2013-04-23 Thread Bjoern Michaelsen
Hi, On Tue, Apr 23, 2013 at 03:36:51PM +0200, Noel Grandin wrote: > On 2013-04-23 15:29, Stephan Bergmann wrote: > >On 04/23/2013 03:09 PM, Bjoern Michaelsen wrote: > >>Why are you rebasing daily? I work on patches and rebase them > >>once directly > >>before pushing them to master sparing myself

Re: [ANN] global header move on Tuesday 2013-04-23 between 1200UTC and 2000UTC

2013-04-23 Thread Stephan Bergmann
On 04/23/2013 03:36 PM, Noel Grandin wrote: And I "push seldom" to reduce the reviewing workload on Stephan :-) Your commits are mostly just fine anyway. And should they cause trouble, you've demonstrated that you're around to get that fixed quickly. So what else can we ask for? There's t

[Libreoffice-commits] core.git: sw/source

2013-04-23 Thread Michael Stahl
sw/source/core/txtnode/ndtxt.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit ccb77a732c0d6017062b59ab32c6978d6d8713c5 Author: Michael Stahl Date: Tue Apr 23 15:31:38 2013 +0200 fdo#49076: copy numbering to clipboard only if start of para selected

Re: Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Tor Lillqvist
> You are of course free to challange the definition of a class as given by > Erich > Gamma, Richard Helm, Ralph Johnson, John Vlisside (sic). I won't bother with the "my idols are more famous than yours" game. Besides, didn't their fifteen years of fame pass already? > You are free to do it bet

[Libreoffice-commits] core.git: sw/inc sw/source

2013-04-23 Thread Miklos Vajna
sw/inc/acmplwrd.hxx | 17 - sw/source/core/doc/acmplwrd.cxx | 36 --- sw/source/ui/docvw/edtwin.cxx | 125 +++- 3 files changed, 16 insertions(+), 162 deletions(-) New commits: commit d92932744fdbaa78cec8dd8b991d5f442f6eef4b Autho

[Libreoffice-commits] core.git: vcl/inc vcl/source

2013-04-23 Thread Caolán McNamara
vcl/inc/vcl/image.hxx|1 + vcl/source/gdi/image.cxx | 15 +++ 2 files changed, 16 insertions(+) New commits: commit fe45c9ef10442d0991abd7a45d0e7f2d7c1338e1 Author: Caolán McNamara Date: Tue Apr 23 14:43:01 2013 +0100 restore ImageList::AddImage variant cor

Re: [ANN] global header move on Tuesday 2013-04-23 between 1200UTC and 2000UTC

2013-04-23 Thread Noel Grandin
On 2013-04-23 15:29, Stephan Bergmann wrote: On 04/23/2013 03:09 PM, Bjoern Michaelsen wrote: Why are you rebasing daily? I work on patches and rebase them once directly before pushing them to master sparing myself a lot of pain (and severely reducing the risk of ending up with rebasing on a br

Different Gerrit workflows

2013-04-23 Thread d . ostrovsky
On Tue Apr 23 05:43:20 PDT 2013, Stephan Bergmann wrote: On 04/21/2013 01:04 PM, David Ostrovsky wrote: So back to your use case: the content of your feature branch can be put on Gerrit for *only* verification (not wasting days or weeks but only 2 hours) with *one* command: git push logerrit :r

Re: Stack trace in Windows

2013-04-23 Thread V Stuart Foote
@bfo, Thanks. Familiar with the reference. Unfortunately completely dependent on a WNT build done with MSVC debug symbols--not the case for our TinderBox builds. Process Monitor and its stack trace is a workable alternative, but it is tedious and gets one only to the ball park--especially if ther

Re: [ANN] global header move on Tuesday 2013-04-23 between 1200UTC and 2000UTC

2013-04-23 Thread Stephan Bergmann
On 04/23/2013 03:09 PM, Bjoern Michaelsen wrote: Why are you rebasing daily? I work on patches and rebase them once directly before pushing them to master sparing myself a lot of pain (and severely reducing the risk of ending up with rebasing on a broken master etc.). I can see others doing the s

Re: Master branch now requires liborcus 0.5.0 or higher.

2013-04-23 Thread Bjoern Michaelsen
Hi, On Tue, Apr 23, 2013 at 03:55:32PM +0300, Tor Lillqvist wrote: > > http://en.wikipedia.org/wiki/Class_%28computer_programming%29 > > "Classes are composed from structural and behavioral constituents." > Of course, using such a definition, even Fortran IV code consisted of > classes! You are

[PATCH] add test for missing module-ix.html

2013-04-23 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3578 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3578/1 add test for missing module-ix.html Change-Id: Ibdbe04028ad9648af011da51b562cc6aa5e4849b --- M odk/CustomTarget_

[PATCH] install gen. IDL docs using filelist

2013-04-23 Thread David Tardon (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3571 to look at the new patch set (#2). Change subject: install gen. IDL docs using filelist .. install gen. ID

[PATCH] put theBrowseNodeFactory singleton into extra file

2013-04-23 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3577 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/3577/1 put theBrowseNodeFactory singleton into extra file Change-Id: Icf770c8b9e80e98935ffacf7da79a6c8af6593d9 --- M of

[PATCH] add missing idl files to the list

2013-04-23 Thread David Tardon (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3576 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/3576/1 add missing idl files to the list Change-Id: I4e1cc5ef83b86bdf0da0091a3ffcd912bdc52395 --- M offapi/UnoApi_offap

[PUSHED libreoffice-4-0] Uploading LGM2013 version of libcdr

2013-04-23 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3559 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3559 To unsubscribe, visi

[PUSHED libreoffice-4-0] Uploading new fresh wonderful libvisio-0.0.26

2013-04-23 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3552 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3552 To unsubscribe, visi

  1   2   >