[PATCH] Correct typos in sw README

2013-03-31 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3131 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3131/1 Correct typos in sw README Change-Id: I61323685b33817a2641713455bac1a079687cb4d --- M sw/README 1 file changed,

[PATCH] Typo fixes, small code changes

2013-03-31 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3135 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/3135/1 Typo fixes, small code changes * Corrected spelling errors in comments * In accpara.cxx, SwAccessibleParagraph::

[PATCH] Remove obsolete user-supplied flags

2013-04-02 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3172 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/3172/1 Remove obsolete user-supplied flags Fix TODO - now that we have migrated to gbuild, there is no more need for th

[ABANDONED] Remove obsolete user-supplied flags

2013-04-02 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Remove obsolete user-supplied flags .. Patch Set 1: Abandoned I'll change the TODO :-) Fair point made! -- To view, visit https://gerrit.libreoffice.org/3172 To unsubs

[PATCH] Missing word "if" in Deliver.mk

2013-04-04 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3205 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/3205/1 Missing word "if" in Deliver.mk Small change to comment - missing word "if" in Deliver.mk for gb_Deliver_CLEARON

[PATCH] Typo in comment in resmgr.hxx

2013-04-06 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3220 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/3220/1 Typo in comment in resmgr.hxx Change-Id: I6378c79f77ab897bf5a4e39c00944037beeef328 --- M tools/inc/tools/resmgr.

[PATCH] Unused variable s in exceptiontree.cxx

2013-04-09 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3283 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/3283/1 Unused variable s in exceptiontree.cxx Change-Id: Ib825817ea5d77ba2ead421daa0e7f2b708d156a1 --- M codemaker/sour

[ABANDONED] Update README to explain what codemaker does

2013-04-09 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Update README to explain what codemaker does .. Patch Set 3: Abandoned Fair enough - decent point. I see you've now done this in master now! -- To view, visit https://

[PATCH] Update README to explain what codemaker does

2013-04-09 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3286 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/3286/1 Update README to explain what codemaker does README change adapted from http://wiki.openoffice.org/wiki/Uno/Bina

[ABANDONED] Update README to explain what codemaker does

2013-04-09 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Update README to explain what codemaker does .. Patch Set 2: Abandoned I must be tired. -- To view, visit https://gerrit.libreoffice.org/3286 To unsubscribe, visit htt

[PATCH] Update README to explain what codemaker does

2013-04-09 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3287 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/3287/1 Update README to explain what codemaker does README change adapted from http://wiki.openoffice.org/wiki/Uno/Bina

[PATCH] "Degugging" no more in make help :-)

2013-04-15 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3395 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/3395/1 "Degugging" no more in make help :-) Change-Id: I032f9737746b39047b2d62df6821da4b3b9e9242 --- M solenv/gbuild/gb

[PATCH] Correct spelling errors in comments.

2013-03-02 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2509 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/2509/1 Correct spelling errors in comments. Change-Id: I360d4672225ba86466d5ecf0abf615172a7c3659 --- M vcl/source/app/s

[PATCH] Translate German DBG_ASSERT - AppFileName should be set to s...

2013-03-02 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2522 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/2522/1 Translate German DBG_ASSERT - AppFileName should be set to something Change-Id: Idf0c1c90ff367285292097980f56ca9

[PATCH] Translated German comment, other comments updated for clarit...

2013-03-03 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2525 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/2525/1 Translated German comment, other comments updated for clarity Change-Id: I6db4f5dd66b928c9424cefebec3016e5bf5e8c

[PATCH] No need for commented out code.

2013-03-03 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2528 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/2528/1 No need for commented out code. Change-Id: I8a8b7735574d712aea2a3f2b42941669b2db00b8 --- M dictionaries M helpco

[PATCH] Translate German comments to English in svmain.cxx

2013-03-03 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2529 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2529/1 Translate German comments to English in svmain.cxx Change-Id: I4f27a839c6403c08983f0366402c852b0710029c --- M vc

[PATCH] Updated README to explain what "SV" stands for in the source...

2013-03-03 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2532 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/2532/1 Updated README to explain what "SV" stands for in the source. Change-Id: I0d0a71a6e74ca2d90487313e33cf82ea7bcac0

[PATCH] One German comment translated, removed commented out line of...

2013-03-06 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2564 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/2564/1 One German comment translated, removed commented out line of code. Change-Id: I0811d0404b325307a7cab60c8c634a74e

[PATCH] Translate German comment in idlemgr.cxx

2013-03-06 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2565 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/2565/1 Translate German comment in idlemgr.cxx Change-Id: Ic5506b8698d0458e3166994a165d4dd1a8f6173d --- M vcl/source/ap

[PATCH] Remove commented out code in salplug.cxx

2013-03-06 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2566 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2566/1 Remove commented out code in salplug.cxx Change-Id: Ie3f55a35874ecaf07440da26c8ba22c2803a0480 --- M vcl/unx/gene

[PATCH] Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM from salpl...

2013-03-08 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2593 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/2593/1 Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM from salplug.cxx Change-Id: I119661f180a12f8cb43760082b37e1b6e

[ABANDONED] Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM from salpl...

2013-03-08 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM from salplug.cxx .. Patch Set 1: Abandoned No way. -- To view, visit https://gerrit.libreoffice.org/2593 To unsubscr

[PATCH] Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM from salpl...

2013-03-08 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2594 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/2594/1 Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM from salplug.cxx Change-Id: I49b77fee3864e8a389998a4e9df1054bf

[PATCH] Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM

2013-03-09 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2627 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/2627/1 Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM Change-Id: I15ae64d621fd0a1fa178f9a4062b93520628bdb0 --- M vcl

[PATCH] Remove RTL_CONSTASCII_USTRINGPARAM and remove rtl:: namespac...

2013-03-13 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2693 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/2693/1 Remove RTL_CONSTASCII_USTRINGPARAM and remove rtl:: namespace for strings Change-Id: I7327cfe644cc7c948692dff66f

[PATCH] Remove rtl:: namespace, fix minor spelling error in comment

2013-03-14 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2726 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/2726/1 Remove rtl:: namespace, fix minor spelling error in comment Change-Id: Icd04bfa61209277c57afe313d679b253aa241b7d

[PATCH] Move setupwizard modify handler code.

2013-03-21 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2890 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/2890/1 Move setupwizard modify handler code. Move setupwizard code into the conditional below it. You can only work on

[PATCH] Remove commented code in VCL demo app - should make the exam...

2013-03-22 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2920 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/2920/1 Remove commented code in VCL demo app - should make the example clearer. Change-Id: I2e56c580b30435731b3b8dc716a

[PATCH] General comment cleanup for demo/test vcl apps

2013-03-22 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2921 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/2921/1 General comment cleanup for demo/test vcl apps Remove unnecessary commented out code, remove comment "spacer" li

[PATCH] Deprecated warnings disabled for Office Beans.

2013-04-16 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3407 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/3407/1 Deprecated warnings disabled for Office Beans. There are classes that are deprecated that rely on deprecated cla

[ABANDONED] Deprecated warnings disabled for Office Beans.

2013-04-16 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Deprecated warnings disabled for Office Beans. .. Patch Set 5: Abandoned Seems I've opened a regular can of worms! Discussing this on the mailing list before making any

[PATCH] General cleanup of OfficeBeans

2013-04-16 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3413 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/3413/1 General cleanup of OfficeBeans Cleaned up Java source files: + removed unnecessary commented out code +

[PATCH] Remove useless commented out code.

2013-04-27 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3631 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3631/1 Remove useless commented out code. Change-Id: Iec64115692b1f51ec1466dd57f8049c6f3aaa82b --- M toolkit/source/awt

[PATCH] change

2013-05-01 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3725 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/3725/1 change Change-Id: If35aad02bfdca012542d552b7f4ec0f3042e757a --- M compilerplugins/clang/checkconfigmacros.cxx M

[PATCH] Convert from EMFP_DEBUG to SAL_INFO

2013-05-01 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3726 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3726/1 Convert from EMFP_DEBUG to SAL_INFO * Change to SAL_INFO instead of EMFP_DEBUG in implrenderer.cxx * Add new log

[ABANDONED] change

2013-05-01 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: change .. Patch Set 1: Abandoned Whoops! -- To view, visit https://gerrit.libreoffice.org/3725 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-Me

[PATCH] Enhancements to VCL metafile handling

2013-05-10 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3839 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3839/1 Enhancements to VCL metafile handling * Remove EMFP_DEBUG with OSL_DEBUG conditional defines and SAL_INFO * Whil

[PATCH] Fix: change to std::dec after having used std::hex

2013-05-10 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3842 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3842/1 Fix: change to std::dec after having used std::hex The basefield flag of a stream is persistent, which I didn't

[PATCH] Potty mouth

2013-05-10 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3843 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3843/1 Potty mouth Change-Id: I276fa2fa24b5553a748e6e628129d54419e69c9a --- M dbaccess/source/ui/browser/brwctrlr.cxx 1

[PATCH] EMF+ fixes

2013-05-11 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3861 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3861/1 EMF+ fixes A number of fixes have been made: * Missing redirect in SAL_WARN - only gets picked up when DBG_LEVEL

[PATCH] Accidentally added "<< << std::hex"

2013-05-11 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3866 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3866/1 Accidentally added "<< << std::hex" Change-Id: Icf83f118849d99bbb41cacc76c2e101f0c156b72 --- M cppcanvas/source/

[PATCH] Janitorial: indent code correctly

2013-05-11 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3867 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3867/1 Janitorial: indent code correctly Change-Id: I9fcbeb5f60df1a977347076dac82d4b5f7aba2c1 --- M cppcanvas/source/mt

[ABANDONED] Accidentally added "<< << std::hex"

2013-05-11 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Accidentally added "<< << std::hex" .. Patch Set 2: Abandoned dtardon fixed this in master already. -- To view, visit https://gerrit.libreoffice.org/3866 To unsubscrib

[PATCH] Documentation update of README.cross

2013-05-15 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3916 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/3916/1 Documentation update of README.cross * Fixed typos * Errant/missing commas fixed * autogen.lastrun -> autogen.in

[PATCH] Remove vertical whitespace for Tor's reading pleasure

2013-05-20 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3978 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3978/1 Remove vertical whitespace for Tor's reading pleasure Change-Id: I6dc1e2e29a0ee3dbbaec86b2d41855d204885adf --- M

[ABANDONED] Remove vertical whitespace for Tor's reading pleasure

2013-05-20 Thread Chris Sherlock (via Code Review)
Chris Sherlock has abandoned this change. Change subject: Remove vertical whitespace for Tor's reading pleasure .. Patch Set 1: Abandoned No need for this :-) Tor has it all under control -- To view, visit https://gerrit.libr